Commit Graph

119 Commits

Author SHA1 Message Date
Ferdinand Thiessen
f8d558e24f fix(core): Ungroup placeholder css rules to prevent browsers from removing all rules
When rules are grouped using the comma operator and one selector is invalid / unknown then the whole group is invalidated[1].
In this case `::-ms-input-placeholder` is unknown to Firefox and Chrome, so the `::placeholder` rule is never applied.
[1]: https://www.w3.org/TR/selectors-3/#grouping

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-04-17 22:25:03 +00:00
Christopher Ng
9012e89431 Fix vue-select styles
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-12-10 01:35:14 +00:00
John Molakvoæ
dcd0878458
Merge pull request #35665 from nextcloud/revert-35165-fix/vue-select-styles 2022-12-08 18:47:29 +01:00
John Molakvoæ
2d5fe7ec23
Revert "Disable style override on vue-select elements" 2022-12-08 11:02:07 +01:00
Christopher Ng
20da75f5ab Increase default input field border contrast
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-12-08 00:28:15 +00:00
Christopher Ng
d3d5034ea4 Disable style override on vue-select elements
- Disable style override on NcActionButton with `:not(.action-button)`
  due to increased specificity over scoped Vue styles when only
  `:not([class^="vs__"])` is added

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-12-06 00:19:53 +00:00
John Molakvoæ
14e0299582
Fix user settings layout
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-23 10:47:38 +01:00
Carl Schwan
f1ce2c2b93
Fix rebasing issues and improve profile settings page a bit more
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-26 19:51:10 +02:00
Carl Schwan
1d35a53991
More dark theme fixes
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-26 19:49:00 +02:00
Carl Schwan
2f30d3227f
Various fixes
- Fix user status dialog
  - Add label where missing
  - Move emoji picker inside input field (similar to talk)
  - Fix selecting an emoji
- Fix multiselect
- Fix button with confirmation action
- Fix some other unrelated dark theme issues
- Fix select2 focus
- Run npm lint:fix

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-26 19:49:00 +02:00
Carl Schwan
f630bd27f7
Adapt to new Nextcloud vue style
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-26 19:49:00 +02:00
Carl Schwan
68ed1af3c0
Fix accessibility of input fields
Input fields require a 44x44 pixels target size, this makes all the
input fields and button use that size.

Bonus is that now the input fields and buttons now have the same size as
the new vue button and this looks less weird than the previous state
with controls of different sizes.

See https://www.w3.org/WAI/WCAG21/Understanding/target-size.html

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-26 19:49:00 +02:00
Carl Schwan
253118298d Redesign guest pages for better accessibility
- Use white box and put content on it
- Improve focus indicator

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-27 10:43:21 +02:00
Julius Härtl
9e0d6f5608
Use hover css variable for primary buttons and add proper focus outline
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-07-18 18:24:26 +02:00
Carl Schwan
c1499519d4 Improve accessibility with more visible focus indication for non vue apps
- Add visible-focus effect on each header entry
- Show focus outline when using focus-visible (keyboard navigation)
- Add polyfy for focus-visible since it's only very recently available
  on webkit
- Change text for link to home button to describe the destination and
  not the current page
- Improve focus effect in app sidebar navigation

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-16 13:21:48 +02:00
John Molakvoæ
73918b8af9
Cleanup and compile
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-13 16:13:00 +02:00
John Molakvoæ
cc6037e438
Migrate core scss
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-13 16:10:59 +02:00
Christopher Ng
0b38fe1f4b Fix collaborative tags styles
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-12-01 18:04:16 +00:00
marco
67915dbc43 Only add the vue exeption to actual button elements
Signed-off-by: marco <marcoambrosini@pm.me>
2021-11-25 16:16:02 +01:00
marco
61cfe35a90 Do notr make action icons too transparent
Signed-off-by: marco <marcoambrosini@pm.me>
2021-10-19 17:52:13 +02:00
Marco Ambrosini
231b5edc7b Do not target vue buttons with server rules
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
2021-09-30 09:41:20 +02:00
Greta
6078eab30b Revert "Do not target vue buttons with server rules"
Signed-off-by: GretaD <gretadoci@gmail.com>
2021-03-24 20:03:57 +01:00
Roeland Jago Douma
2f70397b03
Merge pull request #25721 from nextcloud/do-not-target-vue-buttons
Do not target vue buttons with server rules
2021-03-09 20:31:57 +01:00
Marco Ambrosini
8691084f17 Do not target vue buttons with server rules
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
2021-03-05 08:16:20 +00:00
Vincent Petry
49eff095ff
Change outline color to --color-main-text
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-26 10:15:21 +01:00
Vincent Petry
23c143e034
Add focus-visible outline for checkboxes and radio buttons
To make keyboard navigation visible in forms.
When clicking with the mouse it doesn't appear.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-02-26 10:15:20 +01:00
Marco Ambrosini
dc9d37e7f8 Do not target vue progressbar with server styles
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
2021-01-25 08:22:18 +00:00
Marco Ambrosini
23b61de21e Increase horizontal padding
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2020-12-22 12:28:47 +00:00
Vincent Petry
1476817975
Properly put hidden-visually off-screen
In some situations the element is still affecting the layout, especially
when a sticky is nearby.

This fix moves it properly off-screen.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-10-29 21:35:36 +01:00
Daniel Calviño Sánchez
52706213d3 Fix cursor on click inputs and their descendants
The cursor in click inputs is shown as a pointer to convey that it can
be interacted with. However, in those click inputs that can have
descendants, like buttons, the descendants may not inherit the cursor
from it (for example, a "strong" element would, but a "span" element
would not), which causes a pointer cursor to be shown on some areas of
the button and a different one to be shown on other areas. To prevent
that now all the descendants of click inputs that can have descendants
use a pointer cursor.

On the other hand, if a click input is disabled it can not be interacted
with it, so now disabled click inputs as well as their descendants show
a default cursor instead of a pointer cursor in that case.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-03-25 10:50:45 +01:00
Daniel Calviño Sánchez
914172690c Fix cursor on disabled contenteditable divs
The cursor should be a default cursor, as the text cursor implies that
text can be introduced.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-01-16 18:28:36 +01:00
Julius Härtl
41134dafa0
Narrow error button styling scope
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-01-10 16:50:20 +01:00
Gary Kim
0efa78d1e2
Prompt on destructive user actions
Signed-off-by: Gary Kim <gary@garykim.dev>
2019-11-05 20:39:07 +08:00
Julius Härtl
57a4a7d0e4
Increase contast between text and placeholder in input fields
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-10-10 15:54:10 +02:00
Gary Kim
c9ef40af27
Fix alignment issues in admin settings
Signed-off-by: Gary Kim <gary@garykim.dev>
2019-07-05 00:10:29 +08:00
John Molakvoæ (skjnldsv)
fcdea35554
Increase checkbox & radio size
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-04-30 09:55:39 +02:00
John Molakvoæ (skjnldsv)
2503520121
Fix default input element height
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-03-02 10:32:36 +01:00
Jan-Christoph Borchardt
58ecd86f55
Fix .infield labels not being readable by screenreaders
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-02-22 12:54:31 +01:00
Jan-Christoph Borchardt
c44c23a1c3
Improve design of description below label of checkbox or radio button
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-02-01 10:06:31 +01:00
Jan-Christoph Borchardt
dd3ed98031
Dark theme: Fix select2 icons
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-01-16 14:34:19 +01:00
Jan-Christoph Borchardt
db1f1048f9
Dark theme: Fix select triangle not being visible
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2019-01-15 20:54:39 +01:00
Julius Härtl
96102c1b70
Fix select2 style preference
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-01-09 15:13:34 +01:00
John Molakvoæ (skjnldsv)
dbee410a6e
Override select2 lib styling
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-01-09 15:02:01 +01:00
John Molakvoæ (skjnldsv)
1cb507e0e3
Fix ie11 checkboxes
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-12-19 11:31:10 +01:00
Daniel Calviño Sánchez
7dad6d8f5b Use default cursor for disabled primary buttons
Disabled buttons use the default cursor, but as the cursor property for
primary buttons is set after the cursor property for disabled buttons
the latter is always overridden, even if the primary button is also
disabled. Due to this it is necessary to explicitly set the default
cursor for disabled primary buttons.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-12-11 10:25:48 +01:00
Jan-Christoph Borchardt
f80a023431
Always give primary button a border for light primary colors
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-21 14:30:05 +01:00
Jan-Christoph Borchardt
325396330c
Apply border to primary button if on log in page (and not in a dark container) or if in header, fix #12294
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2018-11-20 17:01:51 +01:00
John Molakvoæ (skjnldsv)
dbcea3316a
Fix inline input confirm margin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2018-11-10 09:48:16 +01:00
Julius Härtl
927bdebd65
Revert "make .button inline-block"
This reverts commit 87c3f79399.
2018-11-01 21:00:22 +01:00
Jonas Sulzer
87c3f79399
make .button inline-block
fix #3752

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
2018-10-30 13:03:20 +01:00