Joas Schilling
f14949218c
fix(settings): Deprecate old things for real
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-14 20:50:07 +01:00
Maxence Lange
2232753b99
add hasListeners()
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-14 14:02:28 -01:00
Joas Schilling
696ed4a125
fix(CS): Fix coding style
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-14 15:38:15 +01:00
Anupam Kumar
7329b83f92
feat: Migrate LinkReferenceProvider to OCP
...
This would be useful to eleminate the need for using this OC class
when an app dev wants to implement a custom reference provider
for the web client but wants to fall back on opengraph for mobile
clients.
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-02-14 18:22:19 +05:30
Julien Veyssier
6580bef319
Use the STT provider's exception message in the RuntimeException that will be caught by upper contexts
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-02-14 13:23:37 +01:00
Maxence Lange
9a299ed60b
exit log() early if no crashreporter registered
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-14 09:40:21 -01:00
F. E Noel Nfebe
3fb1674251
Merge pull request #43461 from nextcloud/fix/get-rid-of-getlogger
...
chore: Migrate away from OC::$server->getLogger
2024-02-14 10:47:22 +01:00
Nextcloud bot
fea2277b63
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-14 00:19:31 +00:00
John Molakvoæ
524ed97d62
fix: replace Account name
by Login
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +01:00
John Molakvoæ
4a509dfe8e
fix: phpunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:06:31 +01:00
John Molakvoæ
9593f4d6f9
fix: openapi
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:06:31 +01:00
Vincent Petry
839ddaa354
feat: rename users to account or person
...
Replace translated text in most locations
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +01:00
Côme Chilliet
c0ce272e9c
chore: Migrate away from OC::$server->getLogger
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-13 17:32:30 +01:00
Joas Schilling
c4684089a8
fix(request): Fix regex handling and coding-style
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-13 16:51:13 +01:00
Mikael Peigney
ffcadf25d4
fix(request): Handle reverse proxy setting a port in Forwarded-For
...
Signed-off-by: Mikael Peigney <Mika56@users.noreply.github.com>
2024-02-13 16:51:13 +01:00
Anna Larch
6434ce96c9
Add timezone getter to ITimeFactory
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-02-13 13:29:06 +01:00
Arthur Schiwon
fd04f058c8
Merge pull request #43542 from nextcloud/fix/db/long-transaction-exception-message
...
fix(db): Unify long transaction log/exception message
2024-02-13 10:13:14 +01:00
John Molakvoæ
56640c7fdd
Merge pull request #39889 from nextcloud/cache-di
2024-02-13 09:40:02 +01:00
Christoph Wurst
aef28e191a
fix(db): Unify long transaction log/exception message
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-13 08:17:49 +01:00
Alexander Piskun
be260d2171
Merge branch 'master' into enh/speech-to-text-provider-with-userid
2024-02-13 09:56:30 +03:00
Andrey Borysenko
162537916b
fix missing return statement, inline return
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-02-12 20:47:33 +01:00
Maxence Lange
c1fc1b29bc
Merge pull request #43424 from nextcloud/enh/noid/debug-on-lazy-appconfig-loading
...
enh(appconfig): debug logs on lazy loadConfig
2024-02-12 18:12:54 -01:00
Maxence Lange
592012034e
Merge pull request #43370 from nextcloud/test-iappconfig
...
[IAppConfig] new tests
2024-02-12 18:09:13 -01:00
Robin Appelman
e9d97a568f
use OCP\Server
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-12 16:39:00 +01:00
Maxence Lange
809e0fe923
fix phpdoc
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-12 13:23:36 -01:00
Maxence Lange
3e58a2501f
use exception for cleaner Trace
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-12 12:53:46 -01:00
Nextcloud bot
61f58e8043
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-12 00:19:03 +00:00
Nextcloud bot
2b1057721a
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-02-11 00:19:34 +00:00
Git'Fellow
b03199e1cb
Merge pull request #42991 from nextcloud/lowToInfo
...
Lower failed movie preview generation logs to level info
2024-02-10 13:46:27 +01:00
Git'Fellow
786894f15c
Fix typo in var
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-09 14:41:26 +01:00
Robin Appelman
e50c176428
also improe cache ci for shared cache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-09 14:00:26 +01:00
Robin Appelman
7a91abb439
improve di performance for cache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-09 13:28:30 +01:00
Robin Appelman
963721330f
only get the path for the users cached mount info when we use it
...
most of the time we shouldn't need it so we can save joining on the filecache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-09 09:50:43 +01:00
Ferdinand Thiessen
a37b6c7e5f
fix!: Remove deprecated RegisterWidgetEvent
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-09 01:34:03 +01:00
Côme Chilliet
303e2febc7
Merge pull request #43387 from nextcloud/fix/migrate-away-from-ilogger-in-jobs
2024-02-08 18:27:44 +01:00
Simon L
8fd2289058
Merge pull request #43357 from nextcloud/enh/41253/fix-occ-upgrade
...
fix(migration): Make naming constraint fail softer on updates
2024-02-08 18:27:39 +01:00
Ferdinand Thiessen
cdf7840d00
Merge pull request #43454 from nextcloud/fix/cleanup-cron-php
...
Cleanup cron.php method calls
2024-02-08 16:21:02 +01:00
Louis Chemineau
898df41de9
Revert "Merge branch 'master' of github.com:nextcloud/server"
...
This reverts commit d9d60238c7
, reversing
changes made to ba3fdb0cdc
.
2024-02-08 15:31:19 +01:00
Côme Chilliet
cf6a0e0833
chore: Deprecate OC_App::loadApps and add missing return type in Server
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 14:34:01 +01:00
jithin-space
7c11414c9b
added patch method
...
Signed-off-by: jithin-space <jithin.thankachan@gpsrenewables.com>
2024-02-08 15:54:20 +05:30
Côme Chilliet
e78e27187a
chore: Delete deprecated internal Job classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +01:00
Côme Chilliet
65981f99bf
chore: Migrate away from internal Job classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +01:00
Côme Chilliet
166773879b
fix!: Migrate jobs away from deprecated interfaces
...
BREAKING CHANGE: Removed ILogFactory::getCustomLogger deprecated method
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +01:00
Joas Schilling
487c33f479
fix(migration): Make naming constraint fail softer on updates
...
Only on installation we want to break hard, so that all developers notice
the bugs when installing the app on any database or CI, and can work on
fixing their migrations before releasing a version incompatible with Postgres.
In case of updates we might be running on production instances and the
administrators being faced with the error would not know how to resolve it
anyway. This can also happen with instances, that had the issue before the
current update, so we don't want to make their life more complicated
than needed.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-07 20:45:51 +01:00
Maxence Lange
70a229da50
redundant condition
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-07 12:24:57 -01:00
Maxence Lange
2122a81419
fix getAllValues() to filter values based on prefix
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-07 12:24:57 -01:00
Maxence Lange
ae8d6b6b69
debug lazy loadConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-07 08:35:00 -01:00
John Molakvoæ
bea8bf9032
Merge pull request #43317 from nextcloud/fix/contacts-name
2024-02-07 10:23:22 +01:00
Robin Appelman
5ea69768b0
Merge pull request #41015 from nextcloud/background-scan-catch-storage-error
...
continue background scanning different storages if one fails
2024-02-07 10:06:32 +01:00
Ferdinand Thiessen
414a4caa65
Merge pull request #43361 from nextcloud/fix/add-missing-phpdoc-template-parameters
...
chore: Add missing ArrayAccess template parameters
2024-02-06 15:11:50 +01:00
Christoph Wurst
67a3ab48b5
Merge pull request #43131 from nextcloud/fix/files/cache-wrapper-no-partial-cache-entry-formatting
...
fix(files): Don't attempt to format a partial cache entry
2024-02-06 13:51:51 +01:00
Côme Chilliet
f73f966c98
chore: Add missing ArrayAccess template parameters
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-06 10:24:41 +01:00
Maxence Lange
8ba2cd4a07
returns non lazy value while searching for lazy
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-06 00:00:58 -01:00
Maxence Lange
f910baf9f7
Merge pull request #43275 from nextcloud/enh/noid/no-exception-on-missing-key-updatelazy-updatesensitie
...
return false on AppConfigUnknownKeyException
2024-02-05 16:21:02 -01:00
Côme Chilliet
d97567a7fd
chore: Add references to phpdoc deprecation notice for IL10N
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-02-05 11:16:04 +01:00
Côme Chilliet
b2e9e0fa0d
chore: Replace OC::$server->getL10N by OCP\Util::getL10N in lib and some apps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-05 11:16:04 +01:00
Côme Chilliet
961ccee5f6
Make it clear in the deprecation comment that DI is preferred
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-05 11:16:04 +01:00
Côme Chilliet
1332078be1
Use OCP\Util::getL10N instead of OC::$server->getL10N
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-05 11:16:04 +01:00
Git'Fellow
6f4d0fe79c
Lower failed movie preview to info
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-03 18:52:05 +01:00
Ferdinand Thiessen
2c8aee8f99
fix(ContactsStore): Sanitize user ID given to guest avatar route
...
It is not allowed to use slashes within path parameters, so they would need to be encoded.
But URL encoded slashes are not suported by Apache, so instead replace slash with space.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-03 11:32:51 +01:00
Arthur Schiwon
8a4bd3b932
Merge pull request #40981 from nextcloud/fix/object-storage-user
...
fix(objectstorage): cleanup HomeObjectStoreStorage
2024-02-02 20:57:01 +01:00
Thomas Citharel
30798eb6c2
refactor(objectstorage): cleanup types
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-02-02 14:59:21 +01:00
Thomas Citharel
3be3dbdb3b
refactor(objectstorage): move $user property from ObjectStoreStorage class to HomeObjectStoreStorage
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-02-02 14:59:21 +01:00
Thomas Citharel
4c618c4bf1
fix(objectstorage): cleanup HomeObjectStoreStorage
...
Fix invalid signature for getUser() method and change occurences of OC\User\User for OCP\IUser
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-02-02 14:59:20 +01:00
Robin Appelman
860caa0849
make failure to load app commands non-fatal
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-02 13:47:17 +01:00
Maxence Lange
1b2e503e7f
return false on AppConfigUnknownKeyException
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-01 21:51:17 -01:00
Maxence Lange
b838237f82
Merge pull request #43132 from nextcloud/enh/41755/update-appframework-api
...
sync with new OCP\IAppConfig
2024-02-01 19:51:47 -01:00
Robin Appelman
edaa436345
add key location to info:file output
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-01 15:32:33 +01:00
Joas Schilling
4993dac98f
Merge pull request #43203 from nextcloud/fix/cleanup-register-command-with-di
...
Use Dependency Injection in register_commands.php
2024-02-01 14:44:07 +01:00
Côme Chilliet
2bfb6fc731
fix: Make Repair object injectable and fix BackgroundRepair test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-01 09:49:32 +01:00
Maxence Lange
e1d7328bb2
adding test
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-31 21:13:32 -01:00
Maxence Lange
51fa22dc26
fix psalm
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-31 21:13:32 -01:00
Maxence Lange
86835ee899
sync with new OCP\IAppConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-31 21:13:32 -01:00
Robin Appelman
3066687c7d
Merge branch 'master' into background-scan-catch-storage-error
2024-01-31 19:42:58 +01:00
Robin Appelman
b777304a77
also updated parent etags when a changed etag is detected during scanning
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-31 18:06:18 +01:00
Robin Appelman
e14bceb63f
dont reuse etag for folders marked explicitly unscanned
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-31 18:05:09 +01:00
Lorenz Brun
a6f879e154
dav: fix wrong decoding of pluses in URLs
...
PHP's urldecode function does not decode URLs according to RFC 3986, but
according to the HTML 4.01 query parameter
encoding. This results in pluses being wrongly decoded to spaces even
though they should not be decoded at all.
Use rawurldecode instead, which follows RFC 3986 properly.
This fixes an issue where files on DAV shares containing pluses were
incorrectly decoded to spaces.
Fixes : #15849
Signed-off-by: Lorenz Brun <lorenz@brun.one>
2024-01-31 13:26:04 +01:00
Louis
7dc5a91f71
Merge pull request #38173 from arawa/feature/37677/exclude-some-groups-from-sharing-with-users
...
New core setting : shareapi_only_share_with_group_members_exclude_gro…
2024-01-31 13:24:47 +01:00
Christoph Wurst
6594360638
Merge pull request #42933 from nextcloud/fix/db/dirty-read-on-primary
...
fix(db): Execute dirty reads on the primary node
2024-01-31 10:55:05 +01:00
Baptiste Fotia
9af96d9f9a
feat(php,vue): Create a new parameter
...
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +01:00
Maxence Lange
6c49e9c68a
Revert "switching to new IAppConfig"
...
This reverts commit c693c58d25
.
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-30 18:37:09 -01:00
Maxence Lange
c693c58d25
switching to new IAppConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-30 18:33:50 -01:00
Côme Chilliet
ceff16bbf9
chore: Fix DI for integrity checker before installation
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 16:31:05 +01:00
Côme Chilliet
0e1931754a
chore: use DI for \OC\Repair
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 16:07:02 +01:00
Côme Chilliet
c1d67cc614
chore: Fix DI for Encryption\DecryptAll command
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 16:03:17 +01:00
Côme Chilliet
52f3616254
Merge pull request #43194 from nextcloud/fix/fix-psalm-missing-template-parameter
2024-01-30 15:24:42 +01:00
Christoph Wurst
97152de9bf
fix(db): Execute dirty reads on the primary node
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-30 12:17:39 +01:00
Joas Schilling
e0053e1c06
Merge pull request #43185 from nextcloud/feat/db/dirty-queries-production
...
feat(db): Make dirty query logging available in production
2024-01-30 12:05:49 +01:00
Côme Chilliet
6533431c36
Merge pull request #43191 from nextcloud/fix/use-di-for-setup-class
2024-01-30 11:10:52 +01:00
Côme Chilliet
8bcc2d352e
chore: Fix missing template parameter for IEventListener
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +01:00
Christoph Wurst
911ab393c0
feat(db): Make dirty query logging available in production
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-30 10:31:03 +01:00
Côme Chilliet
1f6279fa76
Merge pull request #43031 from nextcloud/fix/fix-throw-phpdoc-in-setupresult
2024-01-29 22:10:53 +01:00
Ferdinand Thiessen
85978593fe
Merge pull request #42794 from nextcloud/fix/invalid-trusted-proxies
...
fix(Request): Catch exceptions in `isTrustedProxy`
2024-01-29 16:19:51 +01:00
Côme Chilliet
67e3ecef98
chore: Cleanup Installer class as well
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 16:10:31 +01:00
Côme Chilliet
ccc66e912b
fix: Use DI for Setup class and move away from deprecated methods
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 15:28:00 +01:00
Côme Chilliet
a2eacf4487
Document throwing behavior of SetupResult upon invalid rich object
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 14:14:17 +01:00
Arthur Schiwon
3749c2c79b
Merge pull request #42930 from nextcloud/fix/6914/overwritecond
...
Fix: config param 'overwritecondaddr' not working
2024-01-29 09:56:56 +01:00
Nextcloud bot
f36a9d09f2
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-28 00:19:08 +00:00
Pavel Kryl
30ad530814
code style: ommited space, reverted [code review]
2024-01-27 15:11:26 +01:00
Pavel Kryl
446ecbc454
fixing bug #6914 : Config Param 'overwritecondaddr' not working
...
- just ignoring/removing extra parameter 'protocol' as suggested by
blizzz
Signed-off-by: Pavel Kryl <pavel@kryl.eu>
2024-01-27 15:11:26 +01:00
Ferdinand Thiessen
7620d230df
fix(Request): Catch exceptions in isTrustedProxy
...
The function fails if the configured trusted proxies contain invalid characters and the underlying IpUtils will throw.
But as it is used by `getRemoteAddress` which is used by logging / templating, thrown errors are not reported but silently fail with error 500.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-27 14:59:51 +01:00
Nextcloud bot
764f34c4f6
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-27 00:19:36 +00:00
Christoph Wurst
7e5303bec7
fix(files): Don't attempt to format a partial cache entry
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-25 19:30:38 +01:00
Maxence Lange
8362025643
better indexes
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-24 20:01:56 -01:00
Julius Härtl
8c777145f2
Merge pull request #42597 from nextcloud/perf/s3-mkdir-update-size
...
perf: Avoid updating the folder size if we know the size difference
2024-01-23 19:39:28 +01:00
Joas Schilling
582ec1294a
fix(apps): Fix type information of app manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-23 09:55:06 +01:00
Christoph Wurst
033a654389
Merge pull request #42929 from nextcloud/fix/db/transacted-read-not-dirty
...
fix(db): Do not log transacted reads as dirty read
2024-01-23 09:34:20 +01:00
Christoph Wurst
03774ad77c
Merge pull request #42971 from nextcloud/fix/auth/login-email-password-login-name-mismatch
...
fix(auth): Fix logging in with email and app password
2024-01-22 10:41:48 +01:00
Nextcloud bot
af313a79e8
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-21 00:19:16 +00:00
Christoph Wurst
7f2fdd8843
fix(auth): Fix logging in with email, password and login name mismatch
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-19 19:29:41 +01:00
FedericoHeichou
3cf66ae156
Add "-i" to sendmail's pipe
...
Signed-off-by: FedericoHeichou <federicoheichou@gmail.com>
2024-01-19 17:08:01 +01:00
Nextcloud bot
9f6df9171b
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-19 00:19:27 +00:00
Christoph Wurst
ab0d7c007d
fix(db): Remove very verbose dirty query logs
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-18 18:33:07 +01:00
Christoph Wurst
f54b08c224
fix(db): Do not log transacted reads as dirty read
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-18 13:37:36 +01:00
Arthur Schiwon
c4f4c5a3fb
Merge pull request #41067 from Murena-SAS/preview-folder-deletes
...
Fix for previews not being generated sometimes
2024-01-18 11:46:12 +01:00
Joas Schilling
0e40457b86
Merge pull request #42847 from nextcloud/fix/42843/exception-on-their-own
...
exceptions on their own
2024-01-18 09:59:36 +01:00
Pytal
e42f511412
Merge pull request #42860 from nextcloud/jr/fix/i42858
...
Update ContactsStore: Avoid exceptions on empties
2024-01-17 10:39:16 -08:00
Robin Appelman
0492e0f1d4
Revert "add key location to info:file output"
...
This reverts commit 7bf82fc312
.
2024-01-17 17:53:37 +01:00
Robin Appelman
7bf82fc312
add key location to info:file output
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-17 17:47:01 +01:00
Git'Fellow
72e0618f20
fix(session): Avoid two useless authtoken DB queries for every anonymous request
...
Co-Authored-By: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-17 09:17:23 +01:00
Josh
36e0b02712
Update ContactsStore: Avoid exceptions on empties
...
Fixes #42858 and makes things more robust
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-01-16 23:57:58 -05:00
Maxence Lange
db8636ac1a
exceptions on their own
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-16 12:48:27 -01:00
Maxence Lange
addd678682
returns default on exception
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-16 12:35:24 -01:00
Maxence Lange
fdd38b46e3
Merge pull request #41755 from nextcloud/enh/noid/lazyconfig
...
Lazy grouping within IAppConfig
2024-01-16 08:39:13 -01:00
John Molakvoæ
85849767f2
Merge pull request #42806 from nextcloud/bugfix/noid/only-send-subscription-key-to-our-appstore
2024-01-16 10:16:05 +01:00
Côme Chilliet
80d58f0162
Merge pull request #41312 from nextcloud/feat/migrate-code-integrity-check
2024-01-16 09:04:24 +01:00
Nextcloud bot
587057b0ed
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-16 00:18:51 +00:00
Maxence Lange
94fe48c998
small fixes
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 -01:00
Maxence Lange
6daea857ab
fixes
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
d
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 -01:00
Maxence Lange
f7d0c74b10
lazy AppConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 -01:00
Joas Schilling
57a30e9bbe
fix(appstore): Only send subscription keys to valid appstores
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-15 15:39:45 +01:00
Côme Chilliet
d481515081
Improve validator output in case of invalid RichObject
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +01:00
Git'Fellow
32bf74af16
Merge pull request #42768 from nextcloud/errorToWarn
...
(dashboard): Lower error to warning log message
2024-01-15 11:38:05 +01:00
Maxence Lange
083a9d8fb2
Merge pull request #42670 from nextcloud/enh/noid/occ-background-job-delete
...
occ background-job:delete
2024-01-15 09:36:36 -01:00
Git'Fellow
53ad3a58ab
Lower to info
...
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-01-15 09:29:22 +01:00
Alexander Piskun
243d352b26
result of build/autoloaderchecker.sh
...
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2024-01-15 10:35:09 +03:00
Alexander Piskun
913f62982e
Merge branch 'master' into enh/speech-to-text-provider-with-userid
2024-01-15 10:32:25 +03:00
Faraz Samapoor
cdf9d94423
Adds new exception to check for the availability of the index.
...
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-01-15 10:36:02 +03:30
Faraz Samapoor
2845071854
Refactors lib/private/FullTextSearch.
...
Mainly using PHP8's constructor property promotion.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2024-01-15 10:36:02 +03:30
Git'Fellow
d01f9e5fd5
Lower error to warning
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-01-14 22:45:48 +01:00
Alexander Piskun
156013a711
introduce IProviderWithUserId
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2024-01-14 22:44:37 +03:00
Andrey Borysenko
ea7f1f9ecd
move setting of userId before provider execution
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-01-14 20:44:43 +02:00
Andrey Borysenko
13588c7566
Introduce ISpeechToTextProviderWithUserId
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-01-14 18:47:40 +02:00
Julius Härtl
296096e069
fix: Add reconnect check in case of timeouts on the db side
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-12 14:38:01 +01:00
Julius Härtl
cc75294eb6
perf: Avoid updating the folder size if we know the size difference
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-12 14:21:08 +01:00
Julius Härtl
c17c42a0b2
feat: First attempt to track dirty tables after writes and switch back to replicas if reads go to other tables
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
debug: error log
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-12 11:02:50 +01:00
Julius Härtl
3e60092b7d
feat: Add logging for transaction time
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-12 11:02:50 +01:00
Maxence Lange
bd3df759fb
occ background-job:delete
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-11 23:17:57 -01:00
Julius Härtl
2df26608ef
Merge pull request #42649 from nextcloud/enh/machine-translation-provider-with-id
2024-01-11 21:50:50 +01:00
Côme Chilliet
f789732922
Merge pull request #42640 from nextcloud/fix/fix-authentication-exceptions-2
...
Always catch OCP versions of authentication exceptions
2024-01-11 18:51:43 +01:00
Côme Chilliet
a526a382bf
Import OCP IToken as OCPIToken to avoid a name clash in lib/private
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 15:45:14 +01:00
Côme Chilliet
6fc224dfce
Document new throw possibility in SetupResult
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:03:55 +01:00
Côme Chilliet
a78abd84ce
Validate rich objects passed to SetupResult
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:03:55 +01:00
Côme Chilliet
f34865eb4e
Add RichObject support for SetupChecks descriptions
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:03:55 +01:00
Côme Chilliet
37a6e15f87
Use OCP version of IToken in AppPasswordCreatedEvent
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +01:00
Côme Chilliet
8fc39aeb1c
Use IToken from OCP instead of OC
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +01:00
Côme Chilliet
95ea6188dc
Suppress or fix psalm errors related to InvalidTokenException
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +01:00
Côme Chilliet
eee9f1eec4
Always catch OCP versions of authentication exceptions
...
And always throw OC versions for BC
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +01:00
Marcel Klehr
477630ed78
Merge branch 'master' into enh/machine-translation-provider-with-id
2024-01-11 13:27:13 +01:00
Joas Schilling
cfd1cc54c1
Merge pull request #42658 from nextcloud/bugfix/42530/mark-more-configs-as-sensitive
...
fix(systemreport): Mark more configs as sensitive
2024-01-11 12:33:45 +01:00
Marcel Klehr
a6513336b4
fix(autoloaders)
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-11 09:32:30 +01:00
Marcel Klehr
970eb692d1
fix(coding style)
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 16:15:06 +01:00
Marcel Klehr
1db8888f99
enh(OCP\Translation): Introduce ITranslationProviderWithUserId
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 16:00:24 +01:00
Marcel Klehr
4bfa3d34fc
enh(OCP\Translation): Make ITranslationProviderWithId extend ITranslationProvider
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 14:08:03 +01:00
Marcel Klehr
c148f84ff7
Rebuild autoloaders
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 11:16:14 +01:00
Marcel Klehr
1fd0c2979e
enh(OCP\Translation): Add ITranslationProviderWithId
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 11:16:14 +01:00
Joas Schilling
c4d233a892
Merge pull request #42377 from nextcloud/fix/text-to-image-manager
...
Fix(text2image): Return providers as indexed array
2024-01-10 09:28:45 +01:00
Joas Schilling
7981a4bc82
Merge pull request #42391 from nextcloud/bugfix/noid/warn-on-excessive-memory-consumption-in-background-jobs
...
feat(cron): Warn on excessive memory consumption in background jobs
2024-01-10 09:15:14 +01:00
Joas Schilling
6294f0f4bc
fix(systemreport): Mark more configs as sensitive
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-09 13:08:27 +01:00
John Molakvoæ
82b5a19a35
fix: public dav and files_sharing testing fixes
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-09 10:56:14 +01:00
John Molakvoæ
7b6a650b6e
feat: public dav endpoint v2
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-09 10:56:06 +01:00
Marcel Klehr
997f6c33cd
fix(psalm issues)
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-09 10:11:39 +01:00
Maxence Lange
dd8297553c
Merge pull request #42560 from nextcloud/fix/42308/logs-more
...
debug logs on huge metadata
2024-01-08 11:45:54 -01:00
Maxence Lange
4367a5e633
blurhash generation
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-05 11:50:51 +01:00
Maxence Lange
e5bee95f05
debug logs on huge metadata
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-04 21:51:56 -01:00
Maxence Lange
71bdda42e4
initialize variables
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-04 10:59:22 -01:00
Nextcloud bot
6690eebff4
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-04 00:19:57 +00:00
Hamid Dehnavi
799928c63d
Merge branch 'master' into refactor_lib_private_notification
2024-01-03 10:22:40 +03:30
Nextcloud bot
89ee85938e
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-03 00:20:07 +00:00
Hamid Dehnavi
82a503a50a
Make adjustments based on the review
...
Co-authored-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2024-01-02 16:54:54 +01:00
Hamid Dehnavi
32ee6f7d04
Add adjustments based on the review
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2024-01-02 16:54:54 +01:00
Hamid Dehnavi
0ac1480be2
refactor lib/private/Notification
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2024-01-02 16:54:54 +01:00
Nextcloud bot
982fc73c3e
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-01-02 00:19:09 +00:00
Josh Richards
7a212b1f38
Fix log rotation notification level (warning->info)
...
Fixes #42537
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2023-12-31 20:26:39 -05:00
Nextcloud bot
c9611c0f5d
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-12-30 00:22:10 +00:00
Julius Härtl
6a63974bf5
Merge pull request #26540 from nextcloud/bugfix/noid/sqlite-datetime
...
Cast datetime columns in sqlite before comparing
2023-12-29 11:52:32 +01:00
Julius Härtl
77cec80feb
Merge pull request #41914 from nextcloud/s3-copy-size-limit
...
only do a multipart s3 copy when above the regular copy limit
2023-12-29 11:28:54 +01:00
Julius Härtl
86dc766276
Cast datetime columns in sqlite before comparing
...
Move the logic to prepare a column to the parent ExpressionBuilder so
that it can be reused for OCI and sqlite
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-12-29 10:36:59 +01:00
Alexander Piskun
cdc2723d97
Merge pull request #42479 from nextcloud/appapi-twofactor
...
AppAPI: allow to bypass Two-Factor
2023-12-29 11:29:29 +03:00
Alexander Piskun
26d343d33a
AppAPI: allowed to bypass Two-Factor
...
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2023-12-28 20:59:02 +03:00
Julius Härtl
e4054370b1
fix(s3): Add config option to disable multipart copy for certain s3 providers
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-12-28 15:31:38 +01:00
Robin Appelman
1043c21b35
only do a multipart s3 copy when above the regular copy limit
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-12-28 15:31:37 +01:00
Julius Härtl
81b089cf30
fix: Avoid using replicas during setup
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-12-28 11:51:35 +01:00
Daniel
b9b0ca6dea
Merge pull request #41998 from nextcloud/enh/read-replica
2023-12-27 21:57:30 +01:00
Nextcloud bot
4c75c8ca1a
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-12-23 00:20:10 +00:00
Stephan Orbaugh
7d8741c53f
Merge pull request #37469 from nextcloud/lock-restore-ttl
...
restore shared lock ttl to previous value when releasing
2023-12-22 10:43:04 +01:00
Robin Appelman
ff62154a79
adjust redis compareSetTTL to use a lua script
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-12-21 15:14:27 +01:00
Robin Appelman
7394645eb7
restore shared lock ttl when releasing
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-12-21 15:14:27 +01:00
Joas Schilling
b8c57efaad
fix(log): Improve logging of background job details for better reproduction/debugging
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-20 15:35:40 +01:00
Joas Schilling
4cb5501a3f
fix(cron): Reset the reserved_at when force executing from CLI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-20 10:07:41 +01:00
MB-Finski
f27d2bf352
Update doc blocks
...
Signed-off-by: MB-Finski <sami.finnila@gmail.com>
2023-12-20 07:49:09 +00:00
Git'Fellow
5077d0a10b
Merge pull request #42298 from nextcloud/readOnlyFSFalse
...
Don't write back .htaccess file on a RO filesystem
2023-12-19 21:34:16 +01:00
Marcel Klehr
53be798a70
Merge branch 'master' into enh/text-processing-provider-with-id
2023-12-19 16:14:13 +01:00
Marcel Klehr
e5622171b4
Update autoloaders
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-12-19 15:01:03 +01:00
Sami Finnilä
8904bf645b
Return providers as indexed array
...
Signed-off-by: MB-Finski <sami.finnila@gmail.com>
2023-12-19 13:25:45 +00:00
Marcel Klehr
6f0b192fcb
Update autoloaders
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-12-19 13:59:30 +01:00
Marcel Klehr
52d729c69e
cs:fix
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-12-19 13:32:15 +01:00
Marcel Klehr
928fee8ab4
enh(SpeechToText): Allow providers to declare a dynamic ID instead of using className
...
this allows AppAPI to register anonymous classes as SpeechToText providers
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-12-19 12:31:21 +01:00
Marcel Klehr
2e0141165a
Merge branch 'master' into enh/text-processing-provider-with-id
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-12-19 12:29:03 +01:00
Louis Chemineau
a39b3a3d84
Add global accessibility switch
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-12-19 10:21:13 +01:00
Eduardo Morales
24f97a57e2
fix(manager): removed dead code
...
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2023-12-18 12:29:50 -06:00
Anna Larch
fc4ef6133b
fix(ooo): add new ooo status with new emoji
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-12-18 11:35:00 +01:00
Nextcloud bot
0ff674607f
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-12-18 00:19:21 +00:00
Nextcloud bot
84e0b9007c
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-12-17 00:18:58 +00:00
Julius Härtl
79c4986354
enh: Implement PrimaryReadReplicaConnection
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-12-16 20:27:37 +01:00
Nextcloud bot
538041b6e7
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-12-16 00:19:23 +00:00
Anna Larch
dc87c531b5
fix(joblist): also reset last_run timestamp on updating an existing job
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-12-15 11:49:51 +01:00
Git'Fellow
b22ac93606
Read Only FS return false
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-12-15 08:35:15 +01:00
Joas Schilling
6056928dc6
feat(comments): Add a meta data column for comments
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-14 14:32:00 +01:00
fenn-cs
0b171f6095
Rename "global search" to "unified search"
...
- Changes appearances of "Global search" to "Unified search" in UI
- Refactors code, to remove usage of term "GlobalSearch" in files and code
structure
- Rename old unified search to `legacy-unified-search`
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-12-12 20:34:37 +01:00
Nextcloud bot
6aeb5d4a08
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-12-12 00:18:52 +00:00
Nextcloud bot
1f10b28c22
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-12-11 00:24:21 +00:00
Arthur Schiwon
70c2f574d2
Merge pull request #42093 from nextcloud/fix/l10n/init-race-condition
...
fix(l10n): fix translations for init scripts
2023-12-08 14:34:29 +01:00
John Molakvoæ
ceb2d41503
fix(l10n): fix translations for init scripts
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-12-08 12:36:39 +01:00
Ferdinand Thiessen
b1fffb0d3b
enh(NavigationManager): Use ID as fallback for app
property of entries
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-12-06 15:46:22 +01:00
Andy Scherzinger
13eecbba06
Merge pull request #42011 from nextcloud/techdebt/noid/allow-to-load-multiple-metadata-with-1-query
...
fix(metadata): Fix copy-paste doc block throws
2023-12-06 00:07:27 +01:00
Julius Härtl
6c52242fb1
Merge pull request #41927 from nextcloud/perf/login-with-email-token
2023-12-05 11:11:33 +01:00
Joas Schilling
fffbb06417
Merge pull request #41962 from nextcloud/fix/dav/check-current-ooo-time
...
fix(dav): Make current ooo info time-dependent
2023-12-05 10:52:28 +01:00
Christoph Wurst
9a206c6282
fix(dav): Make current ooo info time-dependent
...
* If there is an out of office absence info and it happens now -> return
data
* Else: return no data
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-12-05 08:36:50 +01:00
Maxence Lange
43469337b4
+files_metadata_installed
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-12-05 01:37:41 -01:00
Joas Schilling
b6e9132a5a
fix(metadata): Fix copy-paste doc block throws
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-04 14:57:32 +01:00
Joas Schilling
2a0daf7aff
fix(metadata): Allow to load metadata of multiple files at once
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-04 13:34:10 +01:00
Joas Schilling
89aa3957ce
Merge pull request #41999 from nextcloud/bugfix/noid/handle-idn_to_utf8-returning-false
...
fix(security): Handle idn_to_utf8 returning false
2023-12-04 11:46:27 +01:00
Joas Schilling
33e1c8b236
fix(security): Handle idn_to_utf8 returning false
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-12-04 10:38:46 +01:00
Marcel Klehr
062a0efed5
fix(TemplateManager): Bail early if templatedirectory is empty
...
fixes #39266
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-12-04 08:53:52 +01:00
Nextcloud bot
df7bc46eab
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-12-04 00:18:27 +00:00
Nextcloud bot
4efa24bd3f
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-12-02 00:21:18 +00:00
Pytal
294330454b
Merge pull request #40169 from nextcloud/enh/load-disabled-users-directly
...
enh(settings): Load from disabled users endpoint
2023-12-01 08:42:04 -08:00
Marcel Klehr
fe6d9e33b4
fix(TextProcessing): Make task type template param covariant
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-12-01 11:52:42 +01:00
Joas Schilling
3267ad7630
Merge pull request #41931 from nextcloud/techdebt/noid/add-typing
...
techdebt(Middleware): Add more specific array types so its clickable in IDEs
2023-12-01 08:00:00 +01:00
Côme Chilliet
adc43eae9b
Invert parameter order in getDisabledUserList to be consistent
...
This matches what was done in the calls and so fixes getting disabled
user list when there are several backends returning disabled users.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-30 17:15:12 -08:00
Julius Härtl
3cd1d74a81
fix: Only apply cast if needed when searching users for value
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-11-30 20:51:48 +01:00
Julius Härtl
a3a343ce41
perf: Use more performant way to obtain and check the email as a login name with token login
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-11-30 20:51:47 +01:00
Joas Schilling
ce583cb67b
techdebt(Middleware): Add more specific array types so its clickable in IDEs
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-30 12:27:08 +01:00
fenn-cs
b5981f67b4
Enable new global search by default
...
The new global search would now be activated by default and users,
have the option to revert to the old unified search by setting `unified_search.enabled`
to true in the NC `config.php` file.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-11-30 12:20:13 +01:00
Louis
bdc7c64ec7
Merge pull request #41765 from nextcloud/artonge/feat/sync_live_photos
...
Synchronize operation on live photo files
2023-11-30 10:33:42 +01:00
Nextcloud bot
7cc66998a2
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-30 00:22:32 +00:00
Louis Chemineau
2f6a4bf4a1
Synchronize operation on live photo files
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-11-29 19:07:32 +01:00
Daniel Kesselberg
9f76600c88
fix: change mime type for msg file
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-11-29 12:27:55 +01:00
Daniel Kesselberg
dea865d247
fix: add mimetype for eml and msg
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-11-28 17:12:21 +01:00
Côme Chilliet
624f8f82ca
Merge pull request #41460 from nextcloud/feat/migrate-database-missing-checks
...
Migrate database missing checks
2023-11-28 14:06:19 +01:00
Git'Fellow
394cd75322
Merge pull request #41272 from nextcloud/fixOccScans
...
fix: reduce memory consumption of scans
2023-11-28 11:36:59 +01:00
Anna Larch
f19645adab
enh(userstatus): add OOO automation and remove calendar automation
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-11-28 10:28:06 +01:00
Arthur Schiwon
53f3149804
Merge pull request #41779 from nextcloud/bugfix/noid/use-destinct-exception-so-apps-dont-parse-messages
...
fix(API): Use a distinct exception so apps can react to it and custom…
2023-11-28 10:25:18 +01:00
Joas Schilling
f6b6776c93
fix(API): Use a distinct exception so apps can react to it and customize the return
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-28 06:11:57 +01:00
Nextcloud bot
79aa8bb64c
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-28 00:26:21 +00:00
Côme Chilliet
1b547c7db8
Migrate missing primary key database check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
ad88c04f2d
Migrate missing index database check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Côme Chilliet
2cb1c0f2dc
Migrate missing column database check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-27 15:23:52 +01:00
Joas Schilling
3ccb301853
Merge pull request #41578 from nextcloud/enh/noid/dispatcher-test-argument-range
...
Enable AppFramework dispatcher to enforce integer ranges
2023-11-27 10:40:50 +01:00
Nextcloud bot
010643394c
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-27 00:22:59 +00:00
Nextcloud bot
371aa1bc5d
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-26 00:23:38 +00:00
Nextcloud bot
28e0ccfed9
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-25 00:25:54 +00:00
Arthur Schiwon
3fa43a529b
enh(dispatcher): enforce psalm ranges in the http dispatcher
...
- allows devs to provide int ranges for API arguments
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-11-24 12:46:38 +01:00
Christoph Wurst
eeba809a52
Merge pull request #41440 from nextcloud/feat/dav/out-of-office-job
...
feat(dav): dispatch out-of-office started and ended events
2023-11-24 07:20:00 +01:00
Nextcloud bot
2ec9936b93
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-24 00:27:09 +00:00
Richard Steinmetz
8191295f66
feat(dav): dispatch out-of-office started and ended events
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-11-23 17:18:49 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Maxence Lange
ee787cd1c6
Merge pull request #41459 from nextcloud/enh/noid/search-metadata-null
...
implements search on null/notnull metadata
2023-11-23 07:52:27 -01:00
Kate
cd25b3a0d1
Merge pull request #41662 from nextcloud/chore/settings/cleanup-manager-type-annotations
2023-11-23 09:21:01 +01:00
jld3103
ae360080f5
chore(settings): Cleanup IManager and Manager type annotations
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-11-23 08:29:37 +01:00
Andy Scherzinger
42724c15c5
Merge pull request #40462 from nextcloud/refactor/lib-array_search-to-in_array
...
refactor: Replace array_search with in_array in lib/
2023-11-22 20:42:52 +01:00
Arthur Schiwon
99f945622f
Merge pull request #40071 from nextcloud/bugfix/noid/dont-block-admin-page-when-updater.nextcloud.com-is-down
...
fix(updatecheck): Don't wait 120s for a response of updater.nextcloud…
2023-11-22 15:18:18 +01:00
Louis Chemineau
a93af13c12
Fix is-define operator
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-11-22 12:43:27 -01:00
Maxence Lange
7467422f57
implements search on null/notnull metadata
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-22 12:43:27 -01:00
Ferdinand Thiessen
9c3321c524
Merge pull request #41565 from nextcloud/fix/object-storage-inconsitent-behavior
...
fix(ObjectStore): Make copying behavior consistent with local storage
2023-11-22 13:54:01 +01:00
Maxence Lange
8877f9bec9
Merge pull request #41653 from nextcloud/enh/noid/sync-token-on-retrievemetadata
...
get sync_token on retrieveMetadata()
2023-11-22 10:13:31 -01:00
Joas Schilling
053157b87e
fix(updatecheck): Don't wait 120s for a response of updater.nextcloud.com
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-22 11:44:43 +01:00
Arthur Schiwon
bc1da2fa54
Merge pull request #40114 from summersab/refactor/OC-Server-getAvatarManager
...
Refactor `OC\Server::getAvatarManager`
2023-11-22 11:43:51 +01:00
Christoph Wurst
ea8f9a7e84
refactor: Repalce array_search with in_array in lib/
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-11-22 11:42:53 +01:00
Benjamin Gaussorgues
ba1af2b22e
Merge pull request #41646 from nextcloud/feat/hide-search-provider
...
feat(search): hide search provider from list
2023-11-22 09:49:46 +01:00
Benjamin Gaussorgues
75e5854458
feat(search): hide search provider
...
Some search providers can be hidden if they send `null` in `getOrder`
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-22 08:47:53 +01:00
Maxence Lange
ff823cf926
accept boolean value
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-22 01:20:42 -01:00
Nextcloud bot
73ecc8f1db
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-22 00:24:44 +00:00
Maxence Lange
e37ab38780
get sync_token on retrieveMetadata()
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-21 21:11:13 -01:00
Louis
b9bd73a92d
Merge pull request #41540 from nextcloud/artonge/feat/add_metadata_generation_job
...
Add metadata generation job
2023-11-21 15:37:48 +01:00
Louis Chemineau
b63ddc73a2
Listen to cache event when deleting metadata
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-11-21 13:52:31 +01:00
Luka Trovic
b134e1cbc7
feat: update sign up link in share pages
...
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2023-11-21 10:10:37 +01:00
Nextcloud bot
0e433501bb
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-21 00:27:59 +00:00
Maxence Lange
ae71ed1e37
Merge pull request #41601 from nextcloud/enh/noid/named-metadata-event
...
add named metadata event
2023-11-20 22:20:29 -01:00
Joas Schilling
e5b996722a
Merge pull request #41616 from nextcloud/bugfix/noid/fix-ocs-absolute-URLs-with-ignore-front-controller
...
fix: Fix linkToOCSRouteAbsolute() without index.php and with subfolder
2023-11-20 17:00:43 +01:00
Maxence Lange
22d6c8dcd4
add named metadata event
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-20 13:32:54 -01:00
Joas Schilling
572ea18ac7
fix: Fix linkToOCSRouteAbsolute() without index.php and subfolder
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-20 11:18:47 +01:00
Simon L
753e7c2dff
Merge pull request #41544 from nextcloud/enh/noid/updatehtaccess-disk-space-check
2023-11-20 08:14:57 +01:00
Ferdinand Thiessen
ecf9f0a872
fix(CSP): Only add strict-dynamic
when using nonces
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-17 22:01:02 +01:00
Simon L
4c522f0f65
do not write htaccess file if disk space is too low
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-11-17 15:22:53 +01:00
Ferdinand Thiessen
e231abd9bf
fix!(ContentSecurityPolicy): Make strict-dynamic
enabled by default on script-src-elem
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-17 14:42:36 +01:00
Ferdinand Thiessen
5172baaf8b
fix(ObjectStore): Make copying behavior consistent with local storage
...
Drop file permissions on copy like we do on local storage.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-17 12:54:37 +01:00
Ferdinand Thiessen
7df9eb3351
feat(ContentSecurityPolicy): Allow to set strict-dynamic
on script-src-elem
only
...
This adds the possibility to set `strict-dynamic` on `script-src-elem` only while keep the default rules for `script-src`.
The idea is to allow loading module js which imports other files and thus does not allow nonces on import but on the initial script tag.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-17 11:12:57 +01:00
Nextcloud bot
158aedb549
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-17 00:27:03 +00:00
Marcel Müller
db3c731b0e
Merge pull request #41541 from nextcloud/fix/noid/serve-flac-files
...
Serve .flac audio files
2023-11-16 20:35:07 +01:00
Christoph Wurst
c9dc377ebc
Merge pull request #41395 from nextcloud/hello-emf
...
feat: add preview provider for emf files based on office
2023-11-16 19:48:06 +01:00
Benjamin Gaussorgues
23605d60dd
Merge pull request #41057 from nextcloud/registermounts-opt
...
optimize UserMountCache::registerStorage
2023-11-16 18:30:01 +01:00
Robin Appelman
b942850af9
optimize UserMountCache::registerStorage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-16 16:21:59 +01:00
Joas Schilling
7b45939561
Merge pull request #41511 from nextcloud/enh/advanced_search_backend
...
Enhancements for advanced search API
2023-11-16 15:41:27 +01:00
Louis Chemineau
a0ff998c00
Add metadata generation job
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-11-16 15:02:38 +01:00
Marcel Müller
eaf863dfdb
Serve .flac audio files
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2023-11-16 14:24:56 +01:00
Louis
9c3350b313
Merge pull request #41465 from nextcloud/artonge/migrate_metadata
...
Migrate old metadata table to the new ones
2023-11-16 11:20:57 +01:00
Louis Chemineau
95938d32d9
Add migration from the old to new metadata tables
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-11-16 09:21:55 +01:00
Joas Schilling
2fa78f6245
Reverse X-Forwarded-For list to read the correct proxy remote address
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-16 07:45:19 +01:00
Benjamin Gaussorgues
ae31d03217
Merge pull request #41486 from nextcloud/fix/41470/invalid_user_group
...
Fix invalid users/groups handling in advanced search
2023-11-16 02:50:09 +01:00
Nextcloud bot
f4d86818b2
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-16 00:28:36 +00:00
Christoph Wurst
33e07121d2
Merge pull request #41501 from nextcloud/feat/dav/show-ooo-ui-by-default
...
feat(dav): Enable OOO UI and expose enabled via OCP
2023-11-15 18:26:27 +01:00
Benjamin Gaussorgues
72c191df11
Introduce constants for builtin search filters
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-15 17:24:37 +01:00
Benjamin Gaussorgues
d79d85ddd2
Undeprecate getTerm
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-15 17:00:18 +01:00
Simon L
c2658bf913
Merge pull request #37959 from nextcloud/ob-proc
2023-11-15 16:47:59 +01:00
Benjamin Gaussorgues
82c164dabe
Change person type separator
...
`/` isn't allowed in UID, it will avoid conflicts
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-15 16:34:56 +01:00
Christoph Wurst
45541eb685
feat(dav): Enable OOO UI and expose enabled via OCP
...
Makes the feature opt-out now that we have meaningful integrations based
on OOO data. Allows instances still to turn the feature off.
For apps like Mail that build on top of this feature we need to know if
the instance has the feature turned on or off. This is exposed as OCP
API, too.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-11-15 15:53:38 +01:00
Christoph Wurst
ce6e3a3a01
Merge pull request #41495 from nextcloud/fix/ocp/register-availability-coordinator
...
fix(ocp): register IAvailabilityCoordinator service alias
2023-11-15 15:33:48 +01:00
Benjamin Gaussorgues
cb4e367a22
Merge pull request #40935 from nextcloud/local-case-insensitive
...
add some support for rename on case insensitive local filesystems
2023-11-15 13:58:44 +01:00
Richard Steinmetz
909b46bb53
fix(ocp): register IAvailabilityCoordinator service alias
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-11-15 13:32:36 +01:00
Benjamin Gaussorgues
33837e7d6f
Fix invalid users/groups handling in advanced search
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-15 10:17:43 +01:00
Julius Härtl
830d85bcf1
Merge pull request #41366 from ir0nhide/fix/multipart-copy-ssec
2023-11-15 08:24:06 +01:00
Git'Fellow
e0cafc8fe8
Merge pull request #38622 from nextcloud/ifElseReturnMatch
...
Replace if/else with return match
2023-11-15 00:05:52 +01:00
Git'Fellow
ef5f7d0a90
Us strpos() only
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-11-15 00:04:25 +01:00
Git'Fellow
53b84732a3
Check for open_basedir before reading /proc
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-11-15 00:04:25 +01:00
Tobias Zimmerer
cdf96fab92
fix(s3): support SSE-C headers for the MultipartCopy call
...
Signed-off-by: Tobias Zimmerer <3228193+ir0nhide@users.noreply.github.com>
2023-11-14 21:19:59 +01:00
Ferdinand Thiessen
927e7fcf67
fix(AppManager): Ensure that app manager can handle empty app keys on the navigation entries
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:04:48 +01:00
Ferdinand Thiessen
8d0c7cc5fa
fix: Allow to set custom app order on navigation entries added by closures to NavigationManager
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:03:28 +01:00
Ferdinand Thiessen
8bd9858345
fix(NavigationManager): Set default app in add
function to allow entries added as closures
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:03:28 +01:00
Ferdinand Thiessen
84acc49932
fix(NavigationManager): Check for appManager
before using it
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:03:28 +01:00
Ferdinand Thiessen
43a0016989
fix(INavigationManager): Add psalm typing for add
parameter
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-11-14 20:03:28 +01:00
Benjamin Gaussorgues
e90df6421a
Merge pull request #41432 from nextcloud/fix/white-user-icon-search
...
Fix search providers icons
2023-11-14 18:09:32 +01:00
Benjamin Gaussorgues
86a44514bd
Fix user search provider icon
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-14 17:51:21 +01:00
Maxence Lange
847c687a06
metadata must be set as editable for PROPPATCH
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-14 14:38:53 +01:00
Maxence Lange
761a688ec9
fix psalm
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-14 10:11:24 -01:00
Maxence Lange
3af12b2a50
ignore metadata if table is empty
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-14 09:28:58 -01:00
Arthur Schiwon
f313b12d54
Merge pull request #41436 from nextcloud/feat/introduce-inAppSearch-method-for-advanced-search
...
Add `inAppSearch` for advanced search providers
2023-11-14 11:13:48 +01:00
Arthur Schiwon
5f69640006
Merge pull request #41446 from nextcloud/fix/noid/moving-metadataquery
...
moving IMetadataQuery
2023-11-14 11:11:06 +01:00
Benjamin Gaussorgues
174b76fff3
Add new method inAppSearch
for advanced search providers
...
Allows to indicates if a search provider also support in app search
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-14 09:58:20 +01:00
Nextcloud bot
6284009fa0
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-14 00:25:51 +00:00
Maxence Lange
380b81315a
moving metadataquery
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-13 22:25:37 -01:00
Daniel Kesselberg
475dd60354
fix: use png as preview right away
...
The initial office preview implementation converted an office document with LibreOffice to PDF, used ImageMagick to extract the first page as JPEG, and passed it OC_Image.
https://github.com/nextcloud/server/pull/10198 changed the implementation to use PNG rather than PDF. OC_Image can use a PNG as a preview right away, so the ImageMagick step is unnecessary.
The registration code was updated to not ask ImageMagick if PDF is supported, as PDFs are no longer used to create office document previews.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-11-13 22:00:45 +01:00
Daniel Kesselberg
b5241d5220
feat: allow multiple libreoffice invocations
...
LibreOffice only allows one invocation per user profile.[^1]
The office provider set the user profile to /tmp/owncloud-instanceid and therefore only one invocation per instance is allowed. This was introduced a while ago, yet it's unclear if this was intentionally or just a side effect.[^2]
The limitation on one invocation leads to the situation that the preview generation only works for a couple of files if you upload a whole folder of emf or word files.
This commit removes the limitation by using a new user profile for each preview. That's done by using instance id plus file id as postfix for getTemporaryFolder.
This has some drawbacks:
- Overload protection: If you upload 100 emf files, you may end up with 100 LibreOffice invocations. Though, you can use preview_concurrency_new to limit the number of previews that can be generated concurrently when php-sysvsem is available.
- New profile: I assume it takes a few bits to generate a fresh LibreOffice user profile. It appears that there is no way to ask LibreOffice to not create a profile and just work with the defaults. The profile will be cleaned after use by our temp manager.
- Remove the configuration option preview_office_cl_parameters: This is not strictly necessary yet, but if you set the configuration option, the generated path for the user profile is also missing. The configuration option is not well documented (e.g., it's unclear that the last option needs to be --outdir) and actually, there should be no reason to change it after all.
[^1]: https://wiki.documentfoundation.org/UserProfile
[^2]: https://github.com/owncloud/core/pull/9784
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-11-13 21:46:31 +01:00
Arthur Schiwon
93505b2cdd
fix(workflowengine): use andWhere() not second where()
...
- an unconditional where() condition is added right before
- fixes also wrongly named methods in the Exception message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-11-13 14:47:47 +01:00
Joas Schilling
073ec6d217
Merge pull request #41406 from nextcloud/bugfix/noid/log-exception-class-when-message-is-empty
...
fix(log): Log exception class when message is empty
2023-11-13 14:28:52 +01:00
Joas Schilling
a5684ea3d2
fix(log): Log exception class when message is empty
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-13 12:45:35 +01:00
Daniel Kesselberg
aa48a5f94f
feat: add preview provider for emf files based on office
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-11-13 12:35:54 +01:00
Joas Schilling
0feb55ee93
Merge pull request #41271 from nextcloud/enh/text-processing-iprovider2
...
enh(TextProcessing): Add two new provider interfaces
2023-11-13 10:49:14 +01:00
Nextcloud bot
d3776e0e00
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-11-12 00:24:19 +00:00