When using fake servers with Sinon.JS, the JavaScript test framework, the XHR objects are also fake. In Sinon 5.0.8 the "setRequestHeader" of XMLHttpRequest was modified to normalize the header values (as requested by the spec), but since then only string values are accepted; null or integer values can no longer be passed to "setRequestHeader", as it expects the "replace" function to be available in the object. However, in the tests null and integer values are passed to "setRequestHeader", which causes them to fail. Both Firefox and Chromium accept passing non-string values to their "setRequestHeader" implementation, and it is done, for example, in davclient.js; it is not clear yet whether Sinon got too restrictive or the code calling "setRequestHeader" was too loose. Given that davclient.js is an external dependency, as a temporary measure Sinon version is forced to be 5.0.7 at most until either Sinon or davclient.js are updated. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com> |
6 years ago | |
---|---|---|
.. | ||
.ci-conf | Adding magic file to enable oci on pull request testing on ci.owncloud.org | 9 years ago |
.phan | Check doc block signature to match the specified return type | 6 years ago |
integration | Return proper boolean user enabled state api | 6 years ago |
.htaccess | Only request "IndexIgnore" if mod_autoindex is loaded | 7 years ago |
OCPSinceChecker.php | $this->blackListedClassNames is unknown | 7 years ago |
autoloaderchecker.sh | Update autoload checker | 6 years ago |
build.xml | cleaning up the build directory | 9 years ago |
files-checker.php | Remove .lgtm file | 6 years ago |
gen-coverage-badge.php | Add script to generate coverage badges | 8 years ago |
htaccess-checker.php | Add .htaccess checker as CI step | 7 years ago |
image-optimization.sh | Move image-optimization.sh to build dir | 7 years ago |
jsdocs9.tar.bz2 | Update integration tests for system tags with groups | 8 years ago |
license.php | Remove brackets for invalid mail addresses when updating the license header | 6 years ago |
mergejs.php | Resolves warnings in Chrome Dev Console: | 6 years ago |
mergejschecker.sh | Add CI step to verify merged vendor js | 7 years ago |
package.json | Limit Sinon version to 5.0.7 at most | 6 years ago |
signed-off-checker.php | Add auth token to github requests | 6 years ago |
translation-checker.php | Loop over the apps directory and add the task | 7 years ago |