Browse Source

BcelObjectType: Add experimental code to set source file name for

reference

Experimental code leading to undesired ripple effects elsewhere,
requiring more rework which now I do not feel inclined to invest to
perfect source file string representation for post-compile binary
classes and aspects.

Relates to #218.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
pull/138/merge
Alexander Kriegisch 2 weeks ago
parent
commit
a3f62b57ca
1 changed files with 13 additions and 4 deletions
  1. 13
    4
      weaver/src/main/java/org/aspectj/weaver/bcel/BcelObjectType.java

+ 13
- 4
weaver/src/main/java/org/aspectj/weaver/bcel/BcelObjectType.java View File

@@ -159,10 +159,19 @@ public class BcelObjectType extends AbstractReferenceTypeDelegate {
// the only class in Java-1.4 with no superclasses
isObject = (javaClass.getSuperclassNameIndex() == 0);
ensureAspectJAttributesUnpacked();
// if (sourceContext instanceof SourceContextImpl) {
// ((SourceContextImpl)sourceContext).setSourceFileName(javaClass.
// getSourceFileName());
// }

// Experimental code leading to undesired ripple effects elsewhere, requiring more rework
/*
final String fileName = javaClass.getFileName();
final String sourceFileName = javaClass.getSourceFileName();
if (fileName == null || !fileName.endsWith(".class"))
setSourcefilename(sourceFileName);
else if (sourceFileName == null || sourceFileName.isEmpty() || sourceFileName.endsWith(".class"))
setSourcefilename(fileName);
else
setSourcefilename(fileName + " (from " + sourceFileName + ")");
*/

setSourcefilename(javaClass.getSourceFileName());
}


Loading…
Cancel
Save