Browse Source

made synchronized method message a lint warning

tags/Root_extensions
aclement 17 years ago
parent
commit
f1ce9eb89f

+ 5
- 0
tests/src/org/aspectj/systemtest/ajc152/SynchronizationTransformTests.java View File

@@ -113,6 +113,11 @@ public class SynchronizationTransformTests extends XMLBasedAjcTestCase {
runTest("Two");
checkMethod("C","ma");
}

public void testTransform2XlintOff() {
runTest("Two - xlintoff");
checkMethod("C","ma");
}
// after() returning/after() throwing on execution jp
// after() returning -> make all returns go through the same exit point and make

+ 15
- 5
tests/src/org/aspectj/systemtest/ajc152/synchronization.xml View File

@@ -430,7 +430,7 @@
<ajc-test dir="features152/synchronization/transformed" title="Two">
<compile files="Two.java -Xjoinpoints:synchronization">
<message kind="warning" line="14" text="advice matching the synchronized method shadow 'method-execution(void C.ma())' will be executed outside the lock rather than inside (compiler limitation)"/>
<message kind="warning" line="14" text="advice matching the synchronized method shadow 'method-execution(void C.ma())' will be executed outside the lock rather than inside (compiler limitation) [Xlint"/>
</compile>
<run class="Two">
<stderr>
@@ -440,10 +440,20 @@
</run>
</ajc-test>
<ajc-test dir="features152/synchronization/transformed" title="Two - xlintoff">
<compile files="Two.java -Xjoinpoints:synchronization -Xlint:ignore"/>
<run class="Two">
<stderr>
<line text="execution advice running"/>
<line text="hello"/>
</stderr>
</run>
</ajc-test>
<ajc-test dir="features152/synchronization/transformed" title="Three">
<compile files="Three.java -Xjoinpoints:synchronization">
<message kind="warning" line="20" text="advice matching the synchronized method shadow 'method-execution(void C.m3())' will be executed outside the lock rather than inside (compiler limitation)"/>
<message kind="warning" line="24" text="advice matching the synchronized method shadow 'method-execution(void C.m32())' will be executed outside the lock rather than inside (compiler limitation)"/>
<message kind="warning" line="20" text="advice matching the synchronized method shadow 'method-execution(void C.m3())' will be executed outside the lock rather than inside (compiler limitation) [Xlint"/>
<message kind="warning" line="24" text="advice matching the synchronized method shadow 'method-execution(void C.m32())' will be executed outside the lock rather than inside (compiler limitation) [Xlint"/>
</compile>
<run class="Three">
<stderr>
@@ -461,8 +471,8 @@
<ajc-test dir="features152/synchronization/transformed" title="Four">
<compile files="Four.java -Xjoinpoints:synchronization">
<message kind="warning" line="16" text="advice matching the synchronized method shadow 'method-execution(void C.m())' will be executed outside the lock rather than inside (compiler limitation)"/>
<message kind="warning" line="20" text="advice matching the synchronized method shadow 'method-execution(void C.m2())' will be executed outside the lock rather than inside (compiler limitation)"/>
<message kind="warning" line="16" text="advice matching the synchronized method shadow 'method-execution(void C.m())' will be executed outside the lock rather than inside (compiler limitation) [Xlint"/>
<message kind="warning" line="20" text="advice matching the synchronized method shadow 'method-execution(void C.m2())' will be executed outside the lock rather than inside (compiler limitation) [Xlint"/>
</compile>
<run class="Four">
<stderr>

Loading…
Cancel
Save