StringBuffer is a legacy synchronized class. StringBuilder is a direct replacement to StringBuffer which generally have better performance.

This was required by the Eclipse team as one precondition for the next
release.

Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>

Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>

Reports any String.indexOf() expressions which can be replaced with a call to the String.contains() method available in Java 5 and newer.

Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>

Reports for loops which iterate over collections or arrays, and can be replaced with an enhanced for loop (i.e. the foreach iteration syntax).

Signed-off-by: Lars Grefer <eclipse@larsgrefer.de>

	  	Avoid clashes in the org.eclipse namespace by renaming our duplicates.

	  	Bogus error message: The abstract method ajc$pointcut$$tracingScope$a2 in type Tracing can only be defined by an abstract class

 	wrong line for method execution join point

removed unused imports, local variables, and private methods
(still there, just commented out).

default mode (inherited behaviour from JDT).

Bugzilla Bug 42740
	  	declare error fails on pointcuts composed from multiple classes
Bugzilla Bug 42746
	  	within() pcd is confused for certain declare softs

and probably:
Bugzilla Bug 42739
	  	Compiler crash in ajc head (post 1.1.1 rc1)

	  	super-qualified pointcut reference cause weaver stack trace
and Bugzilla Bug 40814
	  	no error when defining interface pointcuts

   compiler error expected for implemented abstract pointcuts 
(using declaredModifiers instead of modifiers so interfaces don't cause trouble)

   compiler error expected for implemented abstract pointcuts

In the process of this many changes were made to try to make
keeping up with the Eclipse-JDT code base as easy as possible in
the future.

should make incremental compilation and using binary aspect libraries
work MUCH better.
The current state doesn't fix any of those issues, but it also does
continue to pass all of the existing tests.

clears up a huge set of warnings in Eclipse so that you
can see the wood for the trees!