You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

GenericITDsDesign.java 11KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254
  1. package org.aspectj.systemtest.ajc150;
  2. import java.io.File;
  3. import java.util.Hashtable;
  4. import java.util.Iterator;
  5. import java.util.List;
  6. import org.aspectj.apache.bcel.classfile.Attribute;
  7. import org.aspectj.apache.bcel.classfile.Field;
  8. import org.aspectj.apache.bcel.classfile.JavaClass;
  9. import org.aspectj.apache.bcel.classfile.Signature;
  10. import org.aspectj.apache.bcel.util.ClassPath;
  11. import org.aspectj.apache.bcel.util.SyntheticRepository;
  12. import org.aspectj.testing.XMLBasedAjcTestCase;
  13. import org.aspectj.tools.ajc.Ajc;
  14. import org.aspectj.weaver.ConcreteTypeMunger;
  15. import org.aspectj.weaver.CrosscuttingMembers;
  16. import org.aspectj.weaver.ReferenceType;
  17. import org.aspectj.weaver.ResolvedMember;
  18. import org.aspectj.weaver.ResolvedType;
  19. import org.aspectj.weaver.ResolvedTypeMunger;
  20. import org.aspectj.weaver.TypeVariable;
  21. import org.aspectj.weaver.TypeVariableReference;
  22. import org.aspectj.weaver.World;
  23. import org.aspectj.weaver.bcel.BcelTypeMunger;
  24. import org.aspectj.weaver.bcel.BcelWorld;
  25. import junit.framework.Test;
  26. public class GenericITDsDesign extends XMLBasedAjcTestCase {
  27. private World recentWorld;
  28. public static Test suite() {
  29. return XMLBasedAjcTestCase.loadSuite(GenericITDsDesign.class);
  30. }
  31. @Override
  32. protected java.net.URL getSpecFile() {
  33. return getClassResource("ajc150.xml");
  34. }
  35. private void verifyDebugString(ResolvedMember theMember, String string) {
  36. assertTrue("Expected '" + string + "' but found " + theMember.toDebugString(), theMember.toDebugString().equals(string));
  37. }
  38. public static JavaClass getClassFromDisk(Ajc ajc, String classname) {
  39. try {
  40. ClassPath cp = new ClassPath(ajc.getSandboxDirectory() + File.pathSeparator + System.getProperty("java.class.path"));
  41. SyntheticRepository sRepos = SyntheticRepository.getInstance(cp);
  42. return sRepos.loadClass(classname);
  43. } catch (ClassNotFoundException e) {
  44. fail("Couldn't find class " + classname + " in the sandbox directory.");
  45. }
  46. return null;
  47. }
  48. public static Signature getClassSignature(Ajc ajc, String classname) {
  49. JavaClass clazz = getClassFromDisk(ajc, classname);
  50. Signature sigAttr = null;
  51. Attribute[] attrs = clazz.getAttributes();
  52. for (int i = 0; i < attrs.length; i++) {
  53. Attribute attribute = attrs[i];
  54. if (attribute.getName().equals("Signature")) {
  55. sigAttr = (Signature) attribute;
  56. }
  57. }
  58. return sigAttr;
  59. }
  60. // Check the signature attribute on a class is correct
  61. public static void verifyClassSignature(Ajc ajc, String classname, String sig) {
  62. Signature sigAttr = getClassSignature(ajc, classname);
  63. assertTrue("Failed to find signature attribute for class " + classname, sigAttr != null);
  64. assertTrue("Expected signature to be '" + sig + "' but was '" + sigAttr.getSignature() + "'", sigAttr.getSignature()
  65. .equals(sig));
  66. }
  67. public List<ConcreteTypeMunger> getTypeMunger(String classname) {
  68. ClassPath cp = new ClassPath(ajc.getSandboxDirectory() + File.pathSeparator + System.getProperty("java.class.path"));
  69. recentWorld = new BcelWorld(cp.toString());
  70. ReferenceType resolvedType = (ReferenceType) recentWorld.resolve(classname);
  71. CrosscuttingMembers cmembers = resolvedType.collectCrosscuttingMembers(true);
  72. List<ConcreteTypeMunger> tmungers = cmembers.getTypeMungers();
  73. return tmungers;
  74. }
  75. private BcelTypeMunger getMungerFromLine(String classname, int linenumber) {
  76. List allMungers = getTypeMunger(classname);
  77. for (Iterator iter = allMungers.iterator(); iter.hasNext();) {
  78. BcelTypeMunger element = (BcelTypeMunger) iter.next();
  79. if (element.getMunger().getSourceLocation().getLine() == linenumber) {
  80. return element;
  81. }
  82. }
  83. for (Iterator iter = allMungers.iterator(); iter.hasNext();) {
  84. BcelTypeMunger element = (BcelTypeMunger) iter.next();
  85. System.err.println("Line: " + element.getMunger().getSourceLocation().getLine() + " > " + element);
  86. }
  87. fail("Couldn't find a type munger from line " + linenumber + " in class " + classname);
  88. return null;
  89. }
  90. public Hashtable<String,Field> getMeTheFields(String classname) {
  91. JavaClass theClass = getClassFromDisk(ajc, classname);
  92. Hashtable<String,Field> retval = new Hashtable<>();
  93. org.aspectj.apache.bcel.classfile.Field[] fs = theClass.getFields();
  94. for (int i = 0; i < fs.length; i++) {
  95. Field field = fs[i];
  96. retval.put(field.getName(), field);
  97. }
  98. return retval;
  99. }
  100. /*
  101. * test plan: 1. Serializing and recovering 'default bounds' type variable info: a. methods b. fields c. ctors 2. Serializing
  102. * and recovering 'extends' with a class bounded type variable info: a. methods b. fields c. ctors 3. Serializing and recovering
  103. * 'extends' with an interface bounded type variable info: a. methods b. fields c. ctors 4. Multiple interface bounds a. methods
  104. * b. fields c. ctors 5. wildcard bounds '? extends/? super' a. methods b. fields c. ctors 6. using type variables in an ITD
  105. * from the containing aspect, no bounds a. methods b. fields c. ctors
  106. */
  107. // Verify: a) After storing it in a class file and recovering it (through deserialization), we can see the type
  108. // variable and that the parameter refers to the type variable.
  109. public void testDesignA() {
  110. runTest("generic itds - design A");
  111. BcelTypeMunger theBcelMunger = getMungerFromLine("X", 5);
  112. ResolvedType typeC = recentWorld.resolve("C");
  113. ResolvedTypeMunger rtMunger = theBcelMunger.getMunger();
  114. ResolvedMember theMember = rtMunger.getSignature();
  115. // Let's check all parts of the member
  116. assertTrue("Declaring type should be C: " + theMember, theMember.getDeclaringType().equals(typeC));
  117. TypeVariable tVar = theMember.getTypeVariables()[0];
  118. TypeVariableReference tvrt = (TypeVariableReference) theMember.getParameterTypes()[0];
  119. theMember.resolve(recentWorld); // resolution will join the type variables together (i.e. make them refer to the same
  120. // instance)
  121. tVar = theMember.getTypeVariables()[0];
  122. tvrt = (TypeVariableReference) theMember.getParameterTypes()[0];
  123. assertTrue(
  124. "Post resolution, the type variable in the parameter should be identical to the type variable declared on the member",
  125. tVar == tvrt.getTypeVariable());
  126. }
  127. // Verify: bounds are preserved and accessible after serialization
  128. public void testDesignB() {
  129. runTest("generic itds - design B");
  130. BcelTypeMunger theBcelMunger = getMungerFromLine("X", 7);
  131. ResolvedTypeMunger rtMunger = theBcelMunger.getMunger();
  132. ResolvedMember theMember = rtMunger.getSignature();
  133. verifyDebugString(theMember, "<T extends java.lang.Number> void C.m0(T)");
  134. theBcelMunger = getMungerFromLine("X", 9);
  135. rtMunger = theBcelMunger.getMunger();
  136. theMember = rtMunger.getSignature();
  137. verifyDebugString(theMember, "<Q extends I> void C.m1(Q)");
  138. theBcelMunger = getMungerFromLine("X", 11);
  139. rtMunger = theBcelMunger.getMunger();
  140. theMember = rtMunger.getSignature();
  141. verifyDebugString(theMember, "<R extends java.lang.Number,I> void C.m2(R)");
  142. }
  143. // Verify: a) multiple type variables work.
  144. // b) type variables below the 'top level' (e.g. List<A>) are preserved.
  145. public void testDesignC() {
  146. runTest("generic itds - design C");
  147. BcelTypeMunger theBcelMunger = getMungerFromLine("X", 9);
  148. // System.err.println(theBcelMunger.getMunger().getSignature().toDebugString());
  149. verifyDebugString(theBcelMunger.getMunger().getSignature(), "<T extends java.lang.Number,Q extends I> void C.m0(T, Q)");
  150. theBcelMunger = getMungerFromLine("X", 11);
  151. // System.err.println(theBcelMunger.getMunger().getSignature().toDebugString());
  152. verifyDebugString(theBcelMunger.getMunger().getSignature(), "<A,B,C> java.util.List<A> C.m1(B, java.util.Collection<C>)");
  153. }
  154. // Verify: a) sharing type vars with some target type results in the correct variable names in the serialized form
  155. public void testDesignD() {
  156. runTest("generic itds - design D");
  157. BcelTypeMunger theBcelMunger = getMungerFromLine("X", 9);
  158. // System.err.println(theBcelMunger.getMunger().getSignature().toDebugString());
  159. verifyDebugString(theBcelMunger.getMunger().getSignature(), "void C.m0(R)");
  160. theBcelMunger = getMungerFromLine("X", 11);
  161. // System.err.println(theBcelMunger.getMunger().getSignature().toDebugString());
  162. verifyDebugString(theBcelMunger.getMunger().getSignature(),
  163. "java.util.List<Q> C.m0(Q, int, java.util.List<java.util.List<Q>>)");
  164. }
  165. // Verify: a) for fields, sharing type vars with some target type results in the correct entries in the class file
  166. public void testDesignE() {
  167. runTest("generic itds - design E");
  168. BcelTypeMunger theBcelMunger = getMungerFromLine("X", 9);
  169. verifyDebugString(theBcelMunger.getMunger().getSignature(), "java.util.List<Z> C.ln");
  170. assertTrue("Expected to find \"Z\": " + theBcelMunger.getTypeVariableAliases(), theBcelMunger.getTypeVariableAliases()
  171. .contains("Z"));
  172. theBcelMunger = getMungerFromLine("X", 11);
  173. verifyDebugString(theBcelMunger.getMunger().getSignature(), "Q C.n");
  174. assertTrue("Expected to find \"Q\": " + theBcelMunger.getTypeVariableAliases(), theBcelMunger.getTypeVariableAliases()
  175. .contains("Q"));
  176. }
  177. // Verifying what gets into a class targetted with a field ITD
  178. public void testDesignF() {
  179. runTest("generic itds - design F");
  180. Hashtable<String,Field> fields = getMeTheFields("C");
  181. // Declared in src as: List C.list1; and List<Z> C<Z>.list2;
  182. Field list1 = (Field) fields.get("list1");// ajc$interField$$list1");
  183. assertTrue("Field list1 should be of type 'Ljava/util/List;' but is " + list1.getSignature(), list1.getSignature().equals(
  184. "Ljava/util/List;"));
  185. Field list2 = (Field) fields.get("list2");// ajc$interField$$list1");
  186. assertTrue("Field list2 should be of type 'Ljava/util/List;' but is " + list2.getSignature(), list2.getSignature().equals(
  187. "Ljava/util/List;"));
  188. // Declared in src as: String C.field1; and Q C<Q>.field2;
  189. // bound for second field collapses to Object
  190. Field field1 = (Field) fields.get("field1");// ajc$interField$$field1");
  191. assertTrue("Field list1 should be of type 'Ljava/lang/String;' but is " + field1.getSignature(), field1.getSignature()
  192. .equals("Ljava/lang/String;"));
  193. Field field2 = (Field) fields.get("field2");// ajc$interField$$field2");
  194. assertTrue("Field list2 should be of type 'Ljava/lang/Object;' but is " + field2.getSignature(), field2.getSignature()
  195. .equals("Ljava/lang/Object;"));
  196. }
  197. // Verifying what gets into a class when an interface it implements was targetted with a field ITD
  198. public void testDesignG() {
  199. runTest("generic itds - design G");
  200. Hashtable<String,Field> fields = getMeTheFields("C");
  201. // The ITDs are targetting an interface. That interface is generic and is parameterized with
  202. // 'String' when implemented in the class C. This means the fields that make it into C should
  203. // be parameterized with String also.
  204. // List<Z> I<Z>.ln; and Q I<Q>.n;
  205. // Field field1 = (Field)fields.get("ajc$interField$X$I$ln");
  206. // assertTrue("Field list1 should be of type 'Ljava/util/List;' but is "+field1.getSignature(),
  207. // field1.getSignature().equals("Ljava/util/List;"));
  208. // Field field2 = (Field)fields.get("ajc$interField$X$I$n");
  209. // assertTrue("Field list2 should be of type 'Ljava/lang/String;' but is "+field2.getSignature(),
  210. // field2.getSignature().equals("Ljava/lang/String;"));
  211. }
  212. // // Verify: a) sharing type vars with some target type results in the correct variable names in the serialized form
  213. // public void testDesignE() {
  214. // runTest("generic itds - design E");
  215. //
  216. // }
  217. }