Browse Source

Fix warnings

tags/release-3.0.0
Decebal Suiu 5 years ago
parent
commit
6addff34e2

+ 1
- 8
pf4j/src/main/java/org/pf4j/BasePluginRepository.java View File

this.filter = filter; this.filter = filter;


// last modified file is first // last modified file is first
this.comparator = new Comparator<File>() {

@Override
public int compare(File o1, File o2) {
return (int) (o2.lastModified() - o1.lastModified());
}

};
this.comparator = (o1, o2) -> (int) (o2.lastModified() - o1.lastModified());
} }


public void setFilter(FileFilter filter) { public void setFilter(FileFilter filter) {

+ 1
- 1
pf4j/src/main/java/org/pf4j/ManifestPluginDescriptorFinder.java View File

} }
} }


protected Path getManifestPath(Path pluginPath) throws PluginException {
protected Path getManifestPath(Path pluginPath) {
if (Files.isDirectory(pluginPath)) { if (Files.isDirectory(pluginPath)) {
// legacy (the path is something like "classes/META-INF/MANIFEST.MF") // legacy (the path is something like "classes/META-INF/MANIFEST.MF")
return FileUtils.findFile(pluginPath,"MANIFEST.MF"); return FileUtils.findFile(pluginPath,"MANIFEST.MF");

+ 2
- 4
pf4j/src/main/java/org/pf4j/PluginWrapper.java View File

} }


PluginWrapper other = (PluginWrapper) obj; PluginWrapper other = (PluginWrapper) obj;
if (!descriptor.getPluginId().equals(other.descriptor.getPluginId())) {
return false;
}


return true;
return descriptor.getPluginId().equals(other.descriptor.getPluginId());

} }


@Override @Override

+ 1
- 5
pf4j/src/main/java/org/pf4j/processor/ExtensionAnnotationProcessor.java View File

String extension = getBinaryName(extensionElement); String extension = getBinaryName(extensionElement);
for (TypeElement extensionPointElement : extensionPointElements) { for (TypeElement extensionPointElement : extensionPointElements) {
String extensionPoint = getBinaryName(extensionPointElement); String extensionPoint = getBinaryName(extensionPointElement);
Set<String> extensionPoints = extensions.get(extensionPoint);
if (extensionPoints == null) {
extensionPoints = new TreeSet<>();
extensions.put(extensionPoint, extensionPoints);
}
Set<String> extensionPoints = extensions.computeIfAbsent(extensionPoint, k -> new TreeSet<>());
extensionPoints.add(extension); extensionPoints.add(extension);
} }
} }

+ 5
- 7
pf4j/src/main/java/org/pf4j/util/AndFileFilter.java View File

import java.util.List; import java.util.List;


/** /**
* This filter providing conditional AND logic across a list of
* file filters. This filter returns <code>true</code> if all filters in the
* list return <code>true</code>. Otherwise, it returns <code>false</code>.
* Checking of the file filter list stops when the first filter returns
* <code>false</code>.
* This filter providing conditional AND logic across a list of file filters.
* This filter returns {@code true} if all filters in the list return {@code true}. Otherwise, it returns {@code false}.
* Checking of the file filter list stops when the first filter returns {@code false}.
* *
* @author Decebal Suiu * @author Decebal Suiu
*/ */
private List<FileFilter> fileFilters; private List<FileFilter> fileFilters;


public AndFileFilter() { public AndFileFilter() {
this(new ArrayList<FileFilter>());
this(new ArrayList<>());
} }


public AndFileFilter(FileFilter... fileFilters) { public AndFileFilter(FileFilter... fileFilters) {


@Override @Override
public boolean accept(File file) { public boolean accept(File file) {
if (this.fileFilters.size() == 0) {
if (this.fileFilters.isEmpty()) {
return false; return false;
} }



+ 5
- 5
pf4j/src/main/java/org/pf4j/util/DirectedGraph.java View File

return; return;
} }


neighbors.put(vertex, new ArrayList<V>());
neighbors.put(vertex, new ArrayList<>());
} }


/** /**
} }


public List<V> getNeighbors(V vertex) { public List<V> getNeighbors(V vertex) {
return containsVertex(vertex) ? neighbors.get(vertex) : new ArrayList<V>();
return containsVertex(vertex) ? neighbors.get(vertex) : new ArrayList<>();
} }


/** /**
} }


/** /**
* Report (as a Map) the in-degree (the number of head ends adjacent to a vertex) of each vertex.
* Report (as a {@link Map}) the in-degree (the number of head ends adjacent to a vertex) of each vertex.
*/ */
public Map<V, Integer> inDegree() { public Map<V, Integer> inDegree() {
Map<V, Integer> result = new HashMap<>(); Map<V, Integer> result = new HashMap<>();
*/ */
@Override @Override
public String toString() { public String toString() {
StringBuffer sb = new StringBuffer();
StringBuilder sb = new StringBuilder();
for (V vertex : neighbors.keySet()) { for (V vertex : neighbors.keySet()) {
sb.append("\n " + vertex + " -> " + neighbors.get(vertex));
sb.append("\n ").append(vertex).append(" -> ").append(neighbors.get(vertex));
} }


return sb.toString(); return sb.toString();

+ 5
- 7
pf4j/src/main/java/org/pf4j/util/OrFileFilter.java View File

import java.util.List; import java.util.List;


/** /**
* This filter providing conditional OR logic across a list of
* file filters. This filter returns <code>true</code> if one filter in the
* list return <code>true</code>. Otherwise, it returns <code>false</code>.
* Checking of the file filter list stops when the first filter returns
* <code>true</code>.
* This filter providing conditional OR logic across a list of file filters.
* This filter returns {@code true} if one filter in the list return {@code true}. Otherwise, it returns {@code false}.
* Checking of the file filter list stops when the first filter returns {@code true}.
* *
* @author Decebal Suiu * @author Decebal Suiu
*/ */
private List<FileFilter> fileFilters; private List<FileFilter> fileFilters;


public OrFileFilter() { public OrFileFilter() {
this(new ArrayList<FileFilter>());
this(new ArrayList<>());
} }


public OrFileFilter(FileFilter... fileFilters) { public OrFileFilter(FileFilter... fileFilters) {


@Override @Override
public boolean accept(File file) { public boolean accept(File file) {
if (this.fileFilters.size() == 0) {
if (this.fileFilters.isEmpty()) {
return true; return true;
} }



Loading…
Cancel
Save