- fixed "equals() method does not check for null argument" - see http://findbugs.sourceforge.net/bugDescriptions.html#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568812 13f79535-47bb-0310-9956-ffa450edef68tags/REL_3_11_BETA1
@Override | @Override | ||||
public String toString(){ | public String toString(){ | ||||
return packagePart == null ? null : packagePart.toString(); | |||||
return packagePart == null ? "" : packagePart.toString(); | |||||
} | } | ||||
/** | /** |
assertNull(part.getRelationId(null)); | assertNull(part.getRelationId(null)); | ||||
assertFalse(part.removeRelation(null, true)); | assertFalse(part.removeRelation(null, true)); | ||||
part.removeRelation(null); | part.removeRelation(null); | ||||
assertNull(part.toString()); | |||||
assertEquals("",part.toString()); | |||||
part.onDocumentCreate(); | part.onDocumentCreate(); | ||||
//part.getTargetPart(null); | //part.getTargetPart(null); | ||||
} | } |
} | } | ||||
@Override | @Override | ||||
public boolean equals(Object o) | |||||
{ | |||||
boolean retVal = true; | |||||
if (((Ffn)o).get_cbFfnM1() == _cbFfnM1) | |||||
{ | |||||
if(((Ffn)o)._info == _info) | |||||
{ | |||||
if(((Ffn)o)._wWeight == _wWeight) | |||||
{ | |||||
if(((Ffn)o)._chs == _chs) | |||||
{ | |||||
if(((Ffn)o)._ixchSzAlt == _ixchSzAlt) | |||||
{ | |||||
if(Arrays.equals(((Ffn)o)._panose,_panose)) | |||||
{ | |||||
if(Arrays.equals(((Ffn)o)._fontSig,_fontSig)) | |||||
{ | |||||
if(!(Arrays.equals(((Ffn)o)._xszFfn,_xszFfn))) | |||||
retVal = false; | |||||
} | |||||
else | |||||
retVal = false; | |||||
} | |||||
else | |||||
retVal = false; | |||||
} | |||||
else | |||||
retVal = false; | |||||
} | |||||
else | |||||
retVal = false; | |||||
} | |||||
else | |||||
retVal = false; | |||||
} | |||||
else | |||||
retVal = false; | |||||
} | |||||
else | |||||
retVal = false; | |||||
return retVal; | |||||
public boolean equals(Object other) { | |||||
if (!(other instanceof Ffn)) return false; | |||||
Ffn o = (Ffn)other; | |||||
return ( | |||||
o._cbFfnM1 == this._cbFfnM1 | |||||
&& o._info == this._info | |||||
&& o._wWeight == _wWeight | |||||
&& o._chs == _chs | |||||
&& o._ixchSzAlt == _ixchSzAlt | |||||
&& Arrays.equals(o._panose,_panose) | |||||
&& Arrays.equals(o._fontSig,_fontSig) | |||||
&& Arrays.equals(o._xszFfn,_xszFfn) | |||||
); | |||||
} | } | ||||
} | } | ||||
@Override | @Override | ||||
public boolean equals(Object o) | |||||
{ | |||||
boolean retVal = true; | |||||
if(((FontTable)o).getStringCount() == _stringCount) | |||||
{ | |||||
if(((FontTable)o).getExtraDataSz() == _extraDataSz) | |||||
{ | |||||
Ffn[] fontNamesNew = ((FontTable)o).getFontNames(); | |||||
for(int i = 0;i<_stringCount; i++) | |||||
{ | |||||
if(!(_fontNames[i].equals(fontNamesNew[i]))) | |||||
retVal = false; | |||||
} | |||||
public boolean equals(Object other) { | |||||
if (!(other instanceof FontTable)) return false; | |||||
FontTable o = (FontTable)other; | |||||
if (o._stringCount != this._stringCount | |||||
|| o._extraDataSz != this._extraDataSz | |||||
|| o._fontNames.length != this._fontNames.length | |||||
) return false; | |||||
for (int i=0; i<o._fontNames.length; i++) { | |||||
if (!o._fontNames[i].equals(this._fontNames[i])) return false; | |||||
} | } | ||||
else | |||||
retVal = false; | |||||
} | |||||
else | |||||
retVal = false; | |||||
return retVal; | |||||
return true; | |||||
} | } | ||||
@Override | @Override |
public boolean equals(Object o) | public boolean equals(Object o) | ||||
{ | { | ||||
if (!(o instanceof ParagraphHeight)) return false; | |||||
ParagraphHeight ph = (ParagraphHeight)o; | ParagraphHeight ph = (ParagraphHeight)o; | ||||
return infoField == ph.infoField && reserved == ph.reserved && | return infoField == ph.infoField && reserved == ph.reserved && |
public boolean equals(Object o) | public boolean equals(Object o) | ||||
{ | { | ||||
if (!(o instanceof PropertyNode)) return false; | |||||
if (limitsAreEqual(o)) | if (limitsAreEqual(o)) | ||||
{ | { | ||||
Object testBuf = ((PropertyNode<?>)o)._buf; | Object testBuf = ((PropertyNode<?>)o)._buf; |
@Override | @Override | ||||
public boolean equals(Object o) | public boolean equals(Object o) | ||||
{ | { | ||||
if (!(o instanceof SectionDescriptor)) return false; | |||||
SectionDescriptor sed = (SectionDescriptor)o; | SectionDescriptor sed = (SectionDescriptor)o; | ||||
return sed.fn == fn && sed.fnMpr == fnMpr; | return sed.fn == fn && sed.fnMpr == fnMpr; | ||||
} | } |
@Override | @Override | ||||
public boolean equals(Object o) | public boolean equals(Object o) | ||||
{ | { | ||||
if (!(o instanceof StyleSheet)) return false; | |||||
StyleSheet ss = (StyleSheet)o; | StyleSheet ss = (StyleSheet)o; | ||||
if (ss._stshif.equals( this._stshif ) && ss._cbStshi == _cbStshi) | |||||
{ | |||||
if (ss._styleDescriptions.length == _styleDescriptions.length) | |||||
{ | |||||
for (int x = 0; x < _styleDescriptions.length; x++) | |||||
{ | |||||
// check for null | |||||
if (ss._styleDescriptions[x] != _styleDescriptions[x]) | |||||
{ | |||||
// check for equality | |||||
if (!ss._styleDescriptions[x].equals(_styleDescriptions[x])) | |||||
{ | |||||
return false; | |||||
} | |||||
} | |||||
} | |||||
return true; | |||||
} | |||||
if (!ss._stshif.equals( this._stshif ) | |||||
|| ss._cbStshi != this._cbStshi | |||||
|| ss._styleDescriptions.length != this._styleDescriptions.length | |||||
) return false; | |||||
for (int i=0; i<_styleDescriptions.length; i++) { | |||||
StyleDescription tsd = this._styleDescriptions[i]; | |||||
StyleDescription osd = ss._styleDescriptions[i]; | |||||
if (tsd == null && osd == null) continue; | |||||
if (tsd == null || osd == null || !osd.equals(tsd)) return false; | |||||
} | } | ||||
return false; | |||||
return true; | |||||
} | } | ||||
@Override | @Override |
@Override | @Override | ||||
public boolean equals(Object o) | public boolean equals(Object o) | ||||
{ | { | ||||
if (limitsAreEqual(o)) | |||||
{ | |||||
TextPiece tp = (TextPiece)o; | |||||
return getStringBuilder().toString().equals(tp.getStringBuilder().toString()) && | |||||
tp._usesUnicode == _usesUnicode && _pd.equals(tp._pd); | |||||
} | |||||
return false; | |||||
if (!(o instanceof TextPiece)) return false; | |||||
TextPiece tp = (TextPiece)o; | |||||
assert(_buf != null && tp._buf != null && _pd != null && tp._pd != null); | |||||
return ( | |||||
limitsAreEqual(o) | |||||
&& tp._usesUnicode == this._usesUnicode | |||||
&& tp._buf.toString().equals(this._buf.toString()) | |||||
&& tp._pd.equals(this._pd) | |||||
); | |||||
} | } | ||||
@Override | @Override |
public boolean equals( Object o ) | public boolean equals( Object o ) | ||||
{ | { | ||||
if (!(o instanceof TextPieceTable)) return false; | |||||
TextPieceTable tpt = (TextPieceTable) o; | TextPieceTable tpt = (TextPieceTable) o; | ||||
int size = tpt._textPieces.size(); | int size = tpt._textPieces.size(); |
@Override | @Override | ||||
public boolean equals(Object o) | public boolean equals(Object o) | ||||
{ | { | ||||
if (!(o instanceof UPX)) return false; | |||||
UPX upx = (UPX)o; | UPX upx = (UPX)o; | ||||
return Arrays.equals(_upx, upx._upx); | return Arrays.equals(_upx, upx._upx); | ||||
} | } |
@Override | @Override | ||||
public boolean equals(Object obj) | public boolean equals(Object obj) | ||||
{ | { | ||||
if (!(obj instanceof SprmBuffer)) return false; | |||||
SprmBuffer sprmBuf = (SprmBuffer)obj; | SprmBuffer sprmBuf = (SprmBuffer)obj; | ||||
return (Arrays.equals(_buf, sprmBuf._buf)); | return (Arrays.equals(_buf, sprmBuf._buf)); | ||||
} | } |
@Override | @Override | ||||
public boolean equals(Object o) | public boolean equals(Object o) | ||||
{ | { | ||||
if (!(o instanceof BorderCode)) return false; | |||||
BorderCode brc = (BorderCode)o; | BorderCode brc = (BorderCode)o; | ||||
return _info == brc._info && _info2 == brc._info2; | return _info == brc._info && _info2 == brc._info2; | ||||
} | } |
@Override | @Override | ||||
public boolean equals(Object o) | public boolean equals(Object o) | ||||
{ | { | ||||
if (!(o instanceof DateAndTime)) return false; | |||||
DateAndTime dttm = (DateAndTime)o; | DateAndTime dttm = (DateAndTime)o; | ||||
return _info == dttm._info && _info2 == dttm._info2; | return _info == dttm._info && _info2 == dttm._info2; | ||||
} | } |
@Override | @Override | ||||
public boolean equals(Object o) | public boolean equals(Object o) | ||||
{ | { | ||||
if (!(o instanceof LineSpacingDescriptor)) return false; | |||||
LineSpacingDescriptor lspd = (LineSpacingDescriptor)o; | LineSpacingDescriptor lspd = (LineSpacingDescriptor)o; | ||||
return _dyaLine == lspd._dyaLine && _fMultiLinespace == lspd._fMultiLinespace; | return _dyaLine == lspd._dyaLine && _fMultiLinespace == lspd._fMultiLinespace; |