Browse Source

Fix some SpotBugs reports

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898383 13f79535-47bb-0310-9956-ffa450edef68
tags/REL_5_2_1
Dominik Stadler 2 years ago
parent
commit
25769795de

+ 2
- 1
poi-integration/src/test/java/org/apache/poi/stress/AbstractFileHandler.java View File

@@ -44,7 +44,8 @@ import org.apache.poi.util.IOUtils;
* in the integration tests, mostly text-extraction related at the moment.
*/
public abstract class AbstractFileHandler implements FileHandler {
public static final Set<String> EXPECTED_EXTRACTOR_FAILURES = new HashSet<>(Arrays.asList(
// some FileHandlers extend this list!?!
protected static final Set<String> EXPECTED_EXTRACTOR_FAILURES = new HashSet<>(Arrays.asList(
// password protected files without password
// ... currently none ...


+ 3
- 2
poi-integration/src/test/java/org/apache/poi/stress/FileHandlerKnown.java View File

@@ -18,7 +18,7 @@ package org.apache.poi.stress;

import java.io.File;
import java.io.InputStream;
import java.util.function.Supplier;
import java.lang.reflect.InvocationTargetException;

@SuppressWarnings("unused")
public enum FileHandlerKnown {
@@ -46,7 +46,8 @@ public enum FileHandlerKnown {
// Because of no-scratchpad handling, we need to resort to reflection here
String n = name().replace("NULL", "Null");
return (FileHandler)Class.forName("org.apache.poi.stress." + n + "FileHandler").getDeclaredConstructor().newInstance();
} catch (Exception e) {
} catch (RuntimeException | ClassNotFoundException | NoSuchMethodException | InstantiationException |
IllegalAccessException | InvocationTargetException e) {
return new NullFileHandler();
}
}

Loading…
Cancel
Save