Branch:
trunk
trunk
BUILD_BRANCH
NIO_32_BRANCH
NIO_BRANCH
REL_1_5_BRANCH
REL_2_BRANCH
REL_3_10_BRANCH
REL_3_11_BRANCH
common_sl
excelant
gsoc2012
hemf
hssf_cryptoapi
jakarta-poi
log4j
maven
mv
ooxml
performance-branch
ss_border_property_template
table-borders
wmf_render
xml_signature
xssf_structured_references
3.10-beta1
ooxml_20081107
trunk_20081106
before21444
REL_5_2_5
REL_5_2_4
REL_5_2_3
REL_5_2_2
REL_5_2_1
REL_5_2_0
REL_5_1_0
REL_5_0_0
REL_4_1_2
REL_4_1_1
REL_4_1_0
REL_4_0_1
REL_4_0_0_FINAL
REL_3_17_BETA1
REL_3_17_FINAL
REL_3_16_BETA2
REL_3_16_BETA1
REL_3_16_FINAL
REL_3_15_BETA3
REL_3_15_BETA2
REL_3_15_BETA1
REL_3_15_FINAL
REL_3_14_BETA1
REL_3_14_BETA1_RC2
REL_3_14_FINAL
REL_3_13_BETA1
REL_3_13_FINAL
REL_3_12_BETA1
REL_3_12_FINAL
REL_3_11_BETA3
REL_3_11_BETA2
REL_3_11_BETA1
REL_3_11_FINAL
REL_3_10_1
REL_3_10_BETA2
REL_3_10_BETA1
REL_3_10_FINAL
REL_3_9
REL_3_8_BETA5
REL_3_8_BETA4
REL_3_8_BETA3
REL_3_8_BETA2
REL_3_8_BETA1
REL_3_8_FINAL
REL_3_7
POI-3.7
REL_3_7_BETA3
REL_3_7_BETA2
REL_3_7_BETA1
REL_3_6
REL_3_5_1_BETA1
REL_3_5_BETA6
REL_3_5_BETA5
REL_3_5_BETA4
REL_3_5_BETA3
REL_3_5_BETA2
REL_3_5-FINAL
REL_3_2_FINAL
REL_3_1_BETA2
REL_3_1_BETA1
REL_3_1_FINAL
REL_3_0_3_BETA1
REL_3_0_2_BETA3
REL_3_0_2_BETA2
REL_3_0_2_BETA1
REL_3_0_1_RC3
REL_3_0_1_RC2
REL_3_0_1_RC1
REL_3_0
REL_3_0_RC4
REL_3_0_RC3
REL_3_0_RC2
REL_3_0_RC1
REL_3_0_ALPHA3
REL_3_0_ALPHA2
REL_2_5_1
REL_2_0_RC1
REL_2_0_PRE3
REL_2_0_PRE1
TAG_2-RC2
REL_1_10
REL_1_5_1
REL_1_5_0
REL_1_5_BRANCH_MERGE5
REL_1_5_BRANCH_MERGE4
REL_1_5_BRANCH_MERGE3
REL_1_5_BRANCH_MERGE2
REL_1_5_BRANCH_MERGE1
start
prelogging
before_junit5_update
before_ooxml_3rd_edition
BEFORE_RICHTEXT
AFTER_RICHTEXT
pre-new-crysalsa
PERF_BEFORE_MERGE
1 Commits (trunk)
1 Commits (trunk)
| Author | SHA1 | Message | Date |
|---|---|---|---|
 Greg Woolsey
|
3cea90e7c4 |
Fix data validation value list evaluation
One of my users found that my initial implementation was lacking a core distinction - most evaluations expect a single result, and "unwrap" 2/3D ValueEval results to a single value based on the input row/column. However, data validation list formulas explicitly are expected to return a 2D ValueEval. This worked when the formula was simple and evaluated to a single Ptg, but only returned one value when the formula was more complex, or referenced a named range defined as a complex formula. This change teaches WorkbookEvaluator about the distinction, by way of a new attribute for FormulaType. There is room for discussion over how it is implemented, but this works for me. Includes the failing workbook we had as a new unit test. While I was in FormulaType I went ahead and removed the deprecated, unused, and redundant code marked for removal in 3.17. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1803121 13f79535-47bb-0310-9956-ffa450edef68 |
6 years ago |