259c9967ef
[bug-63046] Use Log4j 2 for logging
This removes the POILogger and POILogFactory mechanism for logging. This mechanism was created at a time when the Java landscape looked very different than it does today.
Log4j 2 is an Apache Foundation project that is well maintained and is widely regarded as having good performance and capabilities. We use only the Log4j API artifact. This lets application developers choose how they want to capture logging events if at all. Integrations with Log4j 2 Core and Logback are available from the Log4j project.
Closes #224
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886770 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
36277f9e54
Code cleanup AbstractEscherHolderRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886623 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
5d9dcdf3df
Add documentation for DrawingGroupRecord
Documentation adapted from [MS-XLS].pdf v20190618.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886619 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
7a0cc6e7e5
Fix inconsistent logging statement
The conditions check for max, but the logging was copy/pasted and still uses the minimum.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886089 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
3778a3e9e2
Sonar fixes
constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'
reorder "final static" -> "static final"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885613 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
4bc450ef5f
Properly close file handles in extractors and when handling password-protected files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885229 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
de1ad1c44c
Adjust some JavaDoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884918 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
a7c1d84c5d
Improve the speed of the styles-optimiser when there are many styles in a Workbook
Profiling showed that the call to isUserDefined() took most of the time,
so we now fetch this only once for each style and remember the result and
use it in the inner loop.
The attached sample-file took aprox. 1m30s on a decent machine, now it is down
to around 2s.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884917 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
d121353f61
Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884807 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
fcc808d17d
[github-208] Fix a few instances of incorrect NotImplemented documentation. Thanks to Marius Volkhart. This closes #208
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884575 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
2b14dc36bb
avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884574 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
bd1d31e410
avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884573 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
0e0d1d56da
avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884572 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
e1bb2cca33
[bug-64972] HSSFPictureData#getPictureType() should return 0 for unknown picture type (to be consistent with other implementations)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884271 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
93c8c1540e
[bug-64972] HSSFPictureData#getPictureType() should return 0 for unknown picture type (to be consistent with other implementations)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884270 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
5aef414f2a
remove more deprecated code (fix some issues)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884265 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
8d54ec7cc7
remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884263 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
78596d7891
remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884262 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
a42127e15b
remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884259 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
bc1569e786
remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884257 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
e7ef490dc9
remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884256 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
3e4d80f66a
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884229 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
d4dde4e36e
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884228 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
451e47021b
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884227 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
c04110b919
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884226 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
e4d6fc0a7f
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884223 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
326ff18e51
[bug-64964] HSSFCell.convertCellValueToBoolean shall throw more specific exception
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884210 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
373b2d1fa5
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884158 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
062455c25d
Apply patch for bug 64791 to use proper position for the WriteAccessRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1882829 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
ce51aaf2dd
Apply some IDE suggestions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1882828 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
90bfac52d6
Sonar fixes - a few "Try-with-resources should be used"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1882820 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
6c7bf59087
[bug-64721] NullPointerException occurs when calling getDataSize() of an object created with ExtRst.copy(). Thanks to Kwon Ohyoung
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1881582 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
a73348fe8b
Update library versions
Replace deprecated junit @Rules with assertThrows
Adapt to XMLSec refactoring in version 2.2.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1880965 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
f8040e5f8c
#64036 - Replace reflection calls in factories for Java 9+
provide EvalutionWorkbook in HSSF/XSSF/SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1880925 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
dfdf9e6d6f
#64411 - Provide JigSaw modules
- rework extractors - see bugzilla entry for more information
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1880839 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
c0f9941604
#64411 - Provide JigSaw modules
- use classpath-build for Java 8, otherwise use modulepath
- save module-info classes to source, when using Java 9+ environment
- rename example packages - otherwise package clashes occured in the tests
- move agile encryption from ooxml to main.
remove EncryptionInfo XmlBeans and schema and use custom xml marshalling
- move ooxml test classes which reside in the same package as their tested main class
- rename base test classes to "BaseTest..." - temporarily I've used a light version of the main test classes to test scratchpad / ooxml
- build.xml - fixed the Rhino javascript errors of the dependency-macros
- DrawTextParagraph - fixed StringIndexOutOfBounds when logging set to debug level
- use JigSaw provider interface (= Java ServiceLoader), i.e. it wasn't possible (without openening everything), to access ooxml factory classes from main factory stub
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1880164 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
8900e397a4
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879911 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
c34c1ca49c
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879909 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
02cebfc312
remove some more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879299 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
241c7e2bb2
remove some more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879298 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
fdd73de259
remove some deprecated classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879269 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
a126dae032
update deprecation version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879268 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
19c97f3285
remove some deprecated methods from Cell
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879266 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
b12e13a041
remove some deprecated Font methods from Workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879259 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
38e58f1ead
remove some deprecated Name methods from Workbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879255 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
fd7c926a4c
Throw an exception with more information instead of an NPE
This seems to be a corrupted document and shows up in regression tests and should at least be reported with some more information
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1878870 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
00185c2857
next version will be 5.0.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1877872 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
237d55b3e3
[bug-64441] synchronize code that initialises WorkbookFactory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1877776 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
979d1b48e7
Github-177: Avoid NullPointerException if RangeCopier encounters empty/missing rows
Also expose one-parameter constructor and verify it in tests.
Closes #177
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1877010 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
4abe6ef9ef
Bug 63294: Add some more methods to allow to use CellType everywhere
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876948 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Marius Volkhart
Andreas Beeker
Dominik Stadler
PJ Fanning