Marius Volkhart
259c9967ef
[bug-63046] Use Log4j 2 for logging
This removes the POILogger and POILogFactory mechanism for logging. This mechanism was created at a time when the Java landscape looked very different than it does today.
Log4j 2 is an Apache Foundation project that is well maintained and is widely regarded as having good performance and capabilities. We use only the Log4j API artifact. This lets application developers choose how they want to capture logging events if at all. Integrations with Log4j 2 Core and Logback are available from the Log4j project.
Closes #224
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886770 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Marius Volkhart
36277f9e54
Code cleanup AbstractEscherHolderRecord
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886623 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Marius Volkhart
5d9dcdf3df
Add documentation for DrawingGroupRecord
Documentation adapted from [MS-XLS].pdf v20190618.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886619 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Marius Volkhart
7a0cc6e7e5
Fix inconsistent logging statement
The conditions check for max, but the logging was copy/pasted and still uses the minimum.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886089 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Andreas Beeker
3778a3e9e2
Sonar fixes
constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'
reorder "final static" -> "static final"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885613 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Andreas Beeker
d121353f61
Sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884807 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
2b14dc36bb
avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884574 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
bd1d31e410
avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884573 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
0e0d1d56da
avoid string concats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884572 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
78596d7891
remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884262 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
e7ef490dc9
remove more deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884256 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
3e4d80f66a
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884229 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
d4dde4e36e
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884228 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
451e47021b
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884227 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
c04110b919
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884226 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
e4d6fc0a7f
remove some deprecated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884223 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
6c7bf59087
[bug-64721] NullPointerException occurs when calling getDataSize() of an object created with ExtRst.copy(). Thanks to Kwon Ohyoung
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1881582 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
PJ Fanning
fdd73de259
remove some deprecated classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879269 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
PJ Fanning
a126dae032
update deprecation version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1879268 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
PJ Fanning
00185c2857
next version will be 5.0.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1877872 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Dominik Stadler
4abe6ef9ef
Bug 63294: Add some more methods to allow to use CellType everywhere
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876948 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
ad73704e81
Sonar fix - "Add the missing @deprecated Javadoc tag."
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876854 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
661c0b66bc
Sonar fixes
- Math operands should be cast before assignment
- Suppress - Make sure that command line arguments are used safely here
- Suppress - Replace this use of System.out or System.err by a logger.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876737 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
c41dee931f
#63745 - Add traversing and debugging interface to HSSF
a few more HSSF / Old Excel classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876732 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
7daeb4278c
Replace Allocate+System.arraycopy with Array.copyOf/Range and IOUtils.safelyClone
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876640 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
d06de78703
#64350 - Sonar fix - "Iterator.next()" methods should throw "NoSuchElementException"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876525 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
f9417a92b2
#64036 - Replace reflection calls in factories for Java 9+ (HSSF Record Factory)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876467 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
4fd05fac12
#63745 - Add traversing and debugging interface to HSSF
This makes toString() implementations obsolete.
This also contains preparation for #64036 to (maybe) change the record factory interface of HSSF.
Remove duplicated record SeriesToChartGroupRecord, which is a duplicate of SeriesChartGroupIndexRecord.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876433 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Tim Allison
5976721660
64261 -- fix handling of drop down list when items are selected
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875956 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
c01273ad02
Sonar Fixes
- use String.replace instead of String.replaceAll for literal values
- use constants from base class
- deprecated various references to constants of org.apache.poi.ss.usermodel.FontFormatting - to be replaced by o.a.p.s.u.Font in POI 5.0.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875859 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Tim Allison
636cc83665
Bug 64130 -- handle empty worksheet names in OldSheetRecord more robustly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1873863 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Dominik Stadler
d3767e1de7
Improve some assertions and error messages for exceptions seen in the regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1873385 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
8202a34d69
#64036 - Replace reflection calls in factories for Java 9+ - Escher factories
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1873187 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
PJ Fanning
b211a1362c
use a few more lambdas
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872644 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
PJ Fanning
2797d07486
try to fix some jdk 14 build issues due to java.lang.Record causing existing POI Record classes to be ambiguous
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872610 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
d66af200eb
Sonar fixes - Tests should include assertions
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872302 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
c66575c1e7
Migrate all junit tests to Junit 4
get rid of references to junit.framework
don't throw AssertionFailedErrors, but use Assert.fail instead
add try-with-resources where it was missing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872041 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
7493473a8e
Replace internal GUID class with ClassID
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871944 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
66471836f5
Replace custom hashCode code with Objects.hash() / Arrays.deepHashCode()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871913 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
ba6152503e
#64004 - Replace clone() with copy constructor - mainly HSSF classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871911 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
0f29ae8e4d
Sonar fixes - type: bugs / severity: major
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871064 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
a17a9168b1
Sonar Fixes - fix/annotate type "vulnerability" / severity "blocker"
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1870657 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
5f28881a35
change package.html to package-info.java
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1870655 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
2a982f62ec
Replace StringBuffer with StringBuilder
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1870600 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
PJ Fanning
701b67c315
replace more StringBuffers
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1870121 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
PJ Fanning
cd3f373c44
change some tabs to spaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1870049 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
PJ Fanning
96bf53f3fc
replace some uses of StringBuffer with StringBuilder
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1870046 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
PJ Fanning
948b0e8f08
convert tabs to spaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1869962 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Axel Howind
4f8879f8ef
use zero size arg to toArray(), use Collection.addAll() (#63805, second patch)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1869919 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Alain Béarez
a59ed12ecf
fix potential output resource leaks (LGTM)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1859592 13f79535-47bb-0310-9956-ffa450edef68
5 years ago