Dominik Stadler
2c866cce02
Bug 63657: Optimize onDocumentWrite() to not do the full re-assignment
if not necessary at all, also use getCArray() instead of getCList() as
access-operations are much quicker this way
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1865209 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Dominik Stadler
8f8362a7f1
Bug 63657: Rework the for bug #62130 to not use up twice as much memory when writing documents.
Unfortunately XMLBeans is very tricky to use here, mainly the fact that setCArray does not replace the internal objects, but copies the content into the currently held objects makes it rather hard to do this right.
Therefore we now try to keep the existing objects and only replace the content as required to
have a stable ordering of cells in the row-XML structure.
This also fixes removing cells from rows to avoid invalid situations and
correctly free CTCellImpl instances.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1864977 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Dominik Stadler
9f07780bac
Bug 62906 and 63401: Ensure tables have an initial name which does not conflict with
existing names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861819 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
31edcd8383
Bug 63509: Allow to format a CellReference without sheet-name for ignoredErrors.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1861817 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
cf23d55b22
[bug-63463] fix issue with shifting rows. Thanks to David Gauntt.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1860384 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
1b4ea32574
[bug-62906] ensure table display name is always set
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858179 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
6a4afb2081
Bug 63371: addMergedRegion does not update CTMergeCells.getCount
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858022 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
ded6e6a425
Bug 63073: Adjust returned index of merged regions and verify all calls in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1858021 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
ff11d159cf
replace version number 4.0.2
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856665 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Greg Woolsey
4a8581dac9
#61700 getForceFormulaRecalculation() returns wrong value
changed to use the proper OOXML attribute instead of a hack about calculation engine version ID. Reporter was right, the behavior was wrong in some cases, but it turns out the fix was a bit more. See issue for details.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856652 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
53356ce163
[bug-61700] getForceFormulaRecalculation() returns wrong value. Fix thanks to Kai G
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856650 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
bce68bedb5
fix build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856649 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Greg Woolsey
6f575305c6
#60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' variations
The function still doesn't deal with auto-filtering, but it now handles variations that should skip hidden rows.
Taught the evaluation framework to know about hidden rows similar to what was already there for skipping subtotals within subtotal ranges.
Added unit test cases.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855789 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
6ce3da363b
Bug 63221: Add margin-settings for top, bottom, left and right to XSSFPrintSetup
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855154 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
1996575eb4
Fix a regression test failure, toString() should never return null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854717 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
30096c13f0
pulled *Cell.setCellValue(String), setCellValue(RichTextString) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852255 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
006119762d
pulled *Cell.setCellValue(Date) and setCellValue(Calendar) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852254 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
0f2845be67
pulled *Cell.setCellValue(double) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852253 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
02d0fbba18
pulled *Cell.getCellTypeEnum() to common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852252 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
ed321b0fff
pulled *Cell.getAddress to common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852251 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
7f3d575ec8
purged usages of Cell.setCellType (left only in tests, where conversions are tested)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852247 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
c8d0b7cb57
made call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType(). Purged all redundant calls from project.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852246 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
099339783b
purged calls to cell.setCellType(CellType.BLANK) from the project, replaced with setBlank()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852245 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
431e195264
added Cell.setBlank() - as an alias, for now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852244 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
4b61d7f2a2
setCellFormula: blank cell gets value 0, non-blank value is preserved
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852212 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
3b20c943bf
Fix some Findbugs and IDE issues, refactor some duplicated code,
improve some exception texts, add comment for missing Ptg for SxName
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
7b44d1e54c
unified setCellType(null/_NONE) logic, setCellFormula(null) logic. updated javadoc and tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850676 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
217633f608
Bug 62993: XSSFEvaluationSheet now retrieves valid last row index from underlying XSSFSheet. Thanks to Axel Howind.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850212 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
c86ae2cb5f
Bug 62828: CellReference(Cell) now initializes sheet name.
Changed CellReference to CellAddress in XSSFHyperlink because it is what it should return.
Updated all relevant tests, added a test for CellReference(Cell).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850210 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
42261c8991
Bug 62307: made Cell#getNumericCellValue() behavior consistent across HSSF/XSSF/SXSSF.\nAll three implementations throw ISE when trying to get numeric value from a boolean-valued cell, have it a formula set or not.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850207 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
9167737811
Bug 60845: Apply patch and adjust tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849969 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
fe44bd234d
IDE and JavaDoc fixes, make base test classes abstract
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849968 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
ee0dc9944d
Remove unnecesssary semicolons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849761 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
e827a69540
Simplify some string operations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849760 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
centic
2bd8838fd8
Code-style: Unify how arrays are specified from C-style to normal Java-style
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849716 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
6a198bf5f2
put back XSSFColor(java.awt.Color clr) constructor
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1846701 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
6b7e322227
add testcase for https://bz.apache.org/bugzilla/show_bug.cgi?id=62906
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1846489 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
0cc8ec178f
IDE warnings, tried to reproduce Bug 58927, but could not
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1845434 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
232616f44d
Adjust sample for creating comments to also create a .xlsx file
Enhance workbook factory to allow to create new empty workbooks as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844881 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
1f9a0caf2e
fix class cast issur recently introduced in BaseXSSFFormulaEvaluator
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844311 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Greg Woolsey
d24b4492f0
#62834 FormulaEvaluator.evaluateInCell() throws Exception
added cell type = formula check when looping through the shared formula range, to ignore any non-formula cells.
Also refactored a bit to enable passing in the evaluation context, as getCellFormula() uses it behind the scenes when evaluating a shared formula cell (has to shift the formula references based on the master cell). Review of these changes is welcome, as always.
Checked all other code referencing the "SHARED" enum, and didn't see anything else that dealt with formula cell values and thus would need to notice non-formula cells.
Added unit test based on the failing file from Bugzilla. Test failed until the fixed code was in place.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844295 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Alain Béarez
ead92fbe9a
fix most alerts reported by LGTM on OOXML
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1843481 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
268c9230cd
use jaxp transformer instead of dom serializer to try fix old-xerces test failure
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842974 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Alain Béarez
b326a5cd01
adding tricks from other answers on StackOverflow
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842959 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Alain Béarez
c66af5c21e
example from StackOverflow question 47065690
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842925 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Alain Béarez
72d02f0c1c
extract valuable code from 54470 submitted patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842548 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
500c64e657
fix lgtm issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1842216 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
6af2173f93
fix javadoc
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1841987 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Greg Woolsey
891deb3967
Bug 62740 - XSSFTable constructor automatically assigns invalid (non-unique) column IDs
fix the logic and update the unit test to check for and catch the problem.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1841357 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Alain Béarez
5abdfcb0a6
import existing chart on current drawing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1840076 13f79535-47bb-0310-9956-ffa450edef68
5 years ago