Greg Woolsey
6b433ae8b3
#62834 FormulaEvaluator.evaluateInCell() throws Exception
added cell type = formula check when looping through the shared formula range, to ignore any non-formula cells.
Also refactored a bit to enable passing in the evaluation context, as getCellFormula() uses it behind the scenes when evaluating a shared formula cell (has to shift the formula references based on the master cell). Review of these changes is welcome, as always.
Checked all other code referencing the "SHARED" enum, and didn't see anything else that dealt with formula cell values and thus would need to notice non-formula cells.
Added unit test based on the failing file from Bugzilla. Test failed until the fixed code was in place.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1844295 13f79535-47bb-0310-9956-ffa450edef68
před 5 roky
PJ Fanning
02f7b450d4
[bug-62275] in vlooup function, treat optional 4th param as true if the value is not provided
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1836857 13f79535-47bb-0310-9956-ffa450edef68
před 6 roky
PJ Fanning
07ee945a82
add test case
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1836856 13f79535-47bb-0310-9956-ffa450edef68
před 6 roky
Greg Woolsey
8caf25f718
ignore a unit test that snuck in. It was created to investigate an open bug report. It fails, as expected, which broke the build.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815336 13f79535-47bb-0310-9956-ffa450edef68
před 6 roky
Greg Woolsey
8572d4b71c
Fixes Bug 61764 Conditional formatting rules don't evaluate properly for some multi-range rule definitions
Fixes Bug 61761 Conditional formatting rule evaluation doesn't like comparing cells of different types
fixed, with unit tests.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1815298 13f79535-47bb-0310-9956-ffa450edef68
před 6 roky
Dominik Stadler
46fd75b1e7
Bug 61148: Fix calculating formula value, unfortunately we currently need to set the value twice
Also rework related tests to run more of the tests for HSSF, XSSF and SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808929 13f79535-47bb-0310-9956-ffa450edef68
před 6 roky
PJ Fanning
e3ddb77bc1
update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808703 13f79535-47bb-0310-9956-ffa450edef68
před 6 roky
Dominik Stadler
0cfa1ede4c
Remove unnecessary type arguments (Java 8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
před 6 roky
Greg Woolsey
d68912db25
Fixes bug #61468, caused by a confusing OOXML spec design as noted in JavaDocs added in r1795648.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1806623 13f79535-47bb-0310-9956-ffa450edef68
před 6 roky
Javen O'Neal
2f470e6d89
unit test that is not written yet should fail
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1799324 13f79535-47bb-0310-9956-ffa450edef68
před 7 roky
Andreas Beeker
1690ec2d19
merge trunk to branch
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1762709 13f79535-47bb-0310-9956-ffa450edef68
před 7 roky
Andreas Beeker
2e50133e88
merge trunk to branch
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1761376 13f79535-47bb-0310-9956-ffa450edef68
před 7 roky
Javen O'Neal
de6c83cb47
move HSSFFormulaEvaluator#evaluateInCell and BaseXSSFFormulaEvaluator#evaluateInCell(Cell) up to BaseFormulaEvaluator to reduce duplicated code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760651 13f79535-47bb-0310-9956-ffa450edef68
před 7 roky
Andreas Beeker
885deafb94
merge down trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1755463 13f79535-47bb-0310-9956-ffa450edef68
před 7 roky
Nick Burch
a57e5b7b93
Switch XSSF onto BaseFormulaEvaluator, reducing code duplication and fixing XSSFFormulaEvaluator.evaluateAll() to mirror HSSF and use any setup referenced workbooks (stackoverflow #38706562)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1755079 13f79535-47bb-0310-9956-ffa450edef68
před 8 roky
Dominik Stadler
1f15f25cb8
Bug 59736: Incorrect evaluation of SUBTOTAL with composite interval
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1754674 13f79535-47bb-0310-9956-ffa450edef68
před 8 roky
Javen O'Neal
5582593ad1
bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
před 8 roky
Javen O'Neal
8d31c01f40
bug 59791: replace deprecated Cell.CELL_TYPE_* usage with CellType.*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751240 13f79535-47bb-0310-9956-ffa450edef68
před 8 roky
Javen O'Neal
460540ded2
whitespace (tabs to spaces, 3-space to 4-space)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747879 13f79535-47bb-0310-9956-ffa450edef68
před 8 roky
Javen O'Neal
0e0afb3c72
bug 57840: add disabled unit test with large number of structured reference formulas
patch and spreadsheet contributed by Mark Woolsey
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747878 13f79535-47bb-0310-9956-ffa450edef68
před 8 roky
Javen O'Neal
962d0829f1
bug 57721: add unit test for evaluating all formulas in a workbook containing structured reference formulas; patch from gruber.chri@gmx.at
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747740 13f79535-47bb-0310-9956-ffa450edef68
před 8 roky
Andreas Beeker
461375359c
fixed sonar issues and eclipse warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706742 13f79535-47bb-0310-9956-ffa450edef68
před 8 roky
Dominik Stadler
4589cb309e
Bug 56655: Fix Sumifs for cases where the criteria is in error.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1686610 13f79535-47bb-0310-9956-ffa450edef68
před 9 roky
Nick Burch
bc64486226
Some more XSSF testing for #57184
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636750 13f79535-47bb-0310-9956-ffa450edef68
před 9 roky
Nick Burch
36142247f4
More disabled unit tests relating to external workbook formula references
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1636626 13f79535-47bb-0310-9956-ffa450edef68
před 9 roky
Nick Burch
f0b083dae3
Comment out work-in-progress extension to test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635542 13f79535-47bb-0310-9956-ffa450edef68
před 9 roky
Nick Burch
4cb616f1f3
Add missing HSSFWorkbook constructor javadocs #57166
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1635533 13f79535-47bb-0310-9956-ffa450edef68
před 9 roky
Andreas Beeker
56051c3e44
merge with trunk
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/xml_signature@1625828 13f79535-47bb-0310-9956-ffa450edef68
před 9 roky
Dominik Stadler
94edf46bbf
Bug 48195: Formulas: Fix incorrect evaluation of IF() with ROW()/COLUMN() as else-result
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1621641 13f79535-47bb-0310-9956-ffa450edef68
před 9 roky
Nick Burch
07a2d641a6
HSSF and XSSF Multi-Sheet formula reference tests from Radoslav from bug #55906
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613654 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Nick Burch
cd7de7d482
Complete evaluation support for multi-sheet references for bug #55906
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613467 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Nick Burch
93f8a87e96
Allow XSSF to evaluate multi-sheet references too, for #55906
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613455 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Nick Burch
8cf36ccc1a
Split the reference and area tests for #55906
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613454 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Nick Burch
e1f4548dcf
More tests for #55906, and provide a new eval that lets you get at evals for many sheets
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613438 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Nick Burch
f19982e245
Areas can have multi-sheet references too, so add FormulaParser support to these as well
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613437 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Nick Burch
2a2cb871d6
Disabled unit tests for multi-sheet references, see bug #55906
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613282 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Nick Burch
ca59e31371
When evaluating a name in another workbook, need to use an OperationEvaluationContext tied to that Workbook, and do so such that XSSF references work too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1613154 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Nick Burch
38434a684e
Get further with the XSSF formula reference evaluation testing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612926 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Nick Burch
70f40542fd
Generalise the CollaboratingWorkbooksEnvironment setup, so that XSSF can use it too
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612254 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Nick Burch
01a9024f55
More unit tests for #56737 and #56752
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1612157 13f79535-47bb-0310-9956-ffa450edef68
před 10 roky
Yegor Kozlov
e3f83511dc
optimized unused imports and removed deprecation warnings in poi-ooxml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1296977 13f79535-47bb-0310-9956-ffa450edef68
před 12 roky
Yegor Kozlov
8e4d2bbba3
Fixed evaluation of cell references with column index greater than 255, see bugzilla 50096
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1033556 13f79535-47bb-0310-9956-ffa450edef68
před 13 roky
Yegor Kozlov
45f1391ee7
fixed evaluation of shared formulas in XSSF, see Bugzilla 49872
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@996265 13f79535-47bb-0310-9956-ffa450edef68
před 13 roky
Yegor Kozlov
e99294ebc5
fixed XSSFFormulaEvaluator to support blank cells, added BaseTestFormulaEvaluator - a common superclass for testing implementations of FormulaEvaluator
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@992620 13f79535-47bb-0310-9956-ffa450edef68
před 14 roky
Josh Micich
bb7b42c126
Fixing compiler warnings - unboxing parameter to overloaded method, unnecessary typecast
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@805900 13f79535-47bb-0310-9956-ffa450edef68
před 15 roky
Josh Micich
2f9d1466a8
Removed static void main(String[]) methods from junit classes. Other minor clean-up.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@784284 13f79535-47bb-0310-9956-ffa450edef68
před 15 roky
Yegor Kozlov
a2d45f6454
fixed formula parser to correctly resolve sheet-level names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@729028 13f79535-47bb-0310-9956-ffa450edef68
před 15 roky
Yegor Kozlov
27f601e40e
1. added support for shared formulas in XSSF, see bug #464332. improved validation of workbook-global and sheet-global names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@728749 13f79535-47bb-0310-9956-ffa450edef68
před 15 roky
Yegor Kozlov
968c6493a5
1. important algorithmic improvements of XSSFRow and XSSFSheet, removed LinkedList in favor of TreeMap, that allowed O(Log(N)) performance instead of O(N) when adding new rows and cells2. Revised cell value accessors in XSSFCell. Now both HSSF and XSSF handle various cell types equally. The same exceptions are thrown in case of type mismatch, same behaviour when setting nulls, etc.
3. Moved FormulaError codes out of the Cell interface into enum. Interface isn't a proper place for it
4. Finally finished javadoc on XSSFRow and XSSFCell
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@707445 13f79535-47bb-0310-9956-ffa450edef68
před 15 roky
Josh Micich
02b99aeedd
Merged revisions 696860,696898 via svnmerge from
https://svn.apache.org/repos/asf/poi/trunk
Quite a lot of manual fixing required. Also moved CellValue to top level class.
........
r696860 | josh | 2008-09-18 17:02:21 -0700 (Thu, 18 Sep 2008) | 1 line
code clean-up (removed compiler warnings/unused methods)
........
r696898 | josh | 2008-09-18 19:19:58 -0700 (Thu, 18 Sep 2008) | 1 line
Partitioning common formula logic. Introduced FormulaParsingWorkbook and EvaluationWorkbook interfaces to make merge with ooxml branch easier
........
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ooxml@696961 13f79535-47bb-0310-9956-ffa450edef68
před 15 roky