Andreas Beeker
60303201dc
use the forbidden-apis policies corresponding to the JRE
fix the forbidden apis issues
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1880866 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Nick Burch
2b2631225d
#64319 Tighten the scientific format code to avoid making eg TRUE into TRUE+, handle formats like 0E-0, and ensure formats like 0E0 work correctly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876396 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
c01273ad02
Sonar Fixes
- use String.replace instead of String.replaceAll for literal values
- use constants from base class
- deprecated various references to constants of org.apache.poi.ss.usermodel.FontFormatting - to be replaced by o.a.p.s.u.Font in POI 5.0.0
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1875859 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
0f29ae8e4d
Sonar fixes - type: bugs / severity: major
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871064 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
PJ Fanning
5d580f48e6
fix build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856649 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Greg Woolsey
67aad69757
#63292 1904 date windowing flag not used for some format cases
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856648 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Greg Woolsey
0d22749477
#63291 CellFormat global cache isn't thread-safe
move date format synchronization down to where the problem instance is held.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856647 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
2a9390d683
[bug-63291] support concurrent date formatting with same DataFormatter
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856449 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
f6eab84243
Simplify some string operations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849760 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Andreas Beeker
fa5e01e391
Remove commented out System.out calls / Move DummyGraphics2d to testcase area, as it's not used by production code
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1846946 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
278ed0fc32
[bug-62639] make private constructor on DateFormatter public
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1838420 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Andreas Beeker
bfe3e6a976
sonar fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1832748 13f79535-47bb-0310-9956-ffa450edef68
6 years ago
Dominik Stadler
76d11ac37e
Some JavaDoc adjustments, typos, IntelliJ warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1814587 13f79535-47bb-0310-9956-ffa450edef68
6 years ago
Dominik Stadler
1b171e8642
Fix some findbugs-issues and apply some code-cleanup and apply some smaller pull requests.
This closes #74, This closes #75, This closes #76
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1812097 13f79535-47bb-0310-9956-ffa450edef68
6 years ago
PJ Fanning
38650a6d2f
use non-deprecated versions of getCellType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808741 13f79535-47bb-0310-9956-ffa450edef68
6 years ago
PJ Fanning
6382370552
update getCellType to return CellType enum instead of int
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808718 13f79535-47bb-0310-9956-ffa450edef68
6 years ago
Dominik Stadler
467053d91c
Various code cleanups, "final" for static methods is useless, for-loops, simplify boolean conditions, try-with-resource, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808620 13f79535-47bb-0310-9956-ffa450edef68
6 years ago
Dominik Stadler
0cfa1ede4c
Remove unnecessary type arguments (Java 8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
6 years ago
PJ Fanning
52d3ea57f4
javadoc: replace invalid self enclosing elements
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1802110 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
PJ Fanning
31f2a54bde
[github-25] support excel number trailing comma format - Thabks to Luca Martini for proving the patch
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800975 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
PJ Fanning
26389768b9
[Bug 60422] fix data formatter issue with specific format in German locale
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1800713 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
Nick Burch
488dff773a
Javadoc fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1795261 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
Greg Woolsey
530dd0e083
61060 - teach DataFormatter about conditional formatting rules with number formats
Currently only implemented for XSSF, as there is no API available for HSSF conditional formatting rule number formats (if it is even in the files).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1794084 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
Greg Woolsey
6971b1ee60
Fix bug #61007
Revert to previous "expected" test results even though they don't match excel for a specific case, to accommodate tighter logic about which format patterns to send to CellFormat vs. handle directly in DataFormatter.
Send what was checked previously plus only multi-segment conditional range formats. Allows existing tests to pass plus the new test with the case for these conditional formats.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791964 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
Greg Woolsey
9490042347
Fix bug #61007
use CellFormat for all format strings containing multiple parts (";" delimited) and update unit test to expect the same values as Excel. Also added tests for the failing formats.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1791949 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
Javen O'Neal
442e7cc721
bug 60031: DataFormatter parses months incorrectly when put at the end of date segment. Thanks to Andrzej Witecki
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1779564 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
Andreas Beeker
2e50133e88
merge trunk to branch
git-svn-id: https://svn.apache.org/repos/asf/poi/branches/hssf_cryptoapi@1761376 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
Javen O'Neal
72a9e2285b
bug 60025: DataFormatter should print booleans as TRUE/FALSE, not true/false
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1760219 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
Dominik Stadler
8924e1260b
Fix some IntelliJ and Findbugs warnings: StringBuilder, foreach, append(), ...
test-updates
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753122 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
04be2bb235
bug 59791: FormulaEvaluator#evaluateFormulaCell(Cell) should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751261 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
5582593ad1
bug 59791: getCellType and getCachedFormulaResultType should return an integer for backwards compatibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751256 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
fb8c79d96c
bug 59791: convert Cell Type to an enum
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751237 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
ff0e46af6d
bug 59773: move loop invariants outside of loop or change for loops to for-each loops
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751131 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
6fbb02ef14
add comments and make the statefulness of localeIsAdapting more obvious.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747171 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
84a5a27dc1
make emulateCSV final, add a single common all-inclusive (private) constructor that all other constructors tree up to and invert the constructors
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747163 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
fb19f7c233
replace Obervable with Observable; emulateCsv with emulateCSV
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747152 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
97b299d672
bug 59638: patch from Axel Howind, support non-comma number grouping separators (such as German 1.234,57)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747139 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
9fa0c96a63
bug 59383: getFormat should cache data formatter (fix from Nick C), accidentally deleted in bug 58532 r1710407.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1741114 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Dominik Stadler
0ba83f7683
Regression in version 3.14-beta1: three or four-part formats with locale id cause exceptions when formatting instead of falling back to other formatting
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1724488 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Nick Burch
d1ea6125fa
Bug #55265 - DataFormatter correct support for alternate number grouping characters, eg 1234 + #'##0 = 1'234 not 1,234
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712605 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Andreas Beeker
3be69f87f7
fixes sonar/findbugs issues
add Date.toString() to forbidden-apis and fix occurrences
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1712181 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Nick Burch
1a96a88ef2
Mention about Locale definitions in Excel cell data format strings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710459 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Nick Burch
b3f68c4eb4
#58532 For Excel cell formats with 3+ parts to them (eg +ve,-ve,0), which
DataFormatter didn't properly support, call out to the alternate CellFormat
instead for the formatting.
This also allows us to enable some disabled parts of DataFormatter unit tests
We still need to rationalise DataFormatter and CellFormatter though, so we
only have one set of cell formatting logic...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1710399 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
David North
940f3c5af3
Format numbers more like Excel does
Thanks to Chris Boyle for the patch
https://bz.apache.org/bugzilla/show_bug.cgi?id=58471
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1706971 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Andreas Beeker
1a0365739f
forbidden apis fixes - a few DateFormat clean ups ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701888 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Andreas Beeker
a3d2eb57ff
Bug 58326 - Forbidden APIs patches - first set of changes for locale and timezone settings
also includes fixes for
- name shadowing
- unused deprecated method "getClipRect" in classes extending Graphics2d
- HexDump - replaced intermediate String.format calls with custom padding
- convert testcases to junit4
- closing resources
also tested with an arbitary timezone (PST) and locale (ru)
supresses forbidden apis check for
- LocaleUtil (the only place where Locale.getDefault() and TimeZone.getDefault() should be called)
- Classes using FontMetrics - without the actual text it's difficult to return something sane
Some usage of UTC and Locale.ROOT might be still wrong, e.g. in MapiMessage we don't access the
extended mapi properties, which might contain the timezone
DataFormatter has now a Observable property which need to be observed when custom formats are used
and the Locale changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1701688 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Andreas Beeker
72433ac405
forbidden apis fixes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700076 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Nick Burch
d2cde65c30
#57951 Use BigDecimal in some cases in DataFormatter.formatRawCellContents, to avoid rounding problems on JDK8. Patch from Robert Kish
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682083 13f79535-47bb-0310-9956-ffa450edef68
9 years ago
Nick Burch
2dea5356aa
Fix inconsistent indents
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1682081 13f79535-47bb-0310-9956-ffa450edef68
9 years ago
Nick Burch
c2edd459c7
Handle date format strings in an iso8601 style format, with a T in them. Fixes bug #54034
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1597038 13f79535-47bb-0310-9956-ffa450edef68
10 years ago