Dominik Stadler
ce919673c4
Bug 66425: Avoid exceptions found via poi-fuzz
We try to avoid throwing NullPointerException, ClassCastExceptions and StackOverflowException, but it was possible
to trigger them
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62530 and https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=62491
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1912433 13f79535-47bb-0310-9956-ffa450edef68
9 months ago
Dominik Stadler
d3e35e740a
Remove deprecation warnings reported with newer commons-io
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1910300 13f79535-47bb-0310-9956-ffa450edef68
1 year ago
PJ Fanning
1bb6dddc06
introduce CellReferenceType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1897780 13f79535-47bb-0310-9956-ffa450edef68
2 years ago
PJ Fanning
e6926f9779
introduce CellReferenceType
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1897779 13f79535-47bb-0310-9956-ffa450edef68
2 years ago
PJ Fanning
607eb0fabe
add R1C1 test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1897657 13f79535-47bb-0310-9956-ffa450edef68
2 years ago
PJ Fanning
ba7cbf4b3c
add R1C1 test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1897654 13f79535-47bb-0310-9956-ffa450edef68
2 years ago
PJ Fanning
3890b7013b
convert tabs to spaces
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1890120 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Andreas Beeker
0614835c55
#65304 - Add commons-io as a dependency
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1889871 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Andreas Beeker
b6aee1ef6d
65206 - Migrate ant / maven to gradle build
compile / jar / test of mrJars
don't include ants build.xml anymore
rename directories to match project and maven artifact names
refactor artifacts - so each project has one artifact
replace static references in hssf/dev tests with junit5 constructs, which had problems in parallel tests
increase gradle heap to 4gb because of OOM - maybe less would also work
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888488 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Andreas Beeker
37791e4bdf
65206 - Migrate ant / maven to gradle build
update gradle files and project structure along https://github.com/centic9/poi/tree/gradle_build
remove eclipse IDE project files
remove obsolete record generator files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1888111 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Andreas Beeker
a4ed4359cc
Sonar fixes
JUnit5 test classes and methods should have default package visibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885308 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Andreas Beeker
606a313c4c
Sonar fixes
JUnit5 test classes and methods should have default package visibility
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885281 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Andreas Beeker
fb2a96a048
Sonar fixes
Fixed offset of compare picture in resize_compare.xlsx
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885280 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Andreas Beeker
a0fa9e19b1
#65026 - Migrate tests to Junit 5
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884783 13f79535-47bb-0310-9956-ffa450edef68
3 years ago
Andreas Beeker
4fd05fac12
#63745 - Add traversing and debugging interface to HSSF
This makes toString() implementations obsolete.
This also contains preparation for #64036 to (maybe) change the record factory interface of HSSF.
Remove duplicated record SeriesToChartGroupRecord, which is a duplicate of SeriesChartGroupIndexRecord.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1876433 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
c66575c1e7
Migrate all junit tests to Junit 4
get rid of references to junit.framework
don't throw AssertionFailedErrors, but use Assert.fail instead
add try-with-resources where it was missing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1872041 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Andreas Beeker
ba6152503e
#64004 - Replace clone() with copy constructor - mainly HSSF classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1871911 13f79535-47bb-0310-9956-ffa450edef68
4 years ago
Dominik Stadler
40f8d119c7
Remove more remnants of NPOIFSFileSystem, mostly in comments and variable names
This avoids confusion if people look at this code in the future without knowledge
about the historical transition from java.io to java.nio
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855873 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Andreas Beeker
8ebfec4808
#62649 - Remove OPOIFS* / rename NPOIFS* to POIFS*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1839709 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Andreas Beeker
96d5fab483
#62649 - Remove OPOIFS
Fix HPSF UTF-8 encoding error with Bug52311.doc while refactoring CopyCompare/EntryUtils
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1839201 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
0cfa1ede4c
Remove unnecessary type arguments (Java 8)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1808516 13f79535-47bb-0310-9956-ffa450edef68
6 years ago
Javen O'Neal
63b9090007
bug 55075,51233: create drawings with correct height when rows are custom height
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763950 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
Dominik Stadler
e65020bb72
Use IOUtils.closeQuietly() in more places
Avoid two possible file-handle leaks when opening files fails with an exception
Make tests close resources properly to not spam the output when running with file-leak-detector
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1763485 13f79535-47bb-0310-9956-ffa450edef68
7 years ago
Nick Burch
fcf3162b54
Sync the file-based "past-the-end" exception to match the stream one, so that extending works, then tests for HSSF writing to a new empty POIFS file #57919
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753489 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Nick Burch
551ca753ca
Start on unit testing for HSSFWorkbook.write(File), bug in POIFS to fix first
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753487 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Nick Burch
9376bdf27f
#57919 Provide an initial in-place write method for HSSFWorkbook
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753103 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Dominik Stadler
3805d00888
Bug 59665: Using HSSFWorkbook#setSheetOrder to move sheets to the end corrupts bspos value in WorkbookRecordList
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1753038 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
8a9cb7c66b
reorganize imports (remove unused imports, sort alphabetically)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751244 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
752eda425d
add unit test for HSSFWorkbook.getSelectedTabs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748899 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
172ac0be60
bug 59170: Removed deprecated methods in POIFS, SS, HSSF, and XSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748897 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
981ebf6f5e
restore r1739550 and r1739552 (by reverting r1739580). Exclude BaseTestXWorkbook, BaseTestXSheet, BaseTestXRow, and BaseTestXCell from the OOXML-Lite target
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739644 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
01bd0b4a39
revert r1739548 and r1739550. I could not figure out how to add BaseTestXWorkbook|Sheet|Row.java without causing junit to complain about 'Test class should have exactly one public constructor'
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739580 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
4d4db5019c
consolidate duplicates between TestXSSF* and TestSXSSF*
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1739552 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Dominik Stadler
6f2763470e
Apply patch from bug 58909 - Add a cloneSheet() which directly sets the sheetname to allow to avoid a costly renaming of sheets.
Combine related unit-tests into Base-Test-Classes to run them for all types of Workbook/Sheet/...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1737237 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
615616a506
add more commented-out tests for bug 58779: closing an XML Workbook that was not opened as read-only will modify the file on disk
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1736742 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Javen O'Neal
fca4f0d0cb
bug 58879: add SpreadsheetVersion to Workbook interface
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1725039 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Andreas Beeker
5fd534c44b
findbugs fixes
close resources in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1711712 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Dominik Stadler
2afe977622
Bug 58499: Don't report Zip-Bomb for small files which should not cause memory issues anyway
Also make error message a bit more specific and list classname in Zip-Bomb-Error to make it easier for users what the
problem is and how to find out where the static methods are
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1709180 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Dominik Stadler
6f2e63db99
Update test to not depend on an existing build-directory
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708682 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Dominik Stadler
0648ee7b54
Bug 58480: Work around problem where on Windows systems a Mapped Buffer can still lock a file even if the Channel was closed properly. Use reflection as DirectBuffer is in package sun.com and thus likely to go away with Java 9.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708609 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Dominik Stadler
d6254deb3b
Eclipse warnings, comment out dead code, close resources, enhance unit tests, javadoc, ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702802 13f79535-47bb-0310-9956-ffa450edef68
8 years ago
Dominik Stadler
642ba72872
Add test from bug 49423 to verify that the problem was fixed in the meantime
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1668481 13f79535-47bb-0310-9956-ffa450edef68
9 years ago
Nick Burch
42bb3f2194
Correct older biff detection, and add unit tests for HSSFWorkbook giving helpful exceptions on the older formats
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642568 13f79535-47bb-0310-9956-ffa450edef68
9 years ago
Dominik Stadler
e270c4ca5c
Revert parts of an inadvertent previous checkin, keep build.xml and @Override changes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629653 13f79535-47bb-0310-9956-ffa450edef68
9 years ago
Dominik Stadler
5f4551da69
Print out current version of java before building to allow to see in build output if we use a supported Java VM version
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1629644 13f79535-47bb-0310-9956-ffa450edef68
9 years ago
Dominik Stadler
8a1411bda1
fix some Eclipse warnings, unnecessary null-check and missing close() in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1594201 13f79535-47bb-0310-9956-ffa450edef68
10 years ago
Andreas Beeker
d58466c8b3
update *ssf-workbook tests to junit4
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1568541 13f79535-47bb-0310-9956-ffa450edef68
10 years ago
Dominik Stadler
b002f0497a
Add some @Overrides suggested by Eclipse, generics and some warnings,
convert some tabs to spaces.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1553466 13f79535-47bb-0310-9956-ffa450edef68
10 years ago
Dominik Stadler
9d7c124057
Fix Bug 54400 by updating the index in the LinkTable whenever sheets are
removed.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1538163 13f79535-47bb-0310-9956-ffa450edef68
10 years ago
Dominik Stadler
f06e06ef12
Add testcase which tries to reproduce Bug 48495, but seems to be fixed
now.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1516981 13f79535-47bb-0310-9956-ffa450edef68
10 years ago