Greg Woolsey
6b76706ef7
#61700 getForceFormulaRecalculation() returns wrong value
changed to use the proper OOXML attribute instead of a hack about calculation engine version ID. Reporter was right, the behavior was wrong in some cases, but it turns out the fix was a bit more. See issue for details.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856652 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
b9101138bd
[bug-61700] getForceFormulaRecalculation() returns wrong value. Fix thanks to Kai G
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856650 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
5d580f48e6
fix build issue
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1856649 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
259d5a234f
upgrade xmlsec, slf4j, batik
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855990 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
d66873a765
upgrade bouncycastle and curvesapi
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855978 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
92232b921a
remove unncessary synchronization
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855956 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
40f8d119c7
Remove more remnants of NPOIFSFileSystem, mostly in comments and variable names
This avoids confusion if people look at this code in the future without knowledge
about the historical transition from java.io to java.nio
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855873 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Greg Woolsey
82f9c29258
#60724 - Partial implementation for SUBTOTAL() 'ignore hidden rows' variations
The function still doesn't deal with auto-filtering, but it now handles variations that should skip hidden rows.
Taught the evaluation framework to know about hidden rows similar to what was already there for skipping subtotals within subtotal ranges.
Added unit test cases.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855789 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
126606c838
fix some cases where iterator usage does not check hasNext
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855480 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
ef369931e2
Bug 63221: Add margin-settings for top, bottom, left and right to XSSFPrintSetup
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855154 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
5329f25b0a
Adjust test to not fail with Xerces XML Parser, fix some IDE warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1855139 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
d6b5e936e9
[bug-63240] make SAXHelper.newXMLReader non-synchronized]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854941 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
0786ae5b57
[bug-63240] make DocumentHelper.newDocumentBuilder non-synchronized]
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854935 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
4c017a0e27
Fix a regression test failure, toString() should never return null
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854717 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
a9b2a8b2bd
Bug 63200: Avoid NullPointerException in XSLFShape.selectPaint() and check some more in integration tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1854639 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Yegor Kozlov
8350124e9b
Bug 63029: revert handling NotOfficeXmlFileException in ZipPackage as this change broke the build
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853474 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Yegor Kozlov
caef630c70
Bug 63029: OPCPackage Potentially clobbers files on close()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1853454 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
a08b69df80
pulled *Cell.setCellValue(String), setCellValue(RichTextString) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852255 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
53eee01b5d
pulled *Cell.setCellValue(Date) and setCellValue(Calendar) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852254 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
5da229797f
pulled *Cell.setCellValue(double) to the common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852253 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
70b4b88a3a
pulled *Cell.getCellTypeEnum() to common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852252 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
bc30eceb02
pulled *Cell.getAddress to common base
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852251 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
a8a0cb56f7
purged usages of Cell.setCellType (left only in tests, where conversions are tested)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852247 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
39d963aa33
made call Cell.setCellType(CellType.FORMULA) illegall. Deprecated Cell.setCellType(). Purged all redundant calls from project.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852246 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
19bf8b23d5
purged calls to cell.setCellType(CellType.BLANK) from the project, replaced with setBlank()
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852245 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
d60cb3a18c
added Cell.setBlank() - as an alias, for now
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852244 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
1253a29571
setCellFormula: blank cell gets value 0, non-blank value is preserved
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1852212 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
db14c353fc
Fix some Findbugs and IDE issues, refactor some duplicated code,
improve some exception texts, add comment for missing Ptg for SxName
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851210 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
32c43c068c
IDE and JavaDoc fixes, move/remove some unfixed tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851089 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Greg Woolsey
8b69fcc642
Bug #60977 writing XSSF with custom properties twice corrupts output
turns out the output XML data buffer for the custom properties document was appended to, not replaced, when writing in the presence of existing content. Now clearing output buffer first in this case. When first creating custom properties, i.e. first write after changes, there is no buffer yet, so nothing to clear.
Does not affect any read operations, or other writes beyond custom properties, as that was where the problem lay, not down in the Zip stuff.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1851084 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
f64aef7417
unified setCellType(null/_NONE) logic, setCellFormula(null) logic. updated javadoc and tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850676 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
1f9b858ae5
Bug 63057: made SXSSFCell.setCellValue(String|RichTextString) exception-safe.
Also removed unused code.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850342 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
3b8055baa0
Bug 62993: XSSFEvaluationSheet now retrieves valid last row index from underlying XSSFSheet. Thanks to Axel Howind.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850212 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
e501d4015d
Bug 62828: CellReference(Cell) now initializes sheet name.
Changed CellReference to CellAddress in XSSFHyperlink because it is what it should return.
Updated all relevant tests, added a test for CellReference(Cell).
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850210 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Vladislav Galas
3aec436a34
Bug 62307: made Cell#getNumericCellValue() behavior consistent across HSSF/XSSF/SXSSF.\nAll three implementations throw ISE when trying to get numeric value from a boolean-valued cell, have it a formula set or not.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850207 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
59a7919af6
Add missing revert() in OPCPackage to close Zip-streams always
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850115 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
fa24471916
Add missing file-close in ZipInputStreamZipEntrySource seen in some mass regression tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850114 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
PJ Fanning
bfecad39e5
fix since annotation
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1850048 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
b416d97de5
Bug 60845: Apply patch and adjust tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849969 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
d942e2042d
IDE and JavaDoc fixes, make base test classes abstract
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849968 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Andreas Beeker
c039da1b94
#63028 - Provide font embedding for slideshows
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849898 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Andreas Beeker
83d4d4169f
Fix Javadocs
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849896 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
2b8200f7d7
Bug 61532: Fix setting values/types during formula evaluation for SXSSF
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849880 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
d3dc9b0338
Bug 62629: Allow to handle files with invalid content types for pictures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849814 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
7de8c2eaec
Re-instate two dev-tools that we lost in some refactoring,
at least OOXMLPrettyPrint is still very useful for comparing ooxml-files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849813 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
ae3d6944db
IDE and JavaDoc fixes, close() in tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849812 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
6f2f283db8
Fix various IDE warnings and some JavaDoc adjustments
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849763 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
d40eb6f37f
Fix incorrect constant for pict-files
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849762 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
235f3e059c
Remove unnecesssary semicolons
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849761 13f79535-47bb-0310-9956-ffa450edef68
5 years ago
Dominik Stadler
f6eab84243
Simplify some string operations
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1849760 13f79535-47bb-0310-9956-ffa450edef68
5 years ago