Nick Burch
f5091846ff
Unit test for VBA macro reading #52949
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738427 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Dominik Stadler
abf2f29478
Slightly improve error message
Fix some IntelliJ/compiler warnings
Use common interfaces where possible
Cleanup after testing POIFSDump
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738032 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Dominik Stadler
6d92ee86ff
Findbugs fixes
OldExcelExtractor could leak file handles in case of exceptions
Free file handles in POIFSDump, add unit-test for POIFSDump
Add a Findbugs exclude and adjust findbugs-ant slightly
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734689 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Nick Burch
a20e6a38d3
More helpful exception message if POIFS is given a raw XML file (eg an Office 2003 XML file), plus tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1734215 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Andreas Beeker
4241f26a13
fix unnecessary cast warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1715626 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Uwe Schindler
5756b4ca25
#58597: Fix tests to not do setAccessible(), add some doPrivileged, too.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1713891 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Dominik Stadler
0648ee7b54
Bug 58480: Work around problem where on Windows systems a Mapped Buffer can still lock a file even if the Channel was closed properly. Use reflection as DirectBuffer is in package sun.com and thus likely to go away with Java 9.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1708609 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Andreas Beeker
fbcf869f48
fix eclipse warning - mostly generics cosmetics
close resources in tests
junit4 conversions
convert spreadsheet based formular test to junit parameterized tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702659 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Andreas Beeker
17d8c71a65
More forbidden apis fixes (added main-tests to the check)
and a few junit4 upgrades
... hopefully this doesn't crash the build again ... :|
to simulate the tests on jenkins on the local developer box, uncomment the UTC lines in the build.xml
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1702356 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Andreas Beeker
ebdbe8b97a
- reworked HexDump class - unified array dumps and usage of standard java calls for hex format
- fixed a few findbugs DM_DEFAULT_ENCODING issues
- removed a few System.out/.err calls - instead the poilogger is used
- closed a few left open resource instances
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1700040 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Dominik Stadler
b6c74c8c8e
Eclipse warnings, code formatting, missing @Overrides, Javadoc, missing close(), ...
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696794 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Dominik Stadler
b49c01c355
Try to make Sonar builds run again: add missing dependency, add ooxml-schema-security, don't depend on dir test-data and build-directory directly, don't override a POILogger that is set via System Properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1696165 13f79535-47bb-0310-9956-ffa450edef68
hace 8 años
Dominik Stadler
dbdbb0cfe6
Bug 58156: Possible data corruption in hasPOIFSHeader and hasOOXMLHeader
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1691948 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
d1bcdb0bcd
When writing the mini-stream, set the size of it on the root property #58061
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1689505 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
92764ff10d
Helper method to report the number of blocks used in a BAT
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1689504 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
562b5e1278
Fix OPOIFS generics warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688920 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
aa84a05ad1
To better match OPOIFS, pad to the end of a block with 0xFF/-1
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688543 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
335ba49ef5
More NPOIFS ministream tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688534 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
c3c7ce3c85
Put the properties table at block 0, with the first BAT at block 1, to hopefully solve #58061
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1688038 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
650bb1b8cb
#56791 Make NPOIFS the default when POIFSFileSystem is requested
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681804 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
9b20ef64bc
Force OPOIFS test to explicitly create OPOIFS instance
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681803 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
f51479df57
Force OPOIFS test to explicitly create OPOIFS instance
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681802 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
1bb45fdc91
Fix warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681763 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
76b49ec06d
Fix testing for NPOIFS zero-length stream writing
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681762 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
e191e05045
More 0 byte stream tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1681754 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
1c4d0baeca
#56791 More updates from OPOIFS to NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678787 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
680740dc25
Add a deep re-write NPOIFS test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678781 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
4cc1544708
Correct zero byte entry support in NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678778 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
1d484efbbb
Disabled NPOIFS unit test - problem with 0 length entries discovered working on #56791
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678769 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
de97868d2f
More NPOIFS ministore tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678767 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
3e2fa9befa
Add a (disabled) failing unit test on heavily nested NPOIFS copies, found working on #56791
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1678764 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
ac7b4bc3dd
#57851 - Skip null properties in PropertyTableBase, which is how PropertyFactory reports unsupported POIFS properties
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675702 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
4a33fe786c
Make the opening code generic
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675700 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
158a02f144
Make the test generic across POIFS and NPOIFS
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675698 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Nick Burch
7fc50ed900
Pull out a common NPOIFS/POIFS test to a decidated bugs test class
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1675696 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Dominik Stadler
1c522adc6b
Fix usage of Generics in some classes
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1674964 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Dominik Stadler
dec03ba459
Add missing close() of resources in both production code and tests
Use revert() instead of close() on OCPPackage in some places to not re-write the file unnecessarily.
This should now run tests without leftover file handles when checked with file leak detector and
allows to find newly introduced cases more easily.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1648160 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Dominik Stadler
b06dee9f51
Add missing license header
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1642034 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Dominik Stadler
eae3eb5c58
Add more output in case of unknown cipher-ids to aid in debugging bugs like 57195
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1641883 13f79535-47bb-0310-9956-ffa450edef68
hace 9 años
Dominik Stadler
427d733469
Add missing @Overrides, reformat some files, increase coverage slightly,
comments, fix Eclipse warnings and add close() calls in some tests and
in HMEFMessage() to close files during tests correctly.
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1602008 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años
Nick Burch
7b134ca25a
More on the HPFS in-place NPOIFS write tests, and a note about what is still to do for them
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590319 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años
Nick Burch
ca16bb9403
Stream tests for NDocumentOutputStream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590303 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años
Nick Burch
6bf09f5b16
Begin to support and test in-place changes to documents within a NPOIFS stream
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590185 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años
Nick Burch
99a52e7638
Complete NPOIFS write tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590162 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años
Nick Burch
2f81141640
More progress with the write/read npoifs tests, but one bug still to go....
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590153 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años
Nick Burch
7e3b3b85d9
Refactor some of the NPOIFS write tests, and begin on the last missing write test
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590149 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años
Nick Burch
00db163084
Finish off the next NPOIFS write text
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590133 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años
Nick Burch
f9c96e48e7
More NPOIFS mini stream improvements, and more tests for it all
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590098 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años
Nick Burch
92dd03dcd6
Correct mini stream initialisation, and enable more npoifs write tests
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590088 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años
Nick Burch
c311ead345
More NPOIFS tests, and a partial mini-stream fix
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1590083 13f79535-47bb-0310-9956-ffa450edef68
hace 10 años