Browse Source

No validation errors when entering an invalid "Estimate hours" value (#27881).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17144 e93f8b46-1217-0410-a6f0-8f06a7374b81
tags/4.0.0
Jean-Philippe Lang 6 years ago
parent
commit
2cb30321a2
2 changed files with 2 additions and 2 deletions
  1. 1
    1
      app/models/issue.rb
  2. 1
    1
      test/unit/issue_test.rb

+ 1
- 1
app/models/issue.rb View File

@@ -440,7 +440,7 @@ class Issue < ActiveRecord::Base
end

def estimated_hours=(h)
write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
write_attribute :estimated_hours, (h.is_a?(String) ? (h.to_hours || h) : h)
end

safe_attributes 'project_id',

+ 1
- 1
test/unit/issue_test.rb View File

@@ -128,7 +128,7 @@ class IssueTest < ActiveSupport::TestCase

def test_estimated_hours_should_be_validated
set_language_if_valid 'en'
['-2'].each do |invalid|
['-2', '123abc'].each do |invalid|
issue = Issue.new(:estimated_hours => invalid)
assert !issue.valid?
assert_include 'Estimated time is invalid', issue.errors.full_messages

Loading…
Cancel
Save