Browse Source

Wrong filters are applied when exporting issues to CSV with blank filter (#23206).

Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@15608 e93f8b46-1217-0410-a6f0-8f06a7374b81
tags/3.4.0
Jean-Philippe Lang 8 years ago
parent
commit
4c78b63d58
2 changed files with 13 additions and 0 deletions
  1. 2
    0
      app/helpers/queries_helper.rb
  2. 11
    0
      test/functional/issues_controller_test.rb

+ 2
- 0
app/helpers/queries_helper.rb View File

@@ -257,6 +257,8 @@ module QueriesHelper
tags << hidden_field_tag("v[#{field}][]", value, :id => nil)
end
end
else
tags << hidden_field_tag("f[]", "", :id => nil)
end
if query.column_names.present?
query.column_names.each do |name|

+ 11
- 0
test/functional/issues_controller_test.rb View File

@@ -488,6 +488,9 @@ class IssuesControllerTest < ActionController::TestCase

assert_select 'input[name=?][value=?]', 'sort', 'status'
end

get :index, :project_id => 1, :set_filter => "1", :f => []
assert_select '#csv-export-form input[name=?][value=?]', 'f[]', ''
end

def test_index_csv
@@ -507,6 +510,14 @@ class IssuesControllerTest < ActionController::TestCase
assert_equal 'text/csv; header=present', @response.content_type
end

def test_index_csv_without_any_filters
@request.session[:user_id] = 1
Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 5, :subject => 'Closed issue', :author_id => 1)
get :index, :set_filter => 1, :f => [], :format => 'csv'
assert_response :success
assert_equal Issue.count, assigns(:issues).count
end

def test_index_csv_with_description
Issue.generate!(:description => 'test_index_csv_with_description')


Loading…
Cancel
Save