Browse Source

Remove deprecated @status=@ param used to get all users. @status=*@ should be used now. (#40124).

git-svn-id: https://svn.redmine.org/redmine/trunk@22635 e93f8b46-1217-0410-a6f0-8f06a7374b81
pull/145/merge
Marius Balteanu 3 months ago
parent
commit
5676499ceb
2 changed files with 0 additions and 11 deletions
  1. 0
    4
      app/controllers/users_controller.rb
  2. 0
    7
      test/integration/api_test/users_test.rb

+ 0
- 4
app/controllers/users_controller.rb View File

@@ -47,10 +47,6 @@ class UsersController < ApplicationController

# API backwards compatibility: handle legacy filter parameters
unless request.format.html?
if params.include?(:status) && params[:status].blank?
ActiveSupport::Deprecation.warn "Getting all users from API using an empty status param (status=) is deprecated and it will be removed in Redmine 6.0. Please use \"status=*\"."
@query.add_filter 'status', '*'
end
if name = params[:name].presence
@query.add_filter 'name', '~', [name]
end

+ 0
- 7
test/integration/api_test/users_test.rb View File

@@ -97,13 +97,6 @@ class Redmine::ApiTest::UsersTest < Redmine::ApiTest::Base
users = User.logged
assert_equal users.size, json['users'].size

get '/users.json', headers: credentials('admin'), params: { status: ''}
assert_response :success
json = ActiveSupport::JSON.decode(response.body)
assert json.key?('users')
users = User.logged
assert_equal users.size, json['users'].size

get '/users.json', headers: credentials('admin'), params: { name: 'jsmith' }
assert_response :success
json = ActiveSupport::JSON.decode(response.body)

Loading…
Cancel
Save