Browse Source

Disable RuboCop offense Performance/Sum in IssueFieldsRows#to_html (#38146).


git-svn-id: https://svn.redmine.org/redmine/trunk@22034 e93f8b46-1217-0410-a6f0-8f06a7374b81
tags/5.1.0
Go MAEDA 1 year ago
parent
commit
7cf89bf44e
2 changed files with 2 additions and 6 deletions
  1. 0
    6
      .rubocop_todo.yml
  2. 2
    0
      app/helpers/issues_helper.rb

+ 0
- 6
.rubocop_todo.yml View File

@@ -486,12 +486,6 @@ Naming/VariableNumber:
- 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb'
- 'test/unit/project_test.rb'

# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: OnlySumOrWithInitialValue.
Performance/Sum:
Exclude:
- 'app/helpers/issues_helper.rb'

# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: Include.
# Include: app/models/**/*.rb

+ 2
- 0
app/helpers/issues_helper.rb View File

@@ -343,9 +343,11 @@ module IssuesHelper
end

def to_html
# rubocop:disable Performance/Sum
content =
content_tag('div', @left.reduce(&:+), :class => 'splitcontentleft') +
content_tag('div', @right.reduce(&:+), :class => 'splitcontentleft')
# rubocop:enable Performance/Sum

content_tag('div', content, :class => 'splitcontent')
end

Loading…
Cancel
Save