Browse Source

Fixed that X-Sendfile header is never set (#24646).

git-svn-id: http://svn.redmine.org/redmine/trunk@16114 e93f8b46-1217-0410-a6f0-8f06a7374b81
tags/3.4.0
Jean-Philippe Lang 7 years ago
parent
commit
aef4a8a65b
2 changed files with 13 additions and 1 deletions
  1. 1
    1
      config/application.rb
  2. 12
    0
      test/integration/attachments_test.rb

+ 1
- 1
config/application.rb View File

@@ -55,7 +55,7 @@ module RedmineApp
config.middleware.insert_after ActionDispatch::ParamsParser, ActionDispatch::XmlParamsParser

# Sets the Content-Length header on responses with fixed-length bodies
config.middleware.use Rack::ContentLength
config.middleware.insert_after Rack::Sendfile, Rack::ContentLength

# Verify validity of user sessions
config.redmine_verify_sessions = true

+ 12
- 0
test/integration/attachments_test.rb View File

@@ -136,6 +136,18 @@ class AttachmentsTest < Redmine::IntegrationTest
assert_include "$('#attachments_1').remove();", response.body
end

def test_download_should_set_sendfile_header
set_fixtures_attachments_directory
Rack::Sendfile.any_instance.stubs(:variation).returns("X-Sendfile")

get "/attachments/download/4"
assert_response :success
assert_not_nil response.headers["X-Sendfile"]

ensure
set_tmp_attachments_directory
end

private

def ajax_upload(filename, content, attachment_id=1)

Loading…
Cancel
Save