瀏覽代碼

Fixed that total estimated time column is shown even when estimated time field is deactivated (#31779).

Patch by Felix Schäfer and Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@18743 e93f8b46-1217-0410-a6f0-8f06a7374b81
tags/4.1.0
Jean-Philippe Lang 4 年之前
父節點
當前提交
c5b5f0d6a9
共有 2 個檔案被更改,包括 20 行新增0 行删除
  1. 1
    0
      app/models/issue_query.rb
  2. 19
    0
      test/unit/query_test.rb

+ 1
- 0
app/models/issue_query.rb 查看文件

end end


disabled_fields = Tracker.disabled_core_fields(trackers).map {|field| field.sub(/_id$/, '')} disabled_fields = Tracker.disabled_core_fields(trackers).map {|field| field.sub(/_id$/, '')}
disabled_fields << "total_estimated_hours" if disabled_fields.include?("estimated_hours")
@available_columns.reject! {|column| @available_columns.reject! {|column|
disabled_fields.include?(column.name.to_s) disabled_fields.include?(column.name.to_s)
} }

+ 19
- 0
test/unit/query_test.rb 查看文件

end end
end end


def test_available_columns_should_not_include_total_estimated_hours_when_trackers_disabled_estimated_hours
Tracker.visible.each do |tracker|
tracker.core_fields = tracker.core_fields.reject{|field| field == 'estimated_hours'}
tracker.save!
end
query = IssueQuery.new
available_columns = query.available_columns.map(&:name)
assert_not_include :estimated_hours, available_columns
assert_not_include :total_estimated_hours, available_columns

tracker = Tracker.visible.first
tracker.core_fields = ['estimated_hours']
tracker.save!
query = IssueQuery.new
available_columns = query.available_columns.map(&:name)
assert_include :estimated_hours, available_columns
assert_include :total_estimated_hours, available_columns
end

def setup_member_of_group def setup_member_of_group
Group.destroy_all # No fixtures Group.destroy_all # No fixtures
@user_in_group = User.generate! @user_in_group = User.generate!

Loading…
取消
儲存