Browse Source

Refactor: move method to model. (references r4057)

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4062 e93f8b46-1217-0410-a6f0-8f06a7374b81
tags/1.1.0
Eric Davis 13 years ago
parent
commit
db11030410
3 changed files with 9 additions and 8 deletions
  1. 0
    7
      app/helpers/journals_helper.rb
  2. 8
    0
      app/models/journal.rb
  3. 1
    1
      app/views/issues/_history.rhtml

+ 0
- 7
app/helpers/journals_helper.rb View File

@@ -39,11 +39,4 @@ module JournalsHelper
onclick = "new Ajax.Request('#{url_for(url)}', {asynchronous:true, evalScripts:true, method:'get'}); return false;"
link_to text, '#', options.merge(:onclick => onclick)
end
def css_journal_classes(journal)
s = 'journal'
s << ' has-notes' unless journal.notes.blank?
s << ' has-details' unless journal.details.blank?
s
end
end

+ 8
- 0
app/models/journal.rb View File

@@ -65,4 +65,12 @@ class Journal < ActiveRecord::Base
def attachments
journalized.respond_to?(:attachments) ? journalized.attachments : nil
end

# Returns a string of css classes
def css_classes
s = 'journal'
s << ' has-notes' unless notes.blank?
s << ' has-details' unless details.blank?
s
end
end

+ 1
- 1
app/views/issues/_history.rhtml View File

@@ -1,6 +1,6 @@
<% reply_links = authorize_for('issues', 'edit') -%>
<% for journal in journals %>
<div id="change-<%= journal.id %>" class="<%= css_journal_classes(journal) %>">
<div id="change-<%= journal.id %>" class="<%= journal.css_classes %>">
<h4><div class="journal-link"><%= link_to "##{journal.indice}", :anchor => "note-#{journal.indice}" %></div>
<%= avatar(journal.user, :size => "24") %>
<%= content_tag('a', '', :name => "note-#{journal.indice}")%>

Loading…
Cancel
Save