git-svn-id: https://svn.redmine.org/redmine/trunk@22031 e93f8b46-1217-0410-a6f0-8f06a7374b81tags/5.1.0
@@ -486,14 +486,6 @@ Naming/VariableNumber: | |||
- 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb' | |||
- 'test/unit/project_test.rb' | |||
# This cop supports unsafe autocorrection (--autocorrect-all). | |||
Performance/RedundantEqualityComparisonBlock: | |||
Exclude: | |||
- 'app/models/query.rb' | |||
- 'app/models/setting.rb' | |||
- 'lib/redmine/field_format.rb' | |||
- 'test/integration/api_test/issues_test.rb' | |||
# This cop supports safe autocorrection (--autocorrect). | |||
Performance/RedundantMatch: | |||
Exclude: |
@@ -846,7 +846,7 @@ class Query < ActiveRecord::Base | |||
end | |||
def has_custom_field_column? | |||
columns.any? {|column| column.is_a? QueryCustomFieldColumn} | |||
columns.any?(QueryCustomFieldColumn) | |||
end | |||
def has_default_columns? |
@@ -217,7 +217,7 @@ class Setting < ActiveRecord::Base | |||
# # => [{'keywords => 'fixes', 'status_id' => "3"}, {'keywords => 'closes', 'status_id' => "5", 'done_ratio' => "100"}] | |||
def self.commit_update_keywords_from_params(params) | |||
s = [] | |||
if params.is_a?(Hash) && params.key?(:keywords) && params.values.all? {|v| v.is_a? Array} | |||
if params.is_a?(Hash) && params.key?(:keywords) && params.values.all?(Array) | |||
attributes = params.except(:keywords).keys | |||
params[:keywords].each_with_index do |keywords, i| | |||
next if keywords.blank? |
@@ -973,7 +973,7 @@ module Redmine | |||
attachment_present = true | |||
value = value.except(:blank) | |||
if value.values.any? && value.values.all? {|v| v.is_a?(Hash)} | |||
if value.values.any? && value.values.all?(Hash) | |||
value = value.values.first | |||
end | |||
@@ -231,7 +231,7 @@ class Redmine::ApiTest::IssuesTest < Redmine::ApiTest::Base | |||
json = ActiveSupport::JSON.decode(response.body) | |||
status_ids_used = json['issues'].collect {|j| j['status']['id']} | |||
assert_equal 3, status_ids_used.length | |||
assert status_ids_used.all? {|id| id == 5} | |||
assert status_ids_used.all?(5) | |||
end | |||
test "GET /issues/:id.xml with journals" do |