Browse Source

Fixed: Files assigned to a version can not be deleted if Issue Tracking module is disabled (#17163).

Patch by Michael Esemplare.

git-svn-id: http://svn.redmine.org/redmine/trunk@13390 e93f8b46-1217-0410-a6f0-8f06a7374b81
tags/2.6.0
Jean-Philippe Lang 9 years ago
parent
commit
e124da5488
2 changed files with 14 additions and 0 deletions
  1. 4
    0
      app/models/version.rb
  2. 10
    0
      test/functional/attachments_controller_test.rb

+ 4
- 0
app/models/version.rb View File

@@ -60,6 +60,10 @@ class Version < ActiveRecord::Base
project.present? && project.attachments_visible?(*args)
end

def attachments_deletable?(usr=User.current)
project.present? && project.attachments_deletable?(usr)
end

def start_date
@start_date ||= fixed_issues.minimum('start_date')
end

+ 10
- 0
test/functional/attachments_controller_test.rb View File

@@ -387,6 +387,16 @@ class AttachmentsControllerTest < ActionController::TestCase
end
end

def test_destroy_version_attachment_with_issue_tracking_disabled
Project.find(1).disable_module! :issue_tracking
set_tmp_attachments_directory
@request.session[:user_id] = 2
assert_difference 'Attachment.count', -1 do
delete :destroy, :id => 9
assert_response 302
end
end

def test_destroy_without_permission
set_tmp_attachments_directory
assert_no_difference 'Attachment.count' do

Loading…
Cancel
Save