You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

roles_controller_test.rb 11KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359
  1. # frozen_string_literal: true
  2. # Redmine - project management software
  3. # Copyright (C) 2006- Jean-Philippe Lang
  4. #
  5. # This program is free software; you can redistribute it and/or
  6. # modify it under the terms of the GNU General Public License
  7. # as published by the Free Software Foundation; either version 2
  8. # of the License, or (at your option) any later version.
  9. #
  10. # This program is distributed in the hope that it will be useful,
  11. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  12. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13. # GNU General Public License for more details.
  14. #
  15. # You should have received a copy of the GNU General Public License
  16. # along with this program; if not, write to the Free Software
  17. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  18. require_relative '../test_helper'
  19. class RolesControllerTest < Redmine::ControllerTest
  20. fixtures :roles, :users, :members, :member_roles, :workflows, :trackers
  21. def setup
  22. User.current = nil
  23. @request.session[:user_id] = 1 # admin
  24. end
  25. def test_index
  26. get :index
  27. assert_response :success
  28. assert_select 'table.roles tbody' do
  29. assert_select 'tr', Role.count
  30. assert_select 'a[href="/roles/1/edit"]', :text => 'Manager'
  31. end
  32. end
  33. def test_index_should_show_warning_when_no_workflow_is_defined
  34. Role.find_by_name('Developer').workflow_rules.destroy_all
  35. Role.find_by_name('Anonymous').workflow_rules.destroy_all
  36. get :index
  37. assert_response :success
  38. assert_select 'table.roles' do
  39. # Manager
  40. assert_select 'tr.givable:nth-of-type(1) span.icon-warning', :count => 0
  41. # Developer
  42. assert_select 'tr.givable:nth-of-type(2) span.icon-warning', :text => /#{I18n.t(:text_role_no_workflow)}/
  43. # Reporter
  44. assert_select 'tr.givable:nth-of-type(3) span.icon-warning', :count => 0
  45. # No warnings for built-in roles such as Anonymous and Non-member
  46. assert_select 'tr.builtin span.icon-warning', :count => 0
  47. end
  48. end
  49. def test_new
  50. get :new
  51. assert_response :success
  52. assert_select 'input[name=?]', 'role[name]'
  53. assert_select 'input[name=?]', 'role[permissions][]'
  54. end
  55. def test_new_should_prefill_permissions_with_non_member_permissions
  56. role = Role.non_member
  57. role.permissions = [:view_issues, :view_documents]
  58. role.save!
  59. get :new
  60. assert_response :success
  61. assert_equal(
  62. %w(view_documents view_issues),
  63. css_select('input[name="role[permissions][]"][checked=checked]').map {|e| e.attr(:value)}.sort
  64. )
  65. end
  66. def test_new_with_copy
  67. copy_from = Role.find(2)
  68. get :new, :params => {:copy => copy_from.id.to_s}
  69. assert_response :success
  70. assert_select 'input[name=?]', 'role[name]'
  71. assert_select 'form' do
  72. # blank name
  73. assert_select 'input[name=?][value=""]', 'role[name]'
  74. # edit_project permission checked
  75. assert_select 'input[type=checkbox][name=?][value=edit_project][checked=checked]', 'role[permissions][]'
  76. # add_project permission not checked
  77. assert_select 'input[type=checkbox][name=?][value=add_project]', 'role[permissions][]'
  78. assert_select 'input[type=checkbox][name=?][value=add_project][checked=checked]', 'role[permissions][]', 0
  79. # workflow copy selected
  80. assert_select 'select[name=?]', 'copy_workflow_from' do
  81. assert_select 'option[value="2"][selected=selected]'
  82. end
  83. end
  84. end
  85. def test_create_with_validaton_failure
  86. post(
  87. :create,
  88. :params => {
  89. :role => {
  90. :name => '',
  91. :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
  92. :assignable => '0'
  93. }
  94. }
  95. )
  96. assert_response :success
  97. assert_select_error /Name cannot be blank/
  98. end
  99. def test_create_without_workflow_copy
  100. post(
  101. :create,
  102. :params => {
  103. :role => {
  104. :name => 'RoleWithoutWorkflowCopy',
  105. :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
  106. :assignable => '0'
  107. }
  108. }
  109. )
  110. assert_redirected_to '/roles'
  111. role = Role.find_by_name('RoleWithoutWorkflowCopy')
  112. assert_not_nil role
  113. assert_equal [:add_issues, :edit_issues, :log_time], role.permissions
  114. assert !role.assignable?
  115. end
  116. def test_create_with_workflow_copy
  117. post(
  118. :create,
  119. :params => {
  120. :role => {
  121. :name => 'RoleWithWorkflowCopy',
  122. :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
  123. :assignable => '0'
  124. },
  125. :copy_workflow_from => '1'
  126. }
  127. )
  128. assert_redirected_to '/roles'
  129. role = Role.find_by_name('RoleWithWorkflowCopy')
  130. assert_not_nil role
  131. assert_equal Role.find(1).workflow_rules.size, role.workflow_rules.size
  132. end
  133. def test_create_with_managed_roles
  134. role = new_record(Role) do
  135. post(
  136. :create,
  137. :params => {
  138. :role => {
  139. :name => 'Role',
  140. :all_roles_managed => '0',
  141. :managed_role_ids => ['2', '3', '']
  142. }
  143. }
  144. )
  145. assert_response 302
  146. end
  147. assert_equal false, role.all_roles_managed
  148. assert_equal [2, 3], role.managed_role_ids.sort
  149. end
  150. def test_edit
  151. get :edit, :params => {:id => 1}
  152. assert_response :success
  153. assert_select 'input[name=?][value=?]', 'role[name]', 'Manager'
  154. assert_select 'select[name=?]', 'role[issues_visibility]'
  155. assert_select '#role-permissions-trackers table .delete_issues_shown'
  156. end
  157. def test_edit_anonymous
  158. get :edit, :params => {:id => Role.anonymous.id}
  159. assert_response :success
  160. assert_select 'input[name=?]', 'role[name]', 0
  161. assert_select 'select[name=?]', 'role[issues_visibility]', 0
  162. assert_select '#role-permissions-trackers table .delete_issues_shown', 0
  163. end
  164. def test_edit_invalid_should_respond_with_404
  165. get :edit, :params => {:id => 999}
  166. assert_response 404
  167. end
  168. def test_update
  169. put(
  170. :update,
  171. :params => {
  172. :id => 1,
  173. :role => {
  174. :name => 'Manager',
  175. :permissions => ['edit_project', ''],
  176. :assignable => '0'
  177. }
  178. }
  179. )
  180. assert_redirected_to '/roles'
  181. role = Role.find(1)
  182. assert_equal [:edit_project], role.permissions
  183. end
  184. def test_update_trackers_permissions
  185. put(
  186. :update,
  187. :params => {
  188. :id => 1,
  189. :role => {
  190. :permissions_all_trackers => {'add_issues' => '0'},
  191. :permissions_tracker_ids => {'add_issues' => ['1', '3', '']}
  192. }
  193. }
  194. )
  195. assert_redirected_to '/roles'
  196. role = Role.find(1)
  197. assert_equal({'add_issues' => '0'}, role.permissions_all_trackers)
  198. assert_equal({'add_issues' => ['1', '3']}, role.permissions_tracker_ids)
  199. assert_equal false, role.permissions_all_trackers?(:add_issues)
  200. assert_equal [1, 3], role.permissions_tracker_ids(:add_issues).sort
  201. end
  202. def test_update_with_failure
  203. put :update, :params => {:id => 1, :role => {:name => ''}}
  204. assert_response :success
  205. assert_select_error /Name cannot be blank/
  206. end
  207. def test_destroy
  208. r = Role.create!(:name => 'ToBeDestroyed', :permissions => [:view_wiki_pages])
  209. delete :destroy, :params => {:id => r}
  210. assert_redirected_to '/roles'
  211. assert_nil Role.find_by_id(r.id)
  212. end
  213. def test_destroy_role_in_use
  214. delete :destroy, :params => {:id => 1}
  215. assert_redirected_to '/roles'
  216. assert_equal 'This role is in use and cannot be deleted.', flash[:error]
  217. assert_not_nil Role.find_by_id(1)
  218. end
  219. def test_permissions
  220. get :permissions
  221. assert_response :success
  222. assert_select 'input[name=?][type=checkbox][value=add_issues][checked=checked]', 'permissions[3][]'
  223. assert_select 'input[name=?][type=checkbox][value=delete_issues]:not([checked])', 'permissions[3][]'
  224. end
  225. def test_permissions_with_filter
  226. get(
  227. :permissions,
  228. :params => {
  229. :ids => ['2', '3']
  230. }
  231. )
  232. assert_response :success
  233. assert_select 'table.permissions thead th', 3
  234. assert_select 'input[name=?][type=checkbox][value=add_issues][checked=checked]', 'permissions[3][]'
  235. assert_select 'input[name=?][type=checkbox][value=delete_issues]:not([checked])', 'permissions[3][]'
  236. end
  237. def test_permissions_csv_export
  238. get(
  239. :permissions,
  240. :params => {
  241. :format => 'csv'
  242. }
  243. )
  244. assert_response :success
  245. assert_equal 'text/csv; header=present', @response.media_type
  246. lines = @response.body.chomp.split("\n")
  247. # Number of lines
  248. permissions = Redmine::AccessControl.permissions - Redmine::AccessControl.public_permissions
  249. permissions = permissions.group_by{|p| p.project_module.to_s}.sort.collect(&:last).flatten
  250. assert_equal permissions.size + 1, lines.size
  251. # Header
  252. assert_equal 'Module,Permissions,Manager,Developer,Reporter,Non member,Anonymous', lines.first
  253. # Details
  254. to_test = {
  255. :add_project => '"",Create project,Yes,No,No,No,""',
  256. :add_issue_notes => 'Issue tracking,Add notes,Yes,Yes,Yes,Yes,Yes',
  257. :manage_wiki => 'Wiki,Manage wiki,Yes,No,No,"",""'
  258. }
  259. to_test.each do |name, expected|
  260. index = permissions.find_index {|p| p.name == name}
  261. assert_not_nil index
  262. assert_equal expected, lines[index + 1]
  263. end
  264. end
  265. def test_update_permissions
  266. post(
  267. :update_permissions,
  268. :params => {
  269. :permissions => {
  270. '1' => ['edit_issues'],
  271. '3' => ['add_issues', 'delete_issues']
  272. }
  273. }
  274. )
  275. assert_redirected_to '/roles'
  276. assert_equal [:edit_issues], Role.find(1).permissions
  277. assert_equal [:add_issues, :delete_issues], Role.find(3).permissions
  278. end
  279. def test_update_permissions_should_not_update_other_roles
  280. assert_no_changes lambda {Role.find(2).permissions} do
  281. assert_changes lambda {Role.find(1).permissions} do
  282. post(
  283. :update_permissions,
  284. :params => {
  285. :permissions => {
  286. '1' => ['edit_issues']
  287. }
  288. }
  289. )
  290. end
  291. end
  292. end
  293. def test_move_highest
  294. put :update, :params => {:id => 3, :role => {:position => 1}}
  295. assert_redirected_to '/roles'
  296. assert_equal 1, Role.find(3).position
  297. end
  298. def test_move_higher
  299. position = Role.find(3).position
  300. put :update, :params => {:id => 3, :role => {:position => position - 1}}
  301. assert_redirected_to '/roles'
  302. assert_equal position - 1, Role.find(3).position
  303. end
  304. def test_move_lower
  305. position = Role.find(2).position
  306. put :update, :params => {:id => 2, :role => {:position => position + 1}}
  307. assert_redirected_to '/roles'
  308. assert_equal position + 1, Role.find(2).position
  309. end
  310. def test_move_lowest
  311. put :update, :params => {:id => 2, :role => {:position => Role.givable.count}}
  312. assert_redirected_to '/roles'
  313. assert_equal Role.givable.count, Role.find(2).position
  314. end
  315. end