You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_nested_set_test.rb 16KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402
  1. # Redmine - project management software
  2. # Copyright (C) 2006-2013 Jean-Philippe Lang
  3. #
  4. # This program is free software; you can redistribute it and/or
  5. # modify it under the terms of the GNU General Public License
  6. # as published by the Free Software Foundation; either version 2
  7. # of the License, or (at your option) any later version.
  8. #
  9. # This program is distributed in the hope that it will be useful,
  10. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  11. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  12. # GNU General Public License for more details.
  13. #
  14. # You should have received a copy of the GNU General Public License
  15. # along with this program; if not, write to the Free Software
  16. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  17. require File.expand_path('../../test_helper', __FILE__)
  18. class IssueNestedSetTest < ActiveSupport::TestCase
  19. fixtures :projects, :users, :roles,
  20. :trackers, :projects_trackers,
  21. :issue_statuses, :issue_categories, :issue_relations,
  22. :enumerations,
  23. :issues
  24. def test_new_record_is_leaf
  25. i = Issue.new
  26. assert i.leaf?
  27. end
  28. def test_create_root_issue
  29. lft1 = new_issue_lft
  30. issue1 = Issue.generate!
  31. lft2 = new_issue_lft
  32. issue2 = Issue.generate!
  33. issue1.reload
  34. issue2.reload
  35. assert_equal [issue1.id, nil, lft1, lft1 + 1], [issue1.root_id, issue1.parent_id, issue1.lft, issue1.rgt]
  36. assert_equal [issue2.id, nil, lft2, lft2 + 1], [issue2.root_id, issue2.parent_id, issue2.lft, issue2.rgt]
  37. end
  38. def test_create_child_issue
  39. lft = new_issue_lft
  40. parent = Issue.generate!
  41. child = Issue.generate!(:parent_issue_id => parent.id)
  42. parent.reload
  43. child.reload
  44. assert_equal [parent.id, nil, lft, lft + 3], [parent.root_id, parent.parent_id, parent.lft, parent.rgt]
  45. assert_equal [parent.id, parent.id, lft + 1, lft + 2], [child.root_id, child.parent_id, child.lft, child.rgt]
  46. end
  47. def test_creating_a_child_in_a_subproject_should_validate
  48. issue = Issue.generate!
  49. child = Issue.new(:project_id => 3, :tracker_id => 2, :author_id => 1,
  50. :subject => 'child', :parent_issue_id => issue.id)
  51. assert_save child
  52. assert_equal issue, child.reload.parent
  53. end
  54. def test_creating_a_child_in_an_invalid_project_should_not_validate
  55. issue = Issue.generate!
  56. child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
  57. :subject => 'child', :parent_issue_id => issue.id)
  58. assert !child.save
  59. assert_not_equal [], child.errors[:parent_issue_id]
  60. end
  61. def test_move_a_root_to_child
  62. lft = new_issue_lft
  63. parent1 = Issue.generate!
  64. parent2 = Issue.generate!
  65. child = Issue.generate!(:parent_issue_id => parent1.id)
  66. parent2.parent_issue_id = parent1.id
  67. parent2.save!
  68. child.reload
  69. parent1.reload
  70. parent2.reload
  71. assert_equal [parent1.id, lft, lft + 5], [parent1.root_id, parent1.lft, parent1.rgt]
  72. assert_equal [parent1.id, lft + 3, lft + 4], [parent2.root_id, parent2.lft, parent2.rgt]
  73. assert_equal [parent1.id, lft + 1, lft + 2], [child.root_id, child.lft, child.rgt]
  74. end
  75. def test_move_a_child_to_root
  76. lft1 = new_issue_lft
  77. parent1 = Issue.generate!
  78. lft2 = new_issue_lft
  79. parent2 = Issue.generate!
  80. child = Issue.generate!(:parent_issue_id => parent1.id)
  81. child.parent_issue_id = nil
  82. child.save!
  83. child.reload
  84. parent1.reload
  85. parent2.reload
  86. assert_equal [parent1.id, lft1, lft1 + 1], [parent1.root_id, parent1.lft, parent1.rgt]
  87. assert_equal [parent2.id, lft2, lft2 + 1], [parent2.root_id, parent2.lft, parent2.rgt]
  88. assert_equal [child.id, 1, 2], [child.root_id, child.lft, child.rgt]
  89. end
  90. def test_move_a_child_to_another_issue
  91. lft1 = new_issue_lft
  92. parent1 = Issue.generate!
  93. lft2 = new_issue_lft
  94. parent2 = Issue.generate!
  95. child = Issue.generate!(:parent_issue_id => parent1.id)
  96. child.parent_issue_id = parent2.id
  97. child.save!
  98. child.reload
  99. parent1.reload
  100. parent2.reload
  101. assert_equal [parent1.id, lft1, lft1 + 1], [parent1.root_id, parent1.lft, parent1.rgt]
  102. assert_equal [parent2.id, lft2, lft2 + 3], [parent2.root_id, parent2.lft, parent2.rgt]
  103. assert_equal [parent2.id, lft2 + 1, lft2 + 2], [child.root_id, child.lft, child.rgt]
  104. end
  105. def test_move_a_child_with_descendants_to_another_issue
  106. lft1 = new_issue_lft
  107. parent1 = Issue.generate!
  108. lft2 = new_issue_lft
  109. parent2 = Issue.generate!
  110. child = Issue.generate!(:parent_issue_id => parent1.id)
  111. grandchild = Issue.generate!(:parent_issue_id => child.id)
  112. parent1.reload
  113. parent2.reload
  114. child.reload
  115. grandchild.reload
  116. assert_equal [parent1.id, lft1, lft1 + 5], [parent1.root_id, parent1.lft, parent1.rgt]
  117. assert_equal [parent2.id, lft2, lft2 + 1], [parent2.root_id, parent2.lft, parent2.rgt]
  118. assert_equal [parent1.id, lft1 + 1, lft1 + 4], [child.root_id, child.lft, child.rgt]
  119. assert_equal [parent1.id, lft1 + 2, lft1 + 3], [grandchild.root_id, grandchild.lft, grandchild.rgt]
  120. child.reload.parent_issue_id = parent2.id
  121. child.save!
  122. child.reload
  123. grandchild.reload
  124. parent1.reload
  125. parent2.reload
  126. assert_equal [parent1.id, lft1, lft1 + 1], [parent1.root_id, parent1.lft, parent1.rgt]
  127. assert_equal [parent2.id, lft2, lft2 + 5], [parent2.root_id, parent2.lft, parent2.rgt]
  128. assert_equal [parent2.id, lft2 + 1, lft2 + 4], [child.root_id, child.lft, child.rgt]
  129. assert_equal [parent2.id, lft2 + 2, lft2 + 3], [grandchild.root_id, grandchild.lft, grandchild.rgt]
  130. end
  131. def test_move_a_child_with_descendants_to_another_project
  132. lft1 = new_issue_lft
  133. parent1 = Issue.generate!
  134. child = Issue.generate!(:parent_issue_id => parent1.id)
  135. grandchild = Issue.generate!(:parent_issue_id => child.id)
  136. child.reload
  137. child.project = Project.find(2)
  138. assert child.save
  139. child.reload
  140. grandchild.reload
  141. parent1.reload
  142. assert_equal [1, parent1.id, lft1, lft1 + 1], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
  143. assert_equal [2, child.id, 1, 4], [child.project_id, child.root_id, child.lft, child.rgt]
  144. assert_equal [2, child.id, 2, 3], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
  145. end
  146. def test_moving_an_issue_to_a_descendant_should_not_validate
  147. parent1 = Issue.generate!
  148. parent2 = Issue.generate!
  149. child = Issue.generate!(:parent_issue_id => parent1.id)
  150. grandchild = Issue.generate!(:parent_issue_id => child.id)
  151. child.reload
  152. child.parent_issue_id = grandchild.id
  153. assert !child.save
  154. assert_not_equal [], child.errors[:parent_issue_id]
  155. end
  156. def test_updating_a_root_issue_should_not_trigger_update_nested_set_attributes_on_parent_change
  157. issue = Issue.find(Issue.generate!.id)
  158. issue.parent_issue_id = ""
  159. issue.expects(:update_nested_set_attributes_on_parent_change).never
  160. issue.save!
  161. end
  162. def test_updating_a_child_issue_should_not_trigger_update_nested_set_attributes_on_parent_change
  163. issue = Issue.find(Issue.generate!(:parent_issue_id => 1).id)
  164. issue.parent_issue_id = "1"
  165. issue.expects(:update_nested_set_attributes_on_parent_change).never
  166. issue.save!
  167. end
  168. def test_moving_a_root_issue_should_trigger_update_nested_set_attributes_on_parent_change
  169. issue = Issue.find(Issue.generate!.id)
  170. issue.parent_issue_id = "1"
  171. issue.expects(:update_nested_set_attributes_on_parent_change).once
  172. issue.save!
  173. end
  174. def test_moving_a_child_issue_to_another_parent_should_trigger_update_nested_set_attributes_on_parent_change
  175. issue = Issue.find(Issue.generate!(:parent_issue_id => 1).id)
  176. issue.parent_issue_id = "2"
  177. issue.expects(:update_nested_set_attributes_on_parent_change).once
  178. issue.save!
  179. end
  180. def test_moving_a_child_issue_to_root_should_trigger_update_nested_set_attributes_on_parent_change
  181. issue = Issue.find(Issue.generate!(:parent_issue_id => 1).id)
  182. issue.parent_issue_id = ""
  183. issue.expects(:update_nested_set_attributes_on_parent_change).once
  184. issue.save!
  185. end
  186. def test_destroy_should_destroy_children
  187. lft1 = new_issue_lft
  188. issue1 = Issue.generate!
  189. issue2 = Issue.generate!
  190. issue3 = Issue.generate!(:parent_issue_id => issue2.id)
  191. issue4 = Issue.generate!(:parent_issue_id => issue1.id)
  192. issue3.init_journal(User.find(2))
  193. issue3.subject = 'child with journal'
  194. issue3.save!
  195. assert_difference 'Issue.count', -2 do
  196. assert_difference 'Journal.count', -1 do
  197. assert_difference 'JournalDetail.count', -1 do
  198. Issue.find(issue2.id).destroy
  199. end
  200. end
  201. end
  202. issue1.reload
  203. issue4.reload
  204. assert !Issue.exists?(issue2.id)
  205. assert !Issue.exists?(issue3.id)
  206. assert_equal [issue1.id, lft1, lft1 + 3], [issue1.root_id, issue1.lft, issue1.rgt]
  207. assert_equal [issue1.id, lft1 + 1, lft1 + 2], [issue4.root_id, issue4.lft, issue4.rgt]
  208. end
  209. def test_destroy_child_should_update_parent
  210. lft1 = new_issue_lft
  211. issue = Issue.generate!
  212. child1 = Issue.generate!(:parent_issue_id => issue.id)
  213. child2 = Issue.generate!(:parent_issue_id => issue.id)
  214. issue.reload
  215. assert_equal [issue.id, lft1, lft1 + 5], [issue.root_id, issue.lft, issue.rgt]
  216. child2.reload.destroy
  217. issue.reload
  218. assert_equal [issue.id, lft1, lft1 + 3], [issue.root_id, issue.lft, issue.rgt]
  219. end
  220. def test_destroy_parent_issue_updated_during_children_destroy
  221. parent = Issue.generate!
  222. Issue.generate!(:start_date => Date.today, :parent_issue_id => parent.id)
  223. Issue.generate!(:start_date => 2.days.from_now, :parent_issue_id => parent.id)
  224. assert_difference 'Issue.count', -3 do
  225. Issue.find(parent.id).destroy
  226. end
  227. end
  228. def test_destroy_child_issue_with_children
  229. root = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'root')
  230. child = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => root.id)
  231. leaf = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'leaf', :parent_issue_id => child.id)
  232. leaf.init_journal(User.find(2))
  233. leaf.subject = 'leaf with journal'
  234. leaf.save!
  235. assert_difference 'Issue.count', -2 do
  236. assert_difference 'Journal.count', -1 do
  237. assert_difference 'JournalDetail.count', -1 do
  238. Issue.find(child.id).destroy
  239. end
  240. end
  241. end
  242. root = Issue.find(root.id)
  243. assert root.leaf?, "Root issue is not a leaf (lft: #{root.lft}, rgt: #{root.rgt})"
  244. end
  245. def test_destroy_issue_with_grand_child
  246. lft1 = new_issue_lft
  247. parent = Issue.generate!
  248. issue = Issue.generate!(:parent_issue_id => parent.id)
  249. child = Issue.generate!(:parent_issue_id => issue.id)
  250. grandchild1 = Issue.generate!(:parent_issue_id => child.id)
  251. grandchild2 = Issue.generate!(:parent_issue_id => child.id)
  252. assert_difference 'Issue.count', -4 do
  253. Issue.find(issue.id).destroy
  254. parent.reload
  255. assert_equal [lft1, lft1 + 1], [parent.lft, parent.rgt]
  256. end
  257. end
  258. def test_parent_priority_should_be_the_highest_child_priority
  259. parent = Issue.generate!(:priority => IssuePriority.find_by_name('Normal'))
  260. # Create children
  261. child1 = Issue.generate!(:priority => IssuePriority.find_by_name('High'), :parent_issue_id => parent.id)
  262. assert_equal 'High', parent.reload.priority.name
  263. child2 = Issue.generate!(:priority => IssuePriority.find_by_name('Immediate'), :parent_issue_id => child1.id)
  264. assert_equal 'Immediate', child1.reload.priority.name
  265. assert_equal 'Immediate', parent.reload.priority.name
  266. child3 = Issue.generate!(:priority => IssuePriority.find_by_name('Low'), :parent_issue_id => parent.id)
  267. assert_equal 'Immediate', parent.reload.priority.name
  268. # Destroy a child
  269. child1.destroy
  270. assert_equal 'Low', parent.reload.priority.name
  271. # Update a child
  272. child3.reload.priority = IssuePriority.find_by_name('Normal')
  273. child3.save!
  274. assert_equal 'Normal', parent.reload.priority.name
  275. end
  276. def test_parent_dates_should_be_lowest_start_and_highest_due_dates
  277. parent = Issue.generate!
  278. Issue.generate!(:start_date => '2010-01-25', :due_date => '2010-02-15', :parent_issue_id => parent.id)
  279. Issue.generate!( :due_date => '2010-02-13', :parent_issue_id => parent.id)
  280. Issue.generate!(:start_date => '2010-02-01', :due_date => '2010-02-22', :parent_issue_id => parent.id)
  281. parent.reload
  282. assert_equal Date.parse('2010-01-25'), parent.start_date
  283. assert_equal Date.parse('2010-02-22'), parent.due_date
  284. end
  285. def test_parent_done_ratio_should_be_average_done_ratio_of_leaves
  286. parent = Issue.generate!
  287. Issue.generate!(:done_ratio => 20, :parent_issue_id => parent.id)
  288. assert_equal 20, parent.reload.done_ratio
  289. Issue.generate!(:done_ratio => 70, :parent_issue_id => parent.id)
  290. assert_equal 45, parent.reload.done_ratio
  291. child = Issue.generate!(:done_ratio => 0, :parent_issue_id => parent.id)
  292. assert_equal 30, parent.reload.done_ratio
  293. Issue.generate!(:done_ratio => 30, :parent_issue_id => child.id)
  294. assert_equal 30, child.reload.done_ratio
  295. assert_equal 40, parent.reload.done_ratio
  296. end
  297. def test_parent_done_ratio_should_be_weighted_by_estimated_times_if_any
  298. parent = Issue.generate!
  299. Issue.generate!(:estimated_hours => 10, :done_ratio => 20, :parent_issue_id => parent.id)
  300. assert_equal 20, parent.reload.done_ratio
  301. Issue.generate!(:estimated_hours => 20, :done_ratio => 50, :parent_issue_id => parent.id)
  302. assert_equal (50 * 20 + 20 * 10) / 30, parent.reload.done_ratio
  303. end
  304. def test_parent_done_ratio_with_child_estimate_to_0_should_reach_100
  305. parent = Issue.generate!
  306. issue1 = Issue.generate!(:parent_issue_id => parent.id)
  307. issue2 = Issue.generate!(:parent_issue_id => parent.id, :estimated_hours => 0)
  308. assert_equal 0, parent.reload.done_ratio
  309. issue1.reload.update_attribute :status_id, 5
  310. assert_equal 50, parent.reload.done_ratio
  311. issue2.reload.update_attribute :status_id, 5
  312. assert_equal 100, parent.reload.done_ratio
  313. end
  314. def test_parent_estimate_should_be_sum_of_leaves
  315. parent = Issue.generate!
  316. Issue.generate!(:estimated_hours => nil, :parent_issue_id => parent.id)
  317. assert_equal nil, parent.reload.estimated_hours
  318. Issue.generate!(:estimated_hours => 5, :parent_issue_id => parent.id)
  319. assert_equal 5, parent.reload.estimated_hours
  320. Issue.generate!(:estimated_hours => 7, :parent_issue_id => parent.id)
  321. assert_equal 12, parent.reload.estimated_hours
  322. end
  323. def test_move_parent_updates_old_parent_attributes
  324. first_parent = Issue.generate!
  325. second_parent = Issue.generate!
  326. child = Issue.generate!(:estimated_hours => 5, :parent_issue_id => first_parent.id)
  327. assert_equal 5, first_parent.reload.estimated_hours
  328. child.update_attributes(:estimated_hours => 7, :parent_issue_id => second_parent.id)
  329. assert_equal 7, second_parent.reload.estimated_hours
  330. assert_nil first_parent.reload.estimated_hours
  331. end
  332. def test_reschuling_a_parent_should_reschedule_subtasks
  333. parent = Issue.generate!
  334. c1 = Issue.generate!(:start_date => '2010-05-12', :due_date => '2010-05-18', :parent_issue_id => parent.id)
  335. c2 = Issue.generate!(:start_date => '2010-06-03', :due_date => '2010-06-10', :parent_issue_id => parent.id)
  336. parent.reload
  337. parent.reschedule_on!(Date.parse('2010-06-02'))
  338. c1.reload
  339. assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-08')], [c1.start_date, c1.due_date]
  340. c2.reload
  341. assert_equal [Date.parse('2010-06-03'), Date.parse('2010-06-10')], [c2.start_date, c2.due_date] # no change
  342. parent.reload
  343. assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-10')], [parent.start_date, parent.due_date]
  344. end
  345. def test_project_copy_should_copy_issue_tree
  346. p = Project.create!(:name => 'Tree copy', :identifier => 'tree-copy', :tracker_ids => [1, 2])
  347. i1 = Issue.generate!(:project => p, :subject => 'i1')
  348. i2 = Issue.generate!(:project => p, :subject => 'i2', :parent_issue_id => i1.id)
  349. i3 = Issue.generate!(:project => p, :subject => 'i3', :parent_issue_id => i1.id)
  350. i4 = Issue.generate!(:project => p, :subject => 'i4', :parent_issue_id => i2.id)
  351. i5 = Issue.generate!(:project => p, :subject => 'i5')
  352. c = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1, 2])
  353. c.copy(p, :only => 'issues')
  354. c.reload
  355. assert_equal 5, c.issues.count
  356. ic1, ic2, ic3, ic4, ic5 = c.issues.order('subject').all
  357. assert ic1.root?
  358. assert_equal ic1, ic2.parent
  359. assert_equal ic1, ic3.parent
  360. assert_equal ic2, ic4.parent
  361. assert ic5.root?
  362. end
  363. end