You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_test.rb 117KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206
  1. # Redmine - project management software
  2. # Copyright (C) 2006-2017 Jean-Philippe Lang
  3. #
  4. # This program is free software; you can redistribute it and/or
  5. # modify it under the terms of the GNU General Public License
  6. # as published by the Free Software Foundation; either version 2
  7. # of the License, or (at your option) any later version.
  8. #
  9. # This program is distributed in the hope that it will be useful,
  10. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  11. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  12. # GNU General Public License for more details.
  13. #
  14. # You should have received a copy of the GNU General Public License
  15. # along with this program; if not, write to the Free Software
  16. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  17. require File.expand_path('../../test_helper', __FILE__)
  18. class IssueTest < ActiveSupport::TestCase
  19. fixtures :projects, :users, :email_addresses, :user_preferences, :members, :member_roles, :roles,
  20. :groups_users,
  21. :trackers, :projects_trackers,
  22. :enabled_modules,
  23. :versions,
  24. :issue_statuses, :issue_categories, :issue_relations, :workflows,
  25. :enumerations,
  26. :issues, :journals, :journal_details,
  27. :watchers,
  28. :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
  29. :time_entries
  30. include Redmine::I18n
  31. def setup
  32. User.current = nil
  33. set_language_if_valid 'en'
  34. end
  35. def teardown
  36. User.current = nil
  37. end
  38. def test_initialize
  39. issue = Issue.new
  40. assert_nil issue.project_id
  41. assert_nil issue.tracker_id
  42. assert_nil issue.status_id
  43. assert_nil issue.author_id
  44. assert_nil issue.assigned_to_id
  45. assert_nil issue.category_id
  46. assert_equal IssuePriority.default, issue.priority
  47. end
  48. def test_create
  49. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
  50. :status_id => 1, :priority => IssuePriority.all.first,
  51. :subject => 'test_create',
  52. :description => 'IssueTest#test_create', :estimated_hours => '1:30')
  53. assert issue.save
  54. issue.reload
  55. assert_equal 1.5, issue.estimated_hours
  56. end
  57. def test_create_minimal
  58. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create')
  59. assert issue.save
  60. assert_equal issue.tracker.default_status, issue.status
  61. assert issue.description.nil?
  62. assert_nil issue.estimated_hours
  63. end
  64. def test_create_with_all_fields_disabled
  65. tracker = Tracker.find(1)
  66. tracker.core_fields = []
  67. tracker.save!
  68. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create_with_all_fields_disabled')
  69. assert_save issue
  70. end
  71. def test_start_date_format_should_be_validated
  72. set_language_if_valid 'en'
  73. ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
  74. issue = Issue.new(:start_date => invalid_date)
  75. assert !issue.valid?
  76. assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
  77. end
  78. end
  79. def test_due_date_format_should_be_validated
  80. set_language_if_valid 'en'
  81. ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
  82. issue = Issue.new(:due_date => invalid_date)
  83. assert !issue.valid?
  84. assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
  85. end
  86. end
  87. def test_due_date_lesser_than_start_date_should_not_validate
  88. set_language_if_valid 'en'
  89. issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
  90. assert !issue.valid?
  91. assert_include 'Due date must be greater than start date', issue.errors.full_messages
  92. end
  93. def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
  94. issue = Issue.generate(:start_date => '2013-06-04')
  95. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  96. assert !issue.valid?
  97. assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  98. end
  99. def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
  100. issue = Issue.generate!(:start_date => '2013-06-04')
  101. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  102. issue.start_date = '2013-06-07'
  103. assert !issue.valid?
  104. assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  105. end
  106. def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
  107. issue = Issue.generate!(:start_date => '2013-06-04')
  108. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  109. assert issue.valid?
  110. end
  111. def test_estimated_hours_should_be_validated
  112. set_language_if_valid 'en'
  113. ['-2', '123abc'].each do |invalid|
  114. issue = Issue.new(:estimated_hours => invalid)
  115. assert !issue.valid?
  116. assert_include 'Estimated time is invalid', issue.errors.full_messages
  117. end
  118. end
  119. def test_create_with_required_custom_field
  120. set_language_if_valid 'en'
  121. field = IssueCustomField.find_by_name('Database')
  122. field.update!(:is_required => true)
  123. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  124. :status_id => 1, :subject => 'test_create',
  125. :description => 'IssueTest#test_create_with_required_custom_field')
  126. assert issue.available_custom_fields.include?(field)
  127. # No value for the custom field
  128. assert !issue.save
  129. assert_equal ["Database cannot be blank"], issue.errors.full_messages
  130. # Blank value
  131. issue.custom_field_values = { field.id => '' }
  132. assert !issue.save
  133. assert_equal ["Database cannot be blank"], issue.errors.full_messages
  134. # Invalid value
  135. issue.custom_field_values = { field.id => 'SQLServer' }
  136. assert !issue.save
  137. assert_equal ["Database is not included in the list"], issue.errors.full_messages
  138. # Valid value
  139. issue.custom_field_values = { field.id => 'PostgreSQL' }
  140. assert issue.save
  141. issue.reload
  142. assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  143. end
  144. def test_create_with_group_assignment
  145. with_settings :issue_group_assignment => '1' do
  146. assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
  147. :subject => 'Group assignment',
  148. :assigned_to_id => 11).save
  149. issue = Issue.order('id DESC').first
  150. assert_kind_of Group, issue.assigned_to
  151. assert_equal Group.find(11), issue.assigned_to
  152. end
  153. end
  154. def test_create_with_parent_issue_id
  155. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  156. :author_id => 1, :subject => 'Group assignment',
  157. :parent_issue_id => 1)
  158. assert_save issue
  159. assert_equal 1, issue.parent_issue_id
  160. assert_equal Issue.find(1), issue.parent
  161. end
  162. def test_create_with_sharp_parent_issue_id
  163. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  164. :author_id => 1, :subject => 'Group assignment',
  165. :parent_issue_id => "#1")
  166. assert_save issue
  167. assert_equal 1, issue.parent_issue_id
  168. assert_equal Issue.find(1), issue.parent
  169. end
  170. def test_create_with_invalid_parent_issue_id
  171. set_language_if_valid 'en'
  172. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  173. :author_id => 1, :subject => 'Group assignment',
  174. :parent_issue_id => '01ABC')
  175. assert !issue.save
  176. assert_equal '01ABC', issue.parent_issue_id
  177. assert_include 'Parent task is invalid', issue.errors.full_messages
  178. end
  179. def test_create_with_invalid_sharp_parent_issue_id
  180. set_language_if_valid 'en'
  181. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  182. :author_id => 1, :subject => 'Group assignment',
  183. :parent_issue_id => '#01ABC')
  184. assert !issue.save
  185. assert_equal '#01ABC', issue.parent_issue_id
  186. assert_include 'Parent task is invalid', issue.errors.full_messages
  187. end
  188. def assert_visibility_match(user, issues)
  189. assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  190. end
  191. def test_visible_scope_for_anonymous
  192. # Anonymous user should see issues of public projects only
  193. issues = Issue.visible(User.anonymous).to_a
  194. assert issues.any?
  195. assert_nil issues.detect {|issue| !issue.project.is_public?}
  196. assert_nil issues.detect {|issue| issue.is_private?}
  197. assert_visibility_match User.anonymous, issues
  198. end
  199. def test_visible_scope_for_anonymous_without_view_issues_permissions
  200. # Anonymous user should not see issues without permission
  201. Role.anonymous.remove_permission!(:view_issues)
  202. issues = Issue.visible(User.anonymous).to_a
  203. assert issues.empty?
  204. assert_visibility_match User.anonymous, issues
  205. end
  206. def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
  207. Role.anonymous.remove_permission!(:view_issues)
  208. Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])
  209. issues = Issue.visible(User.anonymous).all
  210. assert issues.any?
  211. assert_equal [1], issues.map(&:project_id).uniq.sort
  212. assert_visibility_match User.anonymous, issues
  213. end
  214. def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
  215. Role.anonymous.update!(:issues_visibility => 'default')
  216. issue = Issue.generate!(:author => User.anonymous, :is_private => true)
  217. assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
  218. assert !issue.visible?(User.anonymous)
  219. end
  220. def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
  221. assert Role.anonymous.update!(:issues_visibility => 'own')
  222. issue = Issue.generate!(:author => User.anonymous, :is_private => true)
  223. assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
  224. assert !issue.visible?(User.anonymous)
  225. end
  226. def test_visible_scope_for_non_member
  227. user = User.find(9)
  228. assert user.projects.empty?
  229. # Non member user should see issues of public projects only
  230. issues = Issue.visible(user).to_a
  231. assert issues.any?
  232. assert_nil issues.detect {|issue| !issue.project.is_public?}
  233. assert_nil issues.detect {|issue| issue.is_private?}
  234. assert_visibility_match user, issues
  235. end
  236. def test_visible_scope_for_non_member_with_own_issues_visibility
  237. Role.non_member.update! :issues_visibility => 'own'
  238. Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
  239. user = User.find(9)
  240. issues = Issue.visible(user).to_a
  241. assert issues.any?
  242. assert_nil issues.detect {|issue| issue.author != user}
  243. assert_visibility_match user, issues
  244. end
  245. def test_visible_scope_for_non_member_without_view_issues_permissions
  246. # Non member user should not see issues without permission
  247. Role.non_member.remove_permission!(:view_issues)
  248. user = User.find(9)
  249. assert user.projects.empty?
  250. issues = Issue.visible(user).to_a
  251. assert issues.empty?
  252. assert_visibility_match user, issues
  253. end
  254. def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
  255. Role.non_member.remove_permission!(:view_issues)
  256. Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
  257. user = User.find(9)
  258. issues = Issue.visible(user).all
  259. assert issues.any?
  260. assert_equal [1], issues.map(&:project_id).uniq.sort
  261. assert_visibility_match user, issues
  262. end
  263. def test_visible_scope_for_member
  264. user = User.find(9)
  265. # User should see issues of projects for which user has view_issues permissions only
  266. Role.non_member.remove_permission!(:view_issues)
  267. Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
  268. issues = Issue.visible(user).to_a
  269. assert issues.any?
  270. assert_nil issues.detect {|issue| issue.project_id != 3}
  271. assert_nil issues.detect {|issue| issue.is_private?}
  272. assert_visibility_match user, issues
  273. end
  274. def test_visible_scope_for_member_without_view_issues_permission_and_non_member_role_having_the_permission
  275. Role.non_member.add_permission!(:view_issues)
  276. Role.find(1).remove_permission!(:view_issues)
  277. user = User.find(2)
  278. assert_equal 0, Issue.where(:project_id => 1).visible(user).count
  279. assert_equal false, Issue.where(:project_id => 1).first.visible?(user)
  280. end
  281. def test_visible_scope_with_custom_non_member_role_having_restricted_permission
  282. role = Role.generate!(:permissions => [:view_project])
  283. assert Role.non_member.has_permission?(:view_issues)
  284. user = User.generate!
  285. Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])
  286. issues = Issue.visible(user).to_a
  287. assert issues.any?
  288. assert_nil issues.detect {|issue| issue.project_id == 1}
  289. end
  290. def test_visible_scope_with_custom_non_member_role_having_extended_permission
  291. role = Role.generate!(:permissions => [:view_project, :view_issues])
  292. Role.non_member.remove_permission!(:view_issues)
  293. user = User.generate!
  294. Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])
  295. issues = Issue.visible(user).to_a
  296. assert issues.any?
  297. assert_not_nil issues.detect {|issue| issue.project_id == 1}
  298. end
  299. def test_visible_scope_for_member_with_groups_should_return_assigned_issues
  300. user = User.find(8)
  301. assert user.groups.any?
  302. group = user.groups.first
  303. Member.create!(:principal => group, :project_id => 1, :role_ids => [2])
  304. Role.non_member.remove_permission!(:view_issues)
  305. with_settings :issue_group_assignment => '1' do
  306. issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 3,
  307. :status_id => 1, :priority => IssuePriority.all.first,
  308. :subject => 'Assignment test',
  309. :assigned_to => group,
  310. :is_private => true)
  311. Role.find(2).update! :issues_visibility => 'default'
  312. issues = Issue.visible(User.find(8)).to_a
  313. assert issues.any?
  314. assert issues.include?(issue)
  315. Role.find(2).update! :issues_visibility => 'own'
  316. issues = Issue.visible(User.find(8)).to_a
  317. assert issues.any?
  318. assert_include issue, issues
  319. end
  320. end
  321. def test_visible_scope_for_member_with_limited_tracker_ids
  322. role = Role.find(1)
  323. role.set_permission_trackers :view_issues, [2]
  324. role.save!
  325. user = User.find(2)
  326. issues = Issue.where(:project_id => 1).visible(user).to_a
  327. assert issues.any?
  328. assert_equal [2], issues.map(&:tracker_id).uniq
  329. assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
  330. end
  331. def test_visible_scope_should_consider_tracker_ids_on_each_project
  332. user = User.generate!
  333. project1 = Project.generate!
  334. role1 = Role.generate!
  335. role1.add_permission! :view_issues
  336. role1.set_permission_trackers :view_issues, :all
  337. role1.save!
  338. User.add_to_project(user, project1, role1)
  339. project2 = Project.generate!
  340. role2 = Role.generate!
  341. role2.add_permission! :view_issues
  342. role2.set_permission_trackers :view_issues, [2]
  343. role2.save!
  344. User.add_to_project(user, project2, role2)
  345. visible_issues = [
  346. Issue.generate!(:project => project1, :tracker_id => 1),
  347. Issue.generate!(:project => project1, :tracker_id => 2),
  348. Issue.generate!(:project => project2, :tracker_id => 2)
  349. ]
  350. hidden_issue = Issue.generate!(:project => project2, :tracker_id => 1)
  351. issues = Issue.where(:project_id => [project1.id, project2.id]).visible(user)
  352. assert_equal visible_issues.map(&:id), issues.ids.sort
  353. assert visible_issues.all? {|issue| issue.visible?(user)}
  354. assert !hidden_issue.visible?(user)
  355. end
  356. def test_visible_scope_should_not_consider_roles_without_view_issues_permission
  357. user = User.generate!
  358. role1 = Role.generate!
  359. role1.remove_permission! :view_issues
  360. role1.set_permission_trackers :view_issues, :all
  361. role1.save!
  362. role2 = Role.generate!
  363. role2.add_permission! :view_issues
  364. role2.set_permission_trackers :view_issues, [2]
  365. role2.save!
  366. User.add_to_project(user, Project.find(1), [role1, role2])
  367. issues = Issue.where(:project_id => 1).visible(user).to_a
  368. assert issues.any?
  369. assert_equal [2], issues.map(&:tracker_id).uniq
  370. assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
  371. end
  372. def test_visible_scope_for_admin
  373. user = User.find(1)
  374. user.members.each(&:destroy)
  375. assert user.projects.empty?
  376. issues = Issue.visible(user).to_a
  377. assert issues.any?
  378. # Admin should see issues on private projects that admin does not belong to
  379. assert issues.detect {|issue| !issue.project.is_public?}
  380. # Admin should see private issues of other users
  381. assert issues.detect {|issue| issue.is_private? && issue.author != user}
  382. assert_visibility_match user, issues
  383. end
  384. def test_visible_scope_with_project
  385. project = Project.find(1)
  386. issues = Issue.visible(User.find(2), :project => project).to_a
  387. projects = issues.collect(&:project).uniq
  388. assert_equal 1, projects.size
  389. assert_equal project, projects.first
  390. end
  391. def test_visible_scope_with_project_and_subprojects
  392. project = Project.find(1)
  393. issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
  394. projects = issues.collect(&:project).uniq
  395. assert projects.size > 1
  396. assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  397. end
  398. def test_visible_and_nested_set_scopes
  399. user = User.generate!
  400. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  401. parent = Issue.generate!(:assigned_to => user)
  402. assert parent.visible?(user)
  403. child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
  404. child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
  405. parent.reload
  406. child1.reload
  407. child2.reload
  408. assert child1.visible?(user)
  409. assert child2.visible?(user)
  410. assert_equal 2, parent.descendants.count
  411. assert_equal 2, parent.descendants.visible(user).count
  412. # awesome_nested_set 2-1-stable branch has regression.
  413. # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
  414. # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
  415. assert_equal 2, parent.descendants.collect{|i| i}.size
  416. assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
  417. end
  418. def test_visible_scope_with_unsaved_user_should_not_raise_an_error
  419. user = User.new
  420. assert_nothing_raised do
  421. Issue.visible(user).to_a
  422. end
  423. end
  424. def test_open_scope
  425. issues = Issue.open.to_a
  426. assert_nil issues.detect(&:closed?)
  427. end
  428. def test_open_scope_with_arg
  429. issues = Issue.open(false).to_a
  430. assert_equal issues, issues.select(&:closed?)
  431. end
  432. def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
  433. version = Version.find(2)
  434. assert version.fixed_issues.any?
  435. assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
  436. end
  437. def test_fixed_version_scope_with_empty_array_should_return_no_result
  438. assert_equal 0, Issue.fixed_version([]).count
  439. end
  440. def test_assigned_to_scope_should_return_issues_assigned_to_the_user
  441. user = User.generate!
  442. issue = Issue.generate!
  443. Issue.where(:id => issue.id).update_all :assigned_to_id => user.id
  444. assert_equal [issue], Issue.assigned_to(user).to_a
  445. end
  446. def test_assigned_to_scope_should_return_issues_assigned_to_the_user_groups
  447. group = Group.generate!
  448. user = User.generate!
  449. group.users << user
  450. issue = Issue.generate!
  451. Issue.where(:id => issue.id).update_all :assigned_to_id => group.id
  452. assert_equal [issue], Issue.assigned_to(user).to_a
  453. end
  454. def test_issue_should_be_readonly_on_closed_project
  455. issue = Issue.find(1)
  456. user = User.find(1)
  457. assert_equal true, issue.visible?(user)
  458. assert_equal true, issue.editable?(user)
  459. assert_equal true, issue.deletable?(user)
  460. issue.project.close
  461. issue.reload
  462. assert_equal true, issue.visible?(user)
  463. assert_equal false, issue.editable?(user)
  464. assert_equal false, issue.deletable?(user)
  465. end
  466. def test_errors_full_messages_should_include_custom_fields_errors
  467. field = IssueCustomField.find_by_name('Database')
  468. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  469. :status_id => 1, :subject => 'test_create',
  470. :description => 'IssueTest#test_create_with_required_custom_field')
  471. assert issue.available_custom_fields.include?(field)
  472. # Invalid value
  473. issue.custom_field_values = { field.id => 'SQLServer' }
  474. assert !issue.valid?
  475. assert_equal 1, issue.errors.full_messages.size
  476. assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
  477. issue.errors.full_messages.first
  478. end
  479. def test_update_issue_with_required_custom_field
  480. field = IssueCustomField.find_by_name('Database')
  481. field.update!(:is_required => true)
  482. issue = Issue.find(1)
  483. assert_nil issue.custom_value_for(field)
  484. assert issue.available_custom_fields.include?(field)
  485. # No change to custom values, issue can be saved
  486. assert issue.save
  487. # Blank value
  488. issue.custom_field_values = { field.id => '' }
  489. assert !issue.save
  490. # Valid value
  491. issue.custom_field_values = { field.id => 'PostgreSQL' }
  492. assert issue.save
  493. issue.reload
  494. assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  495. end
  496. def test_should_not_update_attributes_if_custom_fields_validation_fails
  497. issue = Issue.find(1)
  498. field = IssueCustomField.find_by_name('Database')
  499. assert issue.available_custom_fields.include?(field)
  500. issue.custom_field_values = { field.id => 'Invalid' }
  501. issue.subject = 'Should be not be saved'
  502. assert !issue.save
  503. issue.reload
  504. assert_equal "Cannot print recipes", issue.subject
  505. end
  506. def test_should_not_recreate_custom_values_objects_on_update
  507. field = IssueCustomField.find_by_name('Database')
  508. issue = Issue.find(1)
  509. issue.custom_field_values = { field.id => 'PostgreSQL' }
  510. assert issue.save
  511. custom_value = issue.custom_value_for(field)
  512. issue.reload
  513. issue.custom_field_values = { field.id => 'MySQL' }
  514. assert issue.save
  515. issue.reload
  516. assert_equal custom_value.id, issue.custom_value_for(field).id
  517. end
  518. def test_setting_project_should_set_version_to_default_version
  519. version = Version.generate!(:project_id => 1)
  520. Project.find(1).update!(:default_version_id => version.id)
  521. issue = Issue.new(:project_id => 1)
  522. assert_equal version, issue.fixed_version
  523. end
  524. def test_default_assigned_to_based_on_category_should_be_set_on_create
  525. user = User.find(3)
  526. category = IssueCategory.create!(:project_id => 1, :name => 'With default assignee', :assigned_to_id => 3)
  527. issue = Issue.generate!(:project_id => 1, :category_id => category.id)
  528. assert_equal user, issue.assigned_to
  529. end
  530. def test_default_assigned_to_based_on_project_should_be_set_on_create
  531. user = User.find(3)
  532. Project.find(1).update!(:default_assigned_to_id => user.id)
  533. issue = Issue.generate!(:project_id => 1)
  534. assert_equal user, issue.assigned_to
  535. end
  536. def test_default_assigned_to_with_required_assignee_should_validate
  537. category = IssueCategory.create!(:project_id => 1, :name => 'With default assignee', :assigned_to_id => 3)
  538. Issue.any_instance.stubs(:required_attribute_names).returns(['assigned_to_id'])
  539. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'Default')
  540. assert !issue.save
  541. assert issue.errors['assigned_to_id'].present?
  542. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'Default', :category_id => category.id)
  543. assert_save issue
  544. end
  545. def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
  546. issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
  547. :status_id => 1, :subject => 'Test',
  548. :custom_field_values => {'2' => 'Test'})
  549. assert !Tracker.find(2).custom_field_ids.include?(2)
  550. issue = Issue.find(issue.id)
  551. issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
  552. issue = Issue.find(issue.id)
  553. custom_value = issue.custom_value_for(2)
  554. assert_not_nil custom_value
  555. assert_equal 'Test', custom_value.value
  556. end
  557. def test_assigning_tracker_id_should_reload_custom_fields_values
  558. issue = Issue.new(:project => Project.find(1))
  559. assert issue.custom_field_values.empty?
  560. issue.tracker_id = 1
  561. assert issue.custom_field_values.any?
  562. end
  563. def test_assigning_attributes_should_assign_project_and_tracker_first
  564. seq = sequence('seq')
  565. issue = Issue.new
  566. issue.expects(:project_id=).in_sequence(seq)
  567. issue.expects(:tracker_id=).in_sequence(seq)
  568. issue.expects(:subject=).in_sequence(seq)
  569. issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
  570. end
  571. def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
  572. attributes = ActiveSupport::OrderedHash.new
  573. attributes['custom_field_values'] = { '1' => 'MySQL' }
  574. attributes['tracker_id'] = '1'
  575. issue = Issue.new(:project => Project.find(1))
  576. issue.attributes = attributes
  577. assert_equal 'MySQL', issue.custom_field_value(1)
  578. end
  579. def test_changing_tracker_should_clear_disabled_core_fields
  580. tracker = Tracker.find(2)
  581. tracker.core_fields = tracker.core_fields - %w(due_date)
  582. tracker.save!
  583. issue = Issue.generate!(:tracker_id => 1, :start_date => Date.today, :due_date => Date.today)
  584. issue.save!
  585. issue.tracker_id = 2
  586. issue.save!
  587. assert_not_nil issue.start_date
  588. assert_nil issue.due_date
  589. end
  590. def test_attribute_cleared_on_tracker_change_should_be_journalized
  591. CustomField.delete_all
  592. tracker = Tracker.find(2)
  593. tracker.core_fields = tracker.core_fields - %w(due_date)
  594. tracker.save!
  595. issue = Issue.generate!(:tracker_id => 1, :due_date => Date.today)
  596. issue.save!
  597. assert_difference 'Journal.count' do
  598. issue.init_journal User.find(1)
  599. issue.tracker_id = 2
  600. issue.save!
  601. assert_nil issue.due_date
  602. end
  603. journal = Journal.order('id DESC').first
  604. details = journal.details.select {|d| d.prop_key == 'due_date'}
  605. assert_equal 1, details.count
  606. end
  607. def test_reload_should_reload_custom_field_values
  608. issue = Issue.generate!
  609. issue.custom_field_values = {'2' => 'Foo'}
  610. issue.save!
  611. issue = Issue.order('id desc').first
  612. assert_equal 'Foo', issue.custom_field_value(2)
  613. issue.custom_field_values = {'2' => 'Bar'}
  614. assert_equal 'Bar', issue.custom_field_value(2)
  615. issue.reload
  616. assert_equal 'Foo', issue.custom_field_value(2)
  617. end
  618. def test_should_update_issue_with_disabled_tracker
  619. p = Project.find(1)
  620. issue = Issue.find(1)
  621. p.trackers.delete(issue.tracker)
  622. assert !p.trackers.include?(issue.tracker)
  623. issue.reload
  624. issue.subject = 'New subject'
  625. assert issue.save
  626. end
  627. def test_should_not_set_a_disabled_tracker
  628. p = Project.find(1)
  629. p.trackers.delete(Tracker.find(2))
  630. issue = Issue.find(1)
  631. issue.tracker_id = 2
  632. issue.subject = 'New subject'
  633. assert !issue.save
  634. assert_not_equal [], issue.errors[:tracker_id]
  635. end
  636. def test_category_based_assignment
  637. issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
  638. :status_id => 1, :priority => IssuePriority.all.first,
  639. :subject => 'Assignment test',
  640. :description => 'Assignment test', :category_id => 1)
  641. assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  642. end
  643. def test_new_statuses_allowed_to
  644. WorkflowTransition.delete_all
  645. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  646. :old_status_id => 1, :new_status_id => 2,
  647. :author => false, :assignee => false)
  648. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  649. :old_status_id => 1, :new_status_id => 3,
  650. :author => true, :assignee => false)
  651. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  652. :old_status_id => 1, :new_status_id => 4,
  653. :author => false, :assignee => true)
  654. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  655. :old_status_id => 1, :new_status_id => 5,
  656. :author => true, :assignee => true)
  657. status = IssueStatus.find(1)
  658. role = Role.find(1)
  659. tracker = Tracker.find(1)
  660. user = User.find(2)
  661. issue = Issue.generate!(:tracker => tracker, :status => status,
  662. :project_id => 1, :author_id => 1)
  663. assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
  664. issue = Issue.generate!(:tracker => tracker, :status => status,
  665. :project_id => 1, :author => user)
  666. assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
  667. issue = Issue.generate!(:tracker => tracker, :status => status,
  668. :project_id => 1, :author_id => 1,
  669. :assigned_to => user)
  670. assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  671. issue = Issue.generate!(:tracker => tracker, :status => status,
  672. :project_id => 1, :author => user,
  673. :assigned_to => user)
  674. assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  675. end
  676. def test_new_statuses_allowed_to_should_consider_group_assignment
  677. WorkflowTransition.delete_all
  678. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  679. :old_status_id => 1, :new_status_id => 4,
  680. :author => false, :assignee => true)
  681. group = Group.generate!
  682. Member.create!(:project_id => 1, :principal => group, :role_ids => [1])
  683. user = User.find(2)
  684. group.users << user
  685. with_settings :issue_group_assignment => '1' do
  686. issue = Issue.generate!(:author_id => 1, :assigned_to => group)
  687. assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
  688. end
  689. end
  690. def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
  691. admin = User.find(1)
  692. issue = Issue.find(1)
  693. assert !admin.member_of?(issue.project)
  694. expected_statuses = [issue.status] +
  695. WorkflowTransition.where(:old_status_id => issue.status_id).
  696. map(&:new_status).uniq.sort
  697. assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
  698. end
  699. def test_new_statuses_allowed_to_should_return_allowed_statuses_when_copying
  700. Tracker.find(1).generate_transitions! :role_id => 1, :clear => true, 0 => [1, 3]
  701. orig = Issue.generate!(:project_id => 1, :tracker_id => 1, :status_id => 4)
  702. issue = orig.copy
  703. assert_equal [1, 3], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
  704. assert_equal 1, issue.status_id
  705. end
  706. def test_safe_attributes_names_should_be_updated_when_changing_project
  707. issue = Issue.new
  708. with_current_user(User.find(2)) do
  709. assert_not_include 'watcher_user_ids', issue.safe_attribute_names
  710. issue.project_id = 1
  711. assert_include 'watcher_user_ids', issue.safe_attribute_names
  712. end
  713. end
  714. def test_safe_attributes_names_should_not_include_disabled_field
  715. tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
  716. issue = Issue.new(:tracker => tracker)
  717. assert_include 'tracker_id', issue.safe_attribute_names
  718. assert_include 'status_id', issue.safe_attribute_names
  719. assert_include 'subject', issue.safe_attribute_names
  720. assert_include 'custom_field_values', issue.safe_attribute_names
  721. assert_include 'custom_fields', issue.safe_attribute_names
  722. assert_include 'lock_version', issue.safe_attribute_names
  723. tracker.core_fields.each do |field|
  724. assert_include field, issue.safe_attribute_names
  725. end
  726. tracker.disabled_core_fields.each do |field|
  727. assert_not_include field, issue.safe_attribute_names
  728. end
  729. end
  730. def test_safe_attributes_should_ignore_disabled_fields
  731. tracker = Tracker.find(1)
  732. tracker.core_fields = %w(assigned_to_id due_date)
  733. tracker.save!
  734. issue = Issue.new(:tracker => tracker)
  735. issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
  736. assert_nil issue.start_date
  737. assert_equal Date.parse('2012-07-14'), issue.due_date
  738. end
  739. def test_safe_attributes_should_accept_target_tracker_enabled_fields
  740. source = Tracker.find(1)
  741. source.core_fields = []
  742. source.save!
  743. target = Tracker.find(2)
  744. target.core_fields = %w(assigned_to_id due_date)
  745. target.save!
  746. user = User.find(2)
  747. issue = Issue.new(:project => Project.find(1), :tracker => source)
  748. issue.send :safe_attributes=, {'tracker_id' => 2, 'due_date' => '2012-07-14'}, user
  749. assert_equal target, issue.tracker
  750. assert_equal Date.parse('2012-07-14'), issue.due_date
  751. end
  752. def test_safe_attributes_should_not_include_readonly_fields
  753. WorkflowPermission.delete_all
  754. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  755. :role_id => 1, :field_name => 'due_date',
  756. :rule => 'readonly')
  757. user = User.find(2)
  758. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  759. assert_equal %w(due_date), issue.read_only_attribute_names(user)
  760. assert_not_include 'due_date', issue.safe_attribute_names(user)
  761. issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
  762. assert_equal Date.parse('2012-07-14'), issue.start_date
  763. assert_nil issue.due_date
  764. end
  765. def test_safe_attributes_should_not_include_readonly_custom_fields
  766. cf1 = IssueCustomField.create!(:name => 'Writable field',
  767. :field_format => 'string',
  768. :is_for_all => true, :tracker_ids => [1])
  769. cf2 = IssueCustomField.create!(:name => 'Readonly field',
  770. :field_format => 'string',
  771. :is_for_all => true, :tracker_ids => [1])
  772. WorkflowPermission.delete_all
  773. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  774. :role_id => 1, :field_name => cf2.id.to_s,
  775. :rule => 'readonly')
  776. user = User.find(2)
  777. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  778. assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
  779. assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
  780. issue.send :safe_attributes=, {'custom_field_values' => {
  781. cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
  782. }}, user
  783. assert_equal 'value1', issue.custom_field_value(cf1)
  784. assert_nil issue.custom_field_value(cf2)
  785. issue.send :safe_attributes=, {'custom_fields' => [
  786. {'id' => cf1.id.to_s, 'value' => 'valuea'},
  787. {'id' => cf2.id.to_s, 'value' => 'valueb'}
  788. ]}, user
  789. assert_equal 'valuea', issue.custom_field_value(cf1)
  790. assert_nil issue.custom_field_value(cf2)
  791. end
  792. def test_editable_custom_field_values_should_return_non_readonly_custom_values
  793. cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
  794. :is_for_all => true, :tracker_ids => [1, 2])
  795. cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
  796. :is_for_all => true, :tracker_ids => [1, 2])
  797. WorkflowPermission.delete_all
  798. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
  799. :field_name => cf2.id.to_s, :rule => 'readonly')
  800. user = User.find(2)
  801. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  802. values = issue.editable_custom_field_values(user)
  803. assert values.detect {|value| value.custom_field == cf1}
  804. assert_nil values.detect {|value| value.custom_field == cf2}
  805. issue.tracker_id = 2
  806. values = issue.editable_custom_field_values(user)
  807. assert values.detect {|value| value.custom_field == cf1}
  808. assert values.detect {|value| value.custom_field == cf2}
  809. end
  810. def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
  811. enabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [1,2])
  812. disabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [2])
  813. user = User.find(2)
  814. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  815. assert_include enabled_cf, issue.editable_custom_fields(user)
  816. assert_not_include disabled_cf, issue.editable_custom_fields(user)
  817. end
  818. def test_safe_attributes_should_accept_target_tracker_writable_fields
  819. WorkflowPermission.delete_all
  820. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  821. :role_id => 1, :field_name => 'due_date',
  822. :rule => 'readonly')
  823. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  824. :role_id => 1, :field_name => 'start_date',
  825. :rule => 'readonly')
  826. user = User.find(2)
  827. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  828. issue.send :safe_attributes=, {'start_date' => '2012-07-12',
  829. 'due_date' => '2012-07-14'}, user
  830. assert_equal Date.parse('2012-07-12'), issue.start_date
  831. assert_nil issue.due_date
  832. issue.send :safe_attributes=, {'start_date' => '2012-07-15',
  833. 'due_date' => '2012-07-16',
  834. 'tracker_id' => 2}, user
  835. assert_equal Date.parse('2012-07-12'), issue.start_date
  836. assert_equal Date.parse('2012-07-16'), issue.due_date
  837. end
  838. def test_safe_attributes_should_accept_target_status_writable_fields
  839. WorkflowPermission.delete_all
  840. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  841. :role_id => 1, :field_name => 'due_date',
  842. :rule => 'readonly')
  843. WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
  844. :role_id => 1, :field_name => 'start_date',
  845. :rule => 'readonly')
  846. user = User.find(2)
  847. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  848. issue.send :safe_attributes=, {'start_date' => '2012-07-12',
  849. 'due_date' => '2012-07-14'},
  850. user
  851. assert_equal Date.parse('2012-07-12'), issue.start_date
  852. assert_nil issue.due_date
  853. issue.send :safe_attributes=, {'start_date' => '2012-07-15',
  854. 'due_date' => '2012-07-16',
  855. 'status_id' => 2},
  856. user
  857. assert_equal Date.parse('2012-07-12'), issue.start_date
  858. assert_equal Date.parse('2012-07-16'), issue.due_date
  859. end
  860. def test_required_attributes_should_be_validated
  861. cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
  862. :is_for_all => true, :tracker_ids => [1, 2])
  863. WorkflowPermission.delete_all
  864. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  865. :role_id => 1, :field_name => 'due_date',
  866. :rule => 'required')
  867. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  868. :role_id => 1, :field_name => 'category_id',
  869. :rule => 'required')
  870. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  871. :role_id => 1, :field_name => cf.id.to_s,
  872. :rule => 'required')
  873. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  874. :role_id => 1, :field_name => 'start_date',
  875. :rule => 'required')
  876. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  877. :role_id => 1, :field_name => cf.id.to_s,
  878. :rule => 'required')
  879. user = User.find(2)
  880. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  881. :status_id => 1, :subject => 'Required fields',
  882. :author => user)
  883. assert_equal [cf.id.to_s, "category_id", "due_date"],
  884. issue.required_attribute_names(user).sort
  885. assert !issue.save, "Issue was saved"
  886. assert_equal ["Category cannot be blank", "Due date cannot be blank", "Foo cannot be blank"],
  887. issue.errors.full_messages.sort
  888. issue.tracker_id = 2
  889. assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
  890. assert !issue.save, "Issue was saved"
  891. assert_equal ["Foo cannot be blank", "Start date cannot be blank"],
  892. issue.errors.full_messages.sort
  893. issue.start_date = Date.today
  894. issue.custom_field_values = {cf.id.to_s => 'bar'}
  895. assert issue.save
  896. end
  897. def test_required_attribute_that_is_disabled_for_the_tracker_should_not_be_required
  898. WorkflowPermission.delete_all
  899. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  900. :role_id => 1, :field_name => 'start_date',
  901. :rule => 'required')
  902. user = User.find(2)
  903. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  904. :subject => 'Required fields', :author => user)
  905. assert !issue.save
  906. assert_include "Start date cannot be blank", issue.errors.full_messages
  907. tracker = Tracker.find(1)
  908. tracker.core_fields -= %w(start_date)
  909. tracker.save!
  910. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  911. :subject => 'Required fields', :author => user)
  912. assert issue.save
  913. end
  914. def test_category_should_not_be_required_if_project_has_no_categories
  915. Project.find(1).issue_categories.delete_all
  916. WorkflowPermission.delete_all
  917. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  918. :role_id => 1, :field_name => 'category_id',:rule => 'required')
  919. user = User.find(2)
  920. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  921. :subject => 'Required fields', :author => user)
  922. assert_save issue
  923. end
  924. def test_fixed_version_should_not_be_required_no_assignable_versions
  925. Version.delete_all
  926. WorkflowPermission.delete_all
  927. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  928. :role_id => 1, :field_name => 'fixed_version_id',:rule => 'required')
  929. user = User.find(2)
  930. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  931. :subject => 'Required fields', :author => user)
  932. assert_save issue
  933. end
  934. def test_required_custom_field_that_is_not_visible_for_the_user_should_not_be_required
  935. CustomField.destroy_all
  936. field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
  937. user = User.generate!
  938. User.add_to_project(user, Project.find(1), Role.find(2))
  939. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  940. :subject => 'Required fields', :author => user)
  941. assert_save issue
  942. end
  943. def test_required_custom_field_that_is_visible_for_the_user_should_be_required
  944. CustomField.destroy_all
  945. field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
  946. user = User.generate!
  947. User.add_to_project(user, Project.find(1), Role.find(1))
  948. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  949. :subject => 'Required fields', :author => user)
  950. assert !issue.save
  951. assert_include "#{field.name} cannot be blank", issue.errors.full_messages
  952. end
  953. def test_required_attribute_names_for_multiple_roles_should_intersect_rules
  954. WorkflowPermission.delete_all
  955. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  956. :role_id => 1, :field_name => 'due_date',
  957. :rule => 'required')
  958. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  959. :role_id => 1, :field_name => 'start_date',
  960. :rule => 'required')
  961. user = User.find(2)
  962. member = Member.find(1)
  963. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  964. assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
  965. member.role_ids = [1, 2]
  966. member.save!
  967. assert_equal [], issue.required_attribute_names(user.reload)
  968. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  969. :role_id => 2, :field_name => 'due_date',
  970. :rule => 'required')
  971. assert_equal %w(due_date), issue.required_attribute_names(user)
  972. member.role_ids = [1, 2, 3]
  973. member.save!
  974. assert_equal [], issue.required_attribute_names(user.reload)
  975. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  976. :role_id => 3, :field_name => 'due_date',
  977. :rule => 'readonly')
  978. # required + readonly => required
  979. assert_equal %w(due_date), issue.required_attribute_names(user)
  980. end
  981. def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
  982. WorkflowPermission.delete_all
  983. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  984. :role_id => 1, :field_name => 'due_date',
  985. :rule => 'readonly')
  986. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  987. :role_id => 1, :field_name => 'start_date',
  988. :rule => 'readonly')
  989. user = User.find(2)
  990. member = Member.find(1)
  991. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  992. assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
  993. member.role_ids = [1, 2]
  994. member.save!
  995. assert_equal [], issue.read_only_attribute_names(user.reload)
  996. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  997. :role_id => 2, :field_name => 'due_date',
  998. :rule => 'readonly')
  999. assert_equal %w(due_date), issue.read_only_attribute_names(user)
  1000. end
  1001. # A field that is not visible by role 2 and readonly by role 1 should be readonly for user with role 1 and 2
  1002. def test_read_only_attribute_names_should_include_custom_fields_that_combine_readonly_and_not_visible_for_roles
  1003. field = IssueCustomField.generate!(
  1004. :is_for_all => true, :trackers => Tracker.all, :visible => false, :role_ids => [1]
  1005. )
  1006. WorkflowPermission.delete_all
  1007. WorkflowPermission.create!(
  1008. :old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => field.id, :rule => 'readonly'
  1009. )
  1010. user = User.generate!
  1011. project = Project.find(1)
  1012. User.add_to_project(user, project, Role.where(:id => [1, 2]))
  1013. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1014. assert_equal [field.id.to_s], issue.read_only_attribute_names(user)
  1015. end
  1016. def test_workflow_rules_should_ignore_roles_without_issue_permissions
  1017. role = Role.generate! :permissions => [:view_issues, :edit_issues]
  1018. ignored_role = Role.generate! :permissions => [:view_issues]
  1019. WorkflowPermission.delete_all
  1020. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1021. :role => role, :field_name => 'due_date',
  1022. :rule => 'required')
  1023. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1024. :role => role, :field_name => 'start_date',
  1025. :rule => 'readonly')
  1026. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1027. :role => role, :field_name => 'done_ratio',
  1028. :rule => 'readonly')
  1029. user = User.generate!
  1030. User.add_to_project user, Project.find(1), [role, ignored_role]
  1031. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1032. assert_equal %w(due_date), issue.required_attribute_names(user)
  1033. assert_equal %w(done_ratio start_date), issue.read_only_attribute_names(user).sort
  1034. end
  1035. def test_workflow_rules_should_work_for_member_with_duplicate_role
  1036. WorkflowPermission.delete_all
  1037. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1038. :role_id => 1, :field_name => 'due_date',
  1039. :rule => 'required')
  1040. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1041. :role_id => 1, :field_name => 'start_date',
  1042. :rule => 'readonly')
  1043. user = User.generate!
  1044. m = Member.new(:user_id => user.id, :project_id => 1)
  1045. m.member_roles.build(:role_id => 1)
  1046. m.member_roles.build(:role_id => 1)
  1047. m.save!
  1048. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1049. assert_equal %w(due_date), issue.required_attribute_names(user)
  1050. assert_equal %w(start_date), issue.read_only_attribute_names(user)
  1051. end
  1052. def test_copy
  1053. issue = Issue.new.copy_from(1)
  1054. assert issue.copy?
  1055. assert issue.save
  1056. issue.reload
  1057. orig = Issue.find(1)
  1058. assert_equal orig.subject, issue.subject
  1059. assert_equal orig.tracker, issue.tracker
  1060. assert_equal "125", issue.custom_value_for(2).value
  1061. end
  1062. def test_copy_to_another_project_should_clear_assignee_if_not_valid
  1063. issue = Issue.generate!(:project_id => 1, :assigned_to_id => 2)
  1064. project = Project.generate!
  1065. issue = Issue.new.copy_from(1)
  1066. issue.project = project
  1067. assert_nil issue.assigned_to
  1068. end
  1069. def test_copy_with_keep_status_should_copy_status
  1070. orig = Issue.find(8)
  1071. assert orig.status != orig.default_status
  1072. issue = Issue.new.copy_from(orig, :keep_status => true)
  1073. assert issue.save
  1074. issue.reload
  1075. assert_equal orig.status, issue.status
  1076. end
  1077. def test_copy_should_add_relation_with_copied_issue
  1078. copied = Issue.find(1)
  1079. issue = Issue.new.copy_from(copied)
  1080. assert issue.save
  1081. issue.reload
  1082. assert_equal 1, issue.relations.size
  1083. relation = issue.relations.first
  1084. assert_equal 'copied_to', relation.relation_type
  1085. assert_equal copied, relation.issue_from
  1086. assert_equal issue, relation.issue_to
  1087. end
  1088. def test_copy_should_copy_subtasks
  1089. issue = Issue.generate_with_descendants!
  1090. copy = issue.reload.copy
  1091. copy.author = User.find(7)
  1092. assert_difference 'Issue.count', 1+issue.descendants.count do
  1093. assert copy.save
  1094. end
  1095. copy.reload
  1096. assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
  1097. child_copy = copy.children.detect {|c| c.subject == 'Child1'}
  1098. assert_equal %w(Child11), child_copy.children.map(&:subject).sort
  1099. assert_equal copy.author, child_copy.author
  1100. end
  1101. def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
  1102. parent = Issue.generate!
  1103. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
  1104. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
  1105. copy = parent.reload.copy
  1106. copy.parent_issue_id = parent.id
  1107. copy.author = User.find(7)
  1108. assert_difference 'Issue.count', 3 do
  1109. assert copy.save
  1110. end
  1111. parent.reload
  1112. copy.reload
  1113. assert_equal parent, copy.parent
  1114. assert_equal 3, parent.children.count
  1115. assert_equal 5, parent.descendants.count
  1116. assert_equal 2, copy.children.count
  1117. assert_equal 2, copy.descendants.count
  1118. end
  1119. def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
  1120. parent = Issue.generate!
  1121. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
  1122. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
  1123. copy = parent.reload.copy
  1124. copy.parent_issue_id = child1.id
  1125. copy.author = User.find(7)
  1126. assert_difference 'Issue.count', 3 do
  1127. assert copy.save
  1128. end
  1129. parent.reload
  1130. child1.reload
  1131. copy.reload
  1132. assert_equal child1, copy.parent
  1133. assert_equal 2, parent.children.count
  1134. assert_equal 5, parent.descendants.count
  1135. assert_equal 1, child1.children.count
  1136. assert_equal 3, child1.descendants.count
  1137. assert_equal 2, copy.children.count
  1138. assert_equal 2, copy.descendants.count
  1139. end
  1140. def test_copy_should_copy_subtasks_to_target_project
  1141. issue = Issue.generate_with_descendants!
  1142. copy = issue.copy(:project_id => 3)
  1143. assert_difference 'Issue.count', 1+issue.descendants.count do
  1144. assert copy.save
  1145. end
  1146. assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
  1147. end
  1148. def test_copy_should_not_copy_subtasks_twice_when_saving_twice
  1149. issue = Issue.generate_with_descendants!
  1150. copy = issue.reload.copy
  1151. assert_difference 'Issue.count', 1+issue.descendants.count do
  1152. assert copy.save
  1153. assert copy.save
  1154. end
  1155. end
  1156. def test_copy_should_clear_closed_on
  1157. copied_open = Issue.find(8).copy(:status_id => 1)
  1158. assert copied_open.save
  1159. assert_nil copied_open.closed_on
  1160. copied_closed = Issue.find(8).copy({}, :keep_status => 1)
  1161. assert copied_closed.save
  1162. assert_not_nil copied_closed.closed_on
  1163. end
  1164. def test_copy_should_not_copy_locked_watchers
  1165. user = User.find(2)
  1166. user2 = User.find(3)
  1167. issue = Issue.find(8)
  1168. Watcher.create!(:user => user, :watchable => issue)
  1169. Watcher.create!(:user => user2, :watchable => issue)
  1170. user2.status = User::STATUS_LOCKED
  1171. user2.save!
  1172. issue = Issue.new.copy_from(8)
  1173. assert issue.save
  1174. assert issue.watched_by?(user)
  1175. assert !issue.watched_by?(user2)
  1176. end
  1177. def test_copy_should_clear_subtasks_target_version_if_locked_or_closed
  1178. version = Version.new(:project => Project.find(1), :name => '2.1',)
  1179. version.save!
  1180. parent = Issue.generate!
  1181. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1', :fixed_version_id => 3)
  1182. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2', :fixed_version_id => version.id)
  1183. version.status = 'locked'
  1184. version.save!
  1185. copy = parent.reload.copy
  1186. assert_difference 'Issue.count', 3 do
  1187. assert copy.save
  1188. end
  1189. assert_equal [3, nil], copy.children.map(&:fixed_version_id)
  1190. end
  1191. def test_copy_should_clear_subtasks_assignee_if_is_locked
  1192. user = User.find(2)
  1193. parent = Issue.generate!
  1194. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1', :assigned_to_id => 3)
  1195. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2', :assigned_to_id => user.id)
  1196. user.status = User::STATUS_LOCKED
  1197. user.save!
  1198. copy = parent.reload.copy
  1199. assert_difference 'Issue.count', 3 do
  1200. assert copy.save
  1201. end
  1202. assert_equal [3, nil], copy.children.map(&:assigned_to_id)
  1203. end
  1204. def test_should_not_call_after_project_change_on_creation
  1205. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  1206. :subject => 'Test', :author_id => 1)
  1207. issue.expects(:after_project_change).never
  1208. issue.save!
  1209. end
  1210. def test_should_not_call_after_project_change_on_update
  1211. issue = Issue.find(1)
  1212. issue.project = Project.find(1)
  1213. issue.subject = 'No project change'
  1214. issue.expects(:after_project_change).never
  1215. issue.save!
  1216. end
  1217. def test_should_call_after_project_change_on_project_change
  1218. issue = Issue.find(1)
  1219. issue.project = Project.find(2)
  1220. issue.expects(:after_project_change).once
  1221. issue.save!
  1222. end
  1223. def test_adding_journal_should_update_timestamp
  1224. issue = Issue.find(1)
  1225. updated_on_was = issue.updated_on
  1226. issue.init_journal(User.first, "Adding notes")
  1227. assert_difference 'Journal.count' do
  1228. assert issue.save
  1229. end
  1230. issue.reload
  1231. assert_not_equal updated_on_was, issue.updated_on
  1232. end
  1233. def test_should_close_duplicates
  1234. # Create 3 issues
  1235. issue1 = Issue.generate!
  1236. issue2 = Issue.generate!
  1237. issue3 = Issue.generate!
  1238. # 2 is a dupe of 1
  1239. IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
  1240. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1241. # And 3 is a dupe of 2
  1242. # IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
  1243. # :relation_type => IssueRelation::TYPE_DUPLICATES)
  1244. # And 3 is a dupe of 1 (circular duplicates)
  1245. IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
  1246. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1247. assert issue1.reload.duplicates.include?(issue2)
  1248. # Closing issue 1
  1249. issue1.init_journal(User.first, "Closing issue1")
  1250. issue1.status = IssueStatus.where(:is_closed => true).first
  1251. assert issue1.save
  1252. # 2 and 3 should be also closed
  1253. assert issue2.reload.closed?
  1254. assert issue3.reload.closed?
  1255. end
  1256. def test_should_not_close_duplicate_when_disabled
  1257. issue = Issue.generate!
  1258. duplicate = Issue.generate!
  1259. IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
  1260. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1261. assert issue.reload.duplicates.include?(duplicate)
  1262. with_settings :close_duplicate_issues => '0' do
  1263. issue.init_journal(User.first, "Closing issue")
  1264. issue.status = IssueStatus.where(:is_closed => true).first
  1265. issue.save
  1266. end
  1267. assert !duplicate.reload.closed?
  1268. end
  1269. def test_should_close_duplicates_with_private_notes
  1270. issue = Issue.generate!
  1271. duplicate = Issue.generate!
  1272. IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
  1273. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1274. assert issue.reload.duplicates.include?(duplicate)
  1275. # Closing issue with private notes
  1276. issue.init_journal(User.first, "Private notes")
  1277. issue.private_notes = true
  1278. issue.status = IssueStatus.where(:is_closed => true).first
  1279. assert_save issue
  1280. duplicate.reload
  1281. assert journal = duplicate.journals.detect {|journal| journal.notes == "Private notes"}
  1282. assert_equal true, journal.private_notes
  1283. end
  1284. def test_should_not_close_duplicated_issue
  1285. issue1 = Issue.generate!
  1286. issue2 = Issue.generate!
  1287. # 2 is a dupe of 1
  1288. IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
  1289. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1290. # 2 is a dup of 1 but 1 is not a duplicate of 2
  1291. assert !issue2.reload.duplicates.include?(issue1)
  1292. # Closing issue 2
  1293. issue2.init_journal(User.first, "Closing issue2")
  1294. issue2.status = IssueStatus.where(:is_closed => true).first
  1295. assert issue2.save
  1296. # 1 should not be also closed
  1297. assert !issue1.reload.closed?
  1298. end
  1299. def test_assignable_versions
  1300. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1301. :status_id => 1, :fixed_version_id => 1,
  1302. :subject => 'New issue')
  1303. assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
  1304. end
  1305. def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
  1306. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1307. :status_id => 1, :fixed_version_id => 1,
  1308. :subject => 'New issue')
  1309. assert !issue.save
  1310. assert_not_equal [], issue.errors[:fixed_version_id]
  1311. end
  1312. def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
  1313. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1314. :status_id => 1, :fixed_version_id => 2,
  1315. :subject => 'New issue')
  1316. assert !issue.save
  1317. assert_not_equal [], issue.errors[:fixed_version_id]
  1318. end
  1319. def test_should_be_able_to_assign_a_new_issue_to_an_open_version
  1320. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1321. :status_id => 1, :fixed_version_id => 3,
  1322. :subject => 'New issue')
  1323. assert issue.save
  1324. end
  1325. def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
  1326. issue = Issue.find(11)
  1327. assert_equal 'closed', issue.fixed_version.status
  1328. issue.subject = 'Subject changed'
  1329. assert issue.save
  1330. end
  1331. def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
  1332. issue = Issue.find(11)
  1333. issue.status_id = 1
  1334. assert !issue.save
  1335. assert_not_equal [], issue.errors[:base]
  1336. end
  1337. def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
  1338. issue = Issue.find(11)
  1339. issue.status_id = 1
  1340. issue.fixed_version_id = 3
  1341. assert issue.save
  1342. end
  1343. def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
  1344. issue = Issue.find(12)
  1345. assert_equal 'locked', issue.fixed_version.status
  1346. issue.status_id = 1
  1347. assert issue.save
  1348. end
  1349. def test_should_not_be_able_to_keep_unshared_version_when_changing_project
  1350. issue = Issue.find(2)
  1351. assert_equal 2, issue.fixed_version_id
  1352. issue.project_id = 3
  1353. assert_nil issue.fixed_version_id
  1354. issue.fixed_version_id = 2
  1355. assert !issue.save
  1356. assert_include 'Target version is not included in the list', issue.errors.full_messages
  1357. end
  1358. def test_should_keep_shared_version_when_changing_project
  1359. Version.find(2).update! :sharing => 'tree'
  1360. issue = Issue.find(2)
  1361. assert_equal 2, issue.fixed_version_id
  1362. issue.project_id = 3
  1363. assert_equal 2, issue.fixed_version_id
  1364. assert issue.save
  1365. end
  1366. def test_allowed_target_projects_should_include_projects_with_issue_tracking_enabled
  1367. assert_include Project.find(2), Issue.allowed_target_projects(User.find(2))
  1368. end
  1369. def test_allowed_target_projects_should_not_include_projects_with_issue_tracking_disabled
  1370. Project.find(2).disable_module! :issue_tracking
  1371. assert_not_include Project.find(2), Issue.allowed_target_projects(User.find(2))
  1372. end
  1373. def test_allowed_target_projects_should_not_include_projects_without_trackers
  1374. project = Project.generate!(:tracker_ids => [])
  1375. assert project.trackers.empty?
  1376. assert_not_include project, Issue.allowed_target_projects(User.find(1))
  1377. end
  1378. def test_allowed_target_trackers_with_one_role_allowed_on_all_trackers
  1379. user = User.generate!
  1380. role = Role.generate!
  1381. role.add_permission! :add_issues
  1382. role.set_permission_trackers :add_issues, :all
  1383. role.save!
  1384. User.add_to_project(user, Project.find(1), role)
  1385. assert_equal [1, 2, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1386. end
  1387. def test_allowed_target_trackers_with_one_role_allowed_on_some_trackers
  1388. user = User.generate!
  1389. role = Role.generate!
  1390. role.add_permission! :add_issues
  1391. role.set_permission_trackers :add_issues, [1, 3]
  1392. role.save!
  1393. User.add_to_project(user, Project.find(1), role)
  1394. assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1395. end
  1396. def test_allowed_target_trackers_with_two_roles_allowed_on_some_trackers
  1397. user = User.generate!
  1398. role1 = Role.generate!
  1399. role1.add_permission! :add_issues
  1400. role1.set_permission_trackers :add_issues, [1]
  1401. role1.save!
  1402. role2 = Role.generate!
  1403. role2.add_permission! :add_issues
  1404. role2.set_permission_trackers :add_issues, [3]
  1405. role2.save!
  1406. User.add_to_project(user, Project.find(1), [role1, role2])
  1407. assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1408. end
  1409. def test_allowed_target_trackers_with_two_roles_allowed_on_all_trackers_and_some_trackers
  1410. user = User.generate!
  1411. role1 = Role.generate!
  1412. role1.add_permission! :add_issues
  1413. role1.set_permission_trackers :add_issues, :all
  1414. role1.save!
  1415. role2 = Role.generate!
  1416. role2.add_permission! :add_issues
  1417. role2.set_permission_trackers :add_issues, [1, 3]
  1418. role2.save!
  1419. User.add_to_project(user, Project.find(1), [role1, role2])
  1420. assert_equal [1, 2, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1421. end
  1422. def test_allowed_target_trackers_should_not_consider_roles_without_add_issues_permission
  1423. user = User.generate!
  1424. role1 = Role.generate!
  1425. role1.remove_permission! :add_issues
  1426. role1.set_permission_trackers :add_issues, :all
  1427. role1.save!
  1428. role2 = Role.generate!
  1429. role2.add_permission! :add_issues
  1430. role2.set_permission_trackers :add_issues, [1, 3]
  1431. role2.save!
  1432. User.add_to_project(user, Project.find(1), [role1, role2])
  1433. assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1434. end
  1435. def test_allowed_target_trackers_without_project_should_be_empty
  1436. issue = Issue.new
  1437. assert_nil issue.project
  1438. assert_equal [], issue.allowed_target_trackers(User.find(2)).ids
  1439. end
  1440. def test_allowed_target_trackers_should_include_current_tracker
  1441. user = User.generate!
  1442. role = Role.generate!
  1443. role.add_permission! :add_issues
  1444. role.set_permission_trackers :add_issues, [3]
  1445. role.save!
  1446. User.add_to_project(user, Project.find(1), role)
  1447. issue = Issue.generate!(:project => Project.find(1), :tracker => Tracker.find(1))
  1448. assert_equal [1, 3], issue.allowed_target_trackers(user).ids.sort
  1449. end
  1450. def test_move_to_another_project_with_same_category
  1451. issue = Issue.find(1)
  1452. issue.project = Project.find(2)
  1453. assert issue.save
  1454. issue.reload
  1455. assert_equal 2, issue.project_id
  1456. # Category changes
  1457. assert_equal 4, issue.category_id
  1458. # Make sure time entries were move to the target project
  1459. assert_equal 2, issue.time_entries.first.project_id
  1460. end
  1461. def test_move_to_another_project_without_same_category
  1462. issue = Issue.find(2)
  1463. issue.project = Project.find(2)
  1464. assert issue.save
  1465. issue.reload
  1466. assert_equal 2, issue.project_id
  1467. # Category cleared
  1468. assert_nil issue.category_id
  1469. end
  1470. def test_move_to_another_project_should_clear_fixed_version_when_not_shared
  1471. issue = Issue.find(1)
  1472. issue.update!(:fixed_version_id => 3)
  1473. issue.project = Project.find(2)
  1474. assert issue.save
  1475. issue.reload
  1476. assert_equal 2, issue.project_id
  1477. # Cleared fixed_version
  1478. assert_nil issue.fixed_version
  1479. end
  1480. def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
  1481. issue = Issue.find(1)
  1482. issue.update!(:fixed_version_id => 4)
  1483. issue.project = Project.find(5)
  1484. assert issue.save
  1485. issue.reload
  1486. assert_equal 5, issue.project_id
  1487. # Keep fixed_version
  1488. assert_equal 4, issue.fixed_version_id
  1489. end
  1490. def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
  1491. issue = Issue.find(1)
  1492. issue.update!(:fixed_version_id => 3)
  1493. issue.project = Project.find(5)
  1494. assert issue.save
  1495. issue.reload
  1496. assert_equal 5, issue.project_id
  1497. # Cleared fixed_version
  1498. assert_nil issue.fixed_version
  1499. end
  1500. def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
  1501. issue = Issue.find(1)
  1502. issue.update!(:fixed_version_id => 7)
  1503. issue.project = Project.find(2)
  1504. assert issue.save
  1505. issue.reload
  1506. assert_equal 2, issue.project_id
  1507. # Keep fixed_version
  1508. assert_equal 7, issue.fixed_version_id
  1509. end
  1510. def test_move_to_another_project_should_keep_parent_if_valid
  1511. issue = Issue.find(1)
  1512. issue.update! :parent_issue_id => 2
  1513. issue.project = Project.find(3)
  1514. assert issue.save
  1515. issue.reload
  1516. assert_equal 2, issue.parent_id
  1517. end
  1518. def test_move_to_another_project_should_clear_parent_if_not_valid
  1519. issue = Issue.find(1)
  1520. issue.update! :parent_issue_id => 2
  1521. issue.project = Project.find(2)
  1522. assert issue.save
  1523. issue.reload
  1524. assert_nil issue.parent_id
  1525. end
  1526. def test_move_to_another_project_with_disabled_tracker
  1527. issue = Issue.find(1)
  1528. target = Project.find(2)
  1529. target.tracker_ids = [3]
  1530. target.save
  1531. issue.project = target
  1532. assert issue.save
  1533. issue.reload
  1534. assert_equal 2, issue.project_id
  1535. assert_equal 3, issue.tracker_id
  1536. end
  1537. def test_move_to_another_project_should_set_error_message_on_child_failure
  1538. parent = Issue.generate!
  1539. child = Issue.generate!(:parent_issue_id => parent.id, :tracker_id => 2)
  1540. project = Project.generate!(:tracker_ids => [1])
  1541. parent.reload
  1542. parent.project_id = project.id
  1543. assert !parent.save
  1544. assert_include "Subtask ##{child.id} could not be moved to the new project: Tracker is not included in the list",
  1545. parent.errors[:base]
  1546. end
  1547. def test_copy_to_the_same_project
  1548. issue = Issue.find(1)
  1549. copy = issue.copy
  1550. assert_difference 'Issue.count' do
  1551. copy.save!
  1552. end
  1553. assert_kind_of Issue, copy
  1554. assert_equal issue.project, copy.project
  1555. assert_equal "125", copy.custom_value_for(2).value
  1556. end
  1557. def test_copy_to_another_project_and_tracker
  1558. issue = Issue.find(1)
  1559. copy = issue.copy(:project_id => 3, :tracker_id => 2)
  1560. assert_difference 'Issue.count' do
  1561. copy.save!
  1562. end
  1563. copy.reload
  1564. assert_kind_of Issue, copy
  1565. assert_equal Project.find(3), copy.project
  1566. assert_equal Tracker.find(2), copy.tracker
  1567. # Custom field #2 is not associated with target tracker
  1568. assert_nil copy.custom_value_for(2)
  1569. end
  1570. test "#copy should not create a journal" do
  1571. copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2}, :link => false)
  1572. copy.save!
  1573. assert_equal 0, copy.reload.journals.size
  1574. end
  1575. test "#copy should allow assigned_to changes" do
  1576. user = User.generate!
  1577. Member.create!(:project_id => 3, :principal => user, :role_ids => [1])
  1578. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => user.id)
  1579. assert_equal user.id, copy.assigned_to_id
  1580. end
  1581. test "#copy should allow status changes" do
  1582. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
  1583. assert_equal 2, copy.status_id
  1584. end
  1585. test "#copy should allow start date changes" do
  1586. date = Date.today
  1587. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
  1588. assert_equal date, copy.start_date
  1589. end
  1590. test "#copy should allow due date changes" do
  1591. date = Date.today
  1592. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
  1593. assert_equal date, copy.due_date
  1594. end
  1595. test "#copy should set current user as author" do
  1596. User.current = User.find(9)
  1597. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
  1598. assert_equal User.current, copy.author
  1599. end
  1600. test "#copy should create a journal with notes" do
  1601. date = Date.today
  1602. notes = "Notes added when copying"
  1603. copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :start_date => date}, :link => false)
  1604. copy.init_journal(User.current, notes)
  1605. copy.save!
  1606. assert_equal 1, copy.journals.size
  1607. journal = copy.journals.first
  1608. assert_equal 0, journal.details.size
  1609. assert_equal notes, journal.notes
  1610. end
  1611. def test_valid_parent_project
  1612. issue = Issue.find(1)
  1613. issue_in_same_project = Issue.find(2)
  1614. issue_in_child_project = Issue.find(5)
  1615. issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
  1616. issue_in_other_child_project = Issue.find(6)
  1617. issue_in_different_tree = Issue.find(4)
  1618. with_settings :cross_project_subtasks => '' do
  1619. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1620. assert_equal false, issue.valid_parent_project?(issue_in_child_project)
  1621. assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
  1622. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1623. end
  1624. with_settings :cross_project_subtasks => 'system' do
  1625. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1626. assert_equal true, issue.valid_parent_project?(issue_in_child_project)
  1627. assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
  1628. end
  1629. with_settings :cross_project_subtasks => 'tree' do
  1630. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1631. assert_equal true, issue.valid_parent_project?(issue_in_child_project)
  1632. assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
  1633. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1634. assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
  1635. assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
  1636. end
  1637. with_settings :cross_project_subtasks => 'descendants' do
  1638. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1639. assert_equal false, issue.valid_parent_project?(issue_in_child_project)
  1640. assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
  1641. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1642. assert_equal true, issue_in_child_project.valid_parent_project?(issue)
  1643. assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
  1644. end
  1645. end
  1646. def test_recipients_should_include_previous_assignee
  1647. user = User.find(3)
  1648. user.members.update_all ["mail_notification = ?", false]
  1649. user.update! :mail_notification => 'only_assigned'
  1650. issue = Issue.find(2)
  1651. issue.assigned_to = nil
  1652. assert_include user.mail, issue.recipients
  1653. issue.save!
  1654. assert_include user.mail, issue.recipients
  1655. issue.assigned_to = User.find(2)
  1656. issue.save!
  1657. assert !issue.recipients.include?(user.mail)
  1658. end
  1659. def test_recipients_should_not_include_users_that_cannot_view_the_issue
  1660. issue = Issue.find(12)
  1661. assert issue.recipients.include?(issue.author.mail)
  1662. # copy the issue to a private project
  1663. copy = issue.copy(:project_id => 5, :tracker_id => 2)
  1664. # author is not a member of project anymore
  1665. assert !copy.recipients.include?(copy.author.mail)
  1666. end
  1667. def test_recipients_should_include_the_assigned_group_members
  1668. group_member = User.generate!
  1669. group = Group.generate!
  1670. group.users << group_member
  1671. issue = Issue.find(12)
  1672. issue.assigned_to = group
  1673. assert issue.recipients.include?(group_member.mail)
  1674. end
  1675. def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
  1676. user = User.find(3)
  1677. issue = Issue.find(9)
  1678. Watcher.create!(:user => user, :watchable => issue)
  1679. assert issue.watched_by?(user)
  1680. assert !issue.watcher_recipients.include?(user.mail)
  1681. end
  1682. def test_issue_destroy
  1683. Issue.find(1).destroy
  1684. assert_nil Issue.find_by_id(1)
  1685. assert_nil TimeEntry.find_by_issue_id(1)
  1686. end
  1687. def test_destroy_should_delete_time_entries_custom_values
  1688. issue = Issue.generate!
  1689. time_entry = TimeEntry.generate!(:issue => issue, :custom_field_values => {10 => '1'})
  1690. assert_difference 'CustomValue.where(:customized_type => "TimeEntry").count', -1 do
  1691. assert issue.destroy
  1692. end
  1693. end
  1694. def test_destroying_a_deleted_issue_should_not_raise_an_error
  1695. issue = Issue.find(1)
  1696. Issue.find(1).destroy
  1697. assert_nothing_raised do
  1698. assert_no_difference 'Issue.count' do
  1699. issue.destroy
  1700. end
  1701. assert issue.destroyed?
  1702. end
  1703. end
  1704. def test_destroying_a_stale_issue_should_not_raise_an_error
  1705. issue = Issue.find(1)
  1706. Issue.find(1).update! :subject => "Updated"
  1707. assert_nothing_raised do
  1708. assert_difference 'Issue.count', -1 do
  1709. issue.destroy
  1710. end
  1711. assert issue.destroyed?
  1712. end
  1713. end
  1714. def test_blocked
  1715. blocked_issue = Issue.find(9)
  1716. blocking_issue = Issue.find(10)
  1717. assert blocked_issue.blocked?
  1718. assert !blocking_issue.blocked?
  1719. end
  1720. def test_blocked_issues_dont_allow_closed_statuses
  1721. blocked_issue = Issue.find(9)
  1722. allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
  1723. assert !allowed_statuses.empty?
  1724. closed_statuses = allowed_statuses.select {|st| st.is_closed?}
  1725. assert closed_statuses.empty?
  1726. end
  1727. def test_unblocked_issues_allow_closed_statuses
  1728. blocking_issue = Issue.find(10)
  1729. allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
  1730. assert !allowed_statuses.empty?
  1731. closed_statuses = allowed_statuses.select {|st| st.is_closed?}
  1732. assert !closed_statuses.empty?
  1733. end
  1734. def test_parent_issues_with_open_subtask_dont_allow_closed_statuses
  1735. parent = Issue.generate!
  1736. child = Issue.generate!(:parent_issue_id => parent.id)
  1737. allowed_statuses = parent.reload.new_statuses_allowed_to(users(:users_002))
  1738. assert allowed_statuses.any?
  1739. assert_equal [], allowed_statuses.select(&:is_closed?)
  1740. end
  1741. def test_parent_issues_with_closed_subtask_allow_closed_statuses
  1742. parent = Issue.generate!
  1743. child = Issue.generate!(:parent_issue_id => parent.id, :status_id => 5)
  1744. allowed_statuses = parent.reload.new_statuses_allowed_to(users(:users_002))
  1745. assert allowed_statuses.any?
  1746. assert allowed_statuses.select(&:is_closed?).any?
  1747. end
  1748. def test_reschedule_an_issue_without_dates
  1749. with_settings :non_working_week_days => [] do
  1750. issue = Issue.new(:start_date => nil, :due_date => nil)
  1751. issue.reschedule_on '2012-10-09'.to_date
  1752. assert_equal '2012-10-09'.to_date, issue.start_date
  1753. assert_equal '2012-10-09'.to_date, issue.due_date
  1754. end
  1755. with_settings :non_working_week_days => %w(6 7) do
  1756. issue = Issue.new(:start_date => nil, :due_date => nil)
  1757. issue.reschedule_on '2012-10-09'.to_date
  1758. assert_equal '2012-10-09'.to_date, issue.start_date
  1759. assert_equal '2012-10-09'.to_date, issue.due_date
  1760. issue = Issue.new(:start_date => nil, :due_date => nil)
  1761. issue.reschedule_on '2012-10-13'.to_date
  1762. assert_equal '2012-10-15'.to_date, issue.start_date
  1763. assert_equal '2012-10-15'.to_date, issue.due_date
  1764. end
  1765. end
  1766. def test_reschedule_an_issue_with_start_date
  1767. with_settings :non_working_week_days => [] do
  1768. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1769. issue.reschedule_on '2012-10-13'.to_date
  1770. assert_equal '2012-10-13'.to_date, issue.start_date
  1771. assert_equal '2012-10-13'.to_date, issue.due_date
  1772. end
  1773. with_settings :non_working_week_days => %w(6 7) do
  1774. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1775. issue.reschedule_on '2012-10-11'.to_date
  1776. assert_equal '2012-10-11'.to_date, issue.start_date
  1777. assert_equal '2012-10-11'.to_date, issue.due_date
  1778. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1779. issue.reschedule_on '2012-10-13'.to_date
  1780. assert_equal '2012-10-15'.to_date, issue.start_date
  1781. assert_equal '2012-10-15'.to_date, issue.due_date
  1782. end
  1783. end
  1784. def test_reschedule_an_issue_with_start_and_due_dates
  1785. with_settings :non_working_week_days => [] do
  1786. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
  1787. issue.reschedule_on '2012-10-13'.to_date
  1788. assert_equal '2012-10-13'.to_date, issue.start_date
  1789. assert_equal '2012-10-19'.to_date, issue.due_date
  1790. end
  1791. with_settings :non_working_week_days => %w(6 7) do
  1792. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
  1793. issue.reschedule_on '2012-10-11'.to_date
  1794. assert_equal '2012-10-11'.to_date, issue.start_date
  1795. assert_equal '2012-10-23'.to_date, issue.due_date
  1796. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
  1797. issue.reschedule_on '2012-10-13'.to_date
  1798. assert_equal '2012-10-15'.to_date, issue.start_date
  1799. assert_equal '2012-10-25'.to_date, issue.due_date
  1800. end
  1801. end
  1802. def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
  1803. with_settings :non_working_week_days => [] do
  1804. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1805. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1806. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1807. :relation_type => IssueRelation::TYPE_PRECEDES)
  1808. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1809. issue1.reload
  1810. issue1.due_date = '2012-10-23'
  1811. issue1.save!
  1812. issue2.reload
  1813. assert_equal Date.parse('2012-10-24'), issue2.start_date
  1814. assert_equal Date.parse('2012-10-26'), issue2.due_date
  1815. end
  1816. # The delay should honor non-working week days
  1817. with_settings :non_working_week_days => %w(6 7) do
  1818. issue1 = Issue.generate!(:start_date => '2014-03-10', :due_date => '2014-03-12')
  1819. issue2 = Issue.generate!(:start_date => '2014-03-10', :due_date => '2014-03-12')
  1820. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1821. :relation_type => IssueRelation::TYPE_PRECEDES,
  1822. :delay => 8)
  1823. assert_equal Date.parse('2014-03-25'), issue2.reload.start_date
  1824. end
  1825. end
  1826. def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
  1827. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1828. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1829. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1830. :relation_type => IssueRelation::TYPE_PRECEDES)
  1831. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1832. issue1.reload
  1833. issue1.start_date = '2012-09-17'
  1834. issue1.due_date = '2012-09-18'
  1835. issue1.save!
  1836. issue2.reload
  1837. assert_equal Date.parse('2012-09-19'), issue2.start_date
  1838. assert_equal Date.parse('2012-09-21'), issue2.due_date
  1839. end
  1840. def test_rescheduling_an_issue_to_a_different_due_date_should_add_journal_to_following_issue
  1841. with_settings :non_working_week_days => [] do
  1842. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1843. issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
  1844. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1845. :relation_type => IssueRelation::TYPE_PRECEDES)
  1846. assert_difference 'issue2.journals.count' do
  1847. issue1.reload
  1848. issue1.init_journal(User.find(3))
  1849. issue1.due_date = '2012-10-23'
  1850. issue1.save!
  1851. end
  1852. journal = issue2.journals.order(:id).last
  1853. start_date_detail = journal.details.find_by(:prop_key => 'start_date')
  1854. assert_equal '2012-10-18', start_date_detail.old_value
  1855. assert_equal '2012-10-24', start_date_detail.value
  1856. due_date_detail = journal.details.find_by(:prop_key => 'due_date')
  1857. assert_equal '2012-10-20', due_date_detail.old_value
  1858. assert_equal '2012-10-26', due_date_detail.value
  1859. end
  1860. end
  1861. def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
  1862. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1863. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1864. issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
  1865. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1866. :relation_type => IssueRelation::TYPE_PRECEDES)
  1867. IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
  1868. :relation_type => IssueRelation::TYPE_PRECEDES)
  1869. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1870. issue1.reload
  1871. issue1.start_date = '2012-09-17'
  1872. issue1.due_date = '2012-09-18'
  1873. issue1.save!
  1874. issue2.reload
  1875. # Issue 2 must start after Issue 3
  1876. assert_equal Date.parse('2012-10-03'), issue2.start_date
  1877. assert_equal Date.parse('2012-10-05'), issue2.due_date
  1878. end
  1879. def test_rescheduling_a_stale_issue_should_not_raise_an_error
  1880. with_settings :non_working_week_days => [] do
  1881. stale = Issue.find(1)
  1882. issue = Issue.find(1)
  1883. issue.subject = "Updated"
  1884. issue.save!
  1885. date = 10.days.from_now.to_date
  1886. assert_nothing_raised do
  1887. stale.reschedule_on!(date)
  1888. end
  1889. assert_equal date, stale.reload.start_date
  1890. end
  1891. end
  1892. def test_child_issue_should_consider_parent_soonest_start_on_create
  1893. set_language_if_valid 'en'
  1894. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1895. issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
  1896. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1897. :relation_type => IssueRelation::TYPE_PRECEDES)
  1898. issue1.reload
  1899. issue2.reload
  1900. assert_equal Date.parse('2012-10-18'), issue2.start_date
  1901. with_settings :date_format => '%m/%d/%Y' do
  1902. child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
  1903. :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
  1904. assert !child.valid?
  1905. assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
  1906. assert_equal Date.parse('2012-10-18'), child.soonest_start
  1907. child.start_date = '2012-10-18'
  1908. assert child.save
  1909. end
  1910. end
  1911. def test_setting_parent_to_a_an_issue_that_precedes_should_not_validate
  1912. # tests that 3 cannot have 1 as parent:
  1913. #
  1914. # 1 -> 2 -> 3
  1915. #
  1916. set_language_if_valid 'en'
  1917. issue1 = Issue.generate!
  1918. issue2 = Issue.generate!
  1919. issue3 = Issue.generate!
  1920. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  1921. IssueRelation.create!(:issue_from => issue2, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
  1922. issue3.reload
  1923. issue3.parent_issue_id = issue1.id
  1924. assert !issue3.valid?
  1925. assert_include 'Parent task is invalid', issue3.errors.full_messages
  1926. end
  1927. def test_setting_parent_to_a_an_issue_that_follows_should_not_validate
  1928. # tests that 1 cannot have 3 as parent:
  1929. #
  1930. # 1 -> 2 -> 3
  1931. #
  1932. set_language_if_valid 'en'
  1933. issue1 = Issue.generate!
  1934. issue2 = Issue.generate!
  1935. issue3 = Issue.generate!
  1936. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  1937. IssueRelation.create!(:issue_from => issue2, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
  1938. issue1.reload
  1939. issue1.parent_issue_id = issue3.id
  1940. assert !issue1.valid?
  1941. assert_include 'Parent task is invalid', issue1.errors.full_messages
  1942. end
  1943. def test_setting_parent_to_a_an_issue_that_precedes_through_hierarchy_should_not_validate
  1944. # tests that 4 cannot have 1 as parent:
  1945. # changing the due date of 4 would update the end date of 1 which would reschedule 2
  1946. # which would change the end date of 3 which would reschedule 4 and so on...
  1947. #
  1948. # 3 -> 4
  1949. # ^
  1950. # 1 -> 2
  1951. #
  1952. set_language_if_valid 'en'
  1953. issue1 = Issue.generate!
  1954. issue2 = Issue.generate!
  1955. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  1956. issue3 = Issue.generate!
  1957. issue2.reload
  1958. issue2.parent_issue_id = issue3.id
  1959. issue2.save!
  1960. issue4 = Issue.generate!
  1961. IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
  1962. issue4.reload
  1963. issue4.parent_issue_id = issue1.id
  1964. assert !issue4.valid?
  1965. assert_include 'Parent task is invalid', issue4.errors.full_messages
  1966. end
  1967. def test_issue_and_following_issue_should_be_able_to_be_moved_to_the_same_parent
  1968. set_language_if_valid 'en'
  1969. issue1 = Issue.generate!
  1970. issue2 = Issue.generate!
  1971. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_FOLLOWS)
  1972. parent = Issue.generate!
  1973. issue1.reload.parent_issue_id = parent.id
  1974. assert_save issue1
  1975. parent.reload
  1976. issue2.reload.parent_issue_id = parent.id
  1977. assert_save issue2
  1978. assert IssueRelation.exists?(relation.id)
  1979. end
  1980. def test_issue_and_preceding_issue_should_be_able_to_be_moved_to_the_same_parent
  1981. set_language_if_valid 'en'
  1982. issue1 = Issue.generate!
  1983. issue2 = Issue.generate!
  1984. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
  1985. parent = Issue.generate!
  1986. issue1.reload.parent_issue_id = parent.id
  1987. assert_save issue1
  1988. parent.reload
  1989. issue2.reload.parent_issue_id = parent.id
  1990. assert_save issue2
  1991. assert IssueRelation.exists?(relation.id)
  1992. end
  1993. def test_issue_and_blocked_issue_should_be_able_to_be_moved_to_the_same_parent
  1994. set_language_if_valid 'en'
  1995. issue1 = Issue.generate!
  1996. issue2 = Issue.generate!
  1997. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_BLOCKED)
  1998. parent = Issue.generate!
  1999. issue1.reload.parent_issue_id = parent.id
  2000. assert_save issue1
  2001. parent.reload
  2002. issue2.reload.parent_issue_id = parent.id
  2003. assert_save issue2
  2004. assert IssueRelation.exists?(relation.id)
  2005. end
  2006. def test_issue_and_blocking_issue_should_be_able_to_be_moved_to_the_same_parent
  2007. set_language_if_valid 'en'
  2008. issue1 = Issue.generate!
  2009. issue2 = Issue.generate!
  2010. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_BLOCKS)
  2011. parent = Issue.generate!
  2012. issue1.reload.parent_issue_id = parent.id
  2013. assert_save issue1
  2014. parent.reload
  2015. issue2.reload.parent_issue_id = parent.id
  2016. assert_save issue2
  2017. assert IssueRelation.exists?(relation.id)
  2018. end
  2019. def test_issue_copy_should_be_able_to_be_moved_to_the_same_parent_as_copied_issue
  2020. issue = Issue.generate!
  2021. parent = Issue.generate!
  2022. issue.parent_issue_id = parent.id
  2023. issue.save!
  2024. issue.reload
  2025. copy = Issue.new.copy_from(issue, :link => true)
  2026. relation = new_record(IssueRelation) do
  2027. copy.save!
  2028. end
  2029. copy.parent_issue_id = parent.id
  2030. assert_save copy
  2031. assert IssueRelation.exists?(relation.id)
  2032. end
  2033. def test_overdue
  2034. User.current = nil
  2035. today = User.current.today
  2036. assert Issue.new(:due_date => (today - 1.day).to_date).overdue?
  2037. assert !Issue.new(:due_date => today).overdue?
  2038. assert !Issue.new(:due_date => (today + 1.day).to_date).overdue?
  2039. assert !Issue.new(:due_date => nil).overdue?
  2040. assert !Issue.new(:due_date => (today - 1.day).to_date,
  2041. :status => IssueStatus.where(:is_closed => true).first
  2042. ).overdue?
  2043. end
  2044. test "#behind_schedule? should be false if the issue has no start_date" do
  2045. assert !Issue.new(:start_date => nil,
  2046. :due_date => 1.day.from_now.to_date,
  2047. :done_ratio => 0).behind_schedule?
  2048. end
  2049. test "#behind_schedule? should be false if the issue has no end_date" do
  2050. assert !Issue.new(:start_date => 1.day.from_now.to_date,
  2051. :due_date => nil,
  2052. :done_ratio => 0).behind_schedule?
  2053. end
  2054. test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
  2055. assert !Issue.new(:start_date => 50.days.ago.to_date,
  2056. :due_date => 50.days.from_now.to_date,
  2057. :done_ratio => 90).behind_schedule?
  2058. end
  2059. test "#behind_schedule? should be true if the issue hasn't been started at all" do
  2060. assert Issue.new(:start_date => 1.day.ago.to_date,
  2061. :due_date => 1.day.from_now.to_date,
  2062. :done_ratio => 0).behind_schedule?
  2063. end
  2064. test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
  2065. assert Issue.new(:start_date => 100.days.ago.to_date,
  2066. :due_date => Date.today,
  2067. :done_ratio => 90).behind_schedule?
  2068. end
  2069. test "#assignable_users should be Users" do
  2070. assert_kind_of User, Issue.find(1).assignable_users.first
  2071. end
  2072. test "#assignable_users should include the issue author" do
  2073. non_project_member = User.generate!
  2074. issue = Issue.generate!(:author => non_project_member)
  2075. assert issue.assignable_users.include?(non_project_member)
  2076. end
  2077. def test_assignable_users_should_not_include_anonymous_user
  2078. issue = Issue.generate!(:author => User.anonymous)
  2079. assert !issue.assignable_users.include?(User.anonymous)
  2080. end
  2081. def test_assignable_users_should_not_include_locked_user
  2082. user = User.generate!
  2083. issue = Issue.generate!(:author => user)
  2084. user.lock!
  2085. assert !issue.assignable_users.include?(user)
  2086. end
  2087. def test_assignable_users_should_include_the_current_assignee
  2088. user = User.generate!
  2089. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2090. issue = Issue.generate!(:assigned_to => user)
  2091. user.lock!
  2092. assert Issue.find(issue.id).assignable_users.include?(user)
  2093. end
  2094. test "#assignable_users should not show the issue author twice" do
  2095. assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
  2096. assert_equal 2, assignable_user_ids.length
  2097. assignable_user_ids.each do |user_id|
  2098. assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
  2099. "User #{user_id} appears more or less than once"
  2100. end
  2101. end
  2102. test "#assignable_users with issue_group_assignment should include groups" do
  2103. issue = Issue.new(:project => Project.find(2))
  2104. with_settings :issue_group_assignment => '1' do
  2105. assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
  2106. assert issue.assignable_users.include?(Group.find(11))
  2107. end
  2108. end
  2109. test "#assignable_users without issue_group_assignment should not include groups" do
  2110. issue = Issue.new(:project => Project.find(2))
  2111. with_settings :issue_group_assignment => '0' do
  2112. assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
  2113. assert !issue.assignable_users.include?(Group.find(11))
  2114. end
  2115. end
  2116. def test_assignable_users_should_not_include_builtin_groups
  2117. Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [1])
  2118. Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [1])
  2119. issue = Issue.new(:project => Project.find(1))
  2120. with_settings :issue_group_assignment => '1' do
  2121. assert_nil issue.assignable_users.detect {|u| u.is_a?(GroupBuiltin)}
  2122. end
  2123. end
  2124. def test_assignable_users_should_not_include_users_that_cannot_view_the_tracker
  2125. user = User.find(3)
  2126. role = Role.find(2)
  2127. role.set_permission_trackers :view_issues, [1, 3]
  2128. role.save!
  2129. issue1 = Issue.new(:project_id => 1, :tracker_id => 1)
  2130. issue2 = Issue.new(:project_id => 1, :tracker_id => 2)
  2131. assert_include user, issue1.assignable_users
  2132. assert_not_include user, issue2.assignable_users
  2133. end
  2134. def test_create_should_send_email_notification
  2135. ActionMailer::Base.deliveries.clear
  2136. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  2137. :author_id => 3, :status_id => 1,
  2138. :priority => IssuePriority.all.first,
  2139. :subject => 'test_create', :estimated_hours => '1:30')
  2140. with_settings :notified_events => %w(issue_added) do
  2141. assert issue.save
  2142. assert_equal 2, ActionMailer::Base.deliveries.size
  2143. end
  2144. end
  2145. def test_create_should_send_one_email_notification_with_both_settings
  2146. ActionMailer::Base.deliveries.clear
  2147. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  2148. :author_id => 3, :status_id => 1,
  2149. :priority => IssuePriority.all.first,
  2150. :subject => 'test_create', :estimated_hours => '1:30')
  2151. with_settings :notified_events => %w(issue_added issue_updated) do
  2152. assert issue.save
  2153. assert_equal 2, ActionMailer::Base.deliveries.size
  2154. end
  2155. end
  2156. def test_create_should_not_send_email_notification_with_no_setting
  2157. ActionMailer::Base.deliveries.clear
  2158. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  2159. :author_id => 3, :status_id => 1,
  2160. :priority => IssuePriority.all.first,
  2161. :subject => 'test_create', :estimated_hours => '1:30')
  2162. with_settings :notified_events => [] do
  2163. assert issue.save
  2164. assert_equal 0, ActionMailer::Base.deliveries.size
  2165. end
  2166. end
  2167. def test_update_should_notify_previous_assignee
  2168. ActionMailer::Base.deliveries.clear
  2169. user = User.find(3)
  2170. user.members.update_all ["mail_notification = ?", false]
  2171. user.update! :mail_notification => 'only_assigned'
  2172. with_settings :notified_events => %w(issue_updated) do
  2173. issue = Issue.find(2)
  2174. issue.init_journal User.find(1)
  2175. issue.assigned_to = nil
  2176. issue.save!
  2177. assert_include [user.mail], ActionMailer::Base.deliveries.map(&:bcc)
  2178. end
  2179. end
  2180. def test_stale_issue_should_not_send_email_notification
  2181. ActionMailer::Base.deliveries.clear
  2182. issue = Issue.find(1)
  2183. stale = Issue.find(1)
  2184. issue.init_journal(User.find(1))
  2185. issue.subject = 'Subjet update'
  2186. with_settings :notified_events => %w(issue_updated) do
  2187. assert issue.save
  2188. assert_equal 2, ActionMailer::Base.deliveries.size
  2189. ActionMailer::Base.deliveries.clear
  2190. stale.init_journal(User.find(1))
  2191. stale.subject = 'Another subjet update'
  2192. assert_raise ActiveRecord::StaleObjectError do
  2193. stale.save
  2194. end
  2195. assert ActionMailer::Base.deliveries.empty?
  2196. end
  2197. end
  2198. def test_journalized_description
  2199. IssueCustomField.delete_all
  2200. i = Issue.first
  2201. old_description = i.description
  2202. new_description = "This is the new description"
  2203. i.init_journal(User.find(2))
  2204. i.description = new_description
  2205. assert_difference 'Journal.count', 1 do
  2206. assert_difference 'JournalDetail.count', 1 do
  2207. i.save!
  2208. end
  2209. end
  2210. detail = JournalDetail.order('id DESC').first
  2211. assert_equal i, detail.journal.journalized
  2212. assert_equal 'attr', detail.property
  2213. assert_equal 'description', detail.prop_key
  2214. assert_equal old_description, detail.old_value
  2215. assert_equal new_description, detail.value
  2216. end
  2217. def test_blank_descriptions_should_not_be_journalized
  2218. IssueCustomField.delete_all
  2219. Issue.where(:id => 1).update_all("description = NULL")
  2220. i = Issue.find(1)
  2221. i.init_journal(User.find(2))
  2222. i.subject = "blank description"
  2223. i.description = "\r\n"
  2224. assert_difference 'Journal.count', 1 do
  2225. assert_difference 'JournalDetail.count', 1 do
  2226. i.save!
  2227. end
  2228. end
  2229. end
  2230. def test_journalized_multi_custom_field
  2231. field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
  2232. :is_filter => true, :is_for_all => true,
  2233. :tracker_ids => [1],
  2234. :possible_values => ['value1', 'value2', 'value3'],
  2235. :multiple => true)
  2236. issue = Issue.create!(:project_id => 1, :tracker_id => 1,
  2237. :subject => 'Test', :author_id => 1)
  2238. assert_difference 'Journal.count' do
  2239. assert_difference 'JournalDetail.count' do
  2240. issue.init_journal(User.first)
  2241. issue.custom_field_values = {field.id => ['value1']}
  2242. issue.save!
  2243. end
  2244. assert_difference 'JournalDetail.count' do
  2245. issue.init_journal(User.first)
  2246. issue.custom_field_values = {field.id => ['value1', 'value2']}
  2247. issue.save!
  2248. end
  2249. assert_difference 'JournalDetail.count', 2 do
  2250. issue.init_journal(User.first)
  2251. issue.custom_field_values = {field.id => ['value3', 'value2']}
  2252. issue.save!
  2253. end
  2254. assert_difference 'JournalDetail.count', 2 do
  2255. issue.init_journal(User.first)
  2256. issue.custom_field_values = {field.id => nil}
  2257. issue.save!
  2258. end
  2259. end
  2260. end
  2261. def test_custom_value_cleared_on_tracker_change_should_be_journalized
  2262. a = IssueCustomField.generate!(:tracker_ids => [1])
  2263. issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {a.id.to_s => "foo"})
  2264. assert_equal "foo", issue.custom_field_value(a)
  2265. journal = new_record(Journal) do
  2266. issue.init_journal(User.first)
  2267. issue.tracker_id = 2
  2268. issue.save!
  2269. end
  2270. details = journal.details.select {|d| d.property == 'cf' && d.prop_key == a.id.to_s}
  2271. assert_equal 1, details.size
  2272. assert_equal 'foo', details.first.old_value
  2273. assert_nil details.first.value
  2274. end
  2275. def test_description_eol_should_be_normalized
  2276. i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
  2277. assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
  2278. end
  2279. def test_saving_twice_should_not_duplicate_journal_details
  2280. i = Issue.first
  2281. i.init_journal(User.find(2), 'Some notes')
  2282. # initial changes
  2283. i.subject = 'New subject'
  2284. i.done_ratio = i.done_ratio + 10
  2285. assert_difference 'Journal.count' do
  2286. assert i.save
  2287. end
  2288. # 1 more change
  2289. i.priority = IssuePriority.where("id <> ?", i.priority_id).first
  2290. assert_no_difference 'Journal.count' do
  2291. assert_difference 'JournalDetail.count', 1 do
  2292. i.save
  2293. end
  2294. end
  2295. # no more change
  2296. assert_no_difference 'Journal.count' do
  2297. assert_no_difference 'JournalDetail.count' do
  2298. i.save
  2299. end
  2300. end
  2301. end
  2302. test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
  2303. @issue = Issue.find(1)
  2304. @issue_status = IssueStatus.find(1)
  2305. @issue_status.update!(:default_done_ratio => 50)
  2306. @issue2 = Issue.find(2)
  2307. @issue_status2 = IssueStatus.find(2)
  2308. @issue_status2.update!(:default_done_ratio => 0)
  2309. with_settings :issue_done_ratio => 'issue_field' do
  2310. assert_equal 0, @issue.done_ratio
  2311. assert_equal 30, @issue2.done_ratio
  2312. end
  2313. with_settings :issue_done_ratio => 'issue_status' do
  2314. assert_equal 50, @issue.done_ratio
  2315. assert_equal 0, @issue2.done_ratio
  2316. end
  2317. end
  2318. test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
  2319. @issue = Issue.find(1)
  2320. @issue_status = IssueStatus.find(1)
  2321. @issue_status.update!(:default_done_ratio => 50)
  2322. @issue2 = Issue.find(2)
  2323. @issue_status2 = IssueStatus.find(2)
  2324. @issue_status2.update!(:default_done_ratio => 0)
  2325. with_settings :issue_done_ratio => 'issue_field' do
  2326. @issue.update_done_ratio_from_issue_status
  2327. @issue2.update_done_ratio_from_issue_status
  2328. assert_equal 0, @issue.read_attribute(:done_ratio)
  2329. assert_equal 30, @issue2.read_attribute(:done_ratio)
  2330. end
  2331. with_settings :issue_done_ratio => 'issue_status' do
  2332. @issue.update_done_ratio_from_issue_status
  2333. @issue2.update_done_ratio_from_issue_status
  2334. assert_equal 50, @issue.read_attribute(:done_ratio)
  2335. assert_equal 0, @issue2.read_attribute(:done_ratio)
  2336. end
  2337. end
  2338. test "#by_tracker" do
  2339. User.current = User.find(2)
  2340. groups = Issue.by_tracker(Project.find(1))
  2341. groups_containing_subprojects = Issue.by_tracker(Project.find(1), true)
  2342. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2343. assert_equal 13, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2344. end
  2345. test "#by_version" do
  2346. User.current = User.find(2)
  2347. project = Project.find(1)
  2348. Issue.generate!(:project_id => project.descendants.visible.first, :fixed_version_id => project.shared_versions.find_by(:sharing => 'tree').id)
  2349. groups = Issue.by_version(project)
  2350. groups_containing_subprojects = Issue.by_version(project, true)
  2351. assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2352. assert_equal 4, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2353. end
  2354. test "#by_priority" do
  2355. User.current = User.find(2)
  2356. project = Project.find(1)
  2357. groups = Issue.by_priority(project)
  2358. groups_containing_subprojects = Issue.by_priority(project, true)
  2359. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2360. assert_equal 13, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2361. end
  2362. test "#by_category" do
  2363. User.current = User.find(2)
  2364. project = Project.find(1)
  2365. issue_category = IssueCategory.create(:project => project.descendants.visible.first, :name => 'test category')
  2366. Issue.generate!(:project_id => project.descendants.visible.first, :category_id => issue_category.id)
  2367. groups = Issue.by_category(project)
  2368. groups_containing_subprojects = Issue.by_category(project, true)
  2369. assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2370. assert_equal 4, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2371. end
  2372. test "#by_assigned_to" do
  2373. User.current = User.find(2)
  2374. project = Project.find(1)
  2375. Issue.generate!(:project_id => project.descendants.visible.first, :assigned_to => User.current)
  2376. groups = Issue.by_assigned_to(project)
  2377. groups_containing_subprojects = Issue.by_assigned_to(project, true)
  2378. assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2379. assert_equal 3, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2380. end
  2381. test "#by_author" do
  2382. User.current = User.find(2)
  2383. project = Project.find(1)
  2384. groups = Issue.by_author(project)
  2385. groups_containing_subprojects = Issue.by_author(project, true)
  2386. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2387. assert_equal 13, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2388. end
  2389. test "#by_subproject" do
  2390. User.current = User.anonymous
  2391. groups = Issue.by_subproject(Project.find(1))
  2392. # Private descendant not visible
  2393. assert_equal 1, groups.count
  2394. assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2395. end
  2396. def test_recently_updated_scope
  2397. #should return the last updated issue
  2398. assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
  2399. end
  2400. def test_on_active_projects_scope
  2401. assert Project.find(2).archive
  2402. before = Issue.on_active_project.length
  2403. # test inclusion to results
  2404. issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
  2405. assert_equal before + 1, Issue.on_active_project.length
  2406. # Move to an archived project
  2407. issue.project = Project.find(2)
  2408. assert issue.save
  2409. assert_equal before, Issue.on_active_project.length
  2410. end
  2411. test "Issue#recipients should include project recipients" do
  2412. issue = Issue.generate!
  2413. assert issue.project.recipients.present?
  2414. issue.project.recipients.each do |project_recipient|
  2415. assert issue.recipients.include?(project_recipient)
  2416. end
  2417. end
  2418. test "Issue#recipients should include the author if the author is active" do
  2419. issue = Issue.generate!(:author => User.generate!)
  2420. assert issue.author, "No author set for Issue"
  2421. assert issue.recipients.include?(issue.author.mail)
  2422. end
  2423. test "Issue#recipients should include the assigned to user if the assigned to user is active" do
  2424. user = User.generate!
  2425. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2426. issue = Issue.generate!(:assigned_to => user)
  2427. assert issue.assigned_to, "No assigned_to set for Issue"
  2428. assert issue.recipients.include?(issue.assigned_to.mail)
  2429. end
  2430. test "Issue#recipients should not include users who opt out of all email" do
  2431. issue = Issue.generate!(:author => User.generate!)
  2432. issue.author.update!(:mail_notification => :none)
  2433. assert !issue.recipients.include?(issue.author.mail)
  2434. end
  2435. test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
  2436. issue = Issue.generate!(:author => User.generate!)
  2437. issue.author.update!(:mail_notification => :only_assigned)
  2438. assert !issue.recipients.include?(issue.author.mail)
  2439. end
  2440. test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
  2441. user = User.generate!
  2442. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2443. issue = Issue.generate!(:assigned_to => user)
  2444. issue.assigned_to.update!(:mail_notification => :only_owner)
  2445. assert !issue.recipients.include?(issue.assigned_to.mail)
  2446. end
  2447. def test_last_journal_id_with_journals_should_return_the_journal_id
  2448. assert_equal 2, Issue.find(1).last_journal_id
  2449. end
  2450. def test_last_journal_id_without_journals_should_return_nil
  2451. assert_nil Issue.find(3).last_journal_id
  2452. end
  2453. def test_journals_after_should_return_journals_with_greater_id
  2454. assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
  2455. assert_equal [], Issue.find(1).journals_after('2')
  2456. end
  2457. def test_journals_after_with_blank_arg_should_return_all_journals
  2458. assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
  2459. end
  2460. def test_css_classes_should_include_tracker
  2461. issue = Issue.new(:tracker => Tracker.find(2))
  2462. classes = issue.css_classes.split(' ')
  2463. assert_include 'tracker-2', classes
  2464. end
  2465. def test_css_classes_should_include_priority
  2466. issue = Issue.new(:priority => IssuePriority.find(8))
  2467. classes = issue.css_classes.split(' ')
  2468. assert_include 'priority-8', classes
  2469. assert_include 'priority-highest', classes
  2470. end
  2471. def test_css_classes_should_include_user_and_group_assignment
  2472. project = Project.first
  2473. user = User.generate!
  2474. group = Group.generate!
  2475. Member.create!(:principal => group, :project => project, :role_ids => [1, 2])
  2476. group.users << user
  2477. assert user.member_of?(project)
  2478. issue1 = Issue.generate(:assigned_to_id => group.id)
  2479. assert_include 'assigned-to-my-group', issue1.css_classes(user)
  2480. assert_not_include 'assigned-to-me', issue1.css_classes(user)
  2481. issue2 = Issue.generate(:assigned_to_id => user.id)
  2482. assert_not_include 'assigned-to-my-group', issue2.css_classes(user)
  2483. assert_include 'assigned-to-me', issue2.css_classes(user)
  2484. end
  2485. def test_save_attachments_with_hash_should_save_attachments_in_keys_order
  2486. set_tmp_attachments_directory
  2487. issue = Issue.generate!
  2488. issue.save_attachments({
  2489. 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
  2490. '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
  2491. '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
  2492. })
  2493. issue.attach_saved_attachments
  2494. assert_equal 3, issue.reload.attachments.count
  2495. assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
  2496. end
  2497. def test_save_attachments_with_array_should_warn_about_missing_tokens
  2498. set_tmp_attachments_directory
  2499. issue = Issue.generate!
  2500. issue.save_attachments([
  2501. {'token' => 'missing'}
  2502. ])
  2503. assert !issue.save
  2504. assert issue.errors[:base].present?
  2505. assert_equal 0, issue.reload.attachments.count
  2506. end
  2507. def test_closed_on_should_be_nil_when_creating_an_open_issue
  2508. issue = Issue.generate!(:status_id => 1).reload
  2509. assert !issue.closed?
  2510. assert_nil issue.closed_on
  2511. end
  2512. def test_closed_on_should_be_set_when_creating_a_closed_issue
  2513. issue = Issue.generate!(:status_id => 5).reload
  2514. assert issue.closed?
  2515. assert_not_nil issue.closed_on
  2516. assert_equal issue.updated_on, issue.closed_on
  2517. assert_equal issue.created_on, issue.closed_on
  2518. end
  2519. def test_closed_on_should_be_nil_when_updating_an_open_issue
  2520. issue = Issue.find(1)
  2521. issue.subject = 'Not closed yet'
  2522. issue.save!
  2523. issue.reload
  2524. assert_nil issue.closed_on
  2525. end
  2526. def test_closed_on_should_be_set_when_closing_an_open_issue
  2527. issue = Issue.find(1)
  2528. issue.subject = 'Now closed'
  2529. issue.status_id = 5
  2530. issue.save!
  2531. issue.reload
  2532. assert_not_nil issue.closed_on
  2533. assert_equal issue.updated_on, issue.closed_on
  2534. end
  2535. def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
  2536. issue = Issue.open(false).first
  2537. was_closed_on = issue.closed_on
  2538. assert_not_nil was_closed_on
  2539. issue.subject = 'Updating a closed issue'
  2540. issue.save!
  2541. issue.reload
  2542. assert_equal was_closed_on, issue.closed_on
  2543. end
  2544. def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
  2545. issue = Issue.open(false).first
  2546. was_closed_on = issue.closed_on
  2547. assert_not_nil was_closed_on
  2548. issue.subject = 'Reopening a closed issue'
  2549. issue.status_id = 1
  2550. issue.save!
  2551. issue.reload
  2552. assert !issue.closed?
  2553. assert_equal was_closed_on, issue.closed_on
  2554. end
  2555. def test_status_was_should_return_nil_for_new_issue
  2556. issue = Issue.new
  2557. assert_nil issue.status_was
  2558. end
  2559. def test_status_was_should_return_status_before_change
  2560. issue = Issue.find(1)
  2561. issue.status = IssueStatus.find(2)
  2562. assert_equal IssueStatus.find(1), issue.status_was
  2563. end
  2564. def test_status_was_should_return_status_before_change_with_status_id
  2565. issue = Issue.find(1)
  2566. assert_equal IssueStatus.find(1), issue.status
  2567. issue.status_id = 2
  2568. assert_equal IssueStatus.find(1), issue.status_was
  2569. end
  2570. def test_status_was_should_be_reset_on_save
  2571. issue = Issue.find(1)
  2572. issue.status = IssueStatus.find(2)
  2573. assert_equal IssueStatus.find(1), issue.status_was
  2574. assert issue.save!
  2575. assert_equal IssueStatus.find(2), issue.status_was
  2576. end
  2577. def test_closing_should_return_true_when_closing_an_issue
  2578. issue = Issue.find(1)
  2579. issue.status = IssueStatus.find(2)
  2580. assert_equal false, issue.closing?
  2581. issue.status = IssueStatus.find(5)
  2582. assert_equal true, issue.closing?
  2583. end
  2584. def test_closing_should_return_true_when_closing_an_issue_with_status_id
  2585. issue = Issue.find(1)
  2586. issue.status_id = 2
  2587. assert_equal false, issue.closing?
  2588. issue.status_id = 5
  2589. assert_equal true, issue.closing?
  2590. end
  2591. def test_closing_should_return_true_for_new_closed_issue
  2592. issue = Issue.new
  2593. assert_equal false, issue.closing?
  2594. issue.status = IssueStatus.find(5)
  2595. assert_equal true, issue.closing?
  2596. end
  2597. def test_closing_should_return_true_for_new_closed_issue_with_status_id
  2598. issue = Issue.new
  2599. assert_equal false, issue.closing?
  2600. issue.status_id = 5
  2601. assert_equal true, issue.closing?
  2602. end
  2603. def test_closing_should_be_reset_after_save
  2604. issue = Issue.find(1)
  2605. issue.status_id = 5
  2606. assert_equal true, issue.closing?
  2607. issue.save!
  2608. assert_equal false, issue.closing?
  2609. end
  2610. def test_reopening_should_return_true_when_reopening_an_issue
  2611. issue = Issue.find(8)
  2612. issue.status = IssueStatus.find(6)
  2613. assert_equal false, issue.reopening?
  2614. issue.status = IssueStatus.find(2)
  2615. assert_equal true, issue.reopening?
  2616. end
  2617. def test_reopening_should_return_true_when_reopening_an_issue_with_status_id
  2618. issue = Issue.find(8)
  2619. issue.status_id = 6
  2620. assert_equal false, issue.reopening?
  2621. issue.status_id = 2
  2622. assert_equal true, issue.reopening?
  2623. end
  2624. def test_reopening_should_return_false_for_new_open_issue
  2625. issue = Issue.new
  2626. issue.status = IssueStatus.find(1)
  2627. assert_equal false, issue.reopening?
  2628. end
  2629. def test_reopening_should_be_reset_after_save
  2630. issue = Issue.find(8)
  2631. issue.status_id = 2
  2632. assert_equal true, issue.reopening?
  2633. issue.save!
  2634. assert_equal false, issue.reopening?
  2635. end
  2636. def test_default_status_without_tracker_should_be_nil
  2637. issue = Issue.new
  2638. assert_nil issue.tracker
  2639. assert_nil issue.default_status
  2640. end
  2641. def test_default_status_should_be_tracker_default_status
  2642. issue = Issue.new(:tracker_id => 1)
  2643. assert_not_nil issue.status
  2644. assert_equal issue.tracker.default_status, issue.default_status
  2645. end
  2646. def test_initializing_with_tracker_should_set_default_status
  2647. issue = Issue.new(:tracker => Tracker.find(1))
  2648. assert_not_nil issue.status
  2649. assert_equal issue.default_status, issue.status
  2650. end
  2651. def test_initializing_with_tracker_id_should_set_default_status
  2652. issue = Issue.new(:tracker_id => 1)
  2653. assert_not_nil issue.status
  2654. assert_equal issue.default_status, issue.status
  2655. end
  2656. def test_setting_tracker_should_set_default_status
  2657. issue = Issue.new
  2658. issue.tracker = Tracker.find(1)
  2659. assert_not_nil issue.status
  2660. assert_equal issue.default_status, issue.status
  2661. end
  2662. def test_changing_tracker_should_set_default_status_if_status_was_default
  2663. WorkflowTransition.delete_all
  2664. WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1
  2665. Tracker.find(2).update! :default_status_id => 2
  2666. issue = Issue.new(:tracker_id => 1, :status_id => 1)
  2667. assert_equal IssueStatus.find(1), issue.status
  2668. issue.tracker = Tracker.find(2)
  2669. assert_equal IssueStatus.find(2), issue.status
  2670. end
  2671. def test_changing_tracker_should_set_default_status_if_status_is_not_used_by_tracker
  2672. WorkflowTransition.delete_all
  2673. Tracker.find(2).update! :default_status_id => 2
  2674. issue = Issue.new(:tracker_id => 1, :status_id => 3)
  2675. assert_equal IssueStatus.find(3), issue.status
  2676. issue.tracker = Tracker.find(2)
  2677. assert_equal IssueStatus.find(2), issue.status
  2678. end
  2679. def test_changing_tracker_should_keep_status_if_status_was_not_default_and_is_used_by_tracker
  2680. WorkflowTransition.delete_all
  2681. WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3
  2682. Tracker.find(2).update! :default_status_id => 2
  2683. issue = Issue.new(:tracker_id => 1, :status_id => 3)
  2684. assert_equal IssueStatus.find(3), issue.status
  2685. issue.tracker = Tracker.find(2)
  2686. assert_equal IssueStatus.find(3), issue.status
  2687. end
  2688. def test_previous_assignee_with_a_group
  2689. group = Group.find(10)
  2690. Member.create!(:project_id => 1, :principal => group, :role_ids => [1])
  2691. with_settings :issue_group_assignment => '1' do
  2692. issue = Issue.generate!(:assigned_to => group)
  2693. issue.reload.assigned_to = nil
  2694. assert_equal group, issue.previous_assignee
  2695. end
  2696. end
  2697. def test_issue_overdue_should_respect_user_timezone
  2698. user_in_europe = users(:users_001)
  2699. user_in_europe.pref.update! :time_zone => 'UTC'
  2700. user_in_asia = users(:users_002)
  2701. user_in_asia.pref.update! :time_zone => 'Hongkong'
  2702. issue = Issue.generate! :due_date => Date.parse('2016-03-20')
  2703. # server time is UTC
  2704. time = Time.parse '2016-03-20 20:00 UTC'
  2705. Time.stubs(:now).returns(time)
  2706. Date.stubs(:today).returns(time.to_date)
  2707. # for a user in the same time zone as the server the issue is not overdue
  2708. # yet
  2709. User.current = user_in_europe
  2710. assert !issue.overdue?
  2711. # at the same time, a user in East Asia looks at the issue - it's already
  2712. # March 21st and the issue should be marked overdue
  2713. User.current = user_in_asia
  2714. assert issue.overdue?
  2715. end
  2716. end