選択できるのは25トピックまでです。 トピックは、先頭が英数字で、英数字とダッシュ('-')を使用した35文字以内のものにしてください。

issue_test.rb 123KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409
  1. # frozen_string_literal: true
  2. # Redmine - project management software
  3. # Copyright (C) 2006-2021 Jean-Philippe Lang
  4. #
  5. # This program is free software; you can redistribute it and/or
  6. # modify it under the terms of the GNU General Public License
  7. # as published by the Free Software Foundation; either version 2
  8. # of the License, or (at your option) any later version.
  9. #
  10. # This program is distributed in the hope that it will be useful,
  11. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  12. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13. # GNU General Public License for more details.
  14. #
  15. # You should have received a copy of the GNU General Public License
  16. # along with this program; if not, write to the Free Software
  17. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  18. require File.expand_path('../../test_helper', __FILE__)
  19. class IssueTest < ActiveSupport::TestCase
  20. fixtures :projects, :users, :email_addresses, :user_preferences, :members, :member_roles, :roles,
  21. :groups_users,
  22. :trackers, :projects_trackers,
  23. :enabled_modules,
  24. :versions,
  25. :issue_statuses, :issue_categories, :issue_relations, :workflows,
  26. :enumerations,
  27. :issues, :journals, :journal_details,
  28. :watchers,
  29. :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
  30. :time_entries
  31. include Redmine::I18n
  32. def setup
  33. User.current = nil
  34. set_language_if_valid 'en'
  35. end
  36. def teardown
  37. User.current = nil
  38. end
  39. def test_initialize
  40. issue = Issue.new
  41. assert_nil issue.project_id
  42. assert_nil issue.tracker_id
  43. assert_nil issue.status_id
  44. assert_nil issue.author_id
  45. assert_nil issue.assigned_to_id
  46. assert_nil issue.category_id
  47. assert_equal IssuePriority.default, issue.priority
  48. end
  49. def test_create
  50. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
  51. :status_id => 1, :priority => IssuePriority.all.first,
  52. :subject => 'test_create',
  53. :description => 'IssueTest#test_create', :estimated_hours => '1:30')
  54. assert issue.save
  55. issue.reload
  56. assert_equal 1.5, issue.estimated_hours
  57. end
  58. def test_create_minimal
  59. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create')
  60. assert issue.save
  61. assert_equal issue.tracker.default_status, issue.status
  62. assert issue.description.nil?
  63. assert_nil issue.estimated_hours
  64. end
  65. def test_create_with_all_fields_disabled
  66. tracker = Tracker.find(1)
  67. tracker.core_fields = []
  68. tracker.save!
  69. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create_with_all_fields_disabled')
  70. assert_save issue
  71. end
  72. def test_start_date_format_should_be_validated
  73. set_language_if_valid 'en'
  74. ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
  75. issue = Issue.new(:start_date => invalid_date)
  76. assert !issue.valid?
  77. assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
  78. end
  79. end
  80. def test_due_date_format_should_be_validated
  81. set_language_if_valid 'en'
  82. ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
  83. issue = Issue.new(:due_date => invalid_date)
  84. assert !issue.valid?
  85. assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
  86. end
  87. end
  88. def test_due_date_lesser_than_start_date_should_not_validate
  89. set_language_if_valid 'en'
  90. issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
  91. assert !issue.valid?
  92. assert_include 'Due date must be greater than start date', issue.errors.full_messages
  93. end
  94. def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
  95. issue = Issue.generate(:start_date => '2013-06-04')
  96. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  97. assert !issue.valid?
  98. assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  99. end
  100. def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
  101. issue = Issue.generate!(:start_date => '2013-06-04')
  102. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  103. issue.start_date = '2013-06-07'
  104. assert !issue.valid?
  105. assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  106. end
  107. def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
  108. issue = Issue.generate!(:start_date => '2013-06-04')
  109. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  110. assert issue.valid?
  111. end
  112. def test_estimated_hours_should_be_validated
  113. set_language_if_valid 'en'
  114. ['-2', '123abc'].each do |invalid|
  115. issue = Issue.new(:estimated_hours => invalid)
  116. assert !issue.valid?
  117. assert_include 'Estimated time is invalid', issue.errors.full_messages
  118. end
  119. end
  120. def test_create_with_required_custom_field
  121. set_language_if_valid 'en'
  122. field = IssueCustomField.find_by_name('Database')
  123. field.update!(:is_required => true)
  124. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  125. :status_id => 1, :subject => 'test_create',
  126. :description => 'IssueTest#test_create_with_required_custom_field')
  127. assert issue.available_custom_fields.include?(field)
  128. # No value for the custom field
  129. assert !issue.save
  130. assert_equal ["Database cannot be blank"], issue.errors.full_messages
  131. # Blank value
  132. issue.custom_field_values = {field.id => ''}
  133. assert !issue.save
  134. assert_equal ["Database cannot be blank"], issue.errors.full_messages
  135. # Invalid value
  136. issue.custom_field_values = {field.id => 'SQLServer'}
  137. assert !issue.save
  138. assert_equal ["Database is not included in the list"], issue.errors.full_messages
  139. # Valid value
  140. issue.custom_field_values = {field.id => 'PostgreSQL'}
  141. assert issue.save
  142. issue.reload
  143. assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  144. end
  145. def test_create_with_group_assignment
  146. with_settings :issue_group_assignment => '1' do
  147. assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
  148. :subject => 'Group assignment',
  149. :assigned_to_id => 11).save
  150. issue = Issue.order('id DESC').first
  151. assert_kind_of Group, issue.assigned_to
  152. assert_equal Group.find(11), issue.assigned_to
  153. end
  154. end
  155. def test_create_with_parent_issue_id
  156. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  157. :author_id => 1, :subject => 'Group assignment',
  158. :parent_issue_id => 1)
  159. assert_save issue
  160. assert_equal 1, issue.parent_issue_id
  161. assert_equal Issue.find(1), issue.parent
  162. end
  163. def test_create_with_sharp_parent_issue_id
  164. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  165. :author_id => 1, :subject => 'Group assignment',
  166. :parent_issue_id => "#1")
  167. assert_save issue
  168. assert_equal 1, issue.parent_issue_id
  169. assert_equal Issue.find(1), issue.parent
  170. end
  171. def test_create_with_invalid_parent_issue_id
  172. set_language_if_valid 'en'
  173. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  174. :author_id => 1, :subject => 'Group assignment',
  175. :parent_issue_id => '01ABC')
  176. assert !issue.save
  177. assert_equal '01ABC', issue.parent_issue_id
  178. assert_include 'Parent task is invalid', issue.errors.full_messages
  179. end
  180. def test_create_with_invalid_sharp_parent_issue_id
  181. set_language_if_valid 'en'
  182. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  183. :author_id => 1, :subject => 'Group assignment',
  184. :parent_issue_id => '#01ABC')
  185. assert !issue.save
  186. assert_equal '#01ABC', issue.parent_issue_id
  187. assert_include 'Parent task is invalid', issue.errors.full_messages
  188. end
  189. def assert_visibility_match(user, issues)
  190. assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  191. end
  192. def test_create_with_emoji_character
  193. skip if Redmine::Database.mysql? && !is_mysql_utf8mb4
  194. set_language_if_valid 'en'
  195. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  196. :author_id => 1, :subject => 'Group assignment',
  197. :description => 'Hello 😀')
  198. assert issue.save
  199. assert_equal 'Hello 😀', issue.description
  200. end
  201. def test_visible_scope_for_anonymous
  202. # Anonymous user should see issues of public projects only
  203. issues = Issue.visible(User.anonymous).to_a
  204. assert issues.any?
  205. assert_nil issues.detect {|issue| !issue.project.is_public?}
  206. assert_nil issues.detect {|issue| issue.is_private?}
  207. assert_visibility_match User.anonymous, issues
  208. end
  209. def test_visible_scope_for_anonymous_without_view_issues_permissions
  210. # Anonymous user should not see issues without permission
  211. Role.anonymous.remove_permission!(:view_issues)
  212. issues = Issue.visible(User.anonymous).to_a
  213. assert issues.empty?
  214. assert_visibility_match User.anonymous, issues
  215. end
  216. def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
  217. Role.anonymous.remove_permission!(:view_issues)
  218. Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])
  219. issues = Issue.visible(User.anonymous).all
  220. assert issues.any?
  221. assert_equal [1], issues.map(&:project_id).uniq.sort
  222. assert_visibility_match User.anonymous, issues
  223. end
  224. def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
  225. Role.anonymous.update!(:issues_visibility => 'default')
  226. issue = Issue.generate!(:author => User.anonymous, :is_private => true)
  227. assert_not Issue.where(:id => issue.id).visible(User.anonymous).exists?
  228. assert !issue.visible?(User.anonymous)
  229. end
  230. def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
  231. assert Role.anonymous.update!(:issues_visibility => 'own')
  232. issue = Issue.generate!(:author => User.anonymous, :is_private => true)
  233. assert_not Issue.where(:id => issue.id).visible(User.anonymous).exists?
  234. assert !issue.visible?(User.anonymous)
  235. end
  236. def test_visible_scope_for_non_member
  237. user = User.find(9)
  238. assert user.projects.empty?
  239. # Non member user should see issues of public projects only
  240. issues = Issue.visible(user).to_a
  241. assert issues.any?
  242. assert_nil issues.detect {|issue| !issue.project.is_public?}
  243. assert_nil issues.detect {|issue| issue.is_private?}
  244. assert_visibility_match user, issues
  245. end
  246. def test_visible_scope_for_non_member_with_own_issues_visibility
  247. Role.non_member.update! :issues_visibility => 'own'
  248. Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
  249. user = User.find(9)
  250. issues = Issue.visible(user).to_a
  251. assert issues.any?
  252. assert_nil issues.detect {|issue| issue.author != user}
  253. assert_visibility_match user, issues
  254. end
  255. def test_visible_scope_for_non_member_without_view_issues_permissions
  256. # Non member user should not see issues without permission
  257. Role.non_member.remove_permission!(:view_issues)
  258. user = User.find(9)
  259. assert user.projects.empty?
  260. issues = Issue.visible(user).to_a
  261. assert issues.empty?
  262. assert_visibility_match user, issues
  263. end
  264. def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
  265. Role.non_member.remove_permission!(:view_issues)
  266. Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
  267. user = User.find(9)
  268. issues = Issue.visible(user).all
  269. assert issues.any?
  270. assert_equal [1], issues.map(&:project_id).uniq.sort
  271. assert_visibility_match user, issues
  272. end
  273. def test_visible_scope_for_member
  274. user = User.find(9)
  275. # User should see issues of projects for which user has view_issues permissions only
  276. Role.non_member.remove_permission!(:view_issues)
  277. Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
  278. issues = Issue.visible(user).to_a
  279. assert issues.any?
  280. assert_nil issues.detect {|issue| issue.project_id != 3}
  281. assert_nil issues.detect {|issue| issue.is_private?}
  282. assert_visibility_match user, issues
  283. end
  284. def test_visible_scope_for_member_without_view_issues_permission_and_non_member_role_having_the_permission
  285. Role.non_member.add_permission!(:view_issues)
  286. Role.find(1).remove_permission!(:view_issues)
  287. user = User.find(2)
  288. assert_equal 0, Issue.where(:project_id => 1).visible(user).count
  289. assert_equal false, Issue.where(:project_id => 1).first.visible?(user)
  290. end
  291. def test_visible_scope_with_custom_non_member_role_having_restricted_permission
  292. role = Role.generate!(:permissions => [:view_project])
  293. assert Role.non_member.has_permission?(:view_issues)
  294. user = User.generate!
  295. Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])
  296. issues = Issue.visible(user).to_a
  297. assert issues.any?
  298. assert_nil issues.detect {|issue| issue.project_id == 1}
  299. end
  300. def test_visible_scope_with_custom_non_member_role_having_extended_permission
  301. role = Role.generate!(:permissions => [:view_project, :view_issues])
  302. Role.non_member.remove_permission!(:view_issues)
  303. user = User.generate!
  304. Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])
  305. issues = Issue.visible(user).to_a
  306. assert issues.any?
  307. assert_not_nil issues.detect {|issue| issue.project_id == 1}
  308. end
  309. def test_visible_scope_for_member_with_groups_should_return_assigned_issues
  310. user = User.find(8)
  311. assert user.groups.any?
  312. group = user.groups.first
  313. Member.create!(:principal => group, :project_id => 1, :role_ids => [2])
  314. Role.non_member.remove_permission!(:view_issues)
  315. with_settings :issue_group_assignment => '1' do
  316. issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 3,
  317. :status_id => 1, :priority => IssuePriority.all.first,
  318. :subject => 'Assignment test',
  319. :assigned_to => group,
  320. :is_private => true)
  321. Role.find(2).update! :issues_visibility => 'default'
  322. issues = Issue.visible(User.find(8)).to_a
  323. assert issues.any?
  324. assert issues.include?(issue)
  325. Role.find(2).update! :issues_visibility => 'own'
  326. issues = Issue.visible(User.find(8)).to_a
  327. assert issues.any?
  328. assert_include issue, issues
  329. end
  330. end
  331. def test_visible_scope_for_member_with_limited_tracker_ids
  332. role = Role.find(1)
  333. role.set_permission_trackers :view_issues, [2]
  334. role.save!
  335. user = User.find(2)
  336. issues = Issue.where(:project_id => 1).visible(user).to_a
  337. assert issues.any?
  338. assert_equal [2], issues.map(&:tracker_id).uniq
  339. assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
  340. end
  341. def test_visible_scope_should_consider_tracker_ids_on_each_project
  342. user = User.generate!
  343. project1 = Project.generate!
  344. role1 = Role.generate!
  345. role1.add_permission! :view_issues
  346. role1.set_permission_trackers :view_issues, :all
  347. role1.save!
  348. User.add_to_project(user, project1, role1)
  349. project2 = Project.generate!
  350. role2 = Role.generate!
  351. role2.add_permission! :view_issues
  352. role2.set_permission_trackers :view_issues, [2]
  353. role2.save!
  354. User.add_to_project(user, project2, role2)
  355. visible_issues = [
  356. Issue.generate!(:project => project1, :tracker_id => 1),
  357. Issue.generate!(:project => project1, :tracker_id => 2),
  358. Issue.generate!(:project => project2, :tracker_id => 2)
  359. ]
  360. hidden_issue = Issue.generate!(:project => project2, :tracker_id => 1)
  361. issues = Issue.where(:project_id => [project1.id, project2.id]).visible(user)
  362. assert_equal visible_issues.map(&:id), issues.ids.sort
  363. assert visible_issues.all? {|issue| issue.visible?(user)}
  364. assert !hidden_issue.visible?(user)
  365. end
  366. def test_visible_scope_should_not_consider_roles_without_view_issues_permission
  367. user = User.generate!
  368. role1 = Role.generate!
  369. role1.remove_permission! :view_issues
  370. role1.set_permission_trackers :view_issues, :all
  371. role1.save!
  372. role2 = Role.generate!
  373. role2.add_permission! :view_issues
  374. role2.set_permission_trackers :view_issues, [2]
  375. role2.save!
  376. User.add_to_project(user, Project.find(1), [role1, role2])
  377. issues = Issue.where(:project_id => 1).visible(user).to_a
  378. assert issues.any?
  379. assert_equal [2], issues.map(&:tracker_id).uniq
  380. assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
  381. end
  382. def test_visible_scope_for_admin
  383. user = User.find(1)
  384. user.members.each(&:destroy)
  385. assert user.projects.empty?
  386. issues = Issue.visible(user).to_a
  387. assert issues.any?
  388. # Admin should see issues on private projects that admin does not belong to
  389. assert issues.detect {|issue| !issue.project.is_public?}
  390. # Admin should see private issues of other users
  391. assert issues.detect {|issue| issue.is_private? && issue.author != user}
  392. assert_visibility_match user, issues
  393. end
  394. def test_visible_scope_with_project
  395. project = Project.find(1)
  396. issues = Issue.visible(User.find(2), :project => project).to_a
  397. projects = issues.collect(&:project).uniq
  398. assert_equal 1, projects.size
  399. assert_equal project, projects.first
  400. end
  401. def test_visible_scope_with_project_and_subprojects
  402. project = Project.find(1)
  403. issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
  404. projects = issues.collect(&:project).uniq
  405. assert projects.size > 1
  406. assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  407. end
  408. def test_visible_and_nested_set_scopes
  409. user = User.generate!
  410. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  411. parent = Issue.generate!(:assigned_to => user)
  412. assert parent.visible?(user)
  413. child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
  414. child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
  415. parent.reload
  416. child1.reload
  417. child2.reload
  418. assert child1.visible?(user)
  419. assert child2.visible?(user)
  420. assert_equal 2, parent.descendants.count
  421. assert_equal 2, parent.descendants.visible(user).count
  422. # awesome_nested_set 2-1-stable branch has regression.
  423. # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
  424. # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
  425. assert_equal 2, parent.descendants.collect{|i| i}.size
  426. assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
  427. end
  428. def test_visible_scope_with_unsaved_user_should_not_raise_an_error
  429. user = User.new
  430. assert_nothing_raised do
  431. Issue.visible(user).to_a
  432. end
  433. end
  434. def test_open_scope
  435. issues = Issue.open.to_a
  436. assert_nil issues.detect(&:closed?)
  437. end
  438. def test_open_scope_with_arg
  439. issues = Issue.open(false).to_a
  440. assert_equal issues, issues.select(&:closed?)
  441. end
  442. def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
  443. version = Version.find(2)
  444. assert version.fixed_issues.any?
  445. assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
  446. end
  447. def test_fixed_version_scope_with_empty_array_should_return_no_result
  448. assert_equal 0, Issue.fixed_version([]).count
  449. end
  450. def test_assigned_to_scope_should_return_issues_assigned_to_the_user
  451. user = User.generate!
  452. issue = Issue.generate!
  453. Issue.where(:id => issue.id).update_all :assigned_to_id => user.id
  454. assert_equal [issue], Issue.assigned_to(user).to_a
  455. end
  456. def test_assigned_to_scope_should_return_issues_assigned_to_the_user_groups
  457. group = Group.generate!
  458. user = User.generate!
  459. group.users << user
  460. issue = Issue.generate!
  461. Issue.where(:id => issue.id).update_all :assigned_to_id => group.id
  462. assert_equal [issue], Issue.assigned_to(user).to_a
  463. end
  464. def test_issue_should_be_readonly_on_closed_project
  465. issue = Issue.find(1)
  466. user = User.find(1)
  467. assert_equal true, issue.visible?(user)
  468. assert_equal true, issue.editable?(user)
  469. assert_equal true, issue.deletable?(user)
  470. issue.project.close
  471. issue.reload
  472. assert_equal true, issue.visible?(user)
  473. assert_equal false, issue.editable?(user)
  474. assert_equal false, issue.deletable?(user)
  475. end
  476. def test_issue_should_editable_by_author
  477. Role.all.each do |r|
  478. r.remove_permission! :edit_issues
  479. r.add_permission! :edit_own_issues
  480. end
  481. issue = Issue.find(1)
  482. user = User.find_by_login('jsmith')
  483. # author
  484. assert_equal user, issue.author
  485. assert_equal true, issue.attributes_editable?(user)
  486. # not author
  487. assert_equal false, issue.attributes_editable?(User.find_by_login('dlopper'))
  488. end
  489. def test_errors_full_messages_should_include_custom_fields_errors
  490. field = IssueCustomField.find_by_name('Database')
  491. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  492. :status_id => 1, :subject => 'test_create',
  493. :description => 'IssueTest#test_create_with_required_custom_field')
  494. assert issue.available_custom_fields.include?(field)
  495. # Invalid value
  496. issue.custom_field_values = {field.id => 'SQLServer'}
  497. assert !issue.valid?
  498. assert_equal 1, issue.errors.full_messages.size
  499. assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
  500. issue.errors.full_messages.first
  501. end
  502. def test_update_issue_with_required_custom_field
  503. field = IssueCustomField.find_by_name('Database')
  504. field.update!(:is_required => true)
  505. issue = Issue.find(1)
  506. assert_nil issue.custom_value_for(field)
  507. assert issue.available_custom_fields.include?(field)
  508. # No change to custom values, issue can be saved
  509. assert issue.save
  510. # Blank value
  511. issue.custom_field_values = {field.id => ''}
  512. assert !issue.save
  513. # Valid value
  514. issue.custom_field_values = {field.id => 'PostgreSQL'}
  515. assert issue.save
  516. issue.reload
  517. assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  518. end
  519. def test_should_not_update_attributes_if_custom_fields_validation_fails
  520. issue = Issue.find(1)
  521. field = IssueCustomField.find_by_name('Database')
  522. assert issue.available_custom_fields.include?(field)
  523. issue.custom_field_values = {field.id => 'Invalid'}
  524. issue.subject = 'Should be not be saved'
  525. assert !issue.save
  526. issue.reload
  527. assert_equal "Cannot print recipes", issue.subject
  528. end
  529. def test_should_not_recreate_custom_values_objects_on_update
  530. field = IssueCustomField.find_by_name('Database')
  531. issue = Issue.find(1)
  532. issue.custom_field_values = {field.id => 'PostgreSQL'}
  533. assert issue.save
  534. custom_value = issue.custom_value_for(field)
  535. issue.reload
  536. issue.custom_field_values = {field.id => 'MySQL'}
  537. assert issue.save
  538. issue.reload
  539. assert_equal custom_value.id, issue.custom_value_for(field).id
  540. end
  541. def test_setting_project_should_set_version_to_default_version
  542. version = Version.generate!(:project_id => 1)
  543. Project.find(1).update!(:default_version_id => version.id)
  544. issue = Issue.new(:project_id => 1)
  545. assert_equal version, issue.fixed_version
  546. end
  547. def test_default_assigned_to_based_on_category_should_be_set_on_create
  548. user = User.find(3)
  549. category = IssueCategory.create!(:project_id => 1, :name => 'With default assignee', :assigned_to_id => 3)
  550. issue = Issue.generate!(:project_id => 1, :category_id => category.id)
  551. assert_equal user, issue.assigned_to
  552. end
  553. def test_default_assigned_to_based_on_project_should_be_set_on_create
  554. user = User.find(3)
  555. Project.find(1).update!(:default_assigned_to_id => user.id)
  556. issue = Issue.generate!(:project_id => 1)
  557. assert_equal user, issue.assigned_to
  558. end
  559. def test_default_assigned_to_with_required_assignee_should_validate
  560. category = IssueCategory.create!(:project_id => 1, :name => 'With default assignee', :assigned_to_id => 3)
  561. Issue.any_instance.stubs(:required_attribute_names).returns(['assigned_to_id'])
  562. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'Default')
  563. assert !issue.save
  564. assert issue.errors['assigned_to_id'].present?
  565. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'Default', :category_id => category.id)
  566. assert_save issue
  567. end
  568. def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
  569. issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
  570. :status_id => 1, :subject => 'Test',
  571. :custom_field_values => {'2' => 'Test'})
  572. assert !Tracker.find(2).custom_field_ids.include?(2)
  573. issue = Issue.find(issue.id)
  574. issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
  575. issue = Issue.find(issue.id)
  576. custom_value = issue.custom_value_for(2)
  577. assert_not_nil custom_value
  578. assert_equal 'Test', custom_value.value
  579. end
  580. def test_assigning_tracker_id_should_reload_custom_fields_values
  581. issue = Issue.new(:project => Project.find(1))
  582. assert issue.custom_field_values.empty?
  583. issue.tracker_id = 1
  584. assert issue.custom_field_values.any?
  585. end
  586. def test_assigning_attributes_should_assign_project_and_tracker_first
  587. seq = sequence('seq')
  588. issue = Issue.new
  589. issue.expects(:project_id=).in_sequence(seq)
  590. issue.expects(:tracker_id=).in_sequence(seq)
  591. issue.expects(:subject=).in_sequence(seq)
  592. assert_raise Exception do
  593. issue.attributes = {:subject => 'Test'}
  594. end
  595. assert_nothing_raised do
  596. issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
  597. end
  598. end
  599. def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
  600. attributes = ActiveSupport::OrderedHash.new
  601. attributes['custom_field_values'] = {'1' => 'MySQL'}
  602. attributes['tracker_id'] = '1'
  603. issue = Issue.new(:project => Project.find(1))
  604. issue.attributes = attributes
  605. assert_equal 'MySQL', issue.custom_field_value(1)
  606. end
  607. def test_changing_tracker_should_clear_disabled_core_fields
  608. tracker = Tracker.find(2)
  609. tracker.core_fields = tracker.core_fields - %w(due_date)
  610. tracker.save!
  611. issue = Issue.generate!(:tracker_id => 1, :start_date => Date.today, :due_date => Date.today)
  612. issue.save!
  613. issue.tracker_id = 2
  614. issue.save!
  615. assert_not_nil issue.start_date
  616. assert_nil issue.due_date
  617. end
  618. def test_attribute_cleared_on_tracker_change_should_be_journalized
  619. CustomField.delete_all
  620. tracker = Tracker.find(2)
  621. tracker.core_fields = tracker.core_fields - %w(due_date)
  622. tracker.save!
  623. issue = Issue.generate!(:tracker_id => 1, :due_date => Date.today)
  624. issue.save!
  625. assert_difference 'Journal.count' do
  626. issue.init_journal User.find(1)
  627. issue.tracker_id = 2
  628. issue.save!
  629. assert_nil issue.due_date
  630. end
  631. journal = Journal.order('id DESC').first
  632. details = journal.details.select {|d| d.prop_key == 'due_date'}
  633. assert_equal 1, details.count
  634. end
  635. def test_reload_should_reload_custom_field_values
  636. issue = Issue.generate!
  637. issue.custom_field_values = {'2' => 'Foo'}
  638. issue.save!
  639. issue = Issue.order('id desc').first
  640. assert_equal 'Foo', issue.custom_field_value(2)
  641. issue.custom_field_values = {'2' => 'Bar'}
  642. assert_equal 'Bar', issue.custom_field_value(2)
  643. issue.reload
  644. assert_equal 'Foo', issue.custom_field_value(2)
  645. end
  646. def test_should_update_issue_with_disabled_tracker
  647. p = Project.find(1)
  648. issue = Issue.find(1)
  649. p.trackers.delete(issue.tracker)
  650. assert !p.trackers.include?(issue.tracker)
  651. issue.reload
  652. issue.subject = 'New subject'
  653. assert issue.save
  654. end
  655. def test_should_not_set_a_disabled_tracker
  656. p = Project.find(1)
  657. p.trackers.delete(Tracker.find(2))
  658. issue = Issue.find(1)
  659. issue.tracker_id = 2
  660. issue.subject = 'New subject'
  661. assert !issue.save
  662. assert_not_equal [], issue.errors[:tracker_id]
  663. end
  664. def test_category_based_assignment
  665. issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
  666. :status_id => 1, :priority => IssuePriority.all.first,
  667. :subject => 'Assignment test',
  668. :description => 'Assignment test', :category_id => 1)
  669. assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  670. end
  671. def test_new_statuses_allowed_to
  672. WorkflowTransition.delete_all
  673. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  674. :old_status_id => 1, :new_status_id => 2,
  675. :author => false, :assignee => false)
  676. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  677. :old_status_id => 1, :new_status_id => 3,
  678. :author => true, :assignee => false)
  679. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  680. :old_status_id => 1, :new_status_id => 4,
  681. :author => false, :assignee => true)
  682. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  683. :old_status_id => 1, :new_status_id => 5,
  684. :author => true, :assignee => true)
  685. status = IssueStatus.find(1)
  686. role = Role.find(1)
  687. tracker = Tracker.find(1)
  688. user = User.find(2)
  689. issue = Issue.generate!(:tracker => tracker, :status => status,
  690. :project_id => 1, :author_id => 1)
  691. assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
  692. issue = Issue.generate!(:tracker => tracker, :status => status,
  693. :project_id => 1, :author => user)
  694. assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
  695. issue = Issue.generate!(:tracker => tracker, :status => status,
  696. :project_id => 1, :author_id => 1,
  697. :assigned_to => user)
  698. assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  699. issue = Issue.generate!(:tracker => tracker, :status => status,
  700. :project_id => 1, :author => user,
  701. :assigned_to => user)
  702. assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  703. end
  704. def test_new_statuses_allowed_to_should_consider_group_assignment
  705. WorkflowTransition.delete_all
  706. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  707. :old_status_id => 1, :new_status_id => 4,
  708. :author => false, :assignee => true)
  709. group = Group.generate!
  710. Member.create!(:project_id => 1, :principal => group, :role_ids => [1])
  711. user = User.find(2)
  712. group.users << user
  713. with_settings :issue_group_assignment => '1' do
  714. issue = Issue.generate!(:author_id => 1, :assigned_to => group)
  715. assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
  716. end
  717. end
  718. def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
  719. admin = User.find(1)
  720. issue = Issue.find(1)
  721. assert !admin.member_of?(issue.project)
  722. expected_statuses = [issue.status] +
  723. WorkflowTransition.where(:old_status_id => issue.status_id).
  724. map(&:new_status).uniq.sort
  725. assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
  726. end
  727. def test_new_statuses_allowed_to_should_return_allowed_statuses_when_copying
  728. Tracker.find(1).generate_transitions! :role_id => 1, :clear => true, 0 => [1, 3]
  729. orig = Issue.generate!(:project_id => 1, :tracker_id => 1, :status_id => 4)
  730. issue = orig.copy
  731. assert_equal [1, 3], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
  732. assert_equal 1, issue.status_id
  733. end
  734. def test_safe_attributes_names_should_be_updated_when_changing_project
  735. issue = Issue.new
  736. with_current_user(User.find(2)) do
  737. assert_not_include 'watcher_user_ids', issue.safe_attribute_names
  738. issue.project_id = 1
  739. assert_include 'watcher_user_ids', issue.safe_attribute_names
  740. end
  741. end
  742. def test_safe_attributes_names_should_not_include_disabled_field
  743. tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
  744. issue = Issue.new(:tracker => tracker)
  745. assert_include 'tracker_id', issue.safe_attribute_names
  746. assert_include 'status_id', issue.safe_attribute_names
  747. assert_include 'subject', issue.safe_attribute_names
  748. assert_include 'custom_field_values', issue.safe_attribute_names
  749. assert_include 'custom_fields', issue.safe_attribute_names
  750. assert_include 'lock_version', issue.safe_attribute_names
  751. tracker.core_fields.each do |field|
  752. assert_include field, issue.safe_attribute_names
  753. end
  754. tracker.disabled_core_fields.each do |field|
  755. assert_not_include field, issue.safe_attribute_names
  756. end
  757. end
  758. def test_safe_attributes_should_ignore_disabled_fields
  759. tracker = Tracker.find(1)
  760. tracker.core_fields = %w(assigned_to_id due_date)
  761. tracker.save!
  762. issue = Issue.new(:tracker => tracker)
  763. issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
  764. assert_nil issue.start_date
  765. assert_equal Date.parse('2012-07-14'), issue.due_date
  766. end
  767. def test_safe_attributes_notes_should_check_add_issue_notes_permission
  768. # With add_issue_notes permission
  769. user = User.find(2)
  770. issue = Issue.new(:project => Project.find(1))
  771. issue.init_journal(user)
  772. issue.send :safe_attributes=, {'notes' => 'note'}, user
  773. assert_equal 'note', issue.notes
  774. # Without add_issue_notes permission
  775. Role.find(1).remove_permission!(:add_issue_notes)
  776. issue = Issue.new(:project => Project.find(1))
  777. user.reload
  778. issue.init_journal(user)
  779. issue.send :safe_attributes=, {'notes' => 'note'}, user
  780. assert_equal '', issue.notes
  781. end
  782. def test_safe_attributes_should_accept_target_tracker_enabled_fields
  783. source = Tracker.find(1)
  784. source.core_fields = []
  785. source.save!
  786. target = Tracker.find(2)
  787. target.core_fields = %w(assigned_to_id due_date)
  788. target.save!
  789. user = User.find(2)
  790. issue = Issue.new(:project => Project.find(1), :tracker => source)
  791. issue.send :safe_attributes=, {'tracker_id' => 2, 'due_date' => '2012-07-14'}, user
  792. assert_equal target, issue.tracker
  793. assert_equal Date.parse('2012-07-14'), issue.due_date
  794. end
  795. def test_safe_attributes_should_not_include_readonly_fields
  796. WorkflowPermission.delete_all
  797. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  798. :role_id => 1, :field_name => 'due_date',
  799. :rule => 'readonly')
  800. user = User.find(2)
  801. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  802. assert_equal %w(due_date), issue.read_only_attribute_names(user)
  803. assert_not_include 'due_date', issue.safe_attribute_names(user)
  804. issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
  805. assert_equal Date.parse('2012-07-14'), issue.start_date
  806. assert_nil issue.due_date
  807. end
  808. def test_safe_attributes_should_not_include_readonly_custom_fields
  809. cf1 = IssueCustomField.create!(:name => 'Writable field',
  810. :field_format => 'string',
  811. :is_for_all => true, :tracker_ids => [1])
  812. cf2 = IssueCustomField.create!(:name => 'Readonly field',
  813. :field_format => 'string',
  814. :is_for_all => true, :tracker_ids => [1])
  815. WorkflowPermission.delete_all
  816. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  817. :role_id => 1, :field_name => cf2.id.to_s,
  818. :rule => 'readonly')
  819. user = User.find(2)
  820. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  821. assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
  822. assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
  823. issue.send(
  824. :safe_attributes=,
  825. {
  826. 'custom_field_values' =>
  827. {
  828. cf1.id.to_s => 'value1',
  829. cf2.id.to_s => 'value2'
  830. }
  831. },
  832. user
  833. )
  834. assert_equal 'value1', issue.custom_field_value(cf1)
  835. assert_nil issue.custom_field_value(cf2)
  836. issue.send(
  837. :safe_attributes=,
  838. {
  839. 'custom_fields' =>
  840. [
  841. {'id' => cf1.id.to_s, 'value' => 'valuea'},
  842. {'id' => cf2.id.to_s, 'value' => 'valueb'}
  843. ]
  844. }, user
  845. )
  846. assert_equal 'valuea', issue.custom_field_value(cf1)
  847. assert_nil issue.custom_field_value(cf2)
  848. end
  849. def test_editable_custom_field_values_should_return_non_readonly_custom_values
  850. cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
  851. :is_for_all => true, :tracker_ids => [1, 2])
  852. cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
  853. :is_for_all => true, :tracker_ids => [1, 2])
  854. WorkflowPermission.delete_all
  855. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
  856. :field_name => cf2.id.to_s, :rule => 'readonly')
  857. user = User.find(2)
  858. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  859. values = issue.editable_custom_field_values(user)
  860. assert values.detect {|value| value.custom_field == cf1}
  861. assert_nil values.detect {|value| value.custom_field == cf2}
  862. issue.tracker_id = 2
  863. values = issue.editable_custom_field_values(user)
  864. assert values.detect {|value| value.custom_field == cf1}
  865. assert values.detect {|value| value.custom_field == cf2}
  866. end
  867. def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
  868. enabled_cf =
  869. IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1],
  870. :visible => false, :role_ids => [1, 2])
  871. disabled_cf =
  872. IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1],
  873. :visible => false, :role_ids => [2])
  874. user = User.find(2)
  875. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  876. assert_include enabled_cf, issue.editable_custom_fields(user)
  877. assert_not_include disabled_cf, issue.editable_custom_fields(user)
  878. end
  879. def test_safe_attributes_should_accept_target_tracker_writable_fields
  880. WorkflowPermission.delete_all
  881. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  882. :role_id => 1, :field_name => 'due_date',
  883. :rule => 'readonly')
  884. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  885. :role_id => 1, :field_name => 'start_date',
  886. :rule => 'readonly')
  887. user = User.find(2)
  888. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  889. issue.send :safe_attributes=, {'start_date' => '2012-07-12',
  890. 'due_date' => '2012-07-14'}, user
  891. assert_equal Date.parse('2012-07-12'), issue.start_date
  892. assert_nil issue.due_date
  893. issue.send :safe_attributes=, {'start_date' => '2012-07-15',
  894. 'due_date' => '2012-07-16',
  895. 'tracker_id' => 2}, user
  896. assert_equal Date.parse('2012-07-12'), issue.start_date
  897. assert_equal Date.parse('2012-07-16'), issue.due_date
  898. end
  899. def test_safe_attributes_should_accept_target_status_writable_fields
  900. WorkflowPermission.delete_all
  901. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  902. :role_id => 1, :field_name => 'due_date',
  903. :rule => 'readonly')
  904. WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
  905. :role_id => 1, :field_name => 'start_date',
  906. :rule => 'readonly')
  907. user = User.find(2)
  908. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  909. issue.send(:safe_attributes=,
  910. {'start_date' => '2012-07-12',
  911. 'due_date' => '2012-07-14'},
  912. user)
  913. assert_equal Date.parse('2012-07-12'), issue.start_date
  914. assert_nil issue.due_date
  915. issue.send(:safe_attributes=,
  916. {'start_date' => '2012-07-15',
  917. 'due_date' => '2012-07-16',
  918. 'status_id' => 2},
  919. user)
  920. assert_equal Date.parse('2012-07-12'), issue.start_date
  921. assert_equal Date.parse('2012-07-16'), issue.due_date
  922. end
  923. def test_required_attributes_should_be_validated
  924. cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
  925. :is_for_all => true, :tracker_ids => [1, 2])
  926. WorkflowPermission.delete_all
  927. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  928. :role_id => 1, :field_name => 'due_date',
  929. :rule => 'required')
  930. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  931. :role_id => 1, :field_name => 'category_id',
  932. :rule => 'required')
  933. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  934. :role_id => 1, :field_name => cf.id.to_s,
  935. :rule => 'required')
  936. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  937. :role_id => 1, :field_name => 'start_date',
  938. :rule => 'required')
  939. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  940. :role_id => 1, :field_name => cf.id.to_s,
  941. :rule => 'required')
  942. user = User.find(2)
  943. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  944. :status_id => 1, :subject => 'Required fields',
  945. :author => user)
  946. assert_equal [cf.id.to_s, "category_id", "due_date"],
  947. issue.required_attribute_names(user).sort
  948. assert !issue.save, "Issue was saved"
  949. assert_equal ["Category cannot be blank", "Due date cannot be blank", "Foo cannot be blank"],
  950. issue.errors.full_messages.sort
  951. issue.tracker_id = 2
  952. assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
  953. assert !issue.save, "Issue was saved"
  954. assert_equal ["Foo cannot be blank", "Start date cannot be blank"],
  955. issue.errors.full_messages.sort
  956. issue.start_date = Date.today
  957. issue.custom_field_values = {cf.id.to_s => 'bar'}
  958. assert issue.save
  959. end
  960. def test_required_attribute_that_is_disabled_for_the_tracker_should_not_be_required
  961. WorkflowPermission.delete_all
  962. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  963. :role_id => 1, :field_name => 'start_date',
  964. :rule => 'required')
  965. user = User.find(2)
  966. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  967. :subject => 'Required fields', :author => user)
  968. assert !issue.save
  969. assert_include "Start date cannot be blank", issue.errors.full_messages
  970. tracker = Tracker.find(1)
  971. tracker.core_fields -= %w(start_date)
  972. tracker.save!
  973. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  974. :subject => 'Required fields', :author => user)
  975. assert issue.save
  976. end
  977. def test_category_should_not_be_required_if_project_has_no_categories
  978. Project.find(1).issue_categories.delete_all
  979. WorkflowPermission.delete_all
  980. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  981. :role_id => 1, :field_name => 'category_id',
  982. :rule => 'required')
  983. user = User.find(2)
  984. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  985. :subject => 'Required fields', :author => user)
  986. assert_save issue
  987. end
  988. def test_fixed_version_should_not_be_required_no_assignable_versions
  989. Version.delete_all
  990. WorkflowPermission.delete_all
  991. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  992. :role_id => 1, :field_name => 'fixed_version_id',
  993. :rule => 'required')
  994. user = User.find(2)
  995. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  996. :subject => 'Required fields', :author => user)
  997. assert_save issue
  998. end
  999. def test_required_custom_field_that_is_not_visible_for_the_user_should_not_be_required
  1000. CustomField.destroy_all
  1001. field = IssueCustomField.generate!(:is_required => true, :visible => false,
  1002. :role_ids => [1], :trackers => Tracker.all,
  1003. :is_for_all => true)
  1004. user = User.generate!
  1005. User.add_to_project(user, Project.find(1), Role.find(2))
  1006. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  1007. :subject => 'Required fields', :author => user)
  1008. assert_save issue
  1009. end
  1010. def test_required_custom_field_that_is_visible_for_the_user_should_be_required
  1011. CustomField.destroy_all
  1012. field = IssueCustomField.generate!(:is_required => true, :visible => false,
  1013. :role_ids => [1], :trackers => Tracker.all,
  1014. :is_for_all => true)
  1015. user = User.generate!
  1016. User.add_to_project(user, Project.find(1), Role.find(1))
  1017. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  1018. :subject => 'Required fields', :author => user)
  1019. assert !issue.save
  1020. assert_include "#{field.name} cannot be blank", issue.errors.full_messages
  1021. end
  1022. def test_required_attribute_names_for_multiple_roles_should_intersect_rules
  1023. WorkflowPermission.delete_all
  1024. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1025. :role_id => 1, :field_name => 'due_date',
  1026. :rule => 'required')
  1027. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1028. :role_id => 1, :field_name => 'start_date',
  1029. :rule => 'required')
  1030. user = User.find(2)
  1031. member = Member.find(1)
  1032. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1033. assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
  1034. member.role_ids = [1, 2]
  1035. member.save!
  1036. assert_equal [], issue.required_attribute_names(user.reload)
  1037. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1038. :role_id => 2, :field_name => 'due_date',
  1039. :rule => 'required')
  1040. assert_equal %w(due_date), issue.required_attribute_names(user)
  1041. member.role_ids = [1, 2, 3]
  1042. member.save!
  1043. assert_equal [], issue.required_attribute_names(user.reload)
  1044. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1045. :role_id => 3, :field_name => 'due_date',
  1046. :rule => 'readonly')
  1047. # required + readonly => required
  1048. assert_equal %w(due_date), issue.required_attribute_names(user)
  1049. end
  1050. def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
  1051. WorkflowPermission.delete_all
  1052. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1053. :role_id => 1, :field_name => 'due_date',
  1054. :rule => 'readonly')
  1055. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1056. :role_id => 1, :field_name => 'start_date',
  1057. :rule => 'readonly')
  1058. user = User.find(2)
  1059. member = Member.find(1)
  1060. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1061. assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
  1062. member.role_ids = [1, 2]
  1063. member.save!
  1064. assert_equal [], issue.read_only_attribute_names(user.reload)
  1065. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1066. :role_id => 2, :field_name => 'due_date',
  1067. :rule => 'readonly')
  1068. assert_equal %w(due_date), issue.read_only_attribute_names(user)
  1069. end
  1070. # A field that is not visible by role 2 and readonly by role 1 should be readonly for user with role 1 and 2
  1071. def test_read_only_attribute_names_should_include_custom_fields_that_combine_readonly_and_not_visible_for_roles
  1072. field = IssueCustomField.generate!(
  1073. :is_for_all => true, :trackers => Tracker.all, :visible => false, :role_ids => [1]
  1074. )
  1075. WorkflowPermission.delete_all
  1076. WorkflowPermission.create!(
  1077. :old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => field.id, :rule => 'readonly'
  1078. )
  1079. user = User.generate!
  1080. project = Project.find(1)
  1081. User.add_to_project(user, project, Role.where(:id => [1, 2]))
  1082. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1083. assert_equal [field.id.to_s], issue.read_only_attribute_names(user)
  1084. end
  1085. def test_workflow_rules_should_ignore_roles_without_issue_permissions
  1086. role = Role.generate! :permissions => [:view_issues, :edit_issues]
  1087. ignored_role = Role.generate! :permissions => [:view_issues]
  1088. WorkflowPermission.delete_all
  1089. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1090. :role => role, :field_name => 'due_date',
  1091. :rule => 'required')
  1092. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1093. :role => role, :field_name => 'start_date',
  1094. :rule => 'readonly')
  1095. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1096. :role => role, :field_name => 'done_ratio',
  1097. :rule => 'readonly')
  1098. user = User.generate!
  1099. User.add_to_project user, Project.find(1), [role, ignored_role]
  1100. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1101. assert_equal %w(due_date), issue.required_attribute_names(user)
  1102. assert_equal %w(done_ratio start_date), issue.read_only_attribute_names(user).sort
  1103. end
  1104. def test_workflow_rules_should_work_for_member_with_duplicate_role
  1105. WorkflowPermission.delete_all
  1106. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1107. :role_id => 1, :field_name => 'due_date',
  1108. :rule => 'required')
  1109. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1110. :role_id => 1, :field_name => 'start_date',
  1111. :rule => 'readonly')
  1112. user = User.generate!
  1113. m = Member.new(:user_id => user.id, :project_id => 1)
  1114. m.member_roles.build(:role_id => 1)
  1115. m.member_roles.build(:role_id => 1)
  1116. m.save!
  1117. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1118. assert_equal %w(due_date), issue.required_attribute_names(user)
  1119. assert_equal %w(start_date), issue.read_only_attribute_names(user)
  1120. end
  1121. def test_copy
  1122. issue = Issue.new.copy_from(1)
  1123. assert issue.copy?
  1124. assert issue.save
  1125. issue.reload
  1126. orig = Issue.find(1)
  1127. assert_equal orig.subject, issue.subject
  1128. assert_equal orig.tracker, issue.tracker
  1129. assert_equal "125", issue.custom_value_for(2).value
  1130. end
  1131. def test_copy_to_another_project_should_clear_assignee_if_not_valid
  1132. issue = Issue.generate!(:project_id => 1, :assigned_to_id => 2)
  1133. project = Project.generate!
  1134. issue = Issue.new.copy_from(1)
  1135. issue.project = project
  1136. assert_nil issue.assigned_to
  1137. end
  1138. def test_copy_with_keep_status_should_copy_status
  1139. orig = Issue.find(8)
  1140. assert orig.status != orig.default_status
  1141. issue = Issue.new.copy_from(orig, :keep_status => true)
  1142. assert issue.save
  1143. issue.reload
  1144. assert_equal orig.status, issue.status
  1145. end
  1146. def test_copy_should_add_relation_with_copied_issue
  1147. copied = Issue.find(1)
  1148. issue = Issue.new.copy_from(copied)
  1149. assert issue.save
  1150. issue.reload
  1151. assert_equal 1, issue.relations.size
  1152. relation = issue.relations.first
  1153. assert_equal 'copied_to', relation.relation_type
  1154. assert_equal copied, relation.issue_from
  1155. assert_equal issue, relation.issue_to
  1156. end
  1157. def test_copy_should_copy_subtasks
  1158. issue = Issue.generate_with_descendants!
  1159. copy = issue.reload.copy
  1160. copy.author = User.find(7)
  1161. assert_difference 'Issue.count', 1+issue.descendants.count do
  1162. assert copy.save
  1163. end
  1164. copy.reload
  1165. assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
  1166. child_copy = copy.children.detect {|c| c.subject == 'Child1'}
  1167. assert_equal %w(Child11), child_copy.children.map(&:subject).sort
  1168. assert_equal copy.author, child_copy.author
  1169. end
  1170. def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
  1171. parent = Issue.generate!
  1172. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
  1173. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
  1174. copy = parent.reload.copy
  1175. copy.parent_issue_id = parent.id
  1176. copy.author = User.find(7)
  1177. assert_difference 'Issue.count', 3 do
  1178. assert copy.save
  1179. end
  1180. parent.reload
  1181. copy.reload
  1182. assert_equal parent, copy.parent
  1183. assert_equal 3, parent.children.count
  1184. assert_equal 5, parent.descendants.count
  1185. assert_equal 2, copy.children.count
  1186. assert_equal 2, copy.descendants.count
  1187. end
  1188. def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
  1189. parent = Issue.generate!
  1190. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
  1191. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
  1192. copy = parent.reload.copy
  1193. copy.parent_issue_id = child1.id
  1194. copy.author = User.find(7)
  1195. assert_difference 'Issue.count', 3 do
  1196. assert copy.save
  1197. end
  1198. parent.reload
  1199. child1.reload
  1200. copy.reload
  1201. assert_equal child1, copy.parent
  1202. assert_equal 2, parent.children.count
  1203. assert_equal 5, parent.descendants.count
  1204. assert_equal 1, child1.children.count
  1205. assert_equal 3, child1.descendants.count
  1206. assert_equal 2, copy.children.count
  1207. assert_equal 2, copy.descendants.count
  1208. end
  1209. def test_copy_should_copy_subtasks_to_target_project
  1210. issue = Issue.generate_with_descendants!
  1211. copy = issue.copy(:project_id => 3)
  1212. assert_difference 'Issue.count', 1+issue.descendants.count do
  1213. assert copy.save
  1214. end
  1215. assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
  1216. end
  1217. def test_copy_should_not_copy_subtasks_twice_when_saving_twice
  1218. issue = Issue.generate_with_descendants!
  1219. copy = issue.reload.copy
  1220. assert_difference 'Issue.count', 1+issue.descendants.count do
  1221. assert copy.save
  1222. assert copy.reload.save
  1223. end
  1224. end
  1225. def test_copy_should_clear_closed_on
  1226. copied_open = Issue.find(8).copy(:status_id => 1)
  1227. assert copied_open.save
  1228. assert_nil copied_open.closed_on
  1229. copied_closed = Issue.find(8).copy({}, :keep_status => 1)
  1230. assert copied_closed.save
  1231. assert_not_nil copied_closed.closed_on
  1232. end
  1233. def test_copy_should_not_copy_locked_watchers
  1234. user = User.find(2)
  1235. user2 = User.find(3)
  1236. issue = Issue.find(8)
  1237. Watcher.create!(:user => user, :watchable => issue)
  1238. Watcher.create!(:user => user2, :watchable => issue)
  1239. user2.status = User::STATUS_LOCKED
  1240. user2.save!
  1241. issue = Issue.new.copy_from(8)
  1242. assert issue.save
  1243. assert issue.watched_by?(user)
  1244. assert !issue.watched_by?(user2)
  1245. end
  1246. def test_copy_should_clear_subtasks_target_version_if_locked_or_closed
  1247. version = Version.new(:project => Project.find(1), :name => '2.1')
  1248. version.save!
  1249. parent = Issue.generate!
  1250. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1', :fixed_version_id => 3)
  1251. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2', :fixed_version_id => version.id)
  1252. version.status = 'locked'
  1253. version.save!
  1254. copy = parent.reload.copy
  1255. assert_difference 'Issue.count', 3 do
  1256. assert copy.save
  1257. end
  1258. assert_equal [3, nil], copy.children.map(&:fixed_version_id)
  1259. end
  1260. def test_copy_should_clear_subtasks_assignee_if_is_locked
  1261. user = User.find(2)
  1262. parent = Issue.generate!
  1263. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1', :assigned_to_id => 3)
  1264. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2', :assigned_to_id => user.id)
  1265. user.status = User::STATUS_LOCKED
  1266. user.save!
  1267. copy = parent.reload.copy
  1268. assert_difference 'Issue.count', 3 do
  1269. assert copy.save
  1270. end
  1271. assert_equal [3, nil], copy.children.map(&:assigned_to_id)
  1272. end
  1273. def test_copy_should_not_add_attachments_to_journal
  1274. set_tmp_attachments_directory
  1275. issue = Issue.generate!
  1276. copy = Issue.new
  1277. copy.init_journal User.find(1)
  1278. copy.copy_from issue
  1279. copy.project = issue.project
  1280. copy.save_attachments(
  1281. { 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')} }
  1282. )
  1283. assert copy.save
  1284. assert j = copy.journals.last
  1285. assert_equal 1, j.details.size
  1286. assert_equal 'relation', j.details[0].property
  1287. end
  1288. def test_should_not_call_after_project_change_on_creation
  1289. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  1290. :subject => 'Test', :author_id => 1)
  1291. issue.expects(:after_project_change).never
  1292. issue.save!
  1293. end
  1294. def test_should_not_call_after_project_change_on_update
  1295. issue = Issue.find(1)
  1296. issue.project = Project.find(1)
  1297. issue.subject = 'No project change'
  1298. issue.expects(:after_project_change).never
  1299. issue.save!
  1300. end
  1301. def test_should_call_after_project_change_on_project_change
  1302. issue = Issue.find(1)
  1303. issue.project = Project.find(2)
  1304. issue.expects(:after_project_change).once
  1305. issue.save!
  1306. end
  1307. def test_adding_journal_should_update_timestamp
  1308. issue = Issue.find(1)
  1309. updated_on_was = issue.updated_on
  1310. issue.init_journal(User.first, "Adding notes")
  1311. assert_difference 'Journal.count' do
  1312. assert issue.save
  1313. end
  1314. issue.reload
  1315. assert_not_equal updated_on_was, issue.updated_on
  1316. end
  1317. def test_should_close_duplicates
  1318. # Create 3 issues
  1319. issue1 = Issue.generate!
  1320. issue2 = Issue.generate!
  1321. issue3 = Issue.generate!
  1322. # 2 is a dupe of 1
  1323. IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
  1324. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1325. # And 3 is a dupe of 2
  1326. IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
  1327. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1328. # And 3 is a dupe of 1 (circular duplicates)
  1329. IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
  1330. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1331. assert issue1.reload.duplicates.include?(issue2)
  1332. # Closing issue 1
  1333. issue1.init_journal(User.first, "Closing issue1")
  1334. issue1.status = IssueStatus.where(:is_closed => true).first
  1335. assert issue1.save
  1336. # 2 and 3 should be also closed
  1337. assert issue2.reload.closed?
  1338. assert issue3.reload.closed?
  1339. end
  1340. def test_should_not_close_duplicate_when_disabled
  1341. issue = Issue.generate!
  1342. duplicate = Issue.generate!
  1343. IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
  1344. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1345. assert issue.reload.duplicates.include?(duplicate)
  1346. with_settings :close_duplicate_issues => '0' do
  1347. issue.init_journal(User.first, "Closing issue")
  1348. issue.status = IssueStatus.where(:is_closed => true).first
  1349. issue.save
  1350. end
  1351. assert !duplicate.reload.closed?
  1352. end
  1353. def test_should_close_duplicates_with_private_notes
  1354. issue = Issue.generate!
  1355. duplicate = Issue.generate!
  1356. IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
  1357. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1358. assert issue.reload.duplicates.include?(duplicate)
  1359. # Closing issue with private notes
  1360. issue.init_journal(User.first, "Private notes")
  1361. issue.private_notes = true
  1362. issue.status = IssueStatus.where(:is_closed => true).first
  1363. assert_save issue
  1364. duplicate.reload
  1365. assert journal = duplicate.journals.detect {|journal| journal.notes == "Private notes"}
  1366. assert_equal true, journal.private_notes
  1367. end
  1368. def test_should_not_close_duplicated_issue
  1369. issue1 = Issue.generate!
  1370. issue2 = Issue.generate!
  1371. # 2 is a dupe of 1
  1372. IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
  1373. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1374. # 2 is a dup of 1 but 1 is not a duplicate of 2
  1375. assert !issue2.reload.duplicates.include?(issue1)
  1376. # Closing issue 2
  1377. issue2.init_journal(User.first, "Closing issue2")
  1378. issue2.status = IssueStatus.where(:is_closed => true).first
  1379. assert issue2.save
  1380. # 1 should not be also closed
  1381. assert !issue1.reload.closed?
  1382. end
  1383. def test_assignable_versions
  1384. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1385. :status_id => 1, :fixed_version_id => 1,
  1386. :subject => 'New issue')
  1387. assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
  1388. end
  1389. def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
  1390. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1391. :status_id => 1, :fixed_version_id => 1,
  1392. :subject => 'New issue')
  1393. assert !issue.save
  1394. assert_not_equal [], issue.errors[:fixed_version_id]
  1395. end
  1396. def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
  1397. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1398. :status_id => 1, :fixed_version_id => 2,
  1399. :subject => 'New issue')
  1400. assert !issue.save
  1401. assert_not_equal [], issue.errors[:fixed_version_id]
  1402. end
  1403. def test_should_be_able_to_assign_a_new_issue_to_an_open_version
  1404. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1405. :status_id => 1, :fixed_version_id => 3,
  1406. :subject => 'New issue')
  1407. assert issue.save
  1408. end
  1409. def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
  1410. issue = Issue.find(11)
  1411. assert_equal 'closed', issue.fixed_version.status
  1412. issue.subject = 'Subject changed'
  1413. assert issue.save
  1414. end
  1415. def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
  1416. issue = Issue.find(11)
  1417. issue.status_id = 1
  1418. assert !issue.save
  1419. assert_not_equal [], issue.errors[:base]
  1420. end
  1421. def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
  1422. issue = Issue.find(11)
  1423. issue.status_id = 1
  1424. issue.fixed_version_id = 3
  1425. assert issue.save
  1426. end
  1427. def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
  1428. issue = Issue.find(12)
  1429. assert_equal 'locked', issue.fixed_version.status
  1430. issue.status_id = 1
  1431. assert issue.save
  1432. end
  1433. def test_should_not_be_able_to_keep_unshared_version_when_changing_project
  1434. issue = Issue.find(2)
  1435. assert_equal 2, issue.fixed_version_id
  1436. issue.project_id = 3
  1437. assert_nil issue.fixed_version_id
  1438. issue.fixed_version_id = 2
  1439. assert !issue.save
  1440. assert_include 'Target version is not included in the list', issue.errors.full_messages
  1441. end
  1442. def test_should_keep_shared_version_when_changing_project
  1443. Version.find(2).update! :sharing => 'tree'
  1444. issue = Issue.find(2)
  1445. assert_equal 2, issue.fixed_version_id
  1446. issue.project_id = 3
  1447. assert_equal 2, issue.fixed_version_id
  1448. assert issue.save
  1449. end
  1450. def test_allowed_target_projects_should_include_projects_with_issue_tracking_enabled
  1451. assert_include Project.find(2), Issue.allowed_target_projects(User.find(2))
  1452. end
  1453. def test_allowed_target_projects_should_not_include_projects_with_issue_tracking_disabled
  1454. Project.find(2).disable_module! :issue_tracking
  1455. assert_not_include Project.find(2), Issue.allowed_target_projects(User.find(2))
  1456. end
  1457. def test_allowed_target_projects_should_not_include_projects_without_trackers
  1458. project = Project.generate!(:tracker_ids => [])
  1459. assert project.trackers.empty?
  1460. assert_not_include project, Issue.allowed_target_projects(User.find(1))
  1461. end
  1462. def test_allowed_target_projects_for_subtask_should_not_include_invalid_projects
  1463. User.current = User.find(1)
  1464. issue = Issue.find(1)
  1465. issue.parent_id = 3
  1466. with_settings :cross_project_subtasks => 'tree' do
  1467. # Should include only the project tree
  1468. assert_equal [1, 3, 5], issue.allowed_target_projects_for_subtask.ids.sort
  1469. end
  1470. end
  1471. def test_allowed_target_trackers_with_one_role_allowed_on_all_trackers
  1472. user = User.generate!
  1473. role = Role.generate!
  1474. role.add_permission! :add_issues
  1475. role.set_permission_trackers :add_issues, :all
  1476. role.save!
  1477. User.add_to_project(user, Project.find(1), role)
  1478. assert_equal [1, 2, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1479. end
  1480. def test_allowed_target_trackers_with_one_role_allowed_on_some_trackers
  1481. user = User.generate!
  1482. role = Role.generate!
  1483. role.add_permission! :add_issues
  1484. role.set_permission_trackers :add_issues, [1, 3]
  1485. role.save!
  1486. User.add_to_project(user, Project.find(1), role)
  1487. assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1488. end
  1489. def test_allowed_target_trackers_with_two_roles_allowed_on_some_trackers
  1490. user = User.generate!
  1491. role1 = Role.generate!
  1492. role1.add_permission! :add_issues
  1493. role1.set_permission_trackers :add_issues, [1]
  1494. role1.save!
  1495. role2 = Role.generate!
  1496. role2.add_permission! :add_issues
  1497. role2.set_permission_trackers :add_issues, [3]
  1498. role2.save!
  1499. User.add_to_project(user, Project.find(1), [role1, role2])
  1500. assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1501. end
  1502. def test_allowed_target_trackers_with_two_roles_allowed_on_all_trackers_and_some_trackers
  1503. user = User.generate!
  1504. role1 = Role.generate!
  1505. role1.add_permission! :add_issues
  1506. role1.set_permission_trackers :add_issues, :all
  1507. role1.save!
  1508. role2 = Role.generate!
  1509. role2.add_permission! :add_issues
  1510. role2.set_permission_trackers :add_issues, [1, 3]
  1511. role2.save!
  1512. User.add_to_project(user, Project.find(1), [role1, role2])
  1513. assert_equal [1, 2, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1514. end
  1515. def test_allowed_target_trackers_should_not_consider_roles_without_add_issues_permission
  1516. user = User.generate!
  1517. role1 = Role.generate!
  1518. role1.remove_permission! :add_issues
  1519. role1.set_permission_trackers :add_issues, :all
  1520. role1.save!
  1521. role2 = Role.generate!
  1522. role2.add_permission! :add_issues
  1523. role2.set_permission_trackers :add_issues, [1, 3]
  1524. role2.save!
  1525. User.add_to_project(user, Project.find(1), [role1, role2])
  1526. assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1527. end
  1528. def test_allowed_target_trackers_without_project_should_be_empty
  1529. issue = Issue.new
  1530. assert_nil issue.project
  1531. assert_equal [], issue.allowed_target_trackers(User.find(2)).ids
  1532. end
  1533. def test_allowed_target_trackers_should_include_current_tracker
  1534. user = User.generate!
  1535. role = Role.generate!
  1536. role.add_permission! :add_issues
  1537. role.set_permission_trackers :add_issues, [3]
  1538. role.save!
  1539. User.add_to_project(user, Project.find(1), role)
  1540. issue = Issue.generate!(:project => Project.find(1), :tracker => Tracker.find(1))
  1541. assert_equal [1, 3], issue.allowed_target_trackers(user).ids.sort
  1542. end
  1543. def test_move_to_another_project_with_same_category
  1544. issue = Issue.find(1)
  1545. issue.project = Project.find(2)
  1546. assert issue.save
  1547. issue.reload
  1548. assert_equal 2, issue.project_id
  1549. # Category changes
  1550. assert_equal 4, issue.category_id
  1551. # Make sure time entries were move to the target project
  1552. assert_equal 2, issue.time_entries.first.project_id
  1553. end
  1554. def test_move_to_another_project_without_same_category
  1555. issue = Issue.find(2)
  1556. issue.project = Project.find(2)
  1557. assert issue.save
  1558. issue.reload
  1559. assert_equal 2, issue.project_id
  1560. # Category cleared
  1561. assert_nil issue.category_id
  1562. end
  1563. def test_move_to_another_project_should_clear_fixed_version_when_not_shared
  1564. issue = Issue.find(1)
  1565. issue.update!(:fixed_version_id => 3)
  1566. issue.project = Project.find(2)
  1567. assert issue.save
  1568. issue.reload
  1569. assert_equal 2, issue.project_id
  1570. # Cleared fixed_version
  1571. assert_nil issue.fixed_version
  1572. end
  1573. def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
  1574. issue = Issue.find(1)
  1575. issue.update!(:fixed_version_id => 4)
  1576. issue.project = Project.find(5)
  1577. assert issue.save
  1578. issue.reload
  1579. assert_equal 5, issue.project_id
  1580. # Keep fixed_version
  1581. assert_equal 4, issue.fixed_version_id
  1582. end
  1583. def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
  1584. issue = Issue.find(1)
  1585. issue.update!(:fixed_version_id => 3)
  1586. issue.project = Project.find(5)
  1587. assert issue.save
  1588. issue.reload
  1589. assert_equal 5, issue.project_id
  1590. # Cleared fixed_version
  1591. assert_nil issue.fixed_version
  1592. end
  1593. def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
  1594. issue = Issue.find(1)
  1595. issue.update!(:fixed_version_id => 7)
  1596. issue.project = Project.find(2)
  1597. assert issue.save
  1598. issue.reload
  1599. assert_equal 2, issue.project_id
  1600. # Keep fixed_version
  1601. assert_equal 7, issue.fixed_version_id
  1602. end
  1603. def test_move_to_another_project_should_keep_parent_if_valid
  1604. issue = Issue.find(1)
  1605. issue.update! :parent_issue_id => 2
  1606. issue.project = Project.find(3)
  1607. assert issue.save
  1608. issue.reload
  1609. assert_equal 2, issue.parent_id
  1610. end
  1611. def test_move_to_another_project_should_clear_parent_if_not_valid
  1612. issue = Issue.find(1)
  1613. issue.update! :parent_issue_id => 2
  1614. issue.project = Project.find(2)
  1615. assert issue.save
  1616. issue.reload
  1617. assert_nil issue.parent_id
  1618. end
  1619. def test_move_to_another_project_with_disabled_tracker
  1620. issue = Issue.find(1)
  1621. target = Project.find(2)
  1622. target.tracker_ids = [3]
  1623. target.save
  1624. issue.project = target
  1625. assert issue.save
  1626. issue.reload
  1627. assert_equal 2, issue.project_id
  1628. assert_equal 3, issue.tracker_id
  1629. end
  1630. def test_move_to_another_project_should_set_error_message_on_child_failure
  1631. parent = Issue.generate!
  1632. child = Issue.generate!(:parent_issue_id => parent.id, :tracker_id => 2)
  1633. project = Project.generate!(:tracker_ids => [1])
  1634. parent.reload
  1635. parent.project_id = project.id
  1636. assert !parent.save
  1637. assert_include(
  1638. "Subtask ##{child.id} could not be moved to the new project: Tracker is not included in the list",
  1639. parent.errors[:base])
  1640. end
  1641. def test_copy_to_the_same_project
  1642. issue = Issue.find(1)
  1643. copy = issue.copy
  1644. assert_difference 'Issue.count' do
  1645. copy.save!
  1646. end
  1647. assert_kind_of Issue, copy
  1648. assert_equal issue.project, copy.project
  1649. assert_equal "125", copy.custom_value_for(2).value
  1650. end
  1651. def test_copy_to_another_project_and_tracker
  1652. issue = Issue.find(1)
  1653. copy = issue.copy(:project_id => 3, :tracker_id => 2)
  1654. assert_difference 'Issue.count' do
  1655. copy.save!
  1656. end
  1657. copy.reload
  1658. assert_kind_of Issue, copy
  1659. assert_equal Project.find(3), copy.project
  1660. assert_equal Tracker.find(2), copy.tracker
  1661. # Custom field #2 is not associated with target tracker
  1662. assert_nil copy.custom_value_for(2)
  1663. end
  1664. test "#copy should not create a journal" do
  1665. copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2}, :link => false)
  1666. copy.save!
  1667. assert_equal 0, copy.reload.journals.size
  1668. end
  1669. test "#copy should allow assigned_to changes" do
  1670. user = User.generate!
  1671. Member.create!(:project_id => 3, :principal => user, :role_ids => [1])
  1672. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => user.id)
  1673. assert_equal user.id, copy.assigned_to_id
  1674. end
  1675. test "#copy should allow status changes" do
  1676. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
  1677. assert_equal 2, copy.status_id
  1678. end
  1679. test "#copy should allow start date changes" do
  1680. date = Date.today
  1681. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
  1682. assert_equal date, copy.start_date
  1683. end
  1684. test "#copy should allow due date changes" do
  1685. date = Date.today
  1686. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
  1687. assert_equal date, copy.due_date
  1688. end
  1689. test "#copy should set current user as author" do
  1690. User.current = User.find(9)
  1691. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
  1692. assert_equal User.current, copy.author
  1693. end
  1694. test "#copy should create a journal with notes" do
  1695. date = Date.today
  1696. notes = "Notes added when copying"
  1697. copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :start_date => date}, :link => false)
  1698. copy.init_journal(User.current, notes)
  1699. copy.save!
  1700. assert_equal 1, copy.journals.size
  1701. journal = copy.journals.first
  1702. assert_equal 0, journal.details.size
  1703. assert_equal notes, journal.notes
  1704. end
  1705. def test_valid_parent_project
  1706. issue = Issue.find(1)
  1707. issue_in_same_project = Issue.find(2)
  1708. issue_in_child_project = Issue.find(5)
  1709. issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
  1710. issue_in_other_child_project = Issue.find(6)
  1711. issue_in_different_tree = Issue.find(4)
  1712. with_settings :cross_project_subtasks => '' do
  1713. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1714. assert_equal false, issue.valid_parent_project?(issue_in_child_project)
  1715. assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
  1716. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1717. end
  1718. with_settings :cross_project_subtasks => 'system' do
  1719. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1720. assert_equal true, issue.valid_parent_project?(issue_in_child_project)
  1721. assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
  1722. end
  1723. with_settings :cross_project_subtasks => 'tree' do
  1724. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1725. assert_equal true, issue.valid_parent_project?(issue_in_child_project)
  1726. assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
  1727. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1728. assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
  1729. assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
  1730. end
  1731. with_settings :cross_project_subtasks => 'descendants' do
  1732. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1733. assert_equal false, issue.valid_parent_project?(issue_in_child_project)
  1734. assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
  1735. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1736. assert_equal true, issue_in_child_project.valid_parent_project?(issue)
  1737. assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
  1738. end
  1739. end
  1740. def test_recipients_should_include_previous_assignee
  1741. user = User.find(3)
  1742. user.members.update_all ["mail_notification = ?", false]
  1743. user.update! :mail_notification => 'only_assigned'
  1744. issue = Issue.find(2)
  1745. issue.assigned_to = nil
  1746. assert_include user.mail, issue.recipients
  1747. issue.save!
  1748. assert_include user.mail, issue.recipients
  1749. issue.assigned_to = User.find(2)
  1750. issue.save!
  1751. assert !issue.recipients.include?(user.mail)
  1752. end
  1753. def test_recipients_should_not_include_users_that_cannot_view_the_issue
  1754. issue = Issue.find(12)
  1755. assert issue.recipients.include?(issue.author.mail)
  1756. # copy the issue to a private project
  1757. copy = issue.copy(:project_id => 5, :tracker_id => 2)
  1758. # author is not a member of project anymore
  1759. assert !copy.recipients.include?(copy.author.mail)
  1760. end
  1761. def test_recipients_should_include_the_assigned_group_members
  1762. group_member = User.generate!
  1763. group = Group.generate!
  1764. group.users << group_member
  1765. issue = Issue.find(12)
  1766. issue.assigned_to = group
  1767. assert issue.recipients.include?(group_member.mail)
  1768. end
  1769. def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
  1770. user = User.find(3)
  1771. issue = Issue.find(9)
  1772. Watcher.create!(:user => user, :watchable => issue)
  1773. assert issue.watched_by?(user)
  1774. assert !issue.watcher_recipients.include?(user.mail)
  1775. end
  1776. def test_issue_destroy
  1777. Issue.find(1).destroy
  1778. assert_nil Issue.find_by_id(1)
  1779. assert_nil TimeEntry.find_by_issue_id(1)
  1780. end
  1781. def test_destroy_should_delete_time_entries_custom_values
  1782. issue = Issue.generate!
  1783. time_entry = TimeEntry.generate!(:issue => issue, :custom_field_values => {10 => '1'})
  1784. assert_difference 'CustomValue.where(:customized_type => "TimeEntry").count', -1 do
  1785. assert issue.destroy
  1786. end
  1787. end
  1788. def test_destroying_a_deleted_issue_should_not_raise_an_error
  1789. issue = Issue.find(1)
  1790. Issue.find(1).destroy
  1791. assert_nothing_raised do
  1792. assert_no_difference 'Issue.count' do
  1793. issue.destroy
  1794. end
  1795. assert issue.destroyed?
  1796. end
  1797. end
  1798. def test_destroying_a_stale_issue_should_not_raise_an_error
  1799. issue = Issue.find(1)
  1800. Issue.find(1).update! :subject => "Updated"
  1801. assert_nothing_raised do
  1802. assert_difference 'Issue.count', -1 do
  1803. issue.destroy
  1804. end
  1805. assert issue.destroyed?
  1806. end
  1807. end
  1808. def test_blocked
  1809. blocked_issue = Issue.find(9)
  1810. blocking_issue = Issue.find(10)
  1811. assert blocked_issue.blocked?
  1812. assert !blocking_issue.blocked?
  1813. end
  1814. def test_blocked_issues_dont_allow_closed_statuses
  1815. blocked_issue = Issue.find(9)
  1816. allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
  1817. assert !allowed_statuses.empty?
  1818. closed_statuses = allowed_statuses.select {|st| st.is_closed?}
  1819. assert closed_statuses.empty?
  1820. end
  1821. def test_unblocked_issues_allow_closed_statuses
  1822. blocking_issue = Issue.find(10)
  1823. allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
  1824. assert !allowed_statuses.empty?
  1825. closed_statuses = allowed_statuses.select {|st| st.is_closed?}
  1826. assert !closed_statuses.empty?
  1827. end
  1828. def test_parent_issues_with_open_subtask_dont_allow_closed_statuses
  1829. parent = Issue.generate!
  1830. child = Issue.generate!(:parent_issue_id => parent.id)
  1831. allowed_statuses = parent.reload.new_statuses_allowed_to(users(:users_002))
  1832. assert !parent.closable?
  1833. assert_equal l(:notice_issue_not_closable_by_open_tasks), parent.transition_warning
  1834. assert allowed_statuses.any?
  1835. assert_equal [], allowed_statuses.select(&:is_closed?)
  1836. end
  1837. def test_parent_issues_with_closed_subtask_allow_closed_statuses
  1838. parent = Issue.generate!
  1839. child = Issue.generate!(:parent_issue_id => parent.id, :status_id => 5)
  1840. allowed_statuses = parent.reload.new_statuses_allowed_to(users(:users_002))
  1841. assert parent.closable?
  1842. assert_nil parent.transition_warning
  1843. assert allowed_statuses.any?
  1844. assert allowed_statuses.select(&:is_closed?).any?
  1845. end
  1846. def test_reschedule_an_issue_without_dates
  1847. with_settings :non_working_week_days => [] do
  1848. issue = Issue.new(:start_date => nil, :due_date => nil)
  1849. issue.reschedule_on '2012-10-09'.to_date
  1850. assert_equal '2012-10-09'.to_date, issue.start_date
  1851. assert_equal '2012-10-09'.to_date, issue.due_date
  1852. end
  1853. with_settings :non_working_week_days => %w(6 7) do
  1854. issue = Issue.new(:start_date => nil, :due_date => nil)
  1855. issue.reschedule_on '2012-10-09'.to_date
  1856. assert_equal '2012-10-09'.to_date, issue.start_date
  1857. assert_equal '2012-10-09'.to_date, issue.due_date
  1858. issue = Issue.new(:start_date => nil, :due_date => nil)
  1859. issue.reschedule_on '2012-10-13'.to_date
  1860. assert_equal '2012-10-15'.to_date, issue.start_date
  1861. assert_equal '2012-10-15'.to_date, issue.due_date
  1862. end
  1863. end
  1864. def test_reschedule_an_issue_with_start_date
  1865. with_settings :non_working_week_days => [] do
  1866. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1867. issue.reschedule_on '2012-10-13'.to_date
  1868. assert_equal '2012-10-13'.to_date, issue.start_date
  1869. assert_equal '2012-10-13'.to_date, issue.due_date
  1870. end
  1871. with_settings :non_working_week_days => %w(6 7) do
  1872. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1873. issue.reschedule_on '2012-10-11'.to_date
  1874. assert_equal '2012-10-11'.to_date, issue.start_date
  1875. assert_equal '2012-10-11'.to_date, issue.due_date
  1876. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1877. issue.reschedule_on '2012-10-13'.to_date
  1878. assert_equal '2012-10-15'.to_date, issue.start_date
  1879. assert_equal '2012-10-15'.to_date, issue.due_date
  1880. end
  1881. end
  1882. def test_reschedule_an_issue_with_start_and_due_dates
  1883. with_settings :non_working_week_days => [] do
  1884. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
  1885. issue.reschedule_on '2012-10-13'.to_date
  1886. assert_equal '2012-10-13'.to_date, issue.start_date
  1887. assert_equal '2012-10-19'.to_date, issue.due_date
  1888. end
  1889. with_settings :non_working_week_days => %w(6 7) do
  1890. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
  1891. issue.reschedule_on '2012-10-11'.to_date
  1892. assert_equal '2012-10-11'.to_date, issue.start_date
  1893. assert_equal '2012-10-23'.to_date, issue.due_date
  1894. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
  1895. issue.reschedule_on '2012-10-13'.to_date
  1896. assert_equal '2012-10-15'.to_date, issue.start_date
  1897. assert_equal '2012-10-25'.to_date, issue.due_date
  1898. end
  1899. end
  1900. def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
  1901. with_settings :non_working_week_days => [] do
  1902. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1903. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1904. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1905. :relation_type => IssueRelation::TYPE_PRECEDES)
  1906. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1907. issue1.reload
  1908. issue1.due_date = '2012-10-23'
  1909. issue1.save!
  1910. issue2.reload
  1911. assert_equal Date.parse('2012-10-24'), issue2.start_date
  1912. assert_equal Date.parse('2012-10-26'), issue2.due_date
  1913. end
  1914. # The delay should honor non-working week days
  1915. with_settings :non_working_week_days => %w(6 7) do
  1916. issue1 = Issue.generate!(:start_date => '2014-03-10', :due_date => '2014-03-12')
  1917. issue2 = Issue.generate!(:start_date => '2014-03-10', :due_date => '2014-03-12')
  1918. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1919. :relation_type => IssueRelation::TYPE_PRECEDES,
  1920. :delay => 8)
  1921. assert_equal Date.parse('2014-03-25'), issue2.reload.start_date
  1922. end
  1923. end
  1924. def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
  1925. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1926. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1927. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1928. :relation_type => IssueRelation::TYPE_PRECEDES)
  1929. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1930. issue1.reload
  1931. issue1.start_date = '2012-09-17'
  1932. issue1.due_date = '2012-09-18'
  1933. issue1.save!
  1934. issue2.reload
  1935. assert_equal Date.parse('2012-09-19'), issue2.start_date
  1936. assert_equal Date.parse('2012-09-21'), issue2.due_date
  1937. end
  1938. def test_rescheduling_an_issue_to_a_different_due_date_should_add_journal_to_following_issue
  1939. with_settings :non_working_week_days => [] do
  1940. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1941. issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
  1942. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1943. :relation_type => IssueRelation::TYPE_PRECEDES)
  1944. assert_difference 'issue2.journals.count' do
  1945. issue1.reload
  1946. issue1.init_journal(User.find(3))
  1947. issue1.due_date = '2012-10-23'
  1948. issue1.save!
  1949. end
  1950. journal = issue2.journals.order(:id).last
  1951. start_date_detail = journal.details.find_by(:prop_key => 'start_date')
  1952. assert_equal '2012-10-18', start_date_detail.old_value
  1953. assert_equal '2012-10-24', start_date_detail.value
  1954. due_date_detail = journal.details.find_by(:prop_key => 'due_date')
  1955. assert_equal '2012-10-20', due_date_detail.old_value
  1956. assert_equal '2012-10-26', due_date_detail.value
  1957. end
  1958. end
  1959. def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
  1960. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1961. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1962. issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
  1963. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1964. :relation_type => IssueRelation::TYPE_PRECEDES)
  1965. IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
  1966. :relation_type => IssueRelation::TYPE_PRECEDES)
  1967. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1968. issue1.reload
  1969. issue1.start_date = '2012-09-17'
  1970. issue1.due_date = '2012-09-18'
  1971. issue1.save!
  1972. issue2.reload
  1973. # Issue 2 must start after Issue 3
  1974. assert_equal Date.parse('2012-10-03'), issue2.start_date
  1975. assert_equal Date.parse('2012-10-05'), issue2.due_date
  1976. end
  1977. def test_rescheduling_a_stale_issue_should_not_raise_an_error
  1978. with_settings :non_working_week_days => [] do
  1979. stale = Issue.find(1)
  1980. issue = Issue.find(1)
  1981. issue.subject = "Updated"
  1982. issue.save!
  1983. date = 10.days.from_now.to_date
  1984. assert_nothing_raised do
  1985. stale.reschedule_on!(date)
  1986. end
  1987. assert_equal date, stale.reload.start_date
  1988. end
  1989. end
  1990. def test_child_issue_should_consider_parent_soonest_start_on_create
  1991. set_language_if_valid 'en'
  1992. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1993. issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
  1994. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1995. :relation_type => IssueRelation::TYPE_PRECEDES)
  1996. issue1.reload
  1997. issue2.reload
  1998. assert_equal Date.parse('2012-10-18'), issue2.start_date
  1999. with_settings :date_format => '%m/%d/%Y' do
  2000. child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
  2001. :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
  2002. assert !child.valid?
  2003. assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
  2004. assert_equal Date.parse('2012-10-18'), child.soonest_start
  2005. child.start_date = '2012-10-18'
  2006. assert child.save
  2007. end
  2008. end
  2009. def test_setting_parent_to_a_an_issue_that_precedes_should_not_validate
  2010. # tests that 3 cannot have 1 as parent:
  2011. #
  2012. # 1 -> 2 -> 3
  2013. #
  2014. set_language_if_valid 'en'
  2015. issue1 = Issue.generate!
  2016. issue2 = Issue.generate!
  2017. issue3 = Issue.generate!
  2018. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  2019. IssueRelation.create!(:issue_from => issue2, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
  2020. issue3.reload
  2021. issue3.parent_issue_id = issue1.id
  2022. assert !issue3.valid?
  2023. assert_include 'Parent task is invalid', issue3.errors.full_messages
  2024. end
  2025. def test_setting_parent_to_a_an_issue_that_follows_should_not_validate
  2026. # tests that 1 cannot have 3 as parent:
  2027. #
  2028. # 1 -> 2 -> 3
  2029. #
  2030. set_language_if_valid 'en'
  2031. issue1 = Issue.generate!
  2032. issue2 = Issue.generate!
  2033. issue3 = Issue.generate!
  2034. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  2035. IssueRelation.create!(:issue_from => issue2, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
  2036. issue1.reload
  2037. issue1.parent_issue_id = issue3.id
  2038. assert !issue1.valid?
  2039. assert_include 'Parent task is invalid', issue1.errors.full_messages
  2040. end
  2041. def test_setting_parent_to_a_an_issue_that_precedes_through_hierarchy_should_not_validate
  2042. # tests that 4 cannot have 1 as parent:
  2043. # changing the due date of 4 would update the end date of 1 which would reschedule 2
  2044. # which would change the end date of 3 which would reschedule 4 and so on...
  2045. #
  2046. # 3 -> 4
  2047. # ^
  2048. # 1 -> 2
  2049. #
  2050. set_language_if_valid 'en'
  2051. issue1 = Issue.generate!
  2052. issue2 = Issue.generate!
  2053. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  2054. issue3 = Issue.generate!
  2055. issue2.reload
  2056. issue2.parent_issue_id = issue3.id
  2057. issue2.save!
  2058. issue4 = Issue.generate!
  2059. IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
  2060. issue4.reload
  2061. issue4.parent_issue_id = issue1.id
  2062. assert !issue4.valid?
  2063. assert_include 'Parent task is invalid', issue4.errors.full_messages
  2064. end
  2065. def test_issue_and_following_issue_should_be_able_to_be_moved_to_the_same_parent
  2066. set_language_if_valid 'en'
  2067. issue1 = Issue.generate!
  2068. issue2 = Issue.generate!
  2069. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_FOLLOWS)
  2070. parent = Issue.generate!
  2071. issue1.reload.parent_issue_id = parent.id
  2072. assert_save issue1
  2073. parent.reload
  2074. issue2.reload.parent_issue_id = parent.id
  2075. assert_save issue2
  2076. assert IssueRelation.exists?(relation.id)
  2077. end
  2078. def test_issue_and_preceding_issue_should_be_able_to_be_moved_to_the_same_parent
  2079. set_language_if_valid 'en'
  2080. issue1 = Issue.generate!
  2081. issue2 = Issue.generate!
  2082. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
  2083. parent = Issue.generate!
  2084. issue1.reload.parent_issue_id = parent.id
  2085. assert_save issue1
  2086. parent.reload
  2087. issue2.reload.parent_issue_id = parent.id
  2088. assert_save issue2
  2089. assert IssueRelation.exists?(relation.id)
  2090. end
  2091. def test_issue_and_blocked_issue_should_be_able_to_be_moved_to_the_same_parent
  2092. set_language_if_valid 'en'
  2093. issue1 = Issue.generate!
  2094. issue2 = Issue.generate!
  2095. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_BLOCKED)
  2096. parent = Issue.generate!
  2097. issue1.reload.parent_issue_id = parent.id
  2098. assert_save issue1
  2099. parent.reload
  2100. issue2.reload.parent_issue_id = parent.id
  2101. assert_save issue2
  2102. assert IssueRelation.exists?(relation.id)
  2103. end
  2104. def test_issue_and_blocking_issue_should_be_able_to_be_moved_to_the_same_parent
  2105. set_language_if_valid 'en'
  2106. issue1 = Issue.generate!
  2107. issue2 = Issue.generate!
  2108. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_BLOCKS)
  2109. parent = Issue.generate!
  2110. issue1.reload.parent_issue_id = parent.id
  2111. assert_save issue1
  2112. parent.reload
  2113. issue2.reload.parent_issue_id = parent.id
  2114. assert_save issue2
  2115. assert IssueRelation.exists?(relation.id)
  2116. end
  2117. def test_issue_copy_should_be_able_to_be_moved_to_the_same_parent_as_copied_issue
  2118. issue = Issue.generate!
  2119. parent = Issue.generate!
  2120. issue.parent_issue_id = parent.id
  2121. issue.save!
  2122. issue.reload
  2123. copy = Issue.new.copy_from(issue, :link => true)
  2124. relation = new_record(IssueRelation) do
  2125. copy.save!
  2126. end
  2127. copy.reload
  2128. copy.parent_issue_id = parent.id
  2129. assert_save copy
  2130. assert IssueRelation.exists?(relation.id)
  2131. end
  2132. def test_overdue
  2133. User.current = nil
  2134. today = User.current.today
  2135. assert Issue.new(:due_date => (today - 1.day).to_date).overdue?
  2136. assert !Issue.new(:due_date => today).overdue?
  2137. assert !Issue.new(:due_date => (today + 1.day).to_date).overdue?
  2138. assert !Issue.new(:due_date => nil).overdue?
  2139. assert !Issue.
  2140. new(
  2141. :due_date => (today - 1.day).to_date,
  2142. :status => IssueStatus.where(:is_closed => true).first
  2143. ).overdue?
  2144. end
  2145. test "#behind_schedule? should be false if the issue has no start_date" do
  2146. assert !Issue.new(:start_date => nil,
  2147. :due_date => 1.day.from_now.to_date,
  2148. :done_ratio => 0).behind_schedule?
  2149. end
  2150. test "#behind_schedule? should be false if the issue has no end_date" do
  2151. assert !Issue.new(:start_date => 1.day.from_now.to_date,
  2152. :due_date => nil,
  2153. :done_ratio => 0).behind_schedule?
  2154. end
  2155. test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
  2156. assert !Issue.new(:start_date => 50.days.ago.to_date,
  2157. :due_date => 50.days.from_now.to_date,
  2158. :done_ratio => 90).behind_schedule?
  2159. end
  2160. test "#behind_schedule? should be true if the issue hasn't been started at all" do
  2161. assert Issue.new(:start_date => 1.day.ago.to_date,
  2162. :due_date => 1.day.from_now.to_date,
  2163. :done_ratio => 0).behind_schedule?
  2164. end
  2165. test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
  2166. assert Issue.new(:start_date => 100.days.ago.to_date,
  2167. :due_date => Date.today,
  2168. :done_ratio => 90).behind_schedule?
  2169. end
  2170. test "#assignable_users should be Users" do
  2171. assert_kind_of User, Issue.find(1).assignable_users.first
  2172. end
  2173. test "#assignable_users should include the issue author" do
  2174. non_project_member = User.generate!
  2175. issue = Issue.generate!(:author => non_project_member)
  2176. assert issue.assignable_users.include?(non_project_member)
  2177. end
  2178. def test_assignable_users_should_not_include_anonymous_user
  2179. issue = Issue.generate!(:author => User.anonymous)
  2180. assert !issue.assignable_users.include?(User.anonymous)
  2181. end
  2182. def test_assignable_users_should_not_include_locked_user
  2183. user = User.generate!
  2184. issue = Issue.generate!(:author => user)
  2185. user.lock!
  2186. assert !issue.assignable_users.include?(user)
  2187. end
  2188. def test_assignable_users_should_include_the_current_assignee
  2189. user = User.generate!
  2190. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2191. issue = Issue.generate!(:assigned_to => user)
  2192. user.lock!
  2193. assert Issue.find(issue.id).assignable_users.include?(user)
  2194. end
  2195. test "#assignable_users should not show the issue author twice" do
  2196. assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
  2197. assert_equal 2, assignable_user_ids.length
  2198. assignable_user_ids.each do |user_id|
  2199. assert_equal 1, assignable_user_ids.count {|i| i == user_id},
  2200. "User #{user_id} appears more or less than once"
  2201. end
  2202. end
  2203. test "#assignable_users with issue_group_assignment should include groups" do
  2204. issue = Issue.new(:project => Project.find(2))
  2205. with_settings :issue_group_assignment => '1' do
  2206. assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
  2207. assert issue.assignable_users.include?(Group.find(11))
  2208. end
  2209. end
  2210. test "#assignable_users without issue_group_assignment should not include groups" do
  2211. issue = Issue.new(:project => Project.find(2))
  2212. with_settings :issue_group_assignment => '0' do
  2213. assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
  2214. assert !issue.assignable_users.include?(Group.find(11))
  2215. end
  2216. end
  2217. def test_assignable_users_should_not_include_builtin_groups
  2218. Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [1])
  2219. Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [1])
  2220. issue = Issue.new(:project => Project.find(1))
  2221. with_settings :issue_group_assignment => '1' do
  2222. assert_nil issue.assignable_users.detect {|u| u.is_a?(GroupBuiltin)}
  2223. end
  2224. end
  2225. def test_assignable_users_should_not_include_users_that_cannot_view_the_tracker
  2226. user = User.find(3)
  2227. role = Role.find(2)
  2228. role.set_permission_trackers :view_issues, [1, 3]
  2229. role.save!
  2230. issue1 = Issue.new(:project_id => 1, :tracker_id => 1)
  2231. issue2 = Issue.new(:project_id => 1, :tracker_id => 2)
  2232. assert_include user, issue1.assignable_users
  2233. assert_not_include user, issue2.assignable_users
  2234. end
  2235. def test_create_should_send_email_notification
  2236. ActionMailer::Base.deliveries.clear
  2237. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  2238. :author_id => 3, :status_id => 1,
  2239. :priority => IssuePriority.all.first,
  2240. :subject => 'test_create', :estimated_hours => '1:30')
  2241. with_settings :notified_events => %w(issue_added) do
  2242. assert issue.save
  2243. assert_equal 2, ActionMailer::Base.deliveries.size
  2244. end
  2245. end
  2246. def test_create_should_send_one_email_notification_with_both_settings
  2247. ActionMailer::Base.deliveries.clear
  2248. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  2249. :author_id => 3, :status_id => 1,
  2250. :priority => IssuePriority.all.first,
  2251. :subject => 'test_create', :estimated_hours => '1:30')
  2252. with_settings :notified_events => %w(issue_added issue_updated) do
  2253. assert issue.save
  2254. assert_equal 2, ActionMailer::Base.deliveries.size
  2255. end
  2256. end
  2257. def test_create_should_not_send_email_notification_with_no_setting
  2258. ActionMailer::Base.deliveries.clear
  2259. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  2260. :author_id => 3, :status_id => 1,
  2261. :priority => IssuePriority.all.first,
  2262. :subject => 'test_create', :estimated_hours => '1:30')
  2263. with_settings :notified_events => [] do
  2264. assert issue.save
  2265. assert_equal 0, ActionMailer::Base.deliveries.size
  2266. end
  2267. end
  2268. def test_update_should_notify_previous_assignee
  2269. ActionMailer::Base.deliveries.clear
  2270. user = User.find(3)
  2271. user.members.update_all ["mail_notification = ?", false]
  2272. user.update! :mail_notification => 'only_assigned'
  2273. with_settings :notified_events => %w(issue_updated) do
  2274. issue = Issue.find(2)
  2275. issue.init_journal User.find(1)
  2276. issue.assigned_to = nil
  2277. issue.save!
  2278. assert_include [user.mail], ActionMailer::Base.deliveries.map(&:to)
  2279. end
  2280. end
  2281. def test_stale_issue_should_not_send_email_notification
  2282. ActionMailer::Base.deliveries.clear
  2283. issue = Issue.find(1)
  2284. stale = Issue.find(1)
  2285. issue.init_journal(User.find(1))
  2286. issue.subject = 'Subjet update'
  2287. with_settings :notified_events => %w(issue_updated) do
  2288. assert issue.save
  2289. assert_equal 2, ActionMailer::Base.deliveries.size
  2290. ActionMailer::Base.deliveries.clear
  2291. stale.init_journal(User.find(1))
  2292. stale.subject = 'Another subjet update'
  2293. assert_raise ActiveRecord::StaleObjectError do
  2294. stale.save
  2295. end
  2296. assert ActionMailer::Base.deliveries.empty?
  2297. end
  2298. end
  2299. def test_journalized_description
  2300. IssueCustomField.delete_all
  2301. i = Issue.first
  2302. old_description = i.description
  2303. new_description = "This is the new description"
  2304. i.init_journal(User.find(2))
  2305. i.description = new_description
  2306. assert_difference 'Journal.count', 1 do
  2307. assert_difference 'JournalDetail.count', 1 do
  2308. i.save!
  2309. end
  2310. end
  2311. detail = JournalDetail.order('id DESC').first
  2312. assert_equal i, detail.journal.journalized
  2313. assert_equal 'attr', detail.property
  2314. assert_equal 'description', detail.prop_key
  2315. assert_equal old_description, detail.old_value
  2316. assert_equal new_description, detail.value
  2317. end
  2318. def test_blank_descriptions_should_not_be_journalized
  2319. IssueCustomField.delete_all
  2320. Issue.where(:id => 1).update_all("description = NULL")
  2321. i = Issue.find(1)
  2322. i.init_journal(User.find(2))
  2323. i.subject = "blank description"
  2324. i.description = "\r\n"
  2325. assert_difference 'Journal.count', 1 do
  2326. assert_difference 'JournalDetail.count', 1 do
  2327. i.save!
  2328. end
  2329. end
  2330. end
  2331. def test_journalized_multi_custom_field
  2332. field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
  2333. :is_filter => true, :is_for_all => true,
  2334. :tracker_ids => [1],
  2335. :possible_values => ['value1', 'value2', 'value3'],
  2336. :multiple => true)
  2337. issue = Issue.generate!(:project_id => 1, :tracker_id => 1,
  2338. :subject => 'Test', :author_id => 1)
  2339. assert_difference 'Journal.count' do
  2340. assert_difference 'JournalDetail.count' do
  2341. issue.init_journal(User.first)
  2342. issue.custom_field_values = {field.id => ['value1']}
  2343. issue.save!
  2344. end
  2345. assert_difference 'JournalDetail.count' do
  2346. issue.init_journal(User.first)
  2347. issue.custom_field_values = {field.id => ['value1', 'value2']}
  2348. issue.save!
  2349. end
  2350. assert_difference 'JournalDetail.count', 2 do
  2351. issue.init_journal(User.first)
  2352. issue.custom_field_values = {field.id => ['value3', 'value2']}
  2353. issue.save!
  2354. end
  2355. assert_difference 'JournalDetail.count', 2 do
  2356. issue.init_journal(User.first)
  2357. issue.custom_field_values = {field.id => nil}
  2358. issue.save!
  2359. end
  2360. end
  2361. end
  2362. def test_custom_value_cleared_on_tracker_change_should_be_journalized
  2363. a = IssueCustomField.generate!(:tracker_ids => [1])
  2364. issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {a.id.to_s => "foo"})
  2365. assert_equal "foo", issue.custom_field_value(a)
  2366. journal = new_record(Journal) do
  2367. issue.init_journal(User.first)
  2368. issue.tracker_id = 2
  2369. issue.save!
  2370. end
  2371. details = journal.details.select {|d| d.property == 'cf' && d.prop_key == a.id.to_s}
  2372. assert_equal 1, details.size
  2373. assert_equal 'foo', details.first.old_value
  2374. assert_nil details.first.value
  2375. end
  2376. def test_description_eol_should_be_normalized
  2377. i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
  2378. assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
  2379. end
  2380. def test_saving_twice_should_not_duplicate_journal_details
  2381. i = Issue.first
  2382. i.init_journal(User.find(2), 'Some notes')
  2383. # initial changes
  2384. i.subject = 'New subject'
  2385. i.done_ratio = i.done_ratio + 10
  2386. assert_difference 'Journal.count' do
  2387. assert i.save
  2388. end
  2389. # 1 more change
  2390. i.priority = IssuePriority.where("id <> ?", i.priority_id).first
  2391. assert_no_difference 'Journal.count' do
  2392. assert_difference 'JournalDetail.count', 1 do
  2393. i.save
  2394. end
  2395. end
  2396. # no more change
  2397. assert_no_difference 'Journal.count' do
  2398. assert_no_difference 'JournalDetail.count' do
  2399. i.save
  2400. end
  2401. end
  2402. end
  2403. test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
  2404. @issue = Issue.find(1)
  2405. @issue_status = IssueStatus.find(1)
  2406. @issue_status.update!(:default_done_ratio => 50)
  2407. @issue2 = Issue.find(2)
  2408. @issue_status2 = IssueStatus.find(2)
  2409. @issue_status2.update!(:default_done_ratio => 0)
  2410. with_settings :issue_done_ratio => 'issue_field' do
  2411. assert_equal 0, @issue.done_ratio
  2412. assert_equal 30, @issue2.done_ratio
  2413. end
  2414. with_settings :issue_done_ratio => 'issue_status' do
  2415. assert_equal 50, @issue.done_ratio
  2416. assert_equal 0, @issue2.done_ratio
  2417. end
  2418. end
  2419. test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
  2420. @issue = Issue.find(1)
  2421. @issue_status = IssueStatus.find(1)
  2422. @issue_status.update!(:default_done_ratio => 50)
  2423. @issue2 = Issue.find(2)
  2424. @issue_status2 = IssueStatus.find(2)
  2425. @issue_status2.update!(:default_done_ratio => 0)
  2426. with_settings :issue_done_ratio => 'issue_field' do
  2427. @issue.update_done_ratio_from_issue_status
  2428. @issue2.update_done_ratio_from_issue_status
  2429. assert_equal 0, @issue.read_attribute(:done_ratio)
  2430. assert_equal 30, @issue2.read_attribute(:done_ratio)
  2431. end
  2432. with_settings :issue_done_ratio => 'issue_status' do
  2433. @issue.update_done_ratio_from_issue_status
  2434. @issue2.update_done_ratio_from_issue_status
  2435. assert_equal 50, @issue.read_attribute(:done_ratio)
  2436. assert_equal 0, @issue2.read_attribute(:done_ratio)
  2437. end
  2438. end
  2439. test "#by_tracker" do
  2440. User.current = User.find(2)
  2441. groups = Issue.by_tracker(Project.find(1))
  2442. groups_containing_subprojects = Issue.by_tracker(Project.find(1), true)
  2443. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2444. assert_equal 13, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2445. end
  2446. test "#by_version" do
  2447. User.current = User.find(2)
  2448. project = Project.find(1)
  2449. Issue.generate!(:project_id => project.descendants.visible.first, :fixed_version_id => project.shared_versions.find_by(:sharing => 'tree').id)
  2450. groups = Issue.by_version(project)
  2451. groups_containing_subprojects = Issue.by_version(project, true)
  2452. assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2453. assert_equal 4, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2454. end
  2455. test "#by_priority" do
  2456. User.current = User.find(2)
  2457. project = Project.find(1)
  2458. groups = Issue.by_priority(project)
  2459. groups_containing_subprojects = Issue.by_priority(project, true)
  2460. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2461. assert_equal 13, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2462. end
  2463. test "#by_category" do
  2464. User.current = User.find(2)
  2465. project = Project.find(1)
  2466. issue_category = IssueCategory.create(:project => project.descendants.visible.first, :name => 'test category')
  2467. Issue.generate!(:project_id => project.descendants.visible.first, :category_id => issue_category.id)
  2468. groups = Issue.by_category(project)
  2469. groups_containing_subprojects = Issue.by_category(project, true)
  2470. assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2471. assert_equal 4, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2472. end
  2473. test "#by_assigned_to" do
  2474. User.current = User.find(2)
  2475. project = Project.find(1)
  2476. Issue.generate!(:project_id => project.descendants.visible.first, :assigned_to => User.current)
  2477. groups = Issue.by_assigned_to(project)
  2478. groups_containing_subprojects = Issue.by_assigned_to(project, true)
  2479. assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2480. assert_equal 3, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2481. end
  2482. test "#by_author" do
  2483. User.current = User.find(2)
  2484. project = Project.find(1)
  2485. groups = Issue.by_author(project)
  2486. groups_containing_subprojects = Issue.by_author(project, true)
  2487. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2488. assert_equal 13, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2489. end
  2490. test "#by_subproject" do
  2491. User.current = User.anonymous
  2492. groups = Issue.by_subproject(Project.find(1))
  2493. # Private descendant not visible
  2494. assert_equal 1, groups.count
  2495. assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2496. end
  2497. def test_recently_updated_scope
  2498. # should return the last updated issue
  2499. assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
  2500. end
  2501. def test_on_active_projects_scope
  2502. assert Project.find(2).archive
  2503. before = Issue.on_active_project.length
  2504. # test inclusion to results
  2505. issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
  2506. assert_equal before + 1, Issue.on_active_project.length
  2507. # Move to an archived project
  2508. issue.project = Project.find(2)
  2509. assert issue.save
  2510. assert_equal before, Issue.on_active_project.length
  2511. end
  2512. test "Issue#recipients should include project recipients" do
  2513. issue = Issue.generate!
  2514. assert issue.project.recipients.present?
  2515. issue.project.recipients.each do |project_recipient|
  2516. assert issue.recipients.include?(project_recipient)
  2517. end
  2518. end
  2519. test "Issue#recipients should include the author if the author is active" do
  2520. issue = Issue.generate!(:author => User.generate!)
  2521. assert issue.author, "No author set for Issue"
  2522. assert issue.recipients.include?(issue.author.mail)
  2523. end
  2524. test "Issue#recipients should include the assigned to user if the assigned to user is active" do
  2525. user = User.generate!
  2526. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2527. issue = Issue.generate!(:assigned_to => user)
  2528. assert issue.assigned_to, "No assigned_to set for Issue"
  2529. assert issue.recipients.include?(issue.assigned_to.mail)
  2530. end
  2531. test "Issue#recipients should not include users who opt out of all email" do
  2532. issue = Issue.generate!(:author => User.generate!)
  2533. issue.author.update!(:mail_notification => :none)
  2534. assert !issue.recipients.include?(issue.author.mail)
  2535. end
  2536. test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
  2537. issue = Issue.generate!(:author => User.generate!)
  2538. issue.author.update!(:mail_notification => :only_assigned)
  2539. assert !issue.recipients.include?(issue.author.mail)
  2540. end
  2541. test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
  2542. user = User.generate!
  2543. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2544. issue = Issue.generate!(:assigned_to => user)
  2545. issue.assigned_to.update!(:mail_notification => :only_owner)
  2546. assert !issue.recipients.include?(issue.assigned_to.mail)
  2547. end
  2548. test "Issue#recipients should include users who want to be notified about high issues but only when issue has high priority" do
  2549. user = User.generate!
  2550. user.pref.update! notify_about_high_priority_issues: true
  2551. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2552. # creation with high prio
  2553. issue = Issue.generate!(priority: IssuePriority.find(6))
  2554. assert issue.recipients.include?(user.mail)
  2555. # creation with default prio
  2556. issue = Issue.generate!
  2557. assert !issue.recipients.include?(user.mail)
  2558. # update prio to high
  2559. issue.update! priority: IssuePriority.find(6)
  2560. assert issue.recipients.include?(user.mail)
  2561. # update prio to low
  2562. issue.update! priority: IssuePriority.find(4)
  2563. assert !issue.recipients.include?(user.mail)
  2564. end
  2565. test "Authors who don't want to be self-notified should not receive emails even when issue has high priority" do
  2566. user = User.generate!
  2567. user.pref.update! notify_about_high_priority_issues: true
  2568. user.pref.update! no_self_notified: true
  2569. project = Project.find(1)
  2570. project.memberships.destroy_all
  2571. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2572. ActionMailer::Base.deliveries.clear
  2573. Issue.create(author: user,
  2574. priority: IssuePriority.find(6),
  2575. subject: 'test create',
  2576. project: project,
  2577. tracker: Tracker.first,
  2578. status: IssueStatus.first)
  2579. assert ActionMailer::Base.deliveries.empty?
  2580. end
  2581. def test_last_journal_id_with_journals_should_return_the_journal_id
  2582. assert_equal 2, Issue.find(1).last_journal_id
  2583. end
  2584. def test_last_journal_id_without_journals_should_return_nil
  2585. assert_nil Issue.find(3).last_journal_id
  2586. end
  2587. def test_journals_after_should_return_journals_with_greater_id
  2588. assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
  2589. assert_equal [], Issue.find(1).journals_after('2')
  2590. end
  2591. def test_journals_after_with_blank_arg_should_return_all_journals
  2592. assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
  2593. end
  2594. def test_css_classes_should_include_tracker
  2595. issue = Issue.new(:tracker => Tracker.find(2))
  2596. classes = issue.css_classes.split(' ')
  2597. assert_include 'tracker-2', classes
  2598. end
  2599. def test_css_classes_should_include_priority
  2600. issue = Issue.new(:priority => IssuePriority.find(8))
  2601. classes = issue.css_classes.split(' ')
  2602. assert_include 'priority-8', classes
  2603. assert_include 'priority-highest', classes
  2604. end
  2605. def test_css_classes_should_include_user_and_group_assignment
  2606. project = Project.first
  2607. user = User.generate!
  2608. group = Group.generate!
  2609. Member.create!(:principal => group, :project => project, :role_ids => [1, 2])
  2610. group.users << user
  2611. assert user.member_of?(project)
  2612. issue1 = Issue.generate(:assigned_to_id => group.id)
  2613. assert_include 'assigned-to-my-group', issue1.css_classes(user)
  2614. assert_not_include 'assigned-to-me', issue1.css_classes(user)
  2615. issue2 = Issue.generate(:assigned_to_id => user.id)
  2616. assert_not_include 'assigned-to-my-group', issue2.css_classes(user)
  2617. assert_include 'assigned-to-me', issue2.css_classes(user)
  2618. end
  2619. def test_css_classes_behind_schedule
  2620. assert_include 'behind-schedule', Issue.find(1).css_classes.split(' ')
  2621. assert_not_include 'behind-schedule', Issue.find(2).css_classes.split(' ')
  2622. end
  2623. def test_save_attachments_with_hash_should_save_attachments_in_keys_order
  2624. set_tmp_attachments_directory
  2625. issue = Issue.generate!
  2626. issue.save_attachments(
  2627. {
  2628. 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
  2629. '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
  2630. '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
  2631. }
  2632. )
  2633. issue.attach_saved_attachments
  2634. assert_equal 3, issue.reload.attachments.count
  2635. assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
  2636. end
  2637. def test_save_attachments_with_array_should_warn_about_missing_tokens
  2638. set_tmp_attachments_directory
  2639. issue = Issue.generate!
  2640. issue.save_attachments([{'token' => 'missing'}])
  2641. assert !issue.save
  2642. assert issue.errors[:base].present?
  2643. assert_equal 0, issue.reload.attachments.count
  2644. end
  2645. def test_closed_on_should_be_nil_when_creating_an_open_issue
  2646. issue = Issue.generate!(:status_id => 1).reload
  2647. assert !issue.closed?
  2648. assert_nil issue.closed_on
  2649. end
  2650. def test_closed_on_should_be_set_when_creating_a_closed_issue
  2651. issue = Issue.generate!(:status_id => 5).reload
  2652. assert issue.closed?
  2653. assert_not_nil issue.closed_on
  2654. assert_equal issue.updated_on, issue.closed_on
  2655. assert_equal issue.created_on, issue.closed_on
  2656. end
  2657. def test_closed_on_should_be_nil_when_updating_an_open_issue
  2658. issue = Issue.find(1)
  2659. issue.subject = 'Not closed yet'
  2660. issue.save!
  2661. issue.reload
  2662. assert_nil issue.closed_on
  2663. end
  2664. def test_closed_on_should_be_set_when_closing_an_open_issue
  2665. issue = Issue.find(1)
  2666. issue.subject = 'Now closed'
  2667. issue.status_id = 5
  2668. issue.save!
  2669. issue.reload
  2670. assert_not_nil issue.closed_on
  2671. assert_equal issue.updated_on, issue.closed_on
  2672. end
  2673. def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
  2674. issue = Issue.open(false).first
  2675. was_closed_on = issue.closed_on
  2676. assert_not_nil was_closed_on
  2677. issue.subject = 'Updating a closed issue'
  2678. issue.save!
  2679. issue.reload
  2680. assert_equal was_closed_on, issue.closed_on
  2681. end
  2682. def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
  2683. issue = Issue.open(false).first
  2684. was_closed_on = issue.closed_on
  2685. assert_not_nil was_closed_on
  2686. issue.subject = 'Reopening a closed issue'
  2687. issue.status_id = 1
  2688. issue.save!
  2689. issue.reload
  2690. assert !issue.closed?
  2691. assert_equal was_closed_on, issue.closed_on
  2692. end
  2693. def test_status_was_should_return_nil_for_new_issue
  2694. issue = Issue.new
  2695. assert_nil issue.status_was
  2696. end
  2697. def test_status_was_should_return_status_before_change
  2698. issue = Issue.find(1)
  2699. issue.status = IssueStatus.find(2)
  2700. assert_equal IssueStatus.find(1), issue.status_was
  2701. end
  2702. def test_status_was_should_return_status_before_change_with_status_id
  2703. issue = Issue.find(1)
  2704. assert_equal IssueStatus.find(1), issue.status
  2705. issue.status_id = 2
  2706. assert_equal IssueStatus.find(1), issue.status_was
  2707. end
  2708. def test_status_was_should_be_reset_on_save
  2709. issue = Issue.find(1)
  2710. issue.status = IssueStatus.find(2)
  2711. assert_equal IssueStatus.find(1), issue.status_was
  2712. assert issue.save!
  2713. assert_equal IssueStatus.find(2), issue.status_was
  2714. end
  2715. def test_closing_should_return_true_when_closing_an_issue
  2716. issue = Issue.find(1)
  2717. issue.status = IssueStatus.find(2)
  2718. assert_equal false, issue.closing?
  2719. issue.status = IssueStatus.find(5)
  2720. assert_equal true, issue.closing?
  2721. end
  2722. def test_closing_should_return_true_when_closing_an_issue_with_status_id
  2723. issue = Issue.find(1)
  2724. issue.status_id = 2
  2725. assert_equal false, issue.closing?
  2726. issue.status_id = 5
  2727. assert_equal true, issue.closing?
  2728. end
  2729. def test_closing_should_return_true_for_new_closed_issue
  2730. issue = Issue.new
  2731. assert_equal false, issue.closing?
  2732. issue.status = IssueStatus.find(5)
  2733. assert_equal true, issue.closing?
  2734. end
  2735. def test_closing_should_return_true_for_new_closed_issue_with_status_id
  2736. issue = Issue.new
  2737. assert_equal false, issue.closing?
  2738. issue.status_id = 5
  2739. assert_equal true, issue.closing?
  2740. end
  2741. def test_closing_should_be_reset_after_save
  2742. issue = Issue.find(1)
  2743. issue.status_id = 5
  2744. assert_equal true, issue.closing?
  2745. issue.save!
  2746. assert_equal false, issue.closing?
  2747. end
  2748. def test_reopening_should_return_true_when_reopening_an_issue
  2749. issue = Issue.find(8)
  2750. issue.status = IssueStatus.find(6)
  2751. assert_equal false, issue.reopening?
  2752. issue.status = IssueStatus.find(2)
  2753. assert_equal true, issue.reopening?
  2754. end
  2755. def test_reopening_should_return_true_when_reopening_an_issue_with_status_id
  2756. issue = Issue.find(8)
  2757. issue.status_id = 6
  2758. assert_equal false, issue.reopening?
  2759. issue.status_id = 2
  2760. assert_equal true, issue.reopening?
  2761. end
  2762. def test_reopening_should_return_false_for_new_open_issue
  2763. issue = Issue.new
  2764. issue.status = IssueStatus.find(1)
  2765. assert_equal false, issue.reopening?
  2766. end
  2767. def test_reopening_should_be_reset_after_save
  2768. issue = Issue.find(8)
  2769. issue.status_id = 2
  2770. assert_equal true, issue.reopening?
  2771. issue.save!
  2772. assert_equal false, issue.reopening?
  2773. end
  2774. def test_default_status_without_tracker_should_be_nil
  2775. issue = Issue.new
  2776. assert_nil issue.tracker
  2777. assert_nil issue.default_status
  2778. end
  2779. def test_default_status_should_be_tracker_default_status
  2780. issue = Issue.new(:tracker_id => 1)
  2781. assert_not_nil issue.status
  2782. assert_equal issue.tracker.default_status, issue.default_status
  2783. end
  2784. def test_initializing_with_tracker_should_set_default_status
  2785. issue = Issue.new(:tracker => Tracker.find(1))
  2786. assert_not_nil issue.status
  2787. assert_equal issue.default_status, issue.status
  2788. end
  2789. def test_initializing_with_tracker_id_should_set_default_status
  2790. issue = Issue.new(:tracker_id => 1)
  2791. assert_not_nil issue.status
  2792. assert_equal issue.default_status, issue.status
  2793. end
  2794. def test_setting_tracker_should_set_default_status
  2795. issue = Issue.new
  2796. issue.tracker = Tracker.find(1)
  2797. assert_not_nil issue.status
  2798. assert_equal issue.default_status, issue.status
  2799. end
  2800. def test_changing_tracker_should_set_default_status_if_status_was_default
  2801. WorkflowTransition.delete_all
  2802. WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1
  2803. Tracker.find(2).update! :default_status_id => 2
  2804. issue = Issue.new(:tracker_id => 1, :status_id => 1)
  2805. assert_equal IssueStatus.find(1), issue.status
  2806. issue.tracker = Tracker.find(2)
  2807. assert_equal IssueStatus.find(2), issue.status
  2808. end
  2809. def test_changing_tracker_should_set_default_status_if_status_is_not_used_by_tracker
  2810. WorkflowTransition.delete_all
  2811. Tracker.find(2).update! :default_status_id => 2
  2812. issue = Issue.new(:tracker_id => 1, :status_id => 3)
  2813. assert_equal IssueStatus.find(3), issue.status
  2814. issue.tracker = Tracker.find(2)
  2815. assert_equal IssueStatus.find(2), issue.status
  2816. end
  2817. def test_changing_tracker_should_keep_status_if_status_was_not_default_and_is_used_by_tracker
  2818. WorkflowTransition.delete_all
  2819. WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3
  2820. Tracker.find(2).update! :default_status_id => 2
  2821. issue = Issue.new(:tracker_id => 1, :status_id => 3)
  2822. assert_equal IssueStatus.find(3), issue.status
  2823. issue.tracker = Tracker.find(2)
  2824. assert_equal IssueStatus.find(3), issue.status
  2825. end
  2826. def test_previous_assignee_with_a_group
  2827. group = Group.find(10)
  2828. Member.create!(:project_id => 1, :principal => group, :role_ids => [1])
  2829. with_settings :issue_group_assignment => '1' do
  2830. issue = Issue.generate!(:assigned_to => group)
  2831. issue.reload.assigned_to = nil
  2832. assert_equal group, issue.previous_assignee
  2833. end
  2834. end
  2835. def test_issue_overdue_should_respect_user_timezone
  2836. user_in_europe = users(:users_001)
  2837. user_in_europe.pref.update! :time_zone => 'UTC'
  2838. user_in_asia = users(:users_002)
  2839. user_in_asia.pref.update! :time_zone => 'Hongkong'
  2840. issue = Issue.generate! :due_date => Date.parse('2016-03-20')
  2841. # server time is UTC
  2842. time = Time.parse '2016-03-20 20:00 UTC'
  2843. Time.stubs(:now).returns(time)
  2844. Date.stubs(:today).returns(time.to_date)
  2845. # for a user in the same time zone as the server the issue is not overdue
  2846. # yet
  2847. User.current = user_in_europe
  2848. assert !issue.overdue?
  2849. # at the same time, a user in East Asia looks at the issue - it's already
  2850. # March 21st and the issue should be marked overdue
  2851. User.current = user_in_asia
  2852. assert issue.overdue?
  2853. end
  2854. def test_closable
  2855. issue10 = Issue.find(10)
  2856. assert issue10.closable?
  2857. assert_nil issue10.transition_warning
  2858. # Issue blocked by another issue
  2859. issue9 = Issue.find(9)
  2860. assert !issue9.closable?
  2861. assert_equal l(:notice_issue_not_closable_by_blocking_issue), issue9.transition_warning
  2862. end
  2863. def test_reopenable
  2864. parent = Issue.generate!(:status_id => 5)
  2865. child = parent.generate_child!(:status_id => 5)
  2866. assert !child.reopenable?
  2867. assert_equal l(:notice_issue_not_reopenable_by_closed_parent_issue), child.transition_warning
  2868. end
  2869. def test_filter_projects_scope
  2870. Issue.send(:public, :filter_projects_scope)
  2871. # Project eCookbook
  2872. issue = Issue.find(1)
  2873. assert_equal Project, issue.filter_projects_scope
  2874. assert_equal Project, issue.filter_projects_scope('system')
  2875. # Project Onlinestore (id 2) is not part of the tree
  2876. assert_equal [1, 3, 4, 5, 6], Issue.find(5).filter_projects_scope('tree').ids.sort
  2877. # Project "Private child of eCookbook"
  2878. issue2 = Issue.find(9)
  2879. # Projects "eCookbook Subproject 1" (id 3) and "eCookbook Subproject 1" (id 4) are not part of hierarchy
  2880. assert_equal [1, 5, 6], issue2.filter_projects_scope('hierarchy').ids.sort
  2881. # Project "Child of private child" is descendant of "Private child of eCookbook"
  2882. assert_equal [5, 6], issue2.filter_projects_scope('descendants').ids.sort
  2883. assert_equal [5], issue2.filter_projects_scope('').ids.sort
  2884. end
  2885. end