You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_nested_set_test.rb 16KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407
  1. # Redmine - project management software
  2. # Copyright (C) 2006-2012 Jean-Philippe Lang
  3. #
  4. # This program is free software; you can redistribute it and/or
  5. # modify it under the terms of the GNU General Public License
  6. # as published by the Free Software Foundation; either version 2
  7. # of the License, or (at your option) any later version.
  8. #
  9. # This program is distributed in the hope that it will be useful,
  10. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  11. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  12. # GNU General Public License for more details.
  13. #
  14. # You should have received a copy of the GNU General Public License
  15. # along with this program; if not, write to the Free Software
  16. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  17. require File.expand_path('../../test_helper', __FILE__)
  18. class IssueNestedSetTest < ActiveSupport::TestCase
  19. fixtures :projects, :users, :members, :member_roles, :roles,
  20. :trackers, :projects_trackers,
  21. :versions,
  22. :issue_statuses, :issue_categories, :issue_relations, :workflows,
  23. :enumerations,
  24. :issues,
  25. :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
  26. :time_entries
  27. self.use_transactional_fixtures = false
  28. def test_create_root_issue
  29. issue1 = create_issue!
  30. issue2 = create_issue!
  31. issue1.reload
  32. issue2.reload
  33. assert_equal [issue1.id, nil, 1, 2], [issue1.root_id, issue1.parent_id, issue1.lft, issue1.rgt]
  34. assert_equal [issue2.id, nil, 1, 2], [issue2.root_id, issue2.parent_id, issue2.lft, issue2.rgt]
  35. end
  36. def test_create_child_issue
  37. parent = create_issue!
  38. child = create_issue!(:parent_issue_id => parent.id)
  39. parent.reload
  40. child.reload
  41. assert_equal [parent.id, nil, 1, 4], [parent.root_id, parent.parent_id, parent.lft, parent.rgt]
  42. assert_equal [parent.id, parent.id, 2, 3], [child.root_id, child.parent_id, child.lft, child.rgt]
  43. end
  44. def test_creating_a_child_in_a_subproject_should_validate
  45. issue = create_issue!
  46. child = Issue.new(:project_id => 3, :tracker_id => 2, :author_id => 1,
  47. :subject => 'child', :parent_issue_id => issue.id)
  48. assert_save child
  49. assert_equal issue, child.reload.parent
  50. end
  51. def test_creating_a_child_in_an_invalid_project_should_not_validate
  52. issue = create_issue!
  53. child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
  54. :subject => 'child', :parent_issue_id => issue.id)
  55. assert !child.save
  56. assert_not_nil child.errors[:parent_issue_id]
  57. end
  58. def test_move_a_root_to_child
  59. parent1 = create_issue!
  60. parent2 = create_issue!
  61. child = create_issue!(:parent_issue_id => parent1.id)
  62. parent2.parent_issue_id = parent1.id
  63. parent2.save!
  64. child.reload
  65. parent1.reload
  66. parent2.reload
  67. assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
  68. assert_equal [parent1.id, 4, 5], [parent2.root_id, parent2.lft, parent2.rgt]
  69. assert_equal [parent1.id, 2, 3], [child.root_id, child.lft, child.rgt]
  70. end
  71. def test_move_a_child_to_root
  72. parent1 = create_issue!
  73. parent2 = create_issue!
  74. child = create_issue!(:parent_issue_id => parent1.id)
  75. child.parent_issue_id = nil
  76. child.save!
  77. child.reload
  78. parent1.reload
  79. parent2.reload
  80. assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
  81. assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
  82. assert_equal [child.id, 1, 2], [child.root_id, child.lft, child.rgt]
  83. end
  84. def test_move_a_child_to_another_issue
  85. parent1 = create_issue!
  86. parent2 = create_issue!
  87. child = create_issue!(:parent_issue_id => parent1.id)
  88. child.parent_issue_id = parent2.id
  89. child.save!
  90. child.reload
  91. parent1.reload
  92. parent2.reload
  93. assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
  94. assert_equal [parent2.id, 1, 4], [parent2.root_id, parent2.lft, parent2.rgt]
  95. assert_equal [parent2.id, 2, 3], [child.root_id, child.lft, child.rgt]
  96. end
  97. def test_move_a_child_with_descendants_to_another_issue
  98. parent1 = create_issue!
  99. parent2 = create_issue!
  100. child = create_issue!(:parent_issue_id => parent1.id)
  101. grandchild = create_issue!(:parent_issue_id => child.id)
  102. parent1.reload
  103. parent2.reload
  104. child.reload
  105. grandchild.reload
  106. assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
  107. assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
  108. assert_equal [parent1.id, 2, 5], [child.root_id, child.lft, child.rgt]
  109. assert_equal [parent1.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
  110. child.reload.parent_issue_id = parent2.id
  111. child.save!
  112. child.reload
  113. grandchild.reload
  114. parent1.reload
  115. parent2.reload
  116. assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
  117. assert_equal [parent2.id, 1, 6], [parent2.root_id, parent2.lft, parent2.rgt]
  118. assert_equal [parent2.id, 2, 5], [child.root_id, child.lft, child.rgt]
  119. assert_equal [parent2.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
  120. end
  121. def test_move_a_child_with_descendants_to_another_project
  122. parent1 = create_issue!
  123. child = create_issue!(:parent_issue_id => parent1.id)
  124. grandchild = create_issue!(:parent_issue_id => child.id)
  125. child.reload
  126. child.project = Project.find(2)
  127. assert child.save
  128. child.reload
  129. grandchild.reload
  130. parent1.reload
  131. assert_equal [1, parent1.id, 1, 2], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
  132. assert_equal [2, child.id, 1, 4], [child.project_id, child.root_id, child.lft, child.rgt]
  133. assert_equal [2, child.id, 2, 3], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
  134. end
  135. def test_invalid_move_to_another_project
  136. parent1 = create_issue!
  137. child = create_issue!(:parent_issue_id => parent1.id)
  138. grandchild = create_issue!(:parent_issue_id => child.id, :tracker_id => 2)
  139. Project.find(2).tracker_ids = [1]
  140. parent1.reload
  141. assert_equal [1, parent1.id, 1, 6], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
  142. # child can not be moved to Project 2 because its child is on a disabled tracker
  143. child = Issue.find(child.id)
  144. child.project = Project.find(2)
  145. assert !child.save
  146. child.reload
  147. grandchild.reload
  148. parent1.reload
  149. # no change
  150. assert_equal [1, parent1.id, 1, 6], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
  151. assert_equal [1, parent1.id, 2, 5], [child.project_id, child.root_id, child.lft, child.rgt]
  152. assert_equal [1, parent1.id, 3, 4], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
  153. end
  154. def test_moving_an_issue_to_a_descendant_should_not_validate
  155. parent1 = create_issue!
  156. parent2 = create_issue!
  157. child = create_issue!(:parent_issue_id => parent1.id)
  158. grandchild = create_issue!(:parent_issue_id => child.id)
  159. child.reload
  160. child.parent_issue_id = grandchild.id
  161. assert !child.save
  162. assert_not_nil child.errors[:parent_issue_id]
  163. end
  164. def test_moving_an_issue_should_keep_valid_relations_only
  165. issue1 = create_issue!
  166. issue2 = create_issue!
  167. issue3 = create_issue!(:parent_issue_id => issue2.id)
  168. issue4 = create_issue!
  169. r1 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  170. r2 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
  171. r3 = IssueRelation.create!(:issue_from => issue2, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
  172. issue2.reload
  173. issue2.parent_issue_id = issue1.id
  174. issue2.save!
  175. assert !IssueRelation.exists?(r1.id)
  176. assert !IssueRelation.exists?(r2.id)
  177. assert IssueRelation.exists?(r3.id)
  178. end
  179. def test_destroy_should_destroy_children
  180. issue1 = create_issue!
  181. issue2 = create_issue!
  182. issue3 = create_issue!(:parent_issue_id => issue2.id)
  183. issue4 = create_issue!(:parent_issue_id => issue1.id)
  184. issue3.init_journal(User.find(2))
  185. issue3.subject = 'child with journal'
  186. issue3.save!
  187. assert_difference 'Issue.count', -2 do
  188. assert_difference 'Journal.count', -1 do
  189. assert_difference 'JournalDetail.count', -1 do
  190. Issue.find(issue2.id).destroy
  191. end
  192. end
  193. end
  194. issue1.reload
  195. issue4.reload
  196. assert !Issue.exists?(issue2.id)
  197. assert !Issue.exists?(issue3.id)
  198. assert_equal [issue1.id, 1, 4], [issue1.root_id, issue1.lft, issue1.rgt]
  199. assert_equal [issue1.id, 2, 3], [issue4.root_id, issue4.lft, issue4.rgt]
  200. end
  201. def test_destroy_child_should_update_parent
  202. issue = create_issue!
  203. child1 = create_issue!(:parent_issue_id => issue.id)
  204. child2 = create_issue!(:parent_issue_id => issue.id)
  205. issue.reload
  206. assert_equal [issue.id, 1, 6], [issue.root_id, issue.lft, issue.rgt]
  207. child2.reload.destroy
  208. issue.reload
  209. assert_equal [issue.id, 1, 4], [issue.root_id, issue.lft, issue.rgt]
  210. end
  211. def test_destroy_parent_issue_updated_during_children_destroy
  212. parent = create_issue!
  213. create_issue!(:start_date => Date.today, :parent_issue_id => parent.id)
  214. create_issue!(:start_date => 2.days.from_now, :parent_issue_id => parent.id)
  215. assert_difference 'Issue.count', -3 do
  216. Issue.find(parent.id).destroy
  217. end
  218. end
  219. def test_destroy_child_issue_with_children
  220. root = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'root')
  221. child = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => root.id)
  222. leaf = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'leaf', :parent_issue_id => child.id)
  223. leaf.init_journal(User.find(2))
  224. leaf.subject = 'leaf with journal'
  225. leaf.save!
  226. assert_difference 'Issue.count', -2 do
  227. assert_difference 'Journal.count', -1 do
  228. assert_difference 'JournalDetail.count', -1 do
  229. Issue.find(child.id).destroy
  230. end
  231. end
  232. end
  233. root = Issue.find(root.id)
  234. assert root.leaf?, "Root issue is not a leaf (lft: #{root.lft}, rgt: #{root.rgt})"
  235. end
  236. def test_destroy_issue_with_grand_child
  237. parent = create_issue!
  238. issue = create_issue!(:parent_issue_id => parent.id)
  239. child = create_issue!(:parent_issue_id => issue.id)
  240. grandchild1 = create_issue!(:parent_issue_id => child.id)
  241. grandchild2 = create_issue!(:parent_issue_id => child.id)
  242. assert_difference 'Issue.count', -4 do
  243. Issue.find(issue.id).destroy
  244. parent.reload
  245. assert_equal [1, 2], [parent.lft, parent.rgt]
  246. end
  247. end
  248. def test_parent_priority_should_be_the_highest_child_priority
  249. parent = create_issue!(:priority => IssuePriority.find_by_name('Normal'))
  250. # Create children
  251. child1 = create_issue!(:priority => IssuePriority.find_by_name('High'), :parent_issue_id => parent.id)
  252. assert_equal 'High', parent.reload.priority.name
  253. child2 = create_issue!(:priority => IssuePriority.find_by_name('Immediate'), :parent_issue_id => child1.id)
  254. assert_equal 'Immediate', child1.reload.priority.name
  255. assert_equal 'Immediate', parent.reload.priority.name
  256. child3 = create_issue!(:priority => IssuePriority.find_by_name('Low'), :parent_issue_id => parent.id)
  257. assert_equal 'Immediate', parent.reload.priority.name
  258. # Destroy a child
  259. child1.destroy
  260. assert_equal 'Low', parent.reload.priority.name
  261. # Update a child
  262. child3.reload.priority = IssuePriority.find_by_name('Normal')
  263. child3.save!
  264. assert_equal 'Normal', parent.reload.priority.name
  265. end
  266. def test_parent_dates_should_be_lowest_start_and_highest_due_dates
  267. parent = create_issue!
  268. create_issue!(:start_date => '2010-01-25', :due_date => '2010-02-15', :parent_issue_id => parent.id)
  269. create_issue!( :due_date => '2010-02-13', :parent_issue_id => parent.id)
  270. create_issue!(:start_date => '2010-02-01', :due_date => '2010-02-22', :parent_issue_id => parent.id)
  271. parent.reload
  272. assert_equal Date.parse('2010-01-25'), parent.start_date
  273. assert_equal Date.parse('2010-02-22'), parent.due_date
  274. end
  275. def test_parent_done_ratio_should_be_average_done_ratio_of_leaves
  276. parent = create_issue!
  277. create_issue!(:done_ratio => 20, :parent_issue_id => parent.id)
  278. assert_equal 20, parent.reload.done_ratio
  279. create_issue!(:done_ratio => 70, :parent_issue_id => parent.id)
  280. assert_equal 45, parent.reload.done_ratio
  281. child = create_issue!(:done_ratio => 0, :parent_issue_id => parent.id)
  282. assert_equal 30, parent.reload.done_ratio
  283. create_issue!(:done_ratio => 30, :parent_issue_id => child.id)
  284. assert_equal 30, child.reload.done_ratio
  285. assert_equal 40, parent.reload.done_ratio
  286. end
  287. def test_parent_done_ratio_should_be_weighted_by_estimated_times_if_any
  288. parent = create_issue!
  289. create_issue!(:estimated_hours => 10, :done_ratio => 20, :parent_issue_id => parent.id)
  290. assert_equal 20, parent.reload.done_ratio
  291. create_issue!(:estimated_hours => 20, :done_ratio => 50, :parent_issue_id => parent.id)
  292. assert_equal (50 * 20 + 20 * 10) / 30, parent.reload.done_ratio
  293. end
  294. def test_parent_estimate_should_be_sum_of_leaves
  295. parent = create_issue!
  296. create_issue!(:estimated_hours => nil, :parent_issue_id => parent.id)
  297. assert_equal nil, parent.reload.estimated_hours
  298. create_issue!(:estimated_hours => 5, :parent_issue_id => parent.id)
  299. assert_equal 5, parent.reload.estimated_hours
  300. create_issue!(:estimated_hours => 7, :parent_issue_id => parent.id)
  301. assert_equal 12, parent.reload.estimated_hours
  302. end
  303. def test_move_parent_updates_old_parent_attributes
  304. first_parent = create_issue!
  305. second_parent = create_issue!
  306. child = create_issue!(:estimated_hours => 5, :parent_issue_id => first_parent.id)
  307. assert_equal 5, first_parent.reload.estimated_hours
  308. child.update_attributes(:estimated_hours => 7, :parent_issue_id => second_parent.id)
  309. assert_equal 7, second_parent.reload.estimated_hours
  310. assert_nil first_parent.reload.estimated_hours
  311. end
  312. def test_reschuling_a_parent_should_reschedule_subtasks
  313. parent = create_issue!
  314. c1 = create_issue!(:start_date => '2010-05-12', :due_date => '2010-05-18', :parent_issue_id => parent.id)
  315. c2 = create_issue!(:start_date => '2010-06-03', :due_date => '2010-06-10', :parent_issue_id => parent.id)
  316. parent.reload
  317. parent.reschedule_after(Date.parse('2010-06-02'))
  318. c1.reload
  319. assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-08')], [c1.start_date, c1.due_date]
  320. c2.reload
  321. assert_equal [Date.parse('2010-06-03'), Date.parse('2010-06-10')], [c2.start_date, c2.due_date] # no change
  322. parent.reload
  323. assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-10')], [parent.start_date, parent.due_date]
  324. end
  325. def test_project_copy_should_copy_issue_tree
  326. p = Project.create!(:name => 'Tree copy', :identifier => 'tree-copy', :tracker_ids => [1, 2])
  327. i1 = create_issue!(:project_id => p.id, :subject => 'i1')
  328. i2 = create_issue!(:project_id => p.id, :subject => 'i2', :parent_issue_id => i1.id)
  329. i3 = create_issue!(:project_id => p.id, :subject => 'i3', :parent_issue_id => i1.id)
  330. i4 = create_issue!(:project_id => p.id, :subject => 'i4', :parent_issue_id => i2.id)
  331. i5 = create_issue!(:project_id => p.id, :subject => 'i5')
  332. c = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1, 2])
  333. c.copy(p, :only => 'issues')
  334. c.reload
  335. assert_equal 5, c.issues.count
  336. ic1, ic2, ic3, ic4, ic5 = c.issues.find(:all, :order => 'subject')
  337. assert ic1.root?
  338. assert_equal ic1, ic2.parent
  339. assert_equal ic1, ic3.parent
  340. assert_equal ic2, ic4.parent
  341. assert ic5.root?
  342. end
  343. # Helper that creates an issue with default attributes
  344. def create_issue!(attributes={})
  345. Issue.create!({:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'test'}.merge(attributes))
  346. end
  347. end