You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

users_controller_test.rb 15KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482
  1. # Redmine - project management software
  2. # Copyright (C) 2006-2014 Jean-Philippe Lang
  3. #
  4. # This program is free software; you can redistribute it and/or
  5. # modify it under the terms of the GNU General Public License
  6. # as published by the Free Software Foundation; either version 2
  7. # of the License, or (at your option) any later version.
  8. #
  9. # This program is distributed in the hope that it will be useful,
  10. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  11. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  12. # GNU General Public License for more details.
  13. #
  14. # You should have received a copy of the GNU General Public License
  15. # along with this program; if not, write to the Free Software
  16. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  17. require File.expand_path('../../test_helper', __FILE__)
  18. class UsersControllerTest < ActionController::TestCase
  19. include Redmine::I18n
  20. fixtures :users, :projects, :members, :member_roles, :roles,
  21. :custom_fields, :custom_values, :groups_users,
  22. :auth_sources
  23. def setup
  24. User.current = nil
  25. @request.session[:user_id] = 1 # admin
  26. end
  27. def test_index
  28. get :index
  29. assert_response :success
  30. assert_template 'index'
  31. assert_not_nil assigns(:users)
  32. # active users only
  33. assert_nil assigns(:users).detect {|u| !u.active?}
  34. end
  35. def test_index_with_status_filter
  36. get :index, :status => 3
  37. assert_response :success
  38. assert_template 'index'
  39. assert_not_nil assigns(:users)
  40. assert_equal [3], assigns(:users).map(&:status).uniq
  41. end
  42. def test_index_with_name_filter
  43. get :index, :name => 'john'
  44. assert_response :success
  45. assert_template 'index'
  46. users = assigns(:users)
  47. assert_not_nil users
  48. assert_equal 1, users.size
  49. assert_equal 'John', users.first.firstname
  50. end
  51. def test_index_with_group_filter
  52. get :index, :group_id => '10'
  53. assert_response :success
  54. assert_template 'index'
  55. users = assigns(:users)
  56. assert users.any?
  57. assert_equal([], (users - Group.find(10).users))
  58. assert_select 'select[name=group_id]' do
  59. assert_select 'option[value=10][selected=selected]'
  60. end
  61. end
  62. def test_show
  63. @request.session[:user_id] = nil
  64. get :show, :id => 2
  65. assert_response :success
  66. assert_template 'show'
  67. assert_not_nil assigns(:user)
  68. assert_tag 'li', :content => /Phone number/
  69. end
  70. def test_show_should_not_display_hidden_custom_fields
  71. @request.session[:user_id] = nil
  72. UserCustomField.find_by_name('Phone number').update_attribute :visible, false
  73. get :show, :id => 2
  74. assert_response :success
  75. assert_template 'show'
  76. assert_not_nil assigns(:user)
  77. assert_no_tag 'li', :content => /Phone number/
  78. end
  79. def test_show_should_not_fail_when_custom_values_are_nil
  80. user = User.find(2)
  81. # Create a custom field to illustrate the issue
  82. custom_field = CustomField.create!(:name => 'Testing', :field_format => 'text')
  83. custom_value = user.custom_values.build(:custom_field => custom_field).save!
  84. get :show, :id => 2
  85. assert_response :success
  86. end
  87. def test_show_inactive
  88. @request.session[:user_id] = nil
  89. get :show, :id => 5
  90. assert_response 404
  91. end
  92. def test_show_should_not_reveal_users_with_no_visible_activity_or_project
  93. @request.session[:user_id] = nil
  94. get :show, :id => 9
  95. assert_response 404
  96. end
  97. def test_show_inactive_by_admin
  98. @request.session[:user_id] = 1
  99. get :show, :id => 5
  100. assert_response 200
  101. assert_not_nil assigns(:user)
  102. end
  103. def test_show_displays_memberships_based_on_project_visibility
  104. @request.session[:user_id] = 1
  105. get :show, :id => 2
  106. assert_response :success
  107. memberships = assigns(:memberships)
  108. assert_not_nil memberships
  109. project_ids = memberships.map(&:project_id)
  110. assert project_ids.include?(2) #private project admin can see
  111. end
  112. def test_show_current_should_require_authentication
  113. @request.session[:user_id] = nil
  114. get :show, :id => 'current'
  115. assert_response 302
  116. end
  117. def test_show_current
  118. @request.session[:user_id] = 2
  119. get :show, :id => 'current'
  120. assert_response :success
  121. assert_template 'show'
  122. assert_equal User.find(2), assigns(:user)
  123. end
  124. def test_new
  125. get :new
  126. assert_response :success
  127. assert_template :new
  128. assert assigns(:user)
  129. end
  130. def test_create
  131. Setting.bcc_recipients = '1'
  132. assert_difference 'User.count' do
  133. assert_difference 'ActionMailer::Base.deliveries.size' do
  134. post :create,
  135. :user => {
  136. :firstname => 'John',
  137. :lastname => 'Doe',
  138. :login => 'jdoe',
  139. :password => 'secret123',
  140. :password_confirmation => 'secret123',
  141. :mail => 'jdoe@gmail.com',
  142. :mail_notification => 'none'
  143. },
  144. :send_information => '1'
  145. end
  146. end
  147. user = User.first(:order => 'id DESC')
  148. assert_redirected_to :controller => 'users', :action => 'edit', :id => user.id
  149. assert_equal 'John', user.firstname
  150. assert_equal 'Doe', user.lastname
  151. assert_equal 'jdoe', user.login
  152. assert_equal 'jdoe@gmail.com', user.mail
  153. assert_equal 'none', user.mail_notification
  154. assert user.check_password?('secret123')
  155. mail = ActionMailer::Base.deliveries.last
  156. assert_not_nil mail
  157. assert_equal [user.mail], mail.bcc
  158. assert_mail_body_match 'secret', mail
  159. end
  160. def test_create_with_preferences
  161. assert_difference 'User.count' do
  162. post :create,
  163. :user => {
  164. :firstname => 'John',
  165. :lastname => 'Doe',
  166. :login => 'jdoe',
  167. :password => 'secret123',
  168. :password_confirmation => 'secret123',
  169. :mail => 'jdoe@gmail.com',
  170. :mail_notification => 'none'
  171. },
  172. :pref => {
  173. 'hide_mail' => '1',
  174. 'time_zone' => 'Paris',
  175. 'comments_sorting' => 'desc',
  176. 'warn_on_leaving_unsaved' => '0'
  177. }
  178. end
  179. user = User.first(:order => 'id DESC')
  180. assert_equal 'jdoe', user.login
  181. assert_equal true, user.pref.hide_mail
  182. assert_equal 'Paris', user.pref.time_zone
  183. assert_equal 'desc', user.pref[:comments_sorting]
  184. assert_equal '0', user.pref[:warn_on_leaving_unsaved]
  185. end
  186. def test_create_with_generate_password_should_email_the_password
  187. assert_difference 'User.count' do
  188. post :create, :user => {
  189. :login => 'randompass',
  190. :firstname => 'Random',
  191. :lastname => 'Pass',
  192. :mail => 'randompass@example.net',
  193. :language => 'en',
  194. :generate_password => '1',
  195. :password => '',
  196. :password_confirmation => ''
  197. }, :send_information => 1
  198. end
  199. user = User.order('id DESC').first
  200. assert_equal 'randompass', user.login
  201. mail = ActionMailer::Base.deliveries.last
  202. assert_not_nil mail
  203. m = mail_body(mail).match(/Password: ([a-zA-Z0-9]+)/)
  204. assert m
  205. password = m[1]
  206. assert user.check_password?(password)
  207. end
  208. def test_create_with_failure
  209. assert_no_difference 'User.count' do
  210. post :create, :user => {}
  211. end
  212. assert_response :success
  213. assert_template 'new'
  214. end
  215. def test_edit
  216. get :edit, :id => 2
  217. assert_response :success
  218. assert_template 'edit'
  219. assert_equal User.find(2), assigns(:user)
  220. end
  221. def test_update
  222. ActionMailer::Base.deliveries.clear
  223. put :update, :id => 2,
  224. :user => {:firstname => 'Changed', :mail_notification => 'only_assigned'},
  225. :pref => {:hide_mail => '1', :comments_sorting => 'desc'}
  226. user = User.find(2)
  227. assert_equal 'Changed', user.firstname
  228. assert_equal 'only_assigned', user.mail_notification
  229. assert_equal true, user.pref[:hide_mail]
  230. assert_equal 'desc', user.pref[:comments_sorting]
  231. assert ActionMailer::Base.deliveries.empty?
  232. end
  233. def test_update_with_failure
  234. assert_no_difference 'User.count' do
  235. put :update, :id => 2, :user => {:firstname => ''}
  236. end
  237. assert_response :success
  238. assert_template 'edit'
  239. end
  240. def test_update_with_group_ids_should_assign_groups
  241. put :update, :id => 2, :user => {:group_ids => ['10']}
  242. user = User.find(2)
  243. assert_equal [10], user.group_ids
  244. end
  245. def test_update_with_activation_should_send_a_notification
  246. u = User.new(:firstname => 'Foo', :lastname => 'Bar', :mail => 'foo.bar@somenet.foo', :language => 'fr')
  247. u.login = 'foo'
  248. u.status = User::STATUS_REGISTERED
  249. u.save!
  250. ActionMailer::Base.deliveries.clear
  251. Setting.bcc_recipients = '1'
  252. put :update, :id => u.id, :user => {:status => User::STATUS_ACTIVE}
  253. assert u.reload.active?
  254. mail = ActionMailer::Base.deliveries.last
  255. assert_not_nil mail
  256. assert_equal ['foo.bar@somenet.foo'], mail.bcc
  257. assert_mail_body_match ll('fr', :notice_account_activated), mail
  258. end
  259. def test_update_with_password_change_should_send_a_notification
  260. ActionMailer::Base.deliveries.clear
  261. Setting.bcc_recipients = '1'
  262. put :update, :id => 2, :user => {:password => 'newpass123', :password_confirmation => 'newpass123'}, :send_information => '1'
  263. u = User.find(2)
  264. assert u.check_password?('newpass123')
  265. mail = ActionMailer::Base.deliveries.last
  266. assert_not_nil mail
  267. assert_equal [u.mail], mail.bcc
  268. assert_mail_body_match 'newpass123', mail
  269. end
  270. def test_update_with_generate_password_should_email_the_password
  271. ActionMailer::Base.deliveries.clear
  272. Setting.bcc_recipients = '1'
  273. put :update, :id => 2, :user => {
  274. :generate_password => '1',
  275. :password => '',
  276. :password_confirmation => ''
  277. }, :send_information => '1'
  278. mail = ActionMailer::Base.deliveries.last
  279. assert_not_nil mail
  280. m = mail_body(mail).match(/Password: ([a-zA-Z0-9]+)/)
  281. assert m
  282. password = m[1]
  283. assert User.find(2).check_password?(password)
  284. end
  285. def test_update_without_generate_password_should_not_change_password
  286. put :update, :id => 2, :user => {
  287. :firstname => 'changed',
  288. :generate_password => '0',
  289. :password => '',
  290. :password_confirmation => ''
  291. }, :send_information => '1'
  292. user = User.find(2)
  293. assert_equal 'changed', user.firstname
  294. assert user.check_password?('jsmith')
  295. end
  296. def test_update_user_switchin_from_auth_source_to_password_authentication
  297. # Configure as auth source
  298. u = User.find(2)
  299. u.auth_source = AuthSource.find(1)
  300. u.save!
  301. put :update, :id => u.id, :user => {:auth_source_id => '', :password => 'newpass123', :password_confirmation => 'newpass123'}
  302. assert_equal nil, u.reload.auth_source
  303. assert u.check_password?('newpass123')
  304. end
  305. def test_update_notified_project
  306. get :edit, :id => 2
  307. assert_response :success
  308. assert_template 'edit'
  309. u = User.find(2)
  310. assert_equal [1, 2, 5], u.projects.collect{|p| p.id}.sort
  311. assert_equal [1, 2, 5], u.notified_projects_ids.sort
  312. assert_select 'input[name=?][value=?]', 'user[notified_project_ids][]', '1'
  313. assert_equal 'all', u.mail_notification
  314. put :update, :id => 2,
  315. :user => {
  316. :mail_notification => 'selected',
  317. :notified_project_ids => [1, 2]
  318. }
  319. u = User.find(2)
  320. assert_equal 'selected', u.mail_notification
  321. assert_equal [1, 2], u.notified_projects_ids.sort
  322. end
  323. def test_update_status_should_not_update_attributes
  324. user = User.find(2)
  325. user.pref[:no_self_notified] = '1'
  326. user.pref.save
  327. put :update, :id => 2, :user => {:status => 3}
  328. assert_response 302
  329. user = User.find(2)
  330. assert_equal 3, user.status
  331. assert_equal '1', user.pref[:no_self_notified]
  332. end
  333. def test_destroy
  334. assert_difference 'User.count', -1 do
  335. delete :destroy, :id => 2
  336. end
  337. assert_redirected_to '/users'
  338. assert_nil User.find_by_id(2)
  339. end
  340. def test_destroy_should_be_denied_for_non_admin_users
  341. @request.session[:user_id] = 3
  342. assert_no_difference 'User.count' do
  343. get :destroy, :id => 2
  344. end
  345. assert_response 403
  346. end
  347. def test_destroy_should_redirect_to_back_url_param
  348. assert_difference 'User.count', -1 do
  349. delete :destroy, :id => 2, :back_url => '/users?name=foo'
  350. end
  351. assert_redirected_to '/users?name=foo'
  352. end
  353. def test_create_membership
  354. assert_difference 'Member.count' do
  355. post :edit_membership, :id => 7, :membership => { :project_id => 3, :role_ids => [2]}
  356. end
  357. assert_redirected_to :action => 'edit', :id => '7', :tab => 'memberships'
  358. member = Member.first(:order => 'id DESC')
  359. assert_equal User.find(7), member.principal
  360. assert_equal [2], member.role_ids
  361. assert_equal 3, member.project_id
  362. end
  363. def test_create_membership_js_format
  364. assert_difference 'Member.count' do
  365. post :edit_membership, :id => 7, :membership => {:project_id => 3, :role_ids => [2]}, :format => 'js'
  366. assert_response :success
  367. assert_template 'edit_membership'
  368. assert_equal 'text/javascript', response.content_type
  369. end
  370. member = Member.first(:order => 'id DESC')
  371. assert_equal User.find(7), member.principal
  372. assert_equal [2], member.role_ids
  373. assert_equal 3, member.project_id
  374. assert_include 'tab-content-memberships', response.body
  375. end
  376. def test_create_membership_js_format_with_failure
  377. assert_no_difference 'Member.count' do
  378. post :edit_membership, :id => 7, :membership => {:project_id => 3}, :format => 'js'
  379. assert_response :success
  380. assert_template 'edit_membership'
  381. assert_equal 'text/javascript', response.content_type
  382. end
  383. assert_include 'alert', response.body, "Alert message not sent"
  384. assert_include 'Role can\\\'t be empty', response.body, "Error message not sent"
  385. end
  386. def test_update_membership
  387. assert_no_difference 'Member.count' do
  388. put :edit_membership, :id => 2, :membership_id => 1, :membership => { :role_ids => [2]}
  389. assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
  390. end
  391. assert_equal [2], Member.find(1).role_ids
  392. end
  393. def test_update_membership_js_format
  394. assert_no_difference 'Member.count' do
  395. put :edit_membership, :id => 2, :membership_id => 1, :membership => {:role_ids => [2]}, :format => 'js'
  396. assert_response :success
  397. assert_template 'edit_membership'
  398. assert_equal 'text/javascript', response.content_type
  399. end
  400. assert_equal [2], Member.find(1).role_ids
  401. assert_include 'tab-content-memberships', response.body
  402. end
  403. def test_destroy_membership
  404. assert_difference 'Member.count', -1 do
  405. delete :destroy_membership, :id => 2, :membership_id => 1
  406. end
  407. assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
  408. assert_nil Member.find_by_id(1)
  409. end
  410. def test_destroy_membership_js_format
  411. assert_difference 'Member.count', -1 do
  412. delete :destroy_membership, :id => 2, :membership_id => 1, :format => 'js'
  413. assert_response :success
  414. assert_template 'destroy_membership'
  415. assert_equal 'text/javascript', response.content_type
  416. end
  417. assert_nil Member.find_by_id(1)
  418. assert_include 'tab-content-memberships', response.body
  419. end
  420. end