You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_nested_set_test.rb 16KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416
  1. # Redmine - project management software
  2. # Copyright (C) 2006-2014 Jean-Philippe Lang
  3. #
  4. # This program is free software; you can redistribute it and/or
  5. # modify it under the terms of the GNU General Public License
  6. # as published by the Free Software Foundation; either version 2
  7. # of the License, or (at your option) any later version.
  8. #
  9. # This program is distributed in the hope that it will be useful,
  10. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  11. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  12. # GNU General Public License for more details.
  13. #
  14. # You should have received a copy of the GNU General Public License
  15. # along with this program; if not, write to the Free Software
  16. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  17. require File.expand_path('../../test_helper', __FILE__)
  18. class IssueNestedSetTest < ActiveSupport::TestCase
  19. fixtures :projects, :users, :roles,
  20. :trackers, :projects_trackers,
  21. :issue_statuses, :issue_categories, :issue_relations,
  22. :enumerations,
  23. :issues
  24. def test_create_root_issue
  25. issue1 = Issue.generate!
  26. issue2 = Issue.generate!
  27. issue1.reload
  28. issue2.reload
  29. assert_equal [issue1.id, nil, 1, 2], [issue1.root_id, issue1.parent_id, issue1.lft, issue1.rgt]
  30. assert_equal [issue2.id, nil, 1, 2], [issue2.root_id, issue2.parent_id, issue2.lft, issue2.rgt]
  31. end
  32. def test_create_child_issue
  33. parent = Issue.generate!
  34. child = Issue.generate!(:parent_issue_id => parent.id)
  35. parent.reload
  36. child.reload
  37. assert_equal [parent.id, nil, 1, 4], [parent.root_id, parent.parent_id, parent.lft, parent.rgt]
  38. assert_equal [parent.id, parent.id, 2, 3], [child.root_id, child.parent_id, child.lft, child.rgt]
  39. end
  40. def test_creating_a_child_in_a_subproject_should_validate
  41. issue = Issue.generate!
  42. child = Issue.new(:project_id => 3, :tracker_id => 2, :author_id => 1,
  43. :subject => 'child', :parent_issue_id => issue.id)
  44. assert_save child
  45. assert_equal issue, child.reload.parent
  46. end
  47. def test_creating_a_child_in_an_invalid_project_should_not_validate
  48. issue = Issue.generate!
  49. child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
  50. :subject => 'child', :parent_issue_id => issue.id)
  51. assert !child.save
  52. assert_not_equal [], child.errors[:parent_issue_id]
  53. end
  54. def test_move_a_root_to_child
  55. parent1 = Issue.generate!
  56. parent2 = Issue.generate!
  57. child = Issue.generate!(:parent_issue_id => parent1.id)
  58. parent2.parent_issue_id = parent1.id
  59. parent2.save!
  60. child.reload
  61. parent1.reload
  62. parent2.reload
  63. assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
  64. assert_equal [parent1.id, 4, 5], [parent2.root_id, parent2.lft, parent2.rgt]
  65. assert_equal [parent1.id, 2, 3], [child.root_id, child.lft, child.rgt]
  66. end
  67. def test_move_a_child_to_root
  68. parent1 = Issue.generate!
  69. parent2 = Issue.generate!
  70. child = Issue.generate!(:parent_issue_id => parent1.id)
  71. child.parent_issue_id = nil
  72. child.save!
  73. child.reload
  74. parent1.reload
  75. parent2.reload
  76. assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
  77. assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
  78. assert_equal [child.id, 1, 2], [child.root_id, child.lft, child.rgt]
  79. end
  80. def test_move_a_child_to_another_issue
  81. parent1 = Issue.generate!
  82. parent2 = Issue.generate!
  83. child = Issue.generate!(:parent_issue_id => parent1.id)
  84. child.parent_issue_id = parent2.id
  85. child.save!
  86. child.reload
  87. parent1.reload
  88. parent2.reload
  89. assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
  90. assert_equal [parent2.id, 1, 4], [parent2.root_id, parent2.lft, parent2.rgt]
  91. assert_equal [parent2.id, 2, 3], [child.root_id, child.lft, child.rgt]
  92. end
  93. def test_move_a_child_with_descendants_to_another_issue
  94. parent1 = Issue.generate!
  95. parent2 = Issue.generate!
  96. child = Issue.generate!(:parent_issue_id => parent1.id)
  97. grandchild = Issue.generate!(:parent_issue_id => child.id)
  98. parent1.reload
  99. parent2.reload
  100. child.reload
  101. grandchild.reload
  102. assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
  103. assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
  104. assert_equal [parent1.id, 2, 5], [child.root_id, child.lft, child.rgt]
  105. assert_equal [parent1.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
  106. child.reload.parent_issue_id = parent2.id
  107. child.save!
  108. child.reload
  109. grandchild.reload
  110. parent1.reload
  111. parent2.reload
  112. assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
  113. assert_equal [parent2.id, 1, 6], [parent2.root_id, parent2.lft, parent2.rgt]
  114. assert_equal [parent2.id, 2, 5], [child.root_id, child.lft, child.rgt]
  115. assert_equal [parent2.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
  116. end
  117. def test_move_a_child_with_descendants_to_another_project
  118. parent1 = Issue.generate!
  119. child = Issue.generate!(:parent_issue_id => parent1.id)
  120. grandchild = Issue.generate!(:parent_issue_id => child.id)
  121. child.reload
  122. child.project = Project.find(2)
  123. assert child.save
  124. child.reload
  125. grandchild.reload
  126. parent1.reload
  127. assert_equal [1, parent1.id, 1, 2], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
  128. assert_equal [2, child.id, 1, 4], [child.project_id, child.root_id, child.lft, child.rgt]
  129. assert_equal [2, child.id, 2, 3], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
  130. end
  131. def test_moving_an_issue_to_a_descendant_should_not_validate
  132. parent1 = Issue.generate!
  133. parent2 = Issue.generate!
  134. child = Issue.generate!(:parent_issue_id => parent1.id)
  135. grandchild = Issue.generate!(:parent_issue_id => child.id)
  136. child.reload
  137. child.parent_issue_id = grandchild.id
  138. assert !child.save
  139. assert_not_equal [], child.errors[:parent_issue_id]
  140. end
  141. def test_updating_a_root_issue_should_not_trigger_update_nested_set_attributes_on_parent_change
  142. issue = Issue.find(Issue.generate!.id)
  143. issue.parent_issue_id = ""
  144. issue.expects(:update_nested_set_attributes_on_parent_change).never
  145. issue.save!
  146. end
  147. def test_updating_a_child_issue_should_not_trigger_update_nested_set_attributes_on_parent_change
  148. issue = Issue.find(Issue.generate!(:parent_issue_id => 1).id)
  149. issue.parent_issue_id = "1"
  150. issue.expects(:update_nested_set_attributes_on_parent_change).never
  151. issue.save!
  152. end
  153. def test_moving_a_root_issue_should_trigger_update_nested_set_attributes_on_parent_change
  154. issue = Issue.find(Issue.generate!.id)
  155. issue.parent_issue_id = "1"
  156. issue.expects(:update_nested_set_attributes_on_parent_change).once
  157. issue.save!
  158. end
  159. def test_moving_a_child_issue_to_another_parent_should_trigger_update_nested_set_attributes_on_parent_change
  160. issue = Issue.find(Issue.generate!(:parent_issue_id => 1).id)
  161. issue.parent_issue_id = "2"
  162. issue.expects(:update_nested_set_attributes_on_parent_change).once
  163. issue.save!
  164. end
  165. def test_moving_a_child_issue_to_root_should_trigger_update_nested_set_attributes_on_parent_change
  166. issue = Issue.find(Issue.generate!(:parent_issue_id => 1).id)
  167. issue.parent_issue_id = ""
  168. issue.expects(:update_nested_set_attributes_on_parent_change).once
  169. issue.save!
  170. end
  171. def test_destroy_should_destroy_children
  172. issue1 = Issue.generate!
  173. issue2 = Issue.generate!
  174. issue3 = Issue.generate!(:parent_issue_id => issue2.id)
  175. issue4 = Issue.generate!(:parent_issue_id => issue1.id)
  176. issue3.init_journal(User.find(2))
  177. issue3.subject = 'child with journal'
  178. issue3.save!
  179. assert_difference 'Issue.count', -2 do
  180. assert_difference 'Journal.count', -1 do
  181. assert_difference 'JournalDetail.count', -1 do
  182. Issue.find(issue2.id).destroy
  183. end
  184. end
  185. end
  186. issue1.reload
  187. issue4.reload
  188. assert !Issue.exists?(issue2.id)
  189. assert !Issue.exists?(issue3.id)
  190. assert_equal [issue1.id, 1, 4], [issue1.root_id, issue1.lft, issue1.rgt]
  191. assert_equal [issue1.id, 2, 3], [issue4.root_id, issue4.lft, issue4.rgt]
  192. end
  193. def test_destroy_child_should_update_parent
  194. issue = Issue.generate!
  195. child1 = Issue.generate!(:parent_issue_id => issue.id)
  196. child2 = Issue.generate!(:parent_issue_id => issue.id)
  197. issue.reload
  198. assert_equal [issue.id, 1, 6], [issue.root_id, issue.lft, issue.rgt]
  199. child2.reload.destroy
  200. issue.reload
  201. assert_equal [issue.id, 1, 4], [issue.root_id, issue.lft, issue.rgt]
  202. end
  203. def test_destroy_parent_issue_updated_during_children_destroy
  204. parent = Issue.generate!
  205. Issue.generate!(:start_date => Date.today, :parent_issue_id => parent.id)
  206. Issue.generate!(:start_date => 2.days.from_now, :parent_issue_id => parent.id)
  207. assert_difference 'Issue.count', -3 do
  208. Issue.find(parent.id).destroy
  209. end
  210. end
  211. def test_destroy_child_issue_with_children
  212. root = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'root')
  213. child = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => root.id)
  214. leaf = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'leaf', :parent_issue_id => child.id)
  215. leaf.init_journal(User.find(2))
  216. leaf.subject = 'leaf with journal'
  217. leaf.save!
  218. assert_difference 'Issue.count', -2 do
  219. assert_difference 'Journal.count', -1 do
  220. assert_difference 'JournalDetail.count', -1 do
  221. Issue.find(child.id).destroy
  222. end
  223. end
  224. end
  225. root = Issue.find(root.id)
  226. assert root.leaf?, "Root issue is not a leaf (lft: #{root.lft}, rgt: #{root.rgt})"
  227. end
  228. def test_destroy_issue_with_grand_child
  229. parent = Issue.generate!
  230. issue = Issue.generate!(:parent_issue_id => parent.id)
  231. child = Issue.generate!(:parent_issue_id => issue.id)
  232. grandchild1 = Issue.generate!(:parent_issue_id => child.id)
  233. grandchild2 = Issue.generate!(:parent_issue_id => child.id)
  234. assert_difference 'Issue.count', -4 do
  235. Issue.find(issue.id).destroy
  236. parent.reload
  237. assert_equal [1, 2], [parent.lft, parent.rgt]
  238. end
  239. end
  240. def test_parent_priority_should_be_the_highest_child_priority
  241. parent = Issue.generate!(:priority => IssuePriority.find_by_name('Normal'))
  242. # Create children
  243. child1 = Issue.generate!(:priority => IssuePriority.find_by_name('High'), :parent_issue_id => parent.id)
  244. assert_equal 'High', parent.reload.priority.name
  245. child2 = Issue.generate!(:priority => IssuePriority.find_by_name('Immediate'), :parent_issue_id => child1.id)
  246. assert_equal 'Immediate', child1.reload.priority.name
  247. assert_equal 'Immediate', parent.reload.priority.name
  248. child3 = Issue.generate!(:priority => IssuePriority.find_by_name('Low'), :parent_issue_id => parent.id)
  249. assert_equal 'Immediate', parent.reload.priority.name
  250. # Destroy a child
  251. child1.destroy
  252. assert_equal 'Low', parent.reload.priority.name
  253. # Update a child
  254. child3.reload.priority = IssuePriority.find_by_name('Normal')
  255. child3.save!
  256. assert_equal 'Normal', parent.reload.priority.name
  257. end
  258. def test_parent_dates_should_be_lowest_start_and_highest_due_dates
  259. parent = Issue.generate!
  260. Issue.generate!(:start_date => '2010-01-25', :due_date => '2010-02-15', :parent_issue_id => parent.id)
  261. Issue.generate!( :due_date => '2010-02-13', :parent_issue_id => parent.id)
  262. Issue.generate!(:start_date => '2010-02-01', :due_date => '2010-02-22', :parent_issue_id => parent.id)
  263. parent.reload
  264. assert_equal Date.parse('2010-01-25'), parent.start_date
  265. assert_equal Date.parse('2010-02-22'), parent.due_date
  266. end
  267. def test_parent_done_ratio_should_be_average_done_ratio_of_leaves
  268. parent = Issue.generate!
  269. Issue.generate!(:done_ratio => 20, :parent_issue_id => parent.id)
  270. assert_equal 20, parent.reload.done_ratio
  271. Issue.generate!(:done_ratio => 70, :parent_issue_id => parent.id)
  272. assert_equal 45, parent.reload.done_ratio
  273. child = Issue.generate!(:done_ratio => 0, :parent_issue_id => parent.id)
  274. assert_equal 30, parent.reload.done_ratio
  275. Issue.generate!(:done_ratio => 30, :parent_issue_id => child.id)
  276. assert_equal 30, child.reload.done_ratio
  277. assert_equal 40, parent.reload.done_ratio
  278. end
  279. def test_parent_done_ratio_should_be_weighted_by_estimated_times_if_any
  280. parent = Issue.generate!
  281. Issue.generate!(:estimated_hours => 10, :done_ratio => 20, :parent_issue_id => parent.id)
  282. assert_equal 20, parent.reload.done_ratio
  283. Issue.generate!(:estimated_hours => 20, :done_ratio => 50, :parent_issue_id => parent.id)
  284. assert_equal (50 * 20 + 20 * 10) / 30, parent.reload.done_ratio
  285. end
  286. def test_parent_done_ratio_with_child_estimate_to_0_should_reach_100
  287. parent = Issue.generate!
  288. issue1 = Issue.generate!(:parent_issue_id => parent.id)
  289. issue2 = Issue.generate!(:parent_issue_id => parent.id, :estimated_hours => 0)
  290. assert_equal 0, parent.reload.done_ratio
  291. issue1.reload.update_attribute :status_id, 5
  292. assert_equal 50, parent.reload.done_ratio
  293. issue2.reload.update_attribute :status_id, 5
  294. assert_equal 100, parent.reload.done_ratio
  295. end
  296. def test_parent_estimate_should_be_sum_of_leaves
  297. parent = Issue.generate!
  298. Issue.generate!(:estimated_hours => nil, :parent_issue_id => parent.id)
  299. assert_equal nil, parent.reload.estimated_hours
  300. Issue.generate!(:estimated_hours => 5, :parent_issue_id => parent.id)
  301. assert_equal 5, parent.reload.estimated_hours
  302. Issue.generate!(:estimated_hours => 7, :parent_issue_id => parent.id)
  303. assert_equal 12, parent.reload.estimated_hours
  304. end
  305. def test_done_ratio_of_parent_with_a_child_with_estimated_time_at_0_should_not_exceed_100
  306. parent = Issue.generate!
  307. Issue.generate!(:estimated_hours => 40, :parent_issue_id => parent.id)
  308. Issue.generate!(:estimated_hours => 40, :parent_issue_id => parent.id)
  309. Issue.generate!(:estimated_hours => 20, :parent_issue_id => parent.id)
  310. Issue.generate!(:estimated_hours => 0, :parent_issue_id => parent.id)
  311. parent.reload.children.each do |child|
  312. child.update_attribute :status_id, 5
  313. end
  314. assert_equal 100, parent.reload.done_ratio
  315. end
  316. def test_move_parent_updates_old_parent_attributes
  317. first_parent = Issue.generate!
  318. second_parent = Issue.generate!
  319. child = Issue.generate!(:estimated_hours => 5, :parent_issue_id => first_parent.id)
  320. assert_equal 5, first_parent.reload.estimated_hours
  321. child.update_attributes(:estimated_hours => 7, :parent_issue_id => second_parent.id)
  322. assert_equal 7, second_parent.reload.estimated_hours
  323. assert_nil first_parent.reload.estimated_hours
  324. end
  325. def test_reschuling_a_parent_should_reschedule_subtasks
  326. parent = Issue.generate!
  327. c1 = Issue.generate!(:start_date => '2010-05-12', :due_date => '2010-05-18', :parent_issue_id => parent.id)
  328. c2 = Issue.generate!(:start_date => '2010-06-03', :due_date => '2010-06-10', :parent_issue_id => parent.id)
  329. parent.reload
  330. parent.reschedule_on!(Date.parse('2010-06-02'))
  331. c1.reload
  332. assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-08')], [c1.start_date, c1.due_date]
  333. c2.reload
  334. assert_equal [Date.parse('2010-06-03'), Date.parse('2010-06-10')], [c2.start_date, c2.due_date] # no change
  335. parent.reload
  336. assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-10')], [parent.start_date, parent.due_date]
  337. end
  338. def test_project_copy_should_copy_issue_tree
  339. p = Project.create!(:name => 'Tree copy', :identifier => 'tree-copy', :tracker_ids => [1, 2])
  340. i1 = Issue.generate!(:project => p, :subject => 'i1')
  341. i2 = Issue.generate!(:project => p, :subject => 'i2', :parent_issue_id => i1.id)
  342. i3 = Issue.generate!(:project => p, :subject => 'i3', :parent_issue_id => i1.id)
  343. i4 = Issue.generate!(:project => p, :subject => 'i4', :parent_issue_id => i2.id)
  344. i5 = Issue.generate!(:project => p, :subject => 'i5')
  345. c = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1, 2])
  346. c.copy(p, :only => 'issues')
  347. c.reload
  348. assert_equal 5, c.issues.count
  349. ic1, ic2, ic3, ic4, ic5 = c.issues.order('subject').all
  350. assert ic1.root?
  351. assert_equal ic1, ic2.parent
  352. assert_equal ic1, ic3.parent
  353. assert_equal ic2, ic4.parent
  354. assert ic5.root?
  355. end
  356. end