You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_test.rb 86KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306
  1. # Redmine - project management software
  2. # Copyright (C) 2006-2014 Jean-Philippe Lang
  3. #
  4. # This program is free software; you can redistribute it and/or
  5. # modify it under the terms of the GNU General Public License
  6. # as published by the Free Software Foundation; either version 2
  7. # of the License, or (at your option) any later version.
  8. #
  9. # This program is distributed in the hope that it will be useful,
  10. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  11. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  12. # GNU General Public License for more details.
  13. #
  14. # You should have received a copy of the GNU General Public License
  15. # along with this program; if not, write to the Free Software
  16. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  17. require File.expand_path('../../test_helper', __FILE__)
  18. class IssueTest < ActiveSupport::TestCase
  19. fixtures :projects, :users, :members, :member_roles, :roles,
  20. :groups_users,
  21. :trackers, :projects_trackers,
  22. :enabled_modules,
  23. :versions,
  24. :issue_statuses, :issue_categories, :issue_relations, :workflows,
  25. :enumerations,
  26. :issues, :journals, :journal_details,
  27. :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
  28. :time_entries
  29. include Redmine::I18n
  30. def teardown
  31. User.current = nil
  32. end
  33. def test_initialize
  34. issue = Issue.new
  35. assert_nil issue.project_id
  36. assert_nil issue.tracker_id
  37. assert_nil issue.author_id
  38. assert_nil issue.assigned_to_id
  39. assert_nil issue.category_id
  40. assert_equal IssueStatus.default, issue.status
  41. assert_equal IssuePriority.default, issue.priority
  42. end
  43. def test_create
  44. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
  45. :status_id => 1, :priority => IssuePriority.all.first,
  46. :subject => 'test_create',
  47. :description => 'IssueTest#test_create', :estimated_hours => '1:30')
  48. assert issue.save
  49. issue.reload
  50. assert_equal 1.5, issue.estimated_hours
  51. end
  52. def test_create_minimal
  53. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
  54. :status_id => 1, :priority => IssuePriority.all.first,
  55. :subject => 'test_create')
  56. assert issue.save
  57. assert issue.description.nil?
  58. assert_nil issue.estimated_hours
  59. end
  60. def test_start_date_format_should_be_validated
  61. set_language_if_valid 'en'
  62. ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
  63. issue = Issue.new(:start_date => invalid_date)
  64. assert !issue.valid?
  65. assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
  66. end
  67. end
  68. def test_due_date_format_should_be_validated
  69. set_language_if_valid 'en'
  70. ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
  71. issue = Issue.new(:due_date => invalid_date)
  72. assert !issue.valid?
  73. assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
  74. end
  75. end
  76. def test_due_date_lesser_than_start_date_should_not_validate
  77. set_language_if_valid 'en'
  78. issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
  79. assert !issue.valid?
  80. assert_include 'Due date must be greater than start date', issue.errors.full_messages
  81. end
  82. def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
  83. issue = Issue.generate(:start_date => '2013-06-04')
  84. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  85. assert !issue.valid?
  86. assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  87. end
  88. def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
  89. issue = Issue.generate!(:start_date => '2013-06-04')
  90. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  91. issue.start_date = '2013-06-07'
  92. assert !issue.valid?
  93. assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  94. end
  95. def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
  96. issue = Issue.generate!(:start_date => '2013-06-04')
  97. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  98. assert issue.valid?
  99. end
  100. def test_estimated_hours_should_be_validated
  101. set_language_if_valid 'en'
  102. ['-2'].each do |invalid|
  103. issue = Issue.new(:estimated_hours => invalid)
  104. assert !issue.valid?
  105. assert_include 'Estimated time is invalid', issue.errors.full_messages
  106. end
  107. end
  108. def test_create_with_required_custom_field
  109. set_language_if_valid 'en'
  110. field = IssueCustomField.find_by_name('Database')
  111. field.update_attribute(:is_required, true)
  112. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  113. :status_id => 1, :subject => 'test_create',
  114. :description => 'IssueTest#test_create_with_required_custom_field')
  115. assert issue.available_custom_fields.include?(field)
  116. # No value for the custom field
  117. assert !issue.save
  118. assert_equal ["Database can't be blank"], issue.errors.full_messages
  119. # Blank value
  120. issue.custom_field_values = { field.id => '' }
  121. assert !issue.save
  122. assert_equal ["Database can't be blank"], issue.errors.full_messages
  123. # Invalid value
  124. issue.custom_field_values = { field.id => 'SQLServer' }
  125. assert !issue.save
  126. assert_equal ["Database is not included in the list"], issue.errors.full_messages
  127. # Valid value
  128. issue.custom_field_values = { field.id => 'PostgreSQL' }
  129. assert issue.save
  130. issue.reload
  131. assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  132. end
  133. def test_create_with_group_assignment
  134. with_settings :issue_group_assignment => '1' do
  135. assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
  136. :subject => 'Group assignment',
  137. :assigned_to_id => 11).save
  138. issue = Issue.first(:order => 'id DESC')
  139. assert_kind_of Group, issue.assigned_to
  140. assert_equal Group.find(11), issue.assigned_to
  141. end
  142. end
  143. def test_create_with_parent_issue_id
  144. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  145. :author_id => 1, :subject => 'Group assignment',
  146. :parent_issue_id => 1)
  147. assert_save issue
  148. assert_equal 1, issue.parent_issue_id
  149. assert_equal Issue.find(1), issue.parent
  150. end
  151. def test_create_with_sharp_parent_issue_id
  152. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  153. :author_id => 1, :subject => 'Group assignment',
  154. :parent_issue_id => "#1")
  155. assert_save issue
  156. assert_equal 1, issue.parent_issue_id
  157. assert_equal Issue.find(1), issue.parent
  158. end
  159. def test_create_with_invalid_parent_issue_id
  160. set_language_if_valid 'en'
  161. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  162. :author_id => 1, :subject => 'Group assignment',
  163. :parent_issue_id => '01ABC')
  164. assert !issue.save
  165. assert_equal '01ABC', issue.parent_issue_id
  166. assert_include 'Parent task is invalid', issue.errors.full_messages
  167. end
  168. def test_create_with_invalid_sharp_parent_issue_id
  169. set_language_if_valid 'en'
  170. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  171. :author_id => 1, :subject => 'Group assignment',
  172. :parent_issue_id => '#01ABC')
  173. assert !issue.save
  174. assert_equal '#01ABC', issue.parent_issue_id
  175. assert_include 'Parent task is invalid', issue.errors.full_messages
  176. end
  177. def assert_visibility_match(user, issues)
  178. assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  179. end
  180. def test_visible_scope_for_anonymous
  181. # Anonymous user should see issues of public projects only
  182. issues = Issue.visible(User.anonymous).all
  183. assert issues.any?
  184. assert_nil issues.detect {|issue| !issue.project.is_public?}
  185. assert_nil issues.detect {|issue| issue.is_private?}
  186. assert_visibility_match User.anonymous, issues
  187. end
  188. def test_visible_scope_for_anonymous_without_view_issues_permissions
  189. # Anonymous user should not see issues without permission
  190. Role.anonymous.remove_permission!(:view_issues)
  191. issues = Issue.visible(User.anonymous).all
  192. assert issues.empty?
  193. assert_visibility_match User.anonymous, issues
  194. end
  195. def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
  196. assert Role.anonymous.update_attribute(:issues_visibility, 'default')
  197. issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
  198. assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
  199. assert !issue.visible?(User.anonymous)
  200. end
  201. def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
  202. assert Role.anonymous.update_attribute(:issues_visibility, 'own')
  203. issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
  204. assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
  205. assert !issue.visible?(User.anonymous)
  206. end
  207. def test_visible_scope_for_non_member
  208. user = User.find(9)
  209. assert user.projects.empty?
  210. # Non member user should see issues of public projects only
  211. issues = Issue.visible(user).all
  212. assert issues.any?
  213. assert_nil issues.detect {|issue| !issue.project.is_public?}
  214. assert_nil issues.detect {|issue| issue.is_private?}
  215. assert_visibility_match user, issues
  216. end
  217. def test_visible_scope_for_non_member_with_own_issues_visibility
  218. Role.non_member.update_attribute :issues_visibility, 'own'
  219. Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
  220. user = User.find(9)
  221. issues = Issue.visible(user).all
  222. assert issues.any?
  223. assert_nil issues.detect {|issue| issue.author != user}
  224. assert_visibility_match user, issues
  225. end
  226. def test_visible_scope_for_non_member_without_view_issues_permissions
  227. # Non member user should not see issues without permission
  228. Role.non_member.remove_permission!(:view_issues)
  229. user = User.find(9)
  230. assert user.projects.empty?
  231. issues = Issue.visible(user).all
  232. assert issues.empty?
  233. assert_visibility_match user, issues
  234. end
  235. def test_visible_scope_for_member
  236. user = User.find(9)
  237. # User should see issues of projects for which user has view_issues permissions only
  238. Role.non_member.remove_permission!(:view_issues)
  239. Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
  240. issues = Issue.visible(user).all
  241. assert issues.any?
  242. assert_nil issues.detect {|issue| issue.project_id != 3}
  243. assert_nil issues.detect {|issue| issue.is_private?}
  244. assert_visibility_match user, issues
  245. end
  246. def test_visible_scope_for_member_with_groups_should_return_assigned_issues
  247. user = User.find(8)
  248. assert user.groups.any?
  249. Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
  250. Role.non_member.remove_permission!(:view_issues)
  251. issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
  252. :status_id => 1, :priority => IssuePriority.all.first,
  253. :subject => 'Assignment test',
  254. :assigned_to => user.groups.first,
  255. :is_private => true)
  256. Role.find(2).update_attribute :issues_visibility, 'default'
  257. issues = Issue.visible(User.find(8)).all
  258. assert issues.any?
  259. assert issues.include?(issue)
  260. Role.find(2).update_attribute :issues_visibility, 'own'
  261. issues = Issue.visible(User.find(8)).all
  262. assert issues.any?
  263. assert issues.include?(issue)
  264. end
  265. def test_visible_scope_for_admin
  266. user = User.find(1)
  267. user.members.each(&:destroy)
  268. assert user.projects.empty?
  269. issues = Issue.visible(user).all
  270. assert issues.any?
  271. # Admin should see issues on private projects that admin does not belong to
  272. assert issues.detect {|issue| !issue.project.is_public?}
  273. # Admin should see private issues of other users
  274. assert issues.detect {|issue| issue.is_private? && issue.author != user}
  275. assert_visibility_match user, issues
  276. end
  277. def test_visible_scope_with_project
  278. project = Project.find(1)
  279. issues = Issue.visible(User.find(2), :project => project).all
  280. projects = issues.collect(&:project).uniq
  281. assert_equal 1, projects.size
  282. assert_equal project, projects.first
  283. end
  284. def test_visible_scope_with_project_and_subprojects
  285. project = Project.find(1)
  286. issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
  287. projects = issues.collect(&:project).uniq
  288. assert projects.size > 1
  289. assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  290. end
  291. def test_visible_and_nested_set_scopes
  292. assert_equal 0, Issue.find(1).descendants.visible.all.size
  293. end
  294. def test_open_scope
  295. issues = Issue.open.all
  296. assert_nil issues.detect(&:closed?)
  297. end
  298. def test_open_scope_with_arg
  299. issues = Issue.open(false).all
  300. assert_equal issues, issues.select(&:closed?)
  301. end
  302. def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
  303. version = Version.find(2)
  304. assert version.fixed_issues.any?
  305. assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
  306. end
  307. def test_fixed_version_scope_with_empty_array_should_return_no_result
  308. assert_equal 0, Issue.fixed_version([]).count
  309. end
  310. def test_errors_full_messages_should_include_custom_fields_errors
  311. field = IssueCustomField.find_by_name('Database')
  312. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  313. :status_id => 1, :subject => 'test_create',
  314. :description => 'IssueTest#test_create_with_required_custom_field')
  315. assert issue.available_custom_fields.include?(field)
  316. # Invalid value
  317. issue.custom_field_values = { field.id => 'SQLServer' }
  318. assert !issue.valid?
  319. assert_equal 1, issue.errors.full_messages.size
  320. assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
  321. issue.errors.full_messages.first
  322. end
  323. def test_update_issue_with_required_custom_field
  324. field = IssueCustomField.find_by_name('Database')
  325. field.update_attribute(:is_required, true)
  326. issue = Issue.find(1)
  327. assert_nil issue.custom_value_for(field)
  328. assert issue.available_custom_fields.include?(field)
  329. # No change to custom values, issue can be saved
  330. assert issue.save
  331. # Blank value
  332. issue.custom_field_values = { field.id => '' }
  333. assert !issue.save
  334. # Valid value
  335. issue.custom_field_values = { field.id => 'PostgreSQL' }
  336. assert issue.save
  337. issue.reload
  338. assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  339. end
  340. def test_should_not_update_attributes_if_custom_fields_validation_fails
  341. issue = Issue.find(1)
  342. field = IssueCustomField.find_by_name('Database')
  343. assert issue.available_custom_fields.include?(field)
  344. issue.custom_field_values = { field.id => 'Invalid' }
  345. issue.subject = 'Should be not be saved'
  346. assert !issue.save
  347. issue.reload
  348. assert_equal "Can't print recipes", issue.subject
  349. end
  350. def test_should_not_recreate_custom_values_objects_on_update
  351. field = IssueCustomField.find_by_name('Database')
  352. issue = Issue.find(1)
  353. issue.custom_field_values = { field.id => 'PostgreSQL' }
  354. assert issue.save
  355. custom_value = issue.custom_value_for(field)
  356. issue.reload
  357. issue.custom_field_values = { field.id => 'MySQL' }
  358. assert issue.save
  359. issue.reload
  360. assert_equal custom_value.id, issue.custom_value_for(field).id
  361. end
  362. def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
  363. issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
  364. :status_id => 1, :subject => 'Test',
  365. :custom_field_values => {'2' => 'Test'})
  366. assert !Tracker.find(2).custom_field_ids.include?(2)
  367. issue = Issue.find(issue.id)
  368. issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
  369. issue = Issue.find(issue.id)
  370. custom_value = issue.custom_value_for(2)
  371. assert_not_nil custom_value
  372. assert_equal 'Test', custom_value.value
  373. end
  374. def test_assigning_tracker_id_should_reload_custom_fields_values
  375. issue = Issue.new(:project => Project.find(1))
  376. assert issue.custom_field_values.empty?
  377. issue.tracker_id = 1
  378. assert issue.custom_field_values.any?
  379. end
  380. def test_assigning_attributes_should_assign_project_and_tracker_first
  381. seq = sequence('seq')
  382. issue = Issue.new
  383. issue.expects(:project_id=).in_sequence(seq)
  384. issue.expects(:tracker_id=).in_sequence(seq)
  385. issue.expects(:subject=).in_sequence(seq)
  386. issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
  387. end
  388. def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
  389. attributes = ActiveSupport::OrderedHash.new
  390. attributes['custom_field_values'] = { '1' => 'MySQL' }
  391. attributes['tracker_id'] = '1'
  392. issue = Issue.new(:project => Project.find(1))
  393. issue.attributes = attributes
  394. assert_equal 'MySQL', issue.custom_field_value(1)
  395. end
  396. def test_reload_should_reload_custom_field_values
  397. issue = Issue.generate!
  398. issue.custom_field_values = {'2' => 'Foo'}
  399. issue.save!
  400. issue = Issue.order('id desc').first
  401. assert_equal 'Foo', issue.custom_field_value(2)
  402. issue.custom_field_values = {'2' => 'Bar'}
  403. assert_equal 'Bar', issue.custom_field_value(2)
  404. issue.reload
  405. assert_equal 'Foo', issue.custom_field_value(2)
  406. end
  407. def test_should_update_issue_with_disabled_tracker
  408. p = Project.find(1)
  409. issue = Issue.find(1)
  410. p.trackers.delete(issue.tracker)
  411. assert !p.trackers.include?(issue.tracker)
  412. issue.reload
  413. issue.subject = 'New subject'
  414. assert issue.save
  415. end
  416. def test_should_not_set_a_disabled_tracker
  417. p = Project.find(1)
  418. p.trackers.delete(Tracker.find(2))
  419. issue = Issue.find(1)
  420. issue.tracker_id = 2
  421. issue.subject = 'New subject'
  422. assert !issue.save
  423. assert_not_equal [], issue.errors[:tracker_id]
  424. end
  425. def test_category_based_assignment
  426. issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
  427. :status_id => 1, :priority => IssuePriority.all.first,
  428. :subject => 'Assignment test',
  429. :description => 'Assignment test', :category_id => 1)
  430. assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  431. end
  432. def test_new_statuses_allowed_to
  433. WorkflowTransition.delete_all
  434. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  435. :old_status_id => 1, :new_status_id => 2,
  436. :author => false, :assignee => false)
  437. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  438. :old_status_id => 1, :new_status_id => 3,
  439. :author => true, :assignee => false)
  440. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  441. :old_status_id => 1, :new_status_id => 4,
  442. :author => false, :assignee => true)
  443. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  444. :old_status_id => 1, :new_status_id => 5,
  445. :author => true, :assignee => true)
  446. status = IssueStatus.find(1)
  447. role = Role.find(1)
  448. tracker = Tracker.find(1)
  449. user = User.find(2)
  450. issue = Issue.generate!(:tracker => tracker, :status => status,
  451. :project_id => 1, :author_id => 1)
  452. assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
  453. issue = Issue.generate!(:tracker => tracker, :status => status,
  454. :project_id => 1, :author => user)
  455. assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
  456. issue = Issue.generate!(:tracker => tracker, :status => status,
  457. :project_id => 1, :author_id => 1,
  458. :assigned_to => user)
  459. assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  460. issue = Issue.generate!(:tracker => tracker, :status => status,
  461. :project_id => 1, :author => user,
  462. :assigned_to => user)
  463. assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  464. group = Group.generate!
  465. group.users << user
  466. issue = Issue.generate!(:tracker => tracker, :status => status,
  467. :project_id => 1, :author => user,
  468. :assigned_to => group)
  469. assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  470. end
  471. def test_new_statuses_allowed_to_should_consider_group_assignment
  472. WorkflowTransition.delete_all
  473. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  474. :old_status_id => 1, :new_status_id => 4,
  475. :author => false, :assignee => true)
  476. user = User.find(2)
  477. group = Group.generate!
  478. group.users << user
  479. issue = Issue.generate!(:author_id => 1, :assigned_to => group)
  480. assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
  481. end
  482. def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
  483. admin = User.find(1)
  484. issue = Issue.find(1)
  485. assert !admin.member_of?(issue.project)
  486. expected_statuses = [issue.status] +
  487. WorkflowTransition.find_all_by_old_status_id(
  488. issue.status_id).map(&:new_status).uniq.sort
  489. assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
  490. end
  491. def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
  492. issue = Issue.find(1).copy
  493. assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
  494. issue = Issue.find(2).copy
  495. assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
  496. end
  497. def test_safe_attributes_names_should_not_include_disabled_field
  498. tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
  499. issue = Issue.new(:tracker => tracker)
  500. assert_include 'tracker_id', issue.safe_attribute_names
  501. assert_include 'status_id', issue.safe_attribute_names
  502. assert_include 'subject', issue.safe_attribute_names
  503. assert_include 'description', issue.safe_attribute_names
  504. assert_include 'custom_field_values', issue.safe_attribute_names
  505. assert_include 'custom_fields', issue.safe_attribute_names
  506. assert_include 'lock_version', issue.safe_attribute_names
  507. tracker.core_fields.each do |field|
  508. assert_include field, issue.safe_attribute_names
  509. end
  510. tracker.disabled_core_fields.each do |field|
  511. assert_not_include field, issue.safe_attribute_names
  512. end
  513. end
  514. def test_safe_attributes_should_ignore_disabled_fields
  515. tracker = Tracker.find(1)
  516. tracker.core_fields = %w(assigned_to_id due_date)
  517. tracker.save!
  518. issue = Issue.new(:tracker => tracker)
  519. issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
  520. assert_nil issue.start_date
  521. assert_equal Date.parse('2012-07-14'), issue.due_date
  522. end
  523. def test_safe_attributes_should_accept_target_tracker_enabled_fields
  524. source = Tracker.find(1)
  525. source.core_fields = []
  526. source.save!
  527. target = Tracker.find(2)
  528. target.core_fields = %w(assigned_to_id due_date)
  529. target.save!
  530. issue = Issue.new(:tracker => source)
  531. issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
  532. assert_equal target, issue.tracker
  533. assert_equal Date.parse('2012-07-14'), issue.due_date
  534. end
  535. def test_safe_attributes_should_not_include_readonly_fields
  536. WorkflowPermission.delete_all
  537. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  538. :role_id => 1, :field_name => 'due_date',
  539. :rule => 'readonly')
  540. user = User.find(2)
  541. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  542. assert_equal %w(due_date), issue.read_only_attribute_names(user)
  543. assert_not_include 'due_date', issue.safe_attribute_names(user)
  544. issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
  545. assert_equal Date.parse('2012-07-14'), issue.start_date
  546. assert_nil issue.due_date
  547. end
  548. def test_safe_attributes_should_not_include_readonly_custom_fields
  549. cf1 = IssueCustomField.create!(:name => 'Writable field',
  550. :field_format => 'string',
  551. :is_for_all => true, :tracker_ids => [1])
  552. cf2 = IssueCustomField.create!(:name => 'Readonly field',
  553. :field_format => 'string',
  554. :is_for_all => true, :tracker_ids => [1])
  555. WorkflowPermission.delete_all
  556. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  557. :role_id => 1, :field_name => cf2.id.to_s,
  558. :rule => 'readonly')
  559. user = User.find(2)
  560. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  561. assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
  562. assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
  563. issue.send :safe_attributes=, {'custom_field_values' => {
  564. cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
  565. }}, user
  566. assert_equal 'value1', issue.custom_field_value(cf1)
  567. assert_nil issue.custom_field_value(cf2)
  568. issue.send :safe_attributes=, {'custom_fields' => [
  569. {'id' => cf1.id.to_s, 'value' => 'valuea'},
  570. {'id' => cf2.id.to_s, 'value' => 'valueb'}
  571. ]}, user
  572. assert_equal 'valuea', issue.custom_field_value(cf1)
  573. assert_nil issue.custom_field_value(cf2)
  574. end
  575. def test_editable_custom_field_values_should_return_non_readonly_custom_values
  576. cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
  577. :is_for_all => true, :tracker_ids => [1, 2])
  578. cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
  579. :is_for_all => true, :tracker_ids => [1, 2])
  580. WorkflowPermission.delete_all
  581. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
  582. :field_name => cf2.id.to_s, :rule => 'readonly')
  583. user = User.find(2)
  584. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  585. values = issue.editable_custom_field_values(user)
  586. assert values.detect {|value| value.custom_field == cf1}
  587. assert_nil values.detect {|value| value.custom_field == cf2}
  588. issue.tracker_id = 2
  589. values = issue.editable_custom_field_values(user)
  590. assert values.detect {|value| value.custom_field == cf1}
  591. assert values.detect {|value| value.custom_field == cf2}
  592. end
  593. def test_safe_attributes_should_accept_target_tracker_writable_fields
  594. WorkflowPermission.delete_all
  595. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  596. :role_id => 1, :field_name => 'due_date',
  597. :rule => 'readonly')
  598. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  599. :role_id => 1, :field_name => 'start_date',
  600. :rule => 'readonly')
  601. user = User.find(2)
  602. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  603. issue.send :safe_attributes=, {'start_date' => '2012-07-12',
  604. 'due_date' => '2012-07-14'}, user
  605. assert_equal Date.parse('2012-07-12'), issue.start_date
  606. assert_nil issue.due_date
  607. issue.send :safe_attributes=, {'start_date' => '2012-07-15',
  608. 'due_date' => '2012-07-16',
  609. 'tracker_id' => 2}, user
  610. assert_equal Date.parse('2012-07-12'), issue.start_date
  611. assert_equal Date.parse('2012-07-16'), issue.due_date
  612. end
  613. def test_safe_attributes_should_accept_target_status_writable_fields
  614. WorkflowPermission.delete_all
  615. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  616. :role_id => 1, :field_name => 'due_date',
  617. :rule => 'readonly')
  618. WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
  619. :role_id => 1, :field_name => 'start_date',
  620. :rule => 'readonly')
  621. user = User.find(2)
  622. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  623. issue.send :safe_attributes=, {'start_date' => '2012-07-12',
  624. 'due_date' => '2012-07-14'},
  625. user
  626. assert_equal Date.parse('2012-07-12'), issue.start_date
  627. assert_nil issue.due_date
  628. issue.send :safe_attributes=, {'start_date' => '2012-07-15',
  629. 'due_date' => '2012-07-16',
  630. 'status_id' => 2},
  631. user
  632. assert_equal Date.parse('2012-07-12'), issue.start_date
  633. assert_equal Date.parse('2012-07-16'), issue.due_date
  634. end
  635. def test_required_attributes_should_be_validated
  636. cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
  637. :is_for_all => true, :tracker_ids => [1, 2])
  638. WorkflowPermission.delete_all
  639. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  640. :role_id => 1, :field_name => 'due_date',
  641. :rule => 'required')
  642. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  643. :role_id => 1, :field_name => 'category_id',
  644. :rule => 'required')
  645. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  646. :role_id => 1, :field_name => cf.id.to_s,
  647. :rule => 'required')
  648. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  649. :role_id => 1, :field_name => 'start_date',
  650. :rule => 'required')
  651. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  652. :role_id => 1, :field_name => cf.id.to_s,
  653. :rule => 'required')
  654. user = User.find(2)
  655. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  656. :status_id => 1, :subject => 'Required fields',
  657. :author => user)
  658. assert_equal [cf.id.to_s, "category_id", "due_date"],
  659. issue.required_attribute_names(user).sort
  660. assert !issue.save, "Issue was saved"
  661. assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
  662. issue.errors.full_messages.sort
  663. issue.tracker_id = 2
  664. assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
  665. assert !issue.save, "Issue was saved"
  666. assert_equal ["Foo can't be blank", "Start date can't be blank"],
  667. issue.errors.full_messages.sort
  668. issue.start_date = Date.today
  669. issue.custom_field_values = {cf.id.to_s => 'bar'}
  670. assert issue.save
  671. end
  672. def test_required_attribute_names_for_multiple_roles_should_intersect_rules
  673. WorkflowPermission.delete_all
  674. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  675. :role_id => 1, :field_name => 'due_date',
  676. :rule => 'required')
  677. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  678. :role_id => 1, :field_name => 'start_date',
  679. :rule => 'required')
  680. user = User.find(2)
  681. member = Member.find(1)
  682. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  683. assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
  684. member.role_ids = [1, 2]
  685. member.save!
  686. assert_equal [], issue.required_attribute_names(user.reload)
  687. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  688. :role_id => 2, :field_name => 'due_date',
  689. :rule => 'required')
  690. assert_equal %w(due_date), issue.required_attribute_names(user)
  691. member.role_ids = [1, 2, 3]
  692. member.save!
  693. assert_equal [], issue.required_attribute_names(user.reload)
  694. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  695. :role_id => 2, :field_name => 'due_date',
  696. :rule => 'readonly')
  697. # required + readonly => required
  698. assert_equal %w(due_date), issue.required_attribute_names(user)
  699. end
  700. def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
  701. WorkflowPermission.delete_all
  702. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  703. :role_id => 1, :field_name => 'due_date',
  704. :rule => 'readonly')
  705. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  706. :role_id => 1, :field_name => 'start_date',
  707. :rule => 'readonly')
  708. user = User.find(2)
  709. member = Member.find(1)
  710. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  711. assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
  712. member.role_ids = [1, 2]
  713. member.save!
  714. assert_equal [], issue.read_only_attribute_names(user.reload)
  715. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  716. :role_id => 2, :field_name => 'due_date',
  717. :rule => 'readonly')
  718. assert_equal %w(due_date), issue.read_only_attribute_names(user)
  719. end
  720. def test_copy
  721. issue = Issue.new.copy_from(1)
  722. assert issue.copy?
  723. assert issue.save
  724. issue.reload
  725. orig = Issue.find(1)
  726. assert_equal orig.subject, issue.subject
  727. assert_equal orig.tracker, issue.tracker
  728. assert_equal "125", issue.custom_value_for(2).value
  729. end
  730. def test_copy_should_copy_status
  731. orig = Issue.find(8)
  732. assert orig.status != IssueStatus.default
  733. issue = Issue.new.copy_from(orig)
  734. assert issue.save
  735. issue.reload
  736. assert_equal orig.status, issue.status
  737. end
  738. def test_copy_should_add_relation_with_copied_issue
  739. copied = Issue.find(1)
  740. issue = Issue.new.copy_from(copied)
  741. assert issue.save
  742. issue.reload
  743. assert_equal 1, issue.relations.size
  744. relation = issue.relations.first
  745. assert_equal 'copied_to', relation.relation_type
  746. assert_equal copied, relation.issue_from
  747. assert_equal issue, relation.issue_to
  748. end
  749. def test_copy_should_copy_subtasks
  750. issue = Issue.generate_with_descendants!
  751. copy = issue.reload.copy
  752. copy.author = User.find(7)
  753. assert_difference 'Issue.count', 1+issue.descendants.count do
  754. assert copy.save
  755. end
  756. copy.reload
  757. assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
  758. child_copy = copy.children.detect {|c| c.subject == 'Child1'}
  759. assert_equal %w(Child11), child_copy.children.map(&:subject).sort
  760. assert_equal copy.author, child_copy.author
  761. end
  762. def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
  763. parent = Issue.generate!
  764. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
  765. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
  766. copy = parent.reload.copy
  767. copy.parent_issue_id = parent.id
  768. copy.author = User.find(7)
  769. assert_difference 'Issue.count', 3 do
  770. assert copy.save
  771. end
  772. parent.reload
  773. copy.reload
  774. assert_equal parent, copy.parent
  775. assert_equal 3, parent.children.count
  776. assert_equal 5, parent.descendants.count
  777. assert_equal 2, copy.children.count
  778. assert_equal 2, copy.descendants.count
  779. end
  780. def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
  781. parent = Issue.generate!
  782. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
  783. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
  784. copy = parent.reload.copy
  785. copy.parent_issue_id = child1.id
  786. copy.author = User.find(7)
  787. assert_difference 'Issue.count', 3 do
  788. assert copy.save
  789. end
  790. parent.reload
  791. child1.reload
  792. copy.reload
  793. assert_equal child1, copy.parent
  794. assert_equal 2, parent.children.count
  795. assert_equal 5, parent.descendants.count
  796. assert_equal 1, child1.children.count
  797. assert_equal 3, child1.descendants.count
  798. assert_equal 2, copy.children.count
  799. assert_equal 2, copy.descendants.count
  800. end
  801. def test_copy_should_copy_subtasks_to_target_project
  802. issue = Issue.generate_with_descendants!
  803. copy = issue.copy(:project_id => 3)
  804. assert_difference 'Issue.count', 1+issue.descendants.count do
  805. assert copy.save
  806. end
  807. assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
  808. end
  809. def test_copy_should_not_copy_subtasks_twice_when_saving_twice
  810. issue = Issue.generate_with_descendants!
  811. copy = issue.reload.copy
  812. assert_difference 'Issue.count', 1+issue.descendants.count do
  813. assert copy.save
  814. assert copy.save
  815. end
  816. end
  817. def test_should_not_call_after_project_change_on_creation
  818. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  819. :subject => 'Test', :author_id => 1)
  820. issue.expects(:after_project_change).never
  821. issue.save!
  822. end
  823. def test_should_not_call_after_project_change_on_update
  824. issue = Issue.find(1)
  825. issue.project = Project.find(1)
  826. issue.subject = 'No project change'
  827. issue.expects(:after_project_change).never
  828. issue.save!
  829. end
  830. def test_should_call_after_project_change_on_project_change
  831. issue = Issue.find(1)
  832. issue.project = Project.find(2)
  833. issue.expects(:after_project_change).once
  834. issue.save!
  835. end
  836. def test_adding_journal_should_update_timestamp
  837. issue = Issue.find(1)
  838. updated_on_was = issue.updated_on
  839. issue.init_journal(User.first, "Adding notes")
  840. assert_difference 'Journal.count' do
  841. assert issue.save
  842. end
  843. issue.reload
  844. assert_not_equal updated_on_was, issue.updated_on
  845. end
  846. def test_should_close_duplicates
  847. # Create 3 issues
  848. issue1 = Issue.generate!
  849. issue2 = Issue.generate!
  850. issue3 = Issue.generate!
  851. # 2 is a dupe of 1
  852. IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
  853. :relation_type => IssueRelation::TYPE_DUPLICATES)
  854. # And 3 is a dupe of 2
  855. IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
  856. :relation_type => IssueRelation::TYPE_DUPLICATES)
  857. # And 3 is a dupe of 1 (circular duplicates)
  858. IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
  859. :relation_type => IssueRelation::TYPE_DUPLICATES)
  860. assert issue1.reload.duplicates.include?(issue2)
  861. # Closing issue 1
  862. issue1.init_journal(User.first, "Closing issue1")
  863. issue1.status = IssueStatus.where(:is_closed => true).first
  864. assert issue1.save
  865. # 2 and 3 should be also closed
  866. assert issue2.reload.closed?
  867. assert issue3.reload.closed?
  868. end
  869. def test_should_not_close_duplicated_issue
  870. issue1 = Issue.generate!
  871. issue2 = Issue.generate!
  872. # 2 is a dupe of 1
  873. IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
  874. :relation_type => IssueRelation::TYPE_DUPLICATES)
  875. # 2 is a dup of 1 but 1 is not a duplicate of 2
  876. assert !issue2.reload.duplicates.include?(issue1)
  877. # Closing issue 2
  878. issue2.init_journal(User.first, "Closing issue2")
  879. issue2.status = IssueStatus.where(:is_closed => true).first
  880. assert issue2.save
  881. # 1 should not be also closed
  882. assert !issue1.reload.closed?
  883. end
  884. def test_assignable_versions
  885. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  886. :status_id => 1, :fixed_version_id => 1,
  887. :subject => 'New issue')
  888. assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
  889. end
  890. def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
  891. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  892. :status_id => 1, :fixed_version_id => 1,
  893. :subject => 'New issue')
  894. assert !issue.save
  895. assert_not_equal [], issue.errors[:fixed_version_id]
  896. end
  897. def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
  898. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  899. :status_id => 1, :fixed_version_id => 2,
  900. :subject => 'New issue')
  901. assert !issue.save
  902. assert_not_equal [], issue.errors[:fixed_version_id]
  903. end
  904. def test_should_be_able_to_assign_a_new_issue_to_an_open_version
  905. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  906. :status_id => 1, :fixed_version_id => 3,
  907. :subject => 'New issue')
  908. assert issue.save
  909. end
  910. def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
  911. issue = Issue.find(11)
  912. assert_equal 'closed', issue.fixed_version.status
  913. issue.subject = 'Subject changed'
  914. assert issue.save
  915. end
  916. def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
  917. issue = Issue.find(11)
  918. issue.status_id = 1
  919. assert !issue.save
  920. assert_not_equal [], issue.errors[:base]
  921. end
  922. def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
  923. issue = Issue.find(11)
  924. issue.status_id = 1
  925. issue.fixed_version_id = 3
  926. assert issue.save
  927. end
  928. def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
  929. issue = Issue.find(12)
  930. assert_equal 'locked', issue.fixed_version.status
  931. issue.status_id = 1
  932. assert issue.save
  933. end
  934. def test_should_not_be_able_to_keep_unshared_version_when_changing_project
  935. issue = Issue.find(2)
  936. assert_equal 2, issue.fixed_version_id
  937. issue.project_id = 3
  938. assert_nil issue.fixed_version_id
  939. issue.fixed_version_id = 2
  940. assert !issue.save
  941. assert_include 'Target version is not included in the list', issue.errors.full_messages
  942. end
  943. def test_should_keep_shared_version_when_changing_project
  944. Version.find(2).update_attribute :sharing, 'tree'
  945. issue = Issue.find(2)
  946. assert_equal 2, issue.fixed_version_id
  947. issue.project_id = 3
  948. assert_equal 2, issue.fixed_version_id
  949. assert issue.save
  950. end
  951. def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
  952. assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
  953. end
  954. def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
  955. Project.find(2).disable_module! :issue_tracking
  956. assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
  957. end
  958. def test_move_to_another_project_with_same_category
  959. issue = Issue.find(1)
  960. issue.project = Project.find(2)
  961. assert issue.save
  962. issue.reload
  963. assert_equal 2, issue.project_id
  964. # Category changes
  965. assert_equal 4, issue.category_id
  966. # Make sure time entries were move to the target project
  967. assert_equal 2, issue.time_entries.first.project_id
  968. end
  969. def test_move_to_another_project_without_same_category
  970. issue = Issue.find(2)
  971. issue.project = Project.find(2)
  972. assert issue.save
  973. issue.reload
  974. assert_equal 2, issue.project_id
  975. # Category cleared
  976. assert_nil issue.category_id
  977. end
  978. def test_move_to_another_project_should_clear_fixed_version_when_not_shared
  979. issue = Issue.find(1)
  980. issue.update_attribute(:fixed_version_id, 1)
  981. issue.project = Project.find(2)
  982. assert issue.save
  983. issue.reload
  984. assert_equal 2, issue.project_id
  985. # Cleared fixed_version
  986. assert_equal nil, issue.fixed_version
  987. end
  988. def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
  989. issue = Issue.find(1)
  990. issue.update_attribute(:fixed_version_id, 4)
  991. issue.project = Project.find(5)
  992. assert issue.save
  993. issue.reload
  994. assert_equal 5, issue.project_id
  995. # Keep fixed_version
  996. assert_equal 4, issue.fixed_version_id
  997. end
  998. def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
  999. issue = Issue.find(1)
  1000. issue.update_attribute(:fixed_version_id, 1)
  1001. issue.project = Project.find(5)
  1002. assert issue.save
  1003. issue.reload
  1004. assert_equal 5, issue.project_id
  1005. # Cleared fixed_version
  1006. assert_equal nil, issue.fixed_version
  1007. end
  1008. def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
  1009. issue = Issue.find(1)
  1010. issue.update_attribute(:fixed_version_id, 7)
  1011. issue.project = Project.find(2)
  1012. assert issue.save
  1013. issue.reload
  1014. assert_equal 2, issue.project_id
  1015. # Keep fixed_version
  1016. assert_equal 7, issue.fixed_version_id
  1017. end
  1018. def test_move_to_another_project_should_keep_parent_if_valid
  1019. issue = Issue.find(1)
  1020. issue.update_attribute(:parent_issue_id, 2)
  1021. issue.project = Project.find(3)
  1022. assert issue.save
  1023. issue.reload
  1024. assert_equal 2, issue.parent_id
  1025. end
  1026. def test_move_to_another_project_should_clear_parent_if_not_valid
  1027. issue = Issue.find(1)
  1028. issue.update_attribute(:parent_issue_id, 2)
  1029. issue.project = Project.find(2)
  1030. assert issue.save
  1031. issue.reload
  1032. assert_nil issue.parent_id
  1033. end
  1034. def test_move_to_another_project_with_disabled_tracker
  1035. issue = Issue.find(1)
  1036. target = Project.find(2)
  1037. target.tracker_ids = [3]
  1038. target.save
  1039. issue.project = target
  1040. assert issue.save
  1041. issue.reload
  1042. assert_equal 2, issue.project_id
  1043. assert_equal 3, issue.tracker_id
  1044. end
  1045. def test_copy_to_the_same_project
  1046. issue = Issue.find(1)
  1047. copy = issue.copy
  1048. assert_difference 'Issue.count' do
  1049. copy.save!
  1050. end
  1051. assert_kind_of Issue, copy
  1052. assert_equal issue.project, copy.project
  1053. assert_equal "125", copy.custom_value_for(2).value
  1054. end
  1055. def test_copy_to_another_project_and_tracker
  1056. issue = Issue.find(1)
  1057. copy = issue.copy(:project_id => 3, :tracker_id => 2)
  1058. assert_difference 'Issue.count' do
  1059. copy.save!
  1060. end
  1061. copy.reload
  1062. assert_kind_of Issue, copy
  1063. assert_equal Project.find(3), copy.project
  1064. assert_equal Tracker.find(2), copy.tracker
  1065. # Custom field #2 is not associated with target tracker
  1066. assert_nil copy.custom_value_for(2)
  1067. end
  1068. test "#copy should not create a journal" do
  1069. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
  1070. copy.save!
  1071. assert_equal 0, copy.reload.journals.size
  1072. end
  1073. test "#copy should allow assigned_to changes" do
  1074. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
  1075. assert_equal 3, copy.assigned_to_id
  1076. end
  1077. test "#copy should allow status changes" do
  1078. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
  1079. assert_equal 2, copy.status_id
  1080. end
  1081. test "#copy should allow start date changes" do
  1082. date = Date.today
  1083. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
  1084. assert_equal date, copy.start_date
  1085. end
  1086. test "#copy should allow due date changes" do
  1087. date = Date.today
  1088. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
  1089. assert_equal date, copy.due_date
  1090. end
  1091. test "#copy should set current user as author" do
  1092. User.current = User.find(9)
  1093. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
  1094. assert_equal User.current, copy.author
  1095. end
  1096. test "#copy should create a journal with notes" do
  1097. date = Date.today
  1098. notes = "Notes added when copying"
  1099. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
  1100. copy.init_journal(User.current, notes)
  1101. copy.save!
  1102. assert_equal 1, copy.journals.size
  1103. journal = copy.journals.first
  1104. assert_equal 0, journal.details.size
  1105. assert_equal notes, journal.notes
  1106. end
  1107. def test_valid_parent_project
  1108. issue = Issue.find(1)
  1109. issue_in_same_project = Issue.find(2)
  1110. issue_in_child_project = Issue.find(5)
  1111. issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
  1112. issue_in_other_child_project = Issue.find(6)
  1113. issue_in_different_tree = Issue.find(4)
  1114. with_settings :cross_project_subtasks => '' do
  1115. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1116. assert_equal false, issue.valid_parent_project?(issue_in_child_project)
  1117. assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
  1118. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1119. end
  1120. with_settings :cross_project_subtasks => 'system' do
  1121. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1122. assert_equal true, issue.valid_parent_project?(issue_in_child_project)
  1123. assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
  1124. end
  1125. with_settings :cross_project_subtasks => 'tree' do
  1126. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1127. assert_equal true, issue.valid_parent_project?(issue_in_child_project)
  1128. assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
  1129. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1130. assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
  1131. assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
  1132. end
  1133. with_settings :cross_project_subtasks => 'descendants' do
  1134. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1135. assert_equal false, issue.valid_parent_project?(issue_in_child_project)
  1136. assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
  1137. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1138. assert_equal true, issue_in_child_project.valid_parent_project?(issue)
  1139. assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
  1140. end
  1141. end
  1142. def test_recipients_should_include_previous_assignee
  1143. user = User.find(3)
  1144. user.members.update_all ["mail_notification = ?", false]
  1145. user.update_attribute :mail_notification, 'only_assigned'
  1146. issue = Issue.find(2)
  1147. issue.assigned_to = nil
  1148. assert_include user.mail, issue.recipients
  1149. issue.save!
  1150. assert !issue.recipients.include?(user.mail)
  1151. end
  1152. def test_recipients_should_not_include_users_that_cannot_view_the_issue
  1153. issue = Issue.find(12)
  1154. assert issue.recipients.include?(issue.author.mail)
  1155. # copy the issue to a private project
  1156. copy = issue.copy(:project_id => 5, :tracker_id => 2)
  1157. # author is not a member of project anymore
  1158. assert !copy.recipients.include?(copy.author.mail)
  1159. end
  1160. def test_recipients_should_include_the_assigned_group_members
  1161. group_member = User.generate!
  1162. group = Group.generate!
  1163. group.users << group_member
  1164. issue = Issue.find(12)
  1165. issue.assigned_to = group
  1166. assert issue.recipients.include?(group_member.mail)
  1167. end
  1168. def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
  1169. user = User.find(3)
  1170. issue = Issue.find(9)
  1171. Watcher.create!(:user => user, :watchable => issue)
  1172. assert issue.watched_by?(user)
  1173. assert !issue.watcher_recipients.include?(user.mail)
  1174. end
  1175. def test_issue_destroy
  1176. Issue.find(1).destroy
  1177. assert_nil Issue.find_by_id(1)
  1178. assert_nil TimeEntry.find_by_issue_id(1)
  1179. end
  1180. def test_destroying_a_deleted_issue_should_not_raise_an_error
  1181. issue = Issue.find(1)
  1182. Issue.find(1).destroy
  1183. assert_nothing_raised do
  1184. assert_no_difference 'Issue.count' do
  1185. issue.destroy
  1186. end
  1187. assert issue.destroyed?
  1188. end
  1189. end
  1190. def test_destroying_a_stale_issue_should_not_raise_an_error
  1191. issue = Issue.find(1)
  1192. Issue.find(1).update_attribute :subject, "Updated"
  1193. assert_nothing_raised do
  1194. assert_difference 'Issue.count', -1 do
  1195. issue.destroy
  1196. end
  1197. assert issue.destroyed?
  1198. end
  1199. end
  1200. def test_blocked
  1201. blocked_issue = Issue.find(9)
  1202. blocking_issue = Issue.find(10)
  1203. assert blocked_issue.blocked?
  1204. assert !blocking_issue.blocked?
  1205. end
  1206. def test_blocked_issues_dont_allow_closed_statuses
  1207. blocked_issue = Issue.find(9)
  1208. allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
  1209. assert !allowed_statuses.empty?
  1210. closed_statuses = allowed_statuses.select {|st| st.is_closed?}
  1211. assert closed_statuses.empty?
  1212. end
  1213. def test_unblocked_issues_allow_closed_statuses
  1214. blocking_issue = Issue.find(10)
  1215. allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
  1216. assert !allowed_statuses.empty?
  1217. closed_statuses = allowed_statuses.select {|st| st.is_closed?}
  1218. assert !closed_statuses.empty?
  1219. end
  1220. def test_reschedule_an_issue_without_dates
  1221. with_settings :non_working_week_days => [] do
  1222. issue = Issue.new(:start_date => nil, :due_date => nil)
  1223. issue.reschedule_on '2012-10-09'.to_date
  1224. assert_equal '2012-10-09'.to_date, issue.start_date
  1225. assert_equal '2012-10-09'.to_date, issue.due_date
  1226. end
  1227. with_settings :non_working_week_days => %w(6 7) do
  1228. issue = Issue.new(:start_date => nil, :due_date => nil)
  1229. issue.reschedule_on '2012-10-09'.to_date
  1230. assert_equal '2012-10-09'.to_date, issue.start_date
  1231. assert_equal '2012-10-09'.to_date, issue.due_date
  1232. issue = Issue.new(:start_date => nil, :due_date => nil)
  1233. issue.reschedule_on '2012-10-13'.to_date
  1234. assert_equal '2012-10-15'.to_date, issue.start_date
  1235. assert_equal '2012-10-15'.to_date, issue.due_date
  1236. end
  1237. end
  1238. def test_reschedule_an_issue_with_start_date
  1239. with_settings :non_working_week_days => [] do
  1240. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1241. issue.reschedule_on '2012-10-13'.to_date
  1242. assert_equal '2012-10-13'.to_date, issue.start_date
  1243. assert_equal '2012-10-13'.to_date, issue.due_date
  1244. end
  1245. with_settings :non_working_week_days => %w(6 7) do
  1246. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1247. issue.reschedule_on '2012-10-11'.to_date
  1248. assert_equal '2012-10-11'.to_date, issue.start_date
  1249. assert_equal '2012-10-11'.to_date, issue.due_date
  1250. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1251. issue.reschedule_on '2012-10-13'.to_date
  1252. assert_equal '2012-10-15'.to_date, issue.start_date
  1253. assert_equal '2012-10-15'.to_date, issue.due_date
  1254. end
  1255. end
  1256. def test_reschedule_an_issue_with_start_and_due_dates
  1257. with_settings :non_working_week_days => [] do
  1258. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
  1259. issue.reschedule_on '2012-10-13'.to_date
  1260. assert_equal '2012-10-13'.to_date, issue.start_date
  1261. assert_equal '2012-10-19'.to_date, issue.due_date
  1262. end
  1263. with_settings :non_working_week_days => %w(6 7) do
  1264. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
  1265. issue.reschedule_on '2012-10-11'.to_date
  1266. assert_equal '2012-10-11'.to_date, issue.start_date
  1267. assert_equal '2012-10-23'.to_date, issue.due_date
  1268. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
  1269. issue.reschedule_on '2012-10-13'.to_date
  1270. assert_equal '2012-10-15'.to_date, issue.start_date
  1271. assert_equal '2012-10-25'.to_date, issue.due_date
  1272. end
  1273. end
  1274. def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
  1275. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1276. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1277. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1278. :relation_type => IssueRelation::TYPE_PRECEDES)
  1279. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1280. issue1.reload
  1281. issue1.due_date = '2012-10-23'
  1282. issue1.save!
  1283. issue2.reload
  1284. assert_equal Date.parse('2012-10-24'), issue2.start_date
  1285. assert_equal Date.parse('2012-10-26'), issue2.due_date
  1286. end
  1287. def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
  1288. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1289. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1290. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1291. :relation_type => IssueRelation::TYPE_PRECEDES)
  1292. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1293. issue1.reload
  1294. issue1.start_date = '2012-09-17'
  1295. issue1.due_date = '2012-09-18'
  1296. issue1.save!
  1297. issue2.reload
  1298. assert_equal Date.parse('2012-09-19'), issue2.start_date
  1299. assert_equal Date.parse('2012-09-21'), issue2.due_date
  1300. end
  1301. def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
  1302. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1303. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1304. issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
  1305. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1306. :relation_type => IssueRelation::TYPE_PRECEDES)
  1307. IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
  1308. :relation_type => IssueRelation::TYPE_PRECEDES)
  1309. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1310. issue1.reload
  1311. issue1.start_date = '2012-09-17'
  1312. issue1.due_date = '2012-09-18'
  1313. issue1.save!
  1314. issue2.reload
  1315. # Issue 2 must start after Issue 3
  1316. assert_equal Date.parse('2012-10-03'), issue2.start_date
  1317. assert_equal Date.parse('2012-10-05'), issue2.due_date
  1318. end
  1319. def test_rescheduling_a_stale_issue_should_not_raise_an_error
  1320. with_settings :non_working_week_days => [] do
  1321. stale = Issue.find(1)
  1322. issue = Issue.find(1)
  1323. issue.subject = "Updated"
  1324. issue.save!
  1325. date = 10.days.from_now.to_date
  1326. assert_nothing_raised do
  1327. stale.reschedule_on!(date)
  1328. end
  1329. assert_equal date, stale.reload.start_date
  1330. end
  1331. end
  1332. def test_child_issue_should_consider_parent_soonest_start_on_create
  1333. set_language_if_valid 'en'
  1334. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1335. issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
  1336. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1337. :relation_type => IssueRelation::TYPE_PRECEDES)
  1338. issue1.reload
  1339. issue2.reload
  1340. assert_equal Date.parse('2012-10-18'), issue2.start_date
  1341. child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
  1342. :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
  1343. assert !child.valid?
  1344. assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
  1345. assert_equal Date.parse('2012-10-18'), child.soonest_start
  1346. child.start_date = '2012-10-18'
  1347. assert child.save
  1348. end
  1349. def test_setting_parent_to_a_dependent_issue_should_not_validate
  1350. set_language_if_valid 'en'
  1351. issue1 = Issue.generate!
  1352. issue2 = Issue.generate!
  1353. issue3 = Issue.generate!
  1354. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  1355. IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
  1356. issue3.reload
  1357. issue3.parent_issue_id = issue2.id
  1358. assert !issue3.valid?
  1359. assert_include 'Parent task is invalid', issue3.errors.full_messages
  1360. end
  1361. def test_setting_parent_should_not_allow_circular_dependency
  1362. set_language_if_valid 'en'
  1363. issue1 = Issue.generate!
  1364. issue2 = Issue.generate!
  1365. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  1366. issue3 = Issue.generate!
  1367. issue2.reload
  1368. issue2.parent_issue_id = issue3.id
  1369. issue2.save!
  1370. issue4 = Issue.generate!
  1371. IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
  1372. issue4.reload
  1373. issue4.parent_issue_id = issue1.id
  1374. assert !issue4.valid?
  1375. assert_include 'Parent task is invalid', issue4.errors.full_messages
  1376. end
  1377. def test_overdue
  1378. assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
  1379. assert !Issue.new(:due_date => Date.today).overdue?
  1380. assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
  1381. assert !Issue.new(:due_date => nil).overdue?
  1382. assert !Issue.new(:due_date => 1.day.ago.to_date,
  1383. :status => IssueStatus.where(:is_closed => true).first
  1384. ).overdue?
  1385. end
  1386. test "#behind_schedule? should be false if the issue has no start_date" do
  1387. assert !Issue.new(:start_date => nil,
  1388. :due_date => 1.day.from_now.to_date,
  1389. :done_ratio => 0).behind_schedule?
  1390. end
  1391. test "#behind_schedule? should be false if the issue has no end_date" do
  1392. assert !Issue.new(:start_date => 1.day.from_now.to_date,
  1393. :due_date => nil,
  1394. :done_ratio => 0).behind_schedule?
  1395. end
  1396. test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
  1397. assert !Issue.new(:start_date => 50.days.ago.to_date,
  1398. :due_date => 50.days.from_now.to_date,
  1399. :done_ratio => 90).behind_schedule?
  1400. end
  1401. test "#behind_schedule? should be true if the issue hasn't been started at all" do
  1402. assert Issue.new(:start_date => 1.day.ago.to_date,
  1403. :due_date => 1.day.from_now.to_date,
  1404. :done_ratio => 0).behind_schedule?
  1405. end
  1406. test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
  1407. assert Issue.new(:start_date => 100.days.ago.to_date,
  1408. :due_date => Date.today,
  1409. :done_ratio => 90).behind_schedule?
  1410. end
  1411. test "#assignable_users should be Users" do
  1412. assert_kind_of User, Issue.find(1).assignable_users.first
  1413. end
  1414. test "#assignable_users should include the issue author" do
  1415. non_project_member = User.generate!
  1416. issue = Issue.generate!(:author => non_project_member)
  1417. assert issue.assignable_users.include?(non_project_member)
  1418. end
  1419. test "#assignable_users should include the current assignee" do
  1420. user = User.generate!
  1421. issue = Issue.generate!(:assigned_to => user)
  1422. user.lock!
  1423. assert Issue.find(issue.id).assignable_users.include?(user)
  1424. end
  1425. test "#assignable_users should not show the issue author twice" do
  1426. assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
  1427. assert_equal 2, assignable_user_ids.length
  1428. assignable_user_ids.each do |user_id|
  1429. assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
  1430. "User #{user_id} appears more or less than once"
  1431. end
  1432. end
  1433. test "#assignable_users with issue_group_assignment should include groups" do
  1434. issue = Issue.new(:project => Project.find(2))
  1435. with_settings :issue_group_assignment => '1' do
  1436. assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
  1437. assert issue.assignable_users.include?(Group.find(11))
  1438. end
  1439. end
  1440. test "#assignable_users without issue_group_assignment should not include groups" do
  1441. issue = Issue.new(:project => Project.find(2))
  1442. with_settings :issue_group_assignment => '0' do
  1443. assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
  1444. assert !issue.assignable_users.include?(Group.find(11))
  1445. end
  1446. end
  1447. def test_create_should_send_email_notification
  1448. ActionMailer::Base.deliveries.clear
  1449. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  1450. :author_id => 3, :status_id => 1,
  1451. :priority => IssuePriority.all.first,
  1452. :subject => 'test_create', :estimated_hours => '1:30')
  1453. assert issue.save
  1454. assert_equal 1, ActionMailer::Base.deliveries.size
  1455. end
  1456. def test_update_should_notify_previous_assignee
  1457. ActionMailer::Base.deliveries.clear
  1458. user = User.find(3)
  1459. user.members.update_all ["mail_notification = ?", false]
  1460. user.update_attribute :mail_notification, 'only_assigned'
  1461. issue = Issue.find(2)
  1462. issue.init_journal User.find(1)
  1463. issue.assigned_to = nil
  1464. issue.save!
  1465. assert_include user.mail, ActionMailer::Base.deliveries.last.bcc
  1466. end
  1467. def test_stale_issue_should_not_send_email_notification
  1468. ActionMailer::Base.deliveries.clear
  1469. issue = Issue.find(1)
  1470. stale = Issue.find(1)
  1471. issue.init_journal(User.find(1))
  1472. issue.subject = 'Subjet update'
  1473. assert issue.save
  1474. assert_equal 1, ActionMailer::Base.deliveries.size
  1475. ActionMailer::Base.deliveries.clear
  1476. stale.init_journal(User.find(1))
  1477. stale.subject = 'Another subjet update'
  1478. assert_raise ActiveRecord::StaleObjectError do
  1479. stale.save
  1480. end
  1481. assert ActionMailer::Base.deliveries.empty?
  1482. end
  1483. def test_journalized_description
  1484. IssueCustomField.delete_all
  1485. i = Issue.first
  1486. old_description = i.description
  1487. new_description = "This is the new description"
  1488. i.init_journal(User.find(2))
  1489. i.description = new_description
  1490. assert_difference 'Journal.count', 1 do
  1491. assert_difference 'JournalDetail.count', 1 do
  1492. i.save!
  1493. end
  1494. end
  1495. detail = JournalDetail.first(:order => 'id DESC')
  1496. assert_equal i, detail.journal.journalized
  1497. assert_equal 'attr', detail.property
  1498. assert_equal 'description', detail.prop_key
  1499. assert_equal old_description, detail.old_value
  1500. assert_equal new_description, detail.value
  1501. end
  1502. def test_blank_descriptions_should_not_be_journalized
  1503. IssueCustomField.delete_all
  1504. Issue.update_all("description = NULL", "id=1")
  1505. i = Issue.find(1)
  1506. i.init_journal(User.find(2))
  1507. i.subject = "blank description"
  1508. i.description = "\r\n"
  1509. assert_difference 'Journal.count', 1 do
  1510. assert_difference 'JournalDetail.count', 1 do
  1511. i.save!
  1512. end
  1513. end
  1514. end
  1515. def test_journalized_multi_custom_field
  1516. field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
  1517. :is_filter => true, :is_for_all => true,
  1518. :tracker_ids => [1],
  1519. :possible_values => ['value1', 'value2', 'value3'],
  1520. :multiple => true)
  1521. issue = Issue.create!(:project_id => 1, :tracker_id => 1,
  1522. :subject => 'Test', :author_id => 1)
  1523. assert_difference 'Journal.count' do
  1524. assert_difference 'JournalDetail.count' do
  1525. issue.init_journal(User.first)
  1526. issue.custom_field_values = {field.id => ['value1']}
  1527. issue.save!
  1528. end
  1529. assert_difference 'JournalDetail.count' do
  1530. issue.init_journal(User.first)
  1531. issue.custom_field_values = {field.id => ['value1', 'value2']}
  1532. issue.save!
  1533. end
  1534. assert_difference 'JournalDetail.count', 2 do
  1535. issue.init_journal(User.first)
  1536. issue.custom_field_values = {field.id => ['value3', 'value2']}
  1537. issue.save!
  1538. end
  1539. assert_difference 'JournalDetail.count', 2 do
  1540. issue.init_journal(User.first)
  1541. issue.custom_field_values = {field.id => nil}
  1542. issue.save!
  1543. end
  1544. end
  1545. end
  1546. def test_description_eol_should_be_normalized
  1547. i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
  1548. assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
  1549. end
  1550. def test_saving_twice_should_not_duplicate_journal_details
  1551. i = Issue.first
  1552. i.init_journal(User.find(2), 'Some notes')
  1553. # initial changes
  1554. i.subject = 'New subject'
  1555. i.done_ratio = i.done_ratio + 10
  1556. assert_difference 'Journal.count' do
  1557. assert i.save
  1558. end
  1559. # 1 more change
  1560. i.priority = IssuePriority.where("id <> ?", i.priority_id).first
  1561. assert_no_difference 'Journal.count' do
  1562. assert_difference 'JournalDetail.count', 1 do
  1563. i.save
  1564. end
  1565. end
  1566. # no more change
  1567. assert_no_difference 'Journal.count' do
  1568. assert_no_difference 'JournalDetail.count' do
  1569. i.save
  1570. end
  1571. end
  1572. end
  1573. def test_all_dependent_issues
  1574. IssueRelation.delete_all
  1575. assert IssueRelation.create!(:issue_from => Issue.find(1),
  1576. :issue_to => Issue.find(2),
  1577. :relation_type => IssueRelation::TYPE_PRECEDES)
  1578. assert IssueRelation.create!(:issue_from => Issue.find(2),
  1579. :issue_to => Issue.find(3),
  1580. :relation_type => IssueRelation::TYPE_PRECEDES)
  1581. assert IssueRelation.create!(:issue_from => Issue.find(3),
  1582. :issue_to => Issue.find(8),
  1583. :relation_type => IssueRelation::TYPE_PRECEDES)
  1584. assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
  1585. end
  1586. def test_all_dependent_issues_with_subtask
  1587. IssueRelation.delete_all
  1588. project = Project.generate!(:name => "testproject")
  1589. parentIssue = Issue.generate!(:project => project)
  1590. childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
  1591. childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
  1592. assert_equal [childIssue1.id, childIssue2.id].sort, parentIssue.all_dependent_issues.collect(&:id).uniq.sort
  1593. end
  1594. def test_all_dependent_issues_does_not_include_self
  1595. IssueRelation.delete_all
  1596. project = Project.generate!(:name => "testproject")
  1597. parentIssue = Issue.generate!(:project => project)
  1598. childIssue = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
  1599. assert_equal [childIssue.id], parentIssue.all_dependent_issues.collect(&:id)
  1600. end
  1601. def test_all_dependent_issues_with_parenttask_and_sibling
  1602. IssueRelation.delete_all
  1603. project = Project.generate!(:name => "testproject")
  1604. parentIssue = Issue.generate!(:project => project)
  1605. childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
  1606. childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
  1607. assert_equal [parentIssue.id].sort, childIssue1.all_dependent_issues.collect(&:id)
  1608. end
  1609. def test_all_dependent_issues_with_relation_to_leaf_in_other_tree
  1610. IssueRelation.delete_all
  1611. project = Project.generate!(:name => "testproject")
  1612. parentIssue1 = Issue.generate!(:project => project)
  1613. childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
  1614. childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
  1615. parentIssue2 = Issue.generate!(:project => project)
  1616. childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
  1617. childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
  1618. assert IssueRelation.create(:issue_from => parentIssue1,
  1619. :issue_to => childIssue2_2,
  1620. :relation_type => IssueRelation::TYPE_BLOCKS)
  1621. assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_2.id].sort,
  1622. parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
  1623. end
  1624. def test_all_dependent_issues_with_relation_to_parent_in_other_tree
  1625. IssueRelation.delete_all
  1626. project = Project.generate!(:name => "testproject")
  1627. parentIssue1 = Issue.generate!(:project => project)
  1628. childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
  1629. childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
  1630. parentIssue2 = Issue.generate!(:project => project)
  1631. childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
  1632. childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
  1633. assert IssueRelation.create(:issue_from => parentIssue1,
  1634. :issue_to => parentIssue2,
  1635. :relation_type => IssueRelation::TYPE_BLOCKS)
  1636. assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_1.id, childIssue2_2.id].sort,
  1637. parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
  1638. end
  1639. def test_all_dependent_issues_with_transitive_relation
  1640. IssueRelation.delete_all
  1641. project = Project.generate!(:name => "testproject")
  1642. parentIssue1 = Issue.generate!(:project => project)
  1643. childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
  1644. parentIssue2 = Issue.generate!(:project => project)
  1645. childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
  1646. independentIssue = Issue.generate!(:project => project)
  1647. assert IssueRelation.create(:issue_from => parentIssue1,
  1648. :issue_to => childIssue2_1,
  1649. :relation_type => IssueRelation::TYPE_RELATES)
  1650. assert IssueRelation.create(:issue_from => childIssue2_1,
  1651. :issue_to => independentIssue,
  1652. :relation_type => IssueRelation::TYPE_RELATES)
  1653. assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
  1654. parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
  1655. end
  1656. def test_all_dependent_issues_with_transitive_relation2
  1657. IssueRelation.delete_all
  1658. project = Project.generate!(:name => "testproject")
  1659. parentIssue1 = Issue.generate!(:project => project)
  1660. childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
  1661. parentIssue2 = Issue.generate!(:project => project)
  1662. childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
  1663. independentIssue = Issue.generate!(:project => project)
  1664. assert IssueRelation.create(:issue_from => parentIssue1,
  1665. :issue_to => independentIssue,
  1666. :relation_type => IssueRelation::TYPE_RELATES)
  1667. assert IssueRelation.create(:issue_from => independentIssue,
  1668. :issue_to => childIssue2_1,
  1669. :relation_type => IssueRelation::TYPE_RELATES)
  1670. assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
  1671. parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
  1672. end
  1673. def test_all_dependent_issues_with_persistent_circular_dependency
  1674. IssueRelation.delete_all
  1675. assert IssueRelation.create!(:issue_from => Issue.find(1),
  1676. :issue_to => Issue.find(2),
  1677. :relation_type => IssueRelation::TYPE_PRECEDES)
  1678. assert IssueRelation.create!(:issue_from => Issue.find(2),
  1679. :issue_to => Issue.find(3),
  1680. :relation_type => IssueRelation::TYPE_PRECEDES)
  1681. r = IssueRelation.create!(:issue_from => Issue.find(3),
  1682. :issue_to => Issue.find(7),
  1683. :relation_type => IssueRelation::TYPE_PRECEDES)
  1684. IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
  1685. assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
  1686. end
  1687. def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
  1688. IssueRelation.delete_all
  1689. assert IssueRelation.create!(:issue_from => Issue.find(1),
  1690. :issue_to => Issue.find(2),
  1691. :relation_type => IssueRelation::TYPE_RELATES)
  1692. assert IssueRelation.create!(:issue_from => Issue.find(2),
  1693. :issue_to => Issue.find(3),
  1694. :relation_type => IssueRelation::TYPE_RELATES)
  1695. assert IssueRelation.create!(:issue_from => Issue.find(3),
  1696. :issue_to => Issue.find(8),
  1697. :relation_type => IssueRelation::TYPE_RELATES)
  1698. r = IssueRelation.create!(:issue_from => Issue.find(8),
  1699. :issue_to => Issue.find(7),
  1700. :relation_type => IssueRelation::TYPE_RELATES)
  1701. IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
  1702. r = IssueRelation.create!(:issue_from => Issue.find(3),
  1703. :issue_to => Issue.find(7),
  1704. :relation_type => IssueRelation::TYPE_RELATES)
  1705. IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
  1706. assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
  1707. end
  1708. test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
  1709. @issue = Issue.find(1)
  1710. @issue_status = IssueStatus.find(1)
  1711. @issue_status.update_attribute(:default_done_ratio, 50)
  1712. @issue2 = Issue.find(2)
  1713. @issue_status2 = IssueStatus.find(2)
  1714. @issue_status2.update_attribute(:default_done_ratio, 0)
  1715. with_settings :issue_done_ratio => 'issue_field' do
  1716. assert_equal 0, @issue.done_ratio
  1717. assert_equal 30, @issue2.done_ratio
  1718. end
  1719. with_settings :issue_done_ratio => 'issue_status' do
  1720. assert_equal 50, @issue.done_ratio
  1721. assert_equal 0, @issue2.done_ratio
  1722. end
  1723. end
  1724. test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
  1725. @issue = Issue.find(1)
  1726. @issue_status = IssueStatus.find(1)
  1727. @issue_status.update_attribute(:default_done_ratio, 50)
  1728. @issue2 = Issue.find(2)
  1729. @issue_status2 = IssueStatus.find(2)
  1730. @issue_status2.update_attribute(:default_done_ratio, 0)
  1731. with_settings :issue_done_ratio => 'issue_field' do
  1732. @issue.update_done_ratio_from_issue_status
  1733. @issue2.update_done_ratio_from_issue_status
  1734. assert_equal 0, @issue.read_attribute(:done_ratio)
  1735. assert_equal 30, @issue2.read_attribute(:done_ratio)
  1736. end
  1737. with_settings :issue_done_ratio => 'issue_status' do
  1738. @issue.update_done_ratio_from_issue_status
  1739. @issue2.update_done_ratio_from_issue_status
  1740. assert_equal 50, @issue.read_attribute(:done_ratio)
  1741. assert_equal 0, @issue2.read_attribute(:done_ratio)
  1742. end
  1743. end
  1744. test "#by_tracker" do
  1745. User.current = User.anonymous
  1746. groups = Issue.by_tracker(Project.find(1))
  1747. assert_equal 3, groups.count
  1748. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  1749. end
  1750. test "#by_version" do
  1751. User.current = User.anonymous
  1752. groups = Issue.by_version(Project.find(1))
  1753. assert_equal 3, groups.count
  1754. assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  1755. end
  1756. test "#by_priority" do
  1757. User.current = User.anonymous
  1758. groups = Issue.by_priority(Project.find(1))
  1759. assert_equal 4, groups.count
  1760. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  1761. end
  1762. test "#by_category" do
  1763. User.current = User.anonymous
  1764. groups = Issue.by_category(Project.find(1))
  1765. assert_equal 2, groups.count
  1766. assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  1767. end
  1768. test "#by_assigned_to" do
  1769. User.current = User.anonymous
  1770. groups = Issue.by_assigned_to(Project.find(1))
  1771. assert_equal 2, groups.count
  1772. assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  1773. end
  1774. test "#by_author" do
  1775. User.current = User.anonymous
  1776. groups = Issue.by_author(Project.find(1))
  1777. assert_equal 4, groups.count
  1778. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  1779. end
  1780. test "#by_subproject" do
  1781. User.current = User.anonymous
  1782. groups = Issue.by_subproject(Project.find(1))
  1783. # Private descendant not visible
  1784. assert_equal 1, groups.count
  1785. assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  1786. end
  1787. def test_recently_updated_scope
  1788. #should return the last updated issue
  1789. assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
  1790. end
  1791. def test_on_active_projects_scope
  1792. assert Project.find(2).archive
  1793. before = Issue.on_active_project.length
  1794. # test inclusion to results
  1795. issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
  1796. assert_equal before + 1, Issue.on_active_project.length
  1797. # Move to an archived project
  1798. issue.project = Project.find(2)
  1799. assert issue.save
  1800. assert_equal before, Issue.on_active_project.length
  1801. end
  1802. test "Issue#recipients should include project recipients" do
  1803. issue = Issue.generate!
  1804. assert issue.project.recipients.present?
  1805. issue.project.recipients.each do |project_recipient|
  1806. assert issue.recipients.include?(project_recipient)
  1807. end
  1808. end
  1809. test "Issue#recipients should include the author if the author is active" do
  1810. issue = Issue.generate!(:author => User.generate!)
  1811. assert issue.author, "No author set for Issue"
  1812. assert issue.recipients.include?(issue.author.mail)
  1813. end
  1814. test "Issue#recipients should include the assigned to user if the assigned to user is active" do
  1815. issue = Issue.generate!(:assigned_to => User.generate!)
  1816. assert issue.assigned_to, "No assigned_to set for Issue"
  1817. assert issue.recipients.include?(issue.assigned_to.mail)
  1818. end
  1819. test "Issue#recipients should not include users who opt out of all email" do
  1820. issue = Issue.generate!(:author => User.generate!)
  1821. issue.author.update_attribute(:mail_notification, :none)
  1822. assert !issue.recipients.include?(issue.author.mail)
  1823. end
  1824. test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
  1825. issue = Issue.generate!(:author => User.generate!)
  1826. issue.author.update_attribute(:mail_notification, :only_assigned)
  1827. assert !issue.recipients.include?(issue.author.mail)
  1828. end
  1829. test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
  1830. issue = Issue.generate!(:assigned_to => User.generate!)
  1831. issue.assigned_to.update_attribute(:mail_notification, :only_owner)
  1832. assert !issue.recipients.include?(issue.assigned_to.mail)
  1833. end
  1834. def test_last_journal_id_with_journals_should_return_the_journal_id
  1835. assert_equal 2, Issue.find(1).last_journal_id
  1836. end
  1837. def test_last_journal_id_without_journals_should_return_nil
  1838. assert_nil Issue.find(3).last_journal_id
  1839. end
  1840. def test_journals_after_should_return_journals_with_greater_id
  1841. assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
  1842. assert_equal [], Issue.find(1).journals_after('2')
  1843. end
  1844. def test_journals_after_with_blank_arg_should_return_all_journals
  1845. assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
  1846. end
  1847. def test_css_classes_should_include_tracker
  1848. issue = Issue.new(:tracker => Tracker.find(2))
  1849. classes = issue.css_classes.split(' ')
  1850. assert_include 'tracker-2', classes
  1851. end
  1852. def test_css_classes_should_include_priority
  1853. issue = Issue.new(:priority => IssuePriority.find(8))
  1854. classes = issue.css_classes.split(' ')
  1855. assert_include 'priority-8', classes
  1856. assert_include 'priority-highest', classes
  1857. end
  1858. def test_css_classes_should_include_user_and_group_assignment
  1859. project = Project.first
  1860. user = User.generate!
  1861. group = Group.generate!
  1862. Member.create!(:principal => group, :project => project, :role_ids => [1, 2])
  1863. group.users << user
  1864. assert user.member_of?(project)
  1865. issue1 = Issue.generate(:assigned_to_id => group.id)
  1866. assert_include 'assigned-to-my-group', issue1.css_classes(user)
  1867. assert_not_include 'assigned-to-me', issue1.css_classes(user)
  1868. issue2 = Issue.generate(:assigned_to_id => user.id)
  1869. assert_not_include 'assigned-to-my-group', issue2.css_classes(user)
  1870. assert_include 'assigned-to-me', issue2.css_classes(user)
  1871. end
  1872. def test_save_attachments_with_hash_should_save_attachments_in_keys_order
  1873. set_tmp_attachments_directory
  1874. issue = Issue.generate!
  1875. issue.save_attachments({
  1876. 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
  1877. '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
  1878. '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
  1879. })
  1880. issue.attach_saved_attachments
  1881. assert_equal 3, issue.reload.attachments.count
  1882. assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
  1883. end
  1884. def test_closed_on_should_be_nil_when_creating_an_open_issue
  1885. issue = Issue.generate!(:status_id => 1).reload
  1886. assert !issue.closed?
  1887. assert_nil issue.closed_on
  1888. end
  1889. def test_closed_on_should_be_set_when_creating_a_closed_issue
  1890. issue = Issue.generate!(:status_id => 5).reload
  1891. assert issue.closed?
  1892. assert_not_nil issue.closed_on
  1893. assert_equal issue.updated_on, issue.closed_on
  1894. assert_equal issue.created_on, issue.closed_on
  1895. end
  1896. def test_closed_on_should_be_nil_when_updating_an_open_issue
  1897. issue = Issue.find(1)
  1898. issue.subject = 'Not closed yet'
  1899. issue.save!
  1900. issue.reload
  1901. assert_nil issue.closed_on
  1902. end
  1903. def test_closed_on_should_be_set_when_closing_an_open_issue
  1904. issue = Issue.find(1)
  1905. issue.subject = 'Now closed'
  1906. issue.status_id = 5
  1907. issue.save!
  1908. issue.reload
  1909. assert_not_nil issue.closed_on
  1910. assert_equal issue.updated_on, issue.closed_on
  1911. end
  1912. def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
  1913. issue = Issue.open(false).first
  1914. was_closed_on = issue.closed_on
  1915. assert_not_nil was_closed_on
  1916. issue.subject = 'Updating a closed issue'
  1917. issue.save!
  1918. issue.reload
  1919. assert_equal was_closed_on, issue.closed_on
  1920. end
  1921. def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
  1922. issue = Issue.open(false).first
  1923. was_closed_on = issue.closed_on
  1924. assert_not_nil was_closed_on
  1925. issue.subject = 'Reopening a closed issue'
  1926. issue.status_id = 1
  1927. issue.save!
  1928. issue.reload
  1929. assert !issue.closed?
  1930. assert_equal was_closed_on, issue.closed_on
  1931. end
  1932. def test_status_was_should_return_nil_for_new_issue
  1933. issue = Issue.new
  1934. assert_nil issue.status_was
  1935. end
  1936. def test_status_was_should_return_status_before_change
  1937. issue = Issue.find(1)
  1938. issue.status = IssueStatus.find(2)
  1939. assert_equal IssueStatus.find(1), issue.status_was
  1940. end
  1941. def test_status_was_should_be_reset_on_save
  1942. issue = Issue.find(1)
  1943. issue.status = IssueStatus.find(2)
  1944. assert_equal IssueStatus.find(1), issue.status_was
  1945. assert issue.save!
  1946. assert_equal IssueStatus.find(2), issue.status_was
  1947. end
  1948. end