You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_test.rb 129KB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562
  1. # frozen_string_literal: true
  2. # Redmine - project management software
  3. # Copyright (C) 2006-2023 Jean-Philippe Lang
  4. #
  5. # This program is free software; you can redistribute it and/or
  6. # modify it under the terms of the GNU General Public License
  7. # as published by the Free Software Foundation; either version 2
  8. # of the License, or (at your option) any later version.
  9. #
  10. # This program is distributed in the hope that it will be useful,
  11. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  12. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13. # GNU General Public License for more details.
  14. #
  15. # You should have received a copy of the GNU General Public License
  16. # along with this program; if not, write to the Free Software
  17. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  18. require_relative '../test_helper'
  19. class IssueTest < ActiveSupport::TestCase
  20. fixtures :projects, :users, :email_addresses, :user_preferences, :members, :member_roles, :roles,
  21. :groups_users,
  22. :trackers, :projects_trackers,
  23. :enabled_modules,
  24. :versions,
  25. :issue_statuses, :issue_categories, :issue_relations, :workflows,
  26. :enumerations,
  27. :issues, :journals, :journal_details,
  28. :watchers,
  29. :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
  30. :time_entries
  31. include Redmine::I18n
  32. def setup
  33. User.current = nil
  34. set_language_if_valid 'en'
  35. end
  36. def teardown
  37. User.current = nil
  38. end
  39. def test_initialize
  40. issue = Issue.new
  41. assert_nil issue.project_id
  42. assert_nil issue.tracker_id
  43. assert_nil issue.status_id
  44. assert_nil issue.author_id
  45. assert_nil issue.assigned_to_id
  46. assert_nil issue.category_id
  47. assert_equal IssuePriority.default, issue.priority
  48. end
  49. def test_create
  50. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
  51. :status_id => 1, :priority => IssuePriority.first,
  52. :subject => 'test_create',
  53. :description => 'IssueTest#test_create', :estimated_hours => '1:30')
  54. assert issue.save
  55. issue.reload
  56. assert_equal 1.5, issue.estimated_hours
  57. end
  58. def test_create_minimal
  59. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create')
  60. assert issue.save
  61. assert_equal issue.tracker.default_status, issue.status
  62. assert issue.description.nil?
  63. assert_nil issue.estimated_hours
  64. end
  65. def test_create_with_all_fields_disabled
  66. tracker = Tracker.find(1)
  67. tracker.core_fields = []
  68. tracker.save!
  69. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create_with_all_fields_disabled')
  70. assert_save issue
  71. end
  72. def test_default_priority_should_be_set_when_priority_field_is_disabled
  73. tracker = Tracker.find(1)
  74. tracker.core_fields = tracker.core_fields - ['priority_id']
  75. tracker.save!
  76. issue = Issue.new(:project_id => 1, :tracker_id => tracker.id, :author_id => 1, :subject => 'priority_id is disabled')
  77. issue.save!
  78. assert_equal IssuePriority.default, issue.priority
  79. end
  80. def test_start_date_format_should_be_validated
  81. set_language_if_valid 'en'
  82. ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
  83. issue = Issue.new(:start_date => invalid_date)
  84. assert !issue.valid?
  85. assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
  86. end
  87. end
  88. def test_due_date_format_should_be_validated
  89. set_language_if_valid 'en'
  90. ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
  91. issue = Issue.new(:due_date => invalid_date)
  92. assert !issue.valid?
  93. assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
  94. end
  95. end
  96. def test_due_date_lesser_than_start_date_should_not_validate
  97. set_language_if_valid 'en'
  98. issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
  99. assert !issue.valid?
  100. assert_include 'Due date must be greater than start date', issue.errors.full_messages
  101. end
  102. def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
  103. issue = Issue.generate(:start_date => '2013-06-04')
  104. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  105. assert !issue.valid?
  106. assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  107. end
  108. def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
  109. issue = Issue.generate!(:start_date => '2013-06-04')
  110. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  111. issue.start_date = '2013-06-07'
  112. assert !issue.valid?
  113. assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
  114. end
  115. def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
  116. issue = Issue.generate!(:start_date => '2013-06-04')
  117. issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
  118. assert issue.valid?
  119. end
  120. def test_estimated_hours_should_be_validated
  121. set_language_if_valid 'en'
  122. ['-2', '123abc'].each do |invalid|
  123. issue = Issue.new(:estimated_hours => invalid)
  124. assert !issue.valid?
  125. assert_include 'Estimated time is invalid', issue.errors.full_messages
  126. end
  127. end
  128. def test_create_with_required_custom_field
  129. set_language_if_valid 'en'
  130. field = IssueCustomField.find_by_name('Database')
  131. field.update!(:is_required => true)
  132. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  133. :status_id => 1, :subject => 'test_create',
  134. :description => 'IssueTest#test_create_with_required_custom_field')
  135. assert issue.available_custom_fields.include?(field)
  136. # No value for the custom field
  137. assert !issue.save
  138. assert_equal ["Database cannot be blank"], issue.errors.full_messages
  139. # Blank value
  140. issue.custom_field_values = {field.id => ''}
  141. assert !issue.save
  142. assert_equal ["Database cannot be blank"], issue.errors.full_messages
  143. # Invalid value
  144. issue.custom_field_values = {field.id => 'SQLServer'}
  145. assert !issue.save
  146. assert_equal ["Database is not included in the list"], issue.errors.full_messages
  147. # Valid value
  148. issue.custom_field_values = {field.id => 'PostgreSQL'}
  149. assert issue.save
  150. issue.reload
  151. assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  152. end
  153. def test_create_with_group_assignment
  154. with_settings :issue_group_assignment => '1' do
  155. assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
  156. :subject => 'Group assignment',
  157. :assigned_to_id => 11).save
  158. issue = Issue.order('id DESC').first
  159. assert_kind_of Group, issue.assigned_to
  160. assert_equal Group.find(11), issue.assigned_to
  161. end
  162. end
  163. def test_create_with_parent_issue_id
  164. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  165. :author_id => 1, :subject => 'Group assignment',
  166. :parent_issue_id => 1)
  167. assert_save issue
  168. assert_equal 1, issue.parent_issue_id
  169. assert_equal Issue.find(1), issue.parent
  170. end
  171. def test_create_with_sharp_parent_issue_id
  172. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  173. :author_id => 1, :subject => 'Group assignment',
  174. :parent_issue_id => "#1")
  175. assert_save issue
  176. assert_equal 1, issue.parent_issue_id
  177. assert_equal Issue.find(1), issue.parent
  178. end
  179. def test_create_with_invalid_parent_issue_id
  180. set_language_if_valid 'en'
  181. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  182. :author_id => 1, :subject => 'Group assignment',
  183. :parent_issue_id => '01ABC')
  184. assert !issue.save
  185. assert_equal '01ABC', issue.parent_issue_id
  186. assert_include 'Parent task is invalid', issue.errors.full_messages
  187. end
  188. def test_create_with_invalid_sharp_parent_issue_id
  189. set_language_if_valid 'en'
  190. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  191. :author_id => 1, :subject => 'Group assignment',
  192. :parent_issue_id => '#01ABC')
  193. assert !issue.save
  194. assert_equal '#01ABC', issue.parent_issue_id
  195. assert_include 'Parent task is invalid', issue.errors.full_messages
  196. end
  197. def assert_visibility_match(user, issues)
  198. assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
  199. end
  200. def test_create_with_emoji_character
  201. skip if Redmine::Database.mysql? && !is_mysql_utf8mb4
  202. set_language_if_valid 'en'
  203. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  204. :author_id => 1, :subject => 'Group assignment',
  205. :description => 'Hello 😀')
  206. assert issue.save
  207. assert_equal 'Hello 😀', issue.description
  208. end
  209. def test_visible_scope_for_anonymous
  210. # Anonymous user should see issues of public projects only
  211. issues = Issue.visible(User.anonymous).to_a
  212. assert issues.any?
  213. assert_nil issues.detect {|issue| !issue.project.is_public?}
  214. assert_nil issues.detect {|issue| issue.is_private?}
  215. assert_visibility_match User.anonymous, issues
  216. end
  217. def test_visible_scope_for_anonymous_without_view_issues_permissions
  218. # Anonymous user should not see issues without permission
  219. Role.anonymous.remove_permission!(:view_issues)
  220. issues = Issue.visible(User.anonymous).to_a
  221. assert issues.empty?
  222. assert_visibility_match User.anonymous, issues
  223. end
  224. def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
  225. Role.anonymous.remove_permission!(:view_issues)
  226. Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])
  227. issues = Issue.visible(User.anonymous).all
  228. assert issues.any?
  229. assert_equal [1], issues.map(&:project_id).uniq.sort
  230. assert_visibility_match User.anonymous, issues
  231. end
  232. def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
  233. Role.anonymous.update!(:issues_visibility => 'default')
  234. issue = Issue.generate!(:author => User.anonymous, :is_private => true)
  235. assert_not Issue.where(:id => issue.id).visible(User.anonymous).exists?
  236. assert !issue.visible?(User.anonymous)
  237. end
  238. def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
  239. assert Role.anonymous.update!(:issues_visibility => 'own')
  240. issue = Issue.generate!(:author => User.anonymous, :is_private => true)
  241. assert_not Issue.where(:id => issue.id).visible(User.anonymous).exists?
  242. assert !issue.visible?(User.anonymous)
  243. end
  244. def test_visible_scope_for_non_member
  245. user = User.find(9)
  246. assert user.projects.empty?
  247. # Non member user should see issues of public projects only
  248. issues = Issue.visible(user).to_a
  249. assert issues.any?
  250. assert_nil issues.detect {|issue| !issue.project.is_public?}
  251. assert_nil issues.detect {|issue| issue.is_private?}
  252. assert_visibility_match user, issues
  253. end
  254. def test_visible_scope_for_non_member_with_own_issues_visibility
  255. Role.non_member.update! :issues_visibility => 'own'
  256. Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
  257. user = User.find(9)
  258. issues = Issue.visible(user).to_a
  259. assert issues.any?
  260. assert_nil issues.detect {|issue| issue.author != user}
  261. assert_visibility_match user, issues
  262. end
  263. def test_visible_scope_for_non_member_without_view_issues_permissions
  264. # Non member user should not see issues without permission
  265. Role.non_member.remove_permission!(:view_issues)
  266. user = User.find(9)
  267. assert user.projects.empty?
  268. issues = Issue.visible(user).to_a
  269. assert issues.empty?
  270. assert_visibility_match user, issues
  271. end
  272. def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
  273. Role.non_member.remove_permission!(:view_issues)
  274. Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
  275. user = User.find(9)
  276. issues = Issue.visible(user).all
  277. assert issues.any?
  278. assert_equal [1], issues.map(&:project_id).uniq.sort
  279. assert_visibility_match user, issues
  280. end
  281. def test_visible_scope_for_member
  282. user = User.find(9)
  283. # User should see issues of projects for which user has view_issues permissions only
  284. Role.non_member.remove_permission!(:view_issues)
  285. Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
  286. issues = Issue.visible(user).to_a
  287. assert issues.any?
  288. assert_nil issues.detect {|issue| issue.project_id != 3}
  289. assert_nil issues.detect {|issue| issue.is_private?}
  290. assert_visibility_match user, issues
  291. end
  292. def test_visible_scope_for_member_without_view_issues_permission_and_non_member_role_having_the_permission
  293. Role.non_member.add_permission!(:view_issues)
  294. Role.find(1).remove_permission!(:view_issues)
  295. user = User.find(2)
  296. assert_equal 0, Issue.where(:project_id => 1).visible(user).count
  297. assert_equal false, Issue.where(:project_id => 1).first.visible?(user)
  298. end
  299. def test_visible_scope_with_custom_non_member_role_having_restricted_permission
  300. role = Role.generate!(:permissions => [:view_project])
  301. assert Role.non_member.has_permission?(:view_issues)
  302. user = User.generate!
  303. Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])
  304. issues = Issue.visible(user).to_a
  305. assert issues.any?
  306. assert_nil issues.detect {|issue| issue.project_id == 1}
  307. end
  308. def test_visible_scope_with_custom_non_member_role_having_extended_permission
  309. role = Role.generate!(:permissions => [:view_project, :view_issues])
  310. Role.non_member.remove_permission!(:view_issues)
  311. user = User.generate!
  312. Member.create!(:principal => Group.non_member, :project_id => 1, :roles => [role])
  313. issues = Issue.visible(user).to_a
  314. assert issues.any?
  315. assert_not_nil issues.detect {|issue| issue.project_id == 1}
  316. end
  317. def test_visible_scope_for_member_with_groups_should_return_assigned_issues
  318. user = User.find(8)
  319. assert user.groups.any?
  320. group = user.groups.first
  321. Member.create!(:principal => group, :project_id => 1, :role_ids => [2])
  322. Role.non_member.remove_permission!(:view_issues)
  323. with_settings :issue_group_assignment => '1' do
  324. issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 3,
  325. :status_id => 1, :priority => IssuePriority.first,
  326. :subject => 'Assignment test',
  327. :assigned_to => group,
  328. :is_private => true)
  329. Role.find(2).update! :issues_visibility => 'default'
  330. issues = Issue.visible(User.find(8)).to_a
  331. assert issues.any?
  332. assert issues.include?(issue)
  333. Role.find(2).update! :issues_visibility => 'own'
  334. issues = Issue.visible(User.find(8)).to_a
  335. assert issues.any?
  336. assert_include issue, issues
  337. end
  338. end
  339. def test_visible_scope_for_member_with_limited_tracker_ids
  340. role = Role.find(1)
  341. role.set_permission_trackers :view_issues, [2]
  342. role.save!
  343. user = User.find(2)
  344. issues = Issue.where(:project_id => 1).visible(user).to_a
  345. assert issues.any?
  346. assert_equal [2], issues.map(&:tracker_id).uniq
  347. assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
  348. end
  349. def test_visible_scope_should_consider_tracker_ids_on_each_project
  350. user = User.generate!
  351. project1 = Project.generate!
  352. role1 = Role.generate!
  353. role1.add_permission! :view_issues
  354. role1.set_permission_trackers :view_issues, :all
  355. role1.save!
  356. User.add_to_project(user, project1, role1)
  357. project2 = Project.generate!
  358. role2 = Role.generate!
  359. role2.add_permission! :view_issues
  360. role2.set_permission_trackers :view_issues, [2]
  361. role2.save!
  362. User.add_to_project(user, project2, role2)
  363. visible_issues = [
  364. Issue.generate!(:project => project1, :tracker_id => 1),
  365. Issue.generate!(:project => project1, :tracker_id => 2),
  366. Issue.generate!(:project => project2, :tracker_id => 2)
  367. ]
  368. hidden_issue = Issue.generate!(:project => project2, :tracker_id => 1)
  369. issues = Issue.where(:project_id => [project1.id, project2.id]).visible(user)
  370. assert_equal visible_issues.map(&:id), issues.ids.sort
  371. assert visible_issues.all? {|issue| issue.visible?(user)}
  372. assert !hidden_issue.visible?(user)
  373. end
  374. def test_visible_scope_should_not_consider_roles_without_view_issues_permission
  375. user = User.generate!
  376. role1 = Role.generate!
  377. role1.remove_permission! :view_issues
  378. role1.set_permission_trackers :view_issues, :all
  379. role1.save!
  380. role2 = Role.generate!
  381. role2.add_permission! :view_issues
  382. role2.set_permission_trackers :view_issues, [2]
  383. role2.save!
  384. User.add_to_project(user, Project.find(1), [role1, role2])
  385. issues = Issue.where(:project_id => 1).visible(user).to_a
  386. assert issues.any?
  387. assert_equal [2], issues.map(&:tracker_id).uniq
  388. assert Issue.where(:project_id => 1).all? {|issue| issue.visible?(user) ^ issue.tracker_id != 2}
  389. end
  390. def test_visible_scope_for_admin
  391. user = User.find(1)
  392. user.members.each(&:destroy)
  393. assert user.projects.empty?
  394. issues = Issue.visible(user).to_a
  395. assert issues.any?
  396. # Admin should see issues on private projects that admin does not belong to
  397. assert issues.detect {|issue| !issue.project.is_public?}
  398. # Admin should see private issues of other users
  399. assert issues.detect {|issue| issue.is_private? && issue.author != user}
  400. assert_visibility_match user, issues
  401. end
  402. def test_visible_scope_with_project
  403. project = Project.find(1)
  404. issues = Issue.visible(User.find(2), :project => project).to_a
  405. projects = issues.collect(&:project).uniq
  406. assert_equal 1, projects.size
  407. assert_equal project, projects.first
  408. end
  409. def test_visible_scope_with_project_and_subprojects
  410. project = Project.find(1)
  411. issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
  412. projects = issues.collect(&:project).uniq
  413. assert projects.size > 1
  414. assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
  415. end
  416. def test_visible_and_nested_set_scopes
  417. user = User.generate!
  418. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  419. parent = Issue.generate!(:assigned_to => user)
  420. assert parent.visible?(user)
  421. child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
  422. child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
  423. parent.reload
  424. child1.reload
  425. child2.reload
  426. assert child1.visible?(user)
  427. assert child2.visible?(user)
  428. assert_equal 2, parent.descendants.count
  429. assert_equal 2, parent.descendants.visible(user).count
  430. # awesome_nested_set 2-1-stable branch has regression.
  431. # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
  432. # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
  433. assert_equal 2, parent.descendants.collect{|i| i}.size
  434. assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
  435. end
  436. def test_visible_scope_with_unsaved_user_should_not_raise_an_error
  437. user = User.new
  438. assert_nothing_raised do
  439. Issue.visible(user).to_a
  440. end
  441. end
  442. def test_open_scope
  443. issues = Issue.open.to_a
  444. assert_nil issues.detect(&:closed?)
  445. end
  446. def test_open_scope_with_arg
  447. issues = Issue.open(false).to_a
  448. assert_equal issues, issues.select(&:closed?)
  449. end
  450. def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
  451. version = Version.find(2)
  452. assert version.fixed_issues.any?
  453. assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
  454. end
  455. def test_fixed_version_scope_with_empty_array_should_return_no_result
  456. assert_equal 0, Issue.fixed_version([]).count
  457. end
  458. def test_assigned_to_scope_should_return_issues_assigned_to_the_user
  459. user = User.generate!
  460. issue = Issue.generate!
  461. Issue.where(:id => issue.id).update_all :assigned_to_id => user.id
  462. assert_equal [issue], Issue.assigned_to(user).to_a
  463. end
  464. def test_assigned_to_scope_should_return_issues_assigned_to_the_user_groups
  465. group = Group.generate!
  466. user = User.generate!
  467. group.users << user
  468. issue = Issue.generate!
  469. Issue.where(:id => issue.id).update_all :assigned_to_id => group.id
  470. assert_equal [issue], Issue.assigned_to(user).to_a
  471. end
  472. def test_issue_should_be_readonly_on_closed_project
  473. issue = Issue.find(1)
  474. user = User.find(1)
  475. assert_equal true, issue.visible?(user)
  476. assert_equal true, issue.editable?(user)
  477. assert_equal true, issue.deletable?(user)
  478. issue.project.close
  479. issue.reload
  480. assert_equal true, issue.visible?(user)
  481. assert_equal false, issue.editable?(user)
  482. assert_equal false, issue.deletable?(user)
  483. end
  484. def test_issue_should_editable_by_author
  485. Role.all.each do |r|
  486. r.remove_permission! :edit_issues
  487. r.add_permission! :edit_own_issues
  488. end
  489. issue = Issue.find(1)
  490. user = User.find_by_login('jsmith')
  491. # author
  492. assert_equal user, issue.author
  493. assert_equal true, issue.attributes_editable?(user)
  494. # not author
  495. assert_equal false, issue.attributes_editable?(User.find_by_login('dlopper'))
  496. end
  497. def test_errors_full_messages_should_include_custom_fields_errors
  498. field = IssueCustomField.find_by_name('Database')
  499. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  500. :status_id => 1, :subject => 'test_create',
  501. :description => 'IssueTest#test_create_with_required_custom_field')
  502. assert issue.available_custom_fields.include?(field)
  503. # Invalid value
  504. issue.custom_field_values = {field.id => 'SQLServer'}
  505. assert !issue.valid?
  506. assert_equal 1, issue.errors.full_messages.size
  507. assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
  508. issue.errors.full_messages.first
  509. end
  510. def test_update_issue_with_required_custom_field
  511. field = IssueCustomField.find_by_name('Database')
  512. field.update!(:is_required => true)
  513. issue = Issue.find(1)
  514. assert_nil issue.custom_value_for(field)
  515. assert issue.available_custom_fields.include?(field)
  516. # No change to custom values, issue can be saved
  517. assert issue.save
  518. # Blank value
  519. issue.custom_field_values = {field.id => ''}
  520. assert !issue.save
  521. # Valid value
  522. issue.custom_field_values = {field.id => 'PostgreSQL'}
  523. assert issue.save
  524. issue.reload
  525. assert_equal 'PostgreSQL', issue.custom_value_for(field).value
  526. end
  527. def test_should_not_update_attributes_if_custom_fields_validation_fails
  528. issue = Issue.find(1)
  529. field = IssueCustomField.find_by_name('Database')
  530. assert issue.available_custom_fields.include?(field)
  531. issue.custom_field_values = {field.id => 'Invalid'}
  532. issue.subject = 'Should be not be saved'
  533. assert !issue.save
  534. issue.reload
  535. assert_equal "Cannot print recipes", issue.subject
  536. end
  537. def test_should_not_recreate_custom_values_objects_on_update
  538. field = IssueCustomField.find_by_name('Database')
  539. issue = Issue.find(1)
  540. issue.custom_field_values = {field.id => 'PostgreSQL'}
  541. assert issue.save
  542. custom_value = issue.custom_value_for(field)
  543. issue.reload
  544. issue.custom_field_values = {field.id => 'MySQL'}
  545. assert issue.save
  546. issue.reload
  547. assert_equal custom_value.id, issue.custom_value_for(field).id
  548. end
  549. def test_setting_project_should_set_version_to_default_version
  550. version = Version.generate!(:project_id => 1)
  551. Project.find(1).update!(:default_version_id => version.id)
  552. issue = Issue.new(:project_id => 1)
  553. assert_equal version, issue.fixed_version
  554. end
  555. def test_default_assigned_to_based_on_category_should_be_set_on_create
  556. user = User.find(3)
  557. category = IssueCategory.create!(:project_id => 1, :name => 'With default assignee', :assigned_to_id => 3)
  558. issue = Issue.generate!(:project_id => 1, :category_id => category.id)
  559. assert_equal user, issue.assigned_to
  560. end
  561. def test_default_assigned_to_based_on_project_should_be_set_on_create
  562. user = User.find(3)
  563. Project.find(1).update!(:default_assigned_to_id => user.id)
  564. issue = Issue.generate!(:project_id => 1)
  565. assert_equal user, issue.assigned_to
  566. end
  567. def test_default_assigned_to_with_required_assignee_should_validate
  568. category = IssueCategory.create!(:project_id => 1, :name => 'With default assignee', :assigned_to_id => 3)
  569. Issue.any_instance.stubs(:required_attribute_names).returns(['assigned_to_id'])
  570. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'Default')
  571. assert !issue.save
  572. assert issue.errors['assigned_to_id'].present?
  573. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'Default', :category_id => category.id)
  574. assert_save issue
  575. end
  576. def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
  577. issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
  578. :status_id => 1, :subject => 'Test',
  579. :custom_field_values => {'2' => 'Test'})
  580. assert !Tracker.find(2).custom_field_ids.include?(2)
  581. issue = Issue.find(issue.id)
  582. issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
  583. issue = Issue.find(issue.id)
  584. custom_value = issue.custom_value_for(2)
  585. assert_not_nil custom_value
  586. assert_equal 'Test', custom_value.value
  587. end
  588. def test_assigning_tracker_id_should_reload_custom_fields_values
  589. issue = Issue.new(:project => Project.find(1))
  590. assert issue.custom_field_values.empty?
  591. issue.tracker_id = 1
  592. assert issue.custom_field_values.any?
  593. end
  594. def test_assigning_attributes_should_assign_project_and_tracker_first
  595. seq = sequence('seq')
  596. issue = Issue.new
  597. issue.expects(:project_id=).in_sequence(seq)
  598. issue.expects(:tracker_id=).in_sequence(seq)
  599. issue.expects(:subject=).in_sequence(seq)
  600. assert_raise Exception do
  601. issue.attributes = {:subject => 'Test'}
  602. end
  603. assert_nothing_raised do
  604. issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
  605. end
  606. end
  607. def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
  608. attributes = ActiveSupport::OrderedHash.new
  609. attributes['custom_field_values'] = {'1' => 'MySQL'}
  610. attributes['tracker_id'] = '1'
  611. issue = Issue.new(:project => Project.find(1))
  612. issue.attributes = attributes
  613. assert_equal 'MySQL', issue.custom_field_value(1)
  614. end
  615. def test_changing_tracker_should_clear_disabled_core_fields
  616. tracker = Tracker.find(2)
  617. tracker.core_fields = tracker.core_fields - %w(due_date)
  618. tracker.save!
  619. issue = Issue.generate!(:tracker_id => 1, :start_date => Date.today, :due_date => Date.today)
  620. issue.save!
  621. issue.tracker_id = 2
  622. issue.save!
  623. assert_not_nil issue.start_date
  624. assert_nil issue.due_date
  625. end
  626. def test_attribute_cleared_on_tracker_change_should_be_journalized
  627. CustomField.delete_all
  628. tracker = Tracker.find(2)
  629. tracker.core_fields = tracker.core_fields - %w(due_date)
  630. tracker.save!
  631. issue = Issue.generate!(:tracker_id => 1, :due_date => Date.today)
  632. issue.save!
  633. assert_difference 'Journal.count' do
  634. issue.init_journal User.find(1)
  635. issue.tracker_id = 2
  636. issue.save!
  637. assert_nil issue.due_date
  638. end
  639. journal = Journal.order('id DESC').first
  640. details = journal.details.select {|d| d.prop_key == 'due_date'}
  641. assert_equal 1, details.count
  642. end
  643. def test_reload_should_reload_custom_field_values
  644. issue = Issue.generate!
  645. issue.custom_field_values = {'2' => 'Foo'}
  646. issue.save!
  647. issue = Issue.order('id desc').first
  648. assert_equal 'Foo', issue.custom_field_value(2)
  649. issue.custom_field_values = {'2' => 'Bar'}
  650. assert_equal 'Bar', issue.custom_field_value(2)
  651. issue.reload
  652. assert_equal 'Foo', issue.custom_field_value(2)
  653. end
  654. def test_should_update_issue_with_disabled_tracker
  655. p = Project.find(1)
  656. issue = Issue.find(1)
  657. p.trackers.delete(issue.tracker)
  658. assert !p.trackers.include?(issue.tracker)
  659. issue.reload
  660. issue.subject = 'New subject'
  661. assert issue.save
  662. end
  663. def test_should_not_set_a_disabled_tracker
  664. p = Project.find(1)
  665. p.trackers.delete(Tracker.find(2))
  666. issue = Issue.find(1)
  667. issue.tracker_id = 2
  668. issue.subject = 'New subject'
  669. assert !issue.save
  670. assert_not_equal [], issue.errors[:tracker_id]
  671. end
  672. def test_category_based_assignment
  673. issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
  674. :status_id => 1, :priority => IssuePriority.first,
  675. :subject => 'Assignment test',
  676. :description => 'Assignment test', :category_id => 1)
  677. assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
  678. end
  679. def test_new_statuses_allowed_to
  680. WorkflowTransition.delete_all
  681. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  682. :old_status_id => 1, :new_status_id => 2,
  683. :author => false, :assignee => false)
  684. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  685. :old_status_id => 1, :new_status_id => 3,
  686. :author => true, :assignee => false)
  687. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  688. :old_status_id => 1, :new_status_id => 4,
  689. :author => false, :assignee => true)
  690. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  691. :old_status_id => 1, :new_status_id => 5,
  692. :author => true, :assignee => true)
  693. status = IssueStatus.find(1)
  694. role = Role.find(1)
  695. tracker = Tracker.find(1)
  696. user = User.find(2)
  697. issue = Issue.generate!(:tracker => tracker, :status => status,
  698. :project_id => 1, :author_id => 1)
  699. assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
  700. issue = Issue.generate!(:tracker => tracker, :status => status,
  701. :project_id => 1, :author => user)
  702. assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
  703. issue = Issue.generate!(:tracker => tracker, :status => status,
  704. :project_id => 1, :author_id => 1,
  705. :assigned_to => user)
  706. assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  707. issue = Issue.generate!(:tracker => tracker, :status => status,
  708. :project_id => 1, :author => user,
  709. :assigned_to => user)
  710. assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
  711. end
  712. def test_new_statuses_allowed_to_should_consider_group_assignment
  713. WorkflowTransition.delete_all
  714. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
  715. :old_status_id => 1, :new_status_id => 4,
  716. :author => false, :assignee => true)
  717. group = Group.generate!
  718. Member.create!(:project_id => 1, :principal => group, :role_ids => [1])
  719. user = User.find(2)
  720. group.users << user
  721. with_settings :issue_group_assignment => '1' do
  722. issue = Issue.generate!(:author_id => 1, :assigned_to => group)
  723. assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
  724. end
  725. end
  726. def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
  727. admin = User.find(1)
  728. issue = Issue.find(1)
  729. assert !admin.member_of?(issue.project)
  730. expected_statuses = [issue.status] +
  731. WorkflowTransition.where(:old_status_id => issue.status_id).
  732. map(&:new_status).uniq.sort
  733. assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
  734. end
  735. def test_new_statuses_allowed_to_should_only_return_transitions_of_considered_workflows
  736. issue = Issue.find(9)
  737. WorkflowTransition.delete_all
  738. WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2)
  739. developer = Role.find(2)
  740. developer.remove_permission! :edit_issues
  741. developer.remove_permission! :add_issues
  742. assert !developer.consider_workflow?
  743. WorkflowTransition.create!(:role_id => 2, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
  744. # status 3 is not displayed
  745. expected_statuses = IssueStatus.where(:id => [1, 2])
  746. admin = User.find(1)
  747. assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
  748. author = User.find(8)
  749. assert_equal expected_statuses, issue.new_statuses_allowed_to(author)
  750. end
  751. def test_new_statuses_allowed_to_should_return_allowed_statuses_when_copying
  752. Tracker.find(1).generate_transitions! :role_id => 1, :clear => true, 0 => [1, 3]
  753. orig = Issue.generate!(:project_id => 1, :tracker_id => 1, :status_id => 4)
  754. issue = orig.copy
  755. assert_equal [1, 3], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
  756. assert_equal 1, issue.status_id
  757. end
  758. def test_safe_attributes_names_should_be_updated_when_changing_project
  759. issue = Issue.new
  760. with_current_user(User.find(2)) do
  761. assert_not_include 'watcher_user_ids', issue.safe_attribute_names
  762. issue.project_id = 1
  763. assert_include 'watcher_user_ids', issue.safe_attribute_names
  764. end
  765. end
  766. def test_safe_attributes_names_should_not_include_disabled_field
  767. tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
  768. issue = Issue.new(:tracker => tracker)
  769. assert_include 'tracker_id', issue.safe_attribute_names
  770. assert_include 'status_id', issue.safe_attribute_names
  771. assert_include 'subject', issue.safe_attribute_names
  772. assert_include 'custom_field_values', issue.safe_attribute_names
  773. assert_include 'custom_fields', issue.safe_attribute_names
  774. assert_include 'lock_version', issue.safe_attribute_names
  775. tracker.core_fields.each do |field|
  776. assert_include field, issue.safe_attribute_names
  777. end
  778. tracker.disabled_core_fields.each do |field|
  779. assert_not_include field, issue.safe_attribute_names
  780. end
  781. end
  782. def test_safe_attributes_should_ignore_disabled_fields
  783. tracker = Tracker.find(1)
  784. tracker.core_fields = %w(assigned_to_id due_date)
  785. tracker.save!
  786. issue = Issue.new(:tracker => tracker)
  787. issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
  788. assert_nil issue.start_date
  789. assert_equal Date.parse('2012-07-14'), issue.due_date
  790. end
  791. def test_safe_attributes_notes_should_check_add_issue_notes_permission
  792. # With add_issue_notes permission
  793. user = User.find(2)
  794. issue = Issue.new(:project => Project.find(1))
  795. issue.init_journal(user)
  796. issue.send :safe_attributes=, {'notes' => 'note'}, user
  797. assert_equal 'note', issue.notes
  798. # Without add_issue_notes permission
  799. Role.find(1).remove_permission!(:add_issue_notes)
  800. issue = Issue.new(:project => Project.find(1))
  801. user.reload
  802. issue.init_journal(user)
  803. issue.send :safe_attributes=, {'notes' => 'note'}, user
  804. assert_equal '', issue.notes
  805. end
  806. def test_safe_attributes_should_accept_target_tracker_enabled_fields
  807. source = Tracker.find(1)
  808. source.core_fields = []
  809. source.save!
  810. target = Tracker.find(2)
  811. target.core_fields = %w(assigned_to_id due_date)
  812. target.save!
  813. user = User.find(2)
  814. issue = Issue.new(:project => Project.find(1), :tracker => source)
  815. issue.send :safe_attributes=, {'tracker_id' => 2, 'due_date' => '2012-07-14'}, user
  816. assert_equal target, issue.tracker
  817. assert_equal Date.parse('2012-07-14'), issue.due_date
  818. end
  819. def test_safe_attributes_should_not_include_readonly_fields
  820. WorkflowPermission.delete_all
  821. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  822. :role_id => 1, :field_name => 'due_date',
  823. :rule => 'readonly')
  824. user = User.find(2)
  825. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  826. assert_equal %w(due_date), issue.read_only_attribute_names(user)
  827. assert_not_include 'due_date', issue.safe_attribute_names(user)
  828. issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
  829. assert_equal Date.parse('2012-07-14'), issue.start_date
  830. assert_nil issue.due_date
  831. end
  832. def test_safe_attributes_should_not_include_readonly_custom_fields
  833. cf1 = IssueCustomField.create!(:name => 'Writable field',
  834. :field_format => 'string',
  835. :is_for_all => true, :tracker_ids => [1])
  836. cf2 = IssueCustomField.create!(:name => 'Readonly field',
  837. :field_format => 'string',
  838. :is_for_all => true, :tracker_ids => [1])
  839. WorkflowPermission.delete_all
  840. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  841. :role_id => 1, :field_name => cf2.id.to_s,
  842. :rule => 'readonly')
  843. user = User.find(2)
  844. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  845. assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
  846. assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
  847. issue.send(
  848. :safe_attributes=,
  849. {
  850. 'custom_field_values' =>
  851. {
  852. cf1.id.to_s => 'value1',
  853. cf2.id.to_s => 'value2'
  854. }
  855. },
  856. user
  857. )
  858. assert_equal 'value1', issue.custom_field_value(cf1)
  859. assert_nil issue.custom_field_value(cf2)
  860. issue.send(
  861. :safe_attributes=,
  862. {
  863. 'custom_fields' =>
  864. [
  865. {'id' => cf1.id.to_s, 'value' => 'valuea'},
  866. {'id' => cf2.id.to_s, 'value' => 'valueb'}
  867. ]
  868. }, user
  869. )
  870. assert_equal 'valuea', issue.custom_field_value(cf1)
  871. assert_nil issue.custom_field_value(cf2)
  872. end
  873. def test_editable_custom_field_values_should_return_non_readonly_custom_values
  874. cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
  875. :is_for_all => true, :tracker_ids => [1, 2])
  876. cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
  877. :is_for_all => true, :tracker_ids => [1, 2])
  878. WorkflowPermission.delete_all
  879. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
  880. :field_name => cf2.id.to_s, :rule => 'readonly')
  881. user = User.find(2)
  882. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  883. values = issue.editable_custom_field_values(user)
  884. assert values.detect {|value| value.custom_field == cf1}
  885. assert_nil values.detect {|value| value.custom_field == cf2}
  886. issue.tracker_id = 2
  887. values = issue.editable_custom_field_values(user)
  888. assert values.detect {|value| value.custom_field == cf1}
  889. assert values.detect {|value| value.custom_field == cf2}
  890. end
  891. def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
  892. enabled_cf =
  893. IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1],
  894. :visible => false, :role_ids => [1, 2])
  895. disabled_cf =
  896. IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1],
  897. :visible => false, :role_ids => [2])
  898. user = User.find(2)
  899. issue = Issue.new(:project_id => 1, :tracker_id => 1)
  900. assert_include enabled_cf, issue.editable_custom_fields(user)
  901. assert_not_include disabled_cf, issue.editable_custom_fields(user)
  902. end
  903. def test_safe_attributes_should_accept_target_tracker_writable_fields
  904. WorkflowPermission.delete_all
  905. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  906. :role_id => 1, :field_name => 'due_date',
  907. :rule => 'readonly')
  908. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  909. :role_id => 1, :field_name => 'start_date',
  910. :rule => 'readonly')
  911. user = User.find(2)
  912. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  913. issue.send :safe_attributes=, {'start_date' => '2012-07-12',
  914. 'due_date' => '2012-07-14'}, user
  915. assert_equal Date.parse('2012-07-12'), issue.start_date
  916. assert_nil issue.due_date
  917. issue.send :safe_attributes=, {'start_date' => '2012-07-15',
  918. 'due_date' => '2012-07-16',
  919. 'tracker_id' => 2}, user
  920. assert_equal Date.parse('2012-07-12'), issue.start_date
  921. assert_equal Date.parse('2012-07-16'), issue.due_date
  922. end
  923. def test_safe_attributes_should_accept_target_status_writable_fields
  924. WorkflowPermission.delete_all
  925. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  926. :role_id => 1, :field_name => 'due_date',
  927. :rule => 'readonly')
  928. WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
  929. :role_id => 1, :field_name => 'start_date',
  930. :rule => 'readonly')
  931. user = User.find(2)
  932. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  933. issue.send(:safe_attributes=,
  934. {'start_date' => '2012-07-12',
  935. 'due_date' => '2012-07-14'},
  936. user)
  937. assert_equal Date.parse('2012-07-12'), issue.start_date
  938. assert_nil issue.due_date
  939. issue.send(:safe_attributes=,
  940. {'start_date' => '2012-07-15',
  941. 'due_date' => '2012-07-16',
  942. 'status_id' => 2},
  943. user)
  944. assert_equal Date.parse('2012-07-12'), issue.start_date
  945. assert_equal Date.parse('2012-07-16'), issue.due_date
  946. end
  947. def test_required_attributes_should_be_validated
  948. cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
  949. :is_for_all => true, :tracker_ids => [1, 2])
  950. WorkflowPermission.delete_all
  951. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  952. :role_id => 1, :field_name => 'due_date',
  953. :rule => 'required')
  954. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  955. :role_id => 1, :field_name => 'category_id',
  956. :rule => 'required')
  957. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  958. :role_id => 1, :field_name => cf.id.to_s,
  959. :rule => 'required')
  960. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  961. :role_id => 1, :field_name => 'start_date',
  962. :rule => 'required')
  963. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
  964. :role_id => 1, :field_name => cf.id.to_s,
  965. :rule => 'required')
  966. user = User.find(2)
  967. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  968. :status_id => 1, :subject => 'Required fields',
  969. :author => user)
  970. assert_equal [cf.id.to_s, "category_id", "due_date"],
  971. issue.required_attribute_names(user).sort
  972. assert !issue.save, "Issue was saved"
  973. assert_equal ["Category cannot be blank", "Due date cannot be blank", "Foo cannot be blank"],
  974. issue.errors.full_messages.sort
  975. issue.tracker_id = 2
  976. assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
  977. assert !issue.save, "Issue was saved"
  978. assert_equal ["Foo cannot be blank", "Start date cannot be blank"],
  979. issue.errors.full_messages.sort
  980. issue.start_date = Date.today
  981. issue.custom_field_values = {cf.id.to_s => 'bar'}
  982. assert issue.save
  983. end
  984. def test_required_attribute_that_is_disabled_for_the_tracker_should_not_be_required
  985. WorkflowPermission.delete_all
  986. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  987. :role_id => 1, :field_name => 'start_date',
  988. :rule => 'required')
  989. user = User.find(2)
  990. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  991. :subject => 'Required fields', :author => user)
  992. assert !issue.save
  993. assert_include "Start date cannot be blank", issue.errors.full_messages
  994. tracker = Tracker.find(1)
  995. tracker.core_fields -= %w(start_date)
  996. tracker.save!
  997. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  998. :subject => 'Required fields', :author => user)
  999. assert issue.save
  1000. end
  1001. def test_category_should_not_be_required_if_project_has_no_categories
  1002. Project.find(1).issue_categories.delete_all
  1003. WorkflowPermission.delete_all
  1004. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1005. :role_id => 1, :field_name => 'category_id',
  1006. :rule => 'required')
  1007. user = User.find(2)
  1008. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  1009. :subject => 'Required fields', :author => user)
  1010. assert_save issue
  1011. end
  1012. def test_fixed_version_should_not_be_required_no_assignable_versions
  1013. Version.delete_all
  1014. WorkflowPermission.delete_all
  1015. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1016. :role_id => 1, :field_name => 'fixed_version_id',
  1017. :rule => 'required')
  1018. user = User.find(2)
  1019. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  1020. :subject => 'Required fields', :author => user)
  1021. assert_save issue
  1022. end
  1023. def test_required_custom_field_that_is_not_visible_for_the_user_should_not_be_required
  1024. CustomField.destroy_all
  1025. field = IssueCustomField.generate!(:is_required => true, :visible => false,
  1026. :role_ids => [1], :trackers => Tracker.all,
  1027. :is_for_all => true)
  1028. user = User.generate!
  1029. User.add_to_project(user, Project.find(1), Role.find(2))
  1030. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  1031. :subject => 'Required fields', :author => user)
  1032. assert_save issue
  1033. end
  1034. def test_required_custom_field_that_is_visible_for_the_user_should_be_required
  1035. CustomField.destroy_all
  1036. field = IssueCustomField.generate!(:is_required => true, :visible => false,
  1037. :role_ids => [1], :trackers => Tracker.all,
  1038. :is_for_all => true)
  1039. user = User.generate!
  1040. User.add_to_project(user, Project.find(1), Role.find(1))
  1041. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  1042. :subject => 'Required fields', :author => user)
  1043. assert !issue.save
  1044. assert_include "#{field.name} cannot be blank", issue.errors.full_messages
  1045. end
  1046. def test_required_attribute_names_for_multiple_roles_should_intersect_rules
  1047. WorkflowPermission.delete_all
  1048. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1049. :role_id => 1, :field_name => 'due_date',
  1050. :rule => 'required')
  1051. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1052. :role_id => 1, :field_name => 'start_date',
  1053. :rule => 'required')
  1054. user = User.find(2)
  1055. member = Member.find(1)
  1056. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1057. assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
  1058. member.role_ids = [1, 2]
  1059. member.save!
  1060. assert_equal [], issue.required_attribute_names(user.reload)
  1061. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1062. :role_id => 2, :field_name => 'due_date',
  1063. :rule => 'required')
  1064. assert_equal %w(due_date), issue.required_attribute_names(user)
  1065. member.role_ids = [1, 2, 3]
  1066. member.save!
  1067. assert_equal [], issue.required_attribute_names(user.reload)
  1068. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1069. :role_id => 3, :field_name => 'due_date',
  1070. :rule => 'readonly')
  1071. # required + readonly => required
  1072. assert_equal %w(due_date), issue.required_attribute_names(user)
  1073. end
  1074. def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
  1075. WorkflowPermission.delete_all
  1076. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1077. :role_id => 1, :field_name => 'due_date',
  1078. :rule => 'readonly')
  1079. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1080. :role_id => 1, :field_name => 'start_date',
  1081. :rule => 'readonly')
  1082. user = User.find(2)
  1083. member = Member.find(1)
  1084. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1085. assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
  1086. member.role_ids = [1, 2]
  1087. member.save!
  1088. assert_equal [], issue.read_only_attribute_names(user.reload)
  1089. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1090. :role_id => 2, :field_name => 'due_date',
  1091. :rule => 'readonly')
  1092. assert_equal %w(due_date), issue.read_only_attribute_names(user)
  1093. end
  1094. # A field that is not visible by role 2 and readonly by role 1 should be readonly for user with role 1 and 2
  1095. def test_read_only_attribute_names_should_include_custom_fields_that_combine_readonly_and_not_visible_for_roles
  1096. field = IssueCustomField.generate!(
  1097. :is_for_all => true, :trackers => Tracker.all, :visible => false, :role_ids => [1]
  1098. )
  1099. WorkflowPermission.delete_all
  1100. WorkflowPermission.create!(
  1101. :old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => field.id, :rule => 'readonly'
  1102. )
  1103. user = User.generate!
  1104. project = Project.find(1)
  1105. User.add_to_project(user, project, Role.where(:id => [1, 2]))
  1106. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1107. assert_equal [field.id.to_s], issue.read_only_attribute_names(user)
  1108. end
  1109. def test_workflow_rules_should_ignore_roles_without_issue_permissions
  1110. role = Role.generate! :permissions => [:view_issues, :edit_issues]
  1111. ignored_role = Role.generate! :permissions => [:view_issues]
  1112. WorkflowPermission.delete_all
  1113. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1114. :role => role, :field_name => 'due_date',
  1115. :rule => 'required')
  1116. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1117. :role => role, :field_name => 'start_date',
  1118. :rule => 'readonly')
  1119. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1120. :role => role, :field_name => 'done_ratio',
  1121. :rule => 'readonly')
  1122. user = User.generate!
  1123. User.add_to_project user, Project.find(1), [role, ignored_role]
  1124. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1125. assert_equal %w(due_date), issue.required_attribute_names(user)
  1126. assert_equal %w(done_ratio start_date), issue.read_only_attribute_names(user).sort
  1127. end
  1128. def test_workflow_rules_should_work_for_member_with_duplicate_role
  1129. WorkflowPermission.delete_all
  1130. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1131. :role_id => 1, :field_name => 'due_date',
  1132. :rule => 'required')
  1133. WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
  1134. :role_id => 1, :field_name => 'start_date',
  1135. :rule => 'readonly')
  1136. user = User.generate!
  1137. m = Member.new(:user_id => user.id, :project_id => 1)
  1138. m.member_roles.build(:role_id => 1)
  1139. m.member_roles.build(:role_id => 1)
  1140. m.save!
  1141. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
  1142. assert_equal %w(due_date), issue.required_attribute_names(user)
  1143. assert_equal %w(start_date), issue.read_only_attribute_names(user)
  1144. end
  1145. def test_copy
  1146. issue = Issue.new.copy_from(1)
  1147. assert issue.copy?
  1148. assert issue.save
  1149. issue.reload
  1150. orig = Issue.find(1)
  1151. assert_equal orig.subject, issue.subject
  1152. assert_equal orig.tracker, issue.tracker
  1153. assert_equal "125", issue.custom_value_for(2).value
  1154. end
  1155. def test_copy_to_another_project_should_clear_assignee_if_not_valid
  1156. issue = Issue.generate!(:project_id => 1, :assigned_to_id => 2)
  1157. project = Project.generate!
  1158. issue = Issue.new.copy_from(1)
  1159. issue.project = project
  1160. assert_nil issue.assigned_to
  1161. end
  1162. def test_copy_with_keep_status_should_copy_status
  1163. orig = Issue.find(8)
  1164. assert orig.status != orig.default_status
  1165. issue = Issue.new.copy_from(orig, :keep_status => true)
  1166. assert issue.save
  1167. issue.reload
  1168. assert_equal orig.status, issue.status
  1169. end
  1170. def test_copy_should_add_relation_with_copied_issue
  1171. copied = Issue.find(1)
  1172. issue = Issue.new.copy_from(copied)
  1173. assert issue.save
  1174. issue.reload
  1175. assert_equal 1, issue.relations.size
  1176. relation = issue.relations.first
  1177. assert_equal 'copied_to', relation.relation_type
  1178. assert_equal copied, relation.issue_from
  1179. assert_equal issue, relation.issue_to
  1180. end
  1181. def test_copy_should_copy_subtasks
  1182. issue = Issue.generate_with_descendants!
  1183. copy = issue.reload.copy
  1184. copy.author = User.find(7)
  1185. assert_difference 'Issue.count', 1+issue.descendants.count do
  1186. assert copy.save
  1187. end
  1188. copy.reload
  1189. assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
  1190. child_copy = copy.children.detect {|c| c.subject == 'Child1'}
  1191. assert_equal %w(Child11), child_copy.children.map(&:subject).sort
  1192. assert_equal copy.author, child_copy.author
  1193. end
  1194. def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
  1195. parent = Issue.generate!
  1196. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
  1197. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
  1198. copy = parent.reload.copy
  1199. copy.parent_issue_id = parent.id
  1200. copy.author = User.find(7)
  1201. assert_difference 'Issue.count', 3 do
  1202. assert copy.save
  1203. end
  1204. parent.reload
  1205. copy.reload
  1206. assert_equal parent, copy.parent
  1207. assert_equal 3, parent.children.count
  1208. assert_equal 5, parent.descendants.count
  1209. assert_equal 2, copy.children.count
  1210. assert_equal 2, copy.descendants.count
  1211. end
  1212. def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
  1213. parent = Issue.generate!
  1214. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
  1215. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
  1216. copy = parent.reload.copy
  1217. copy.parent_issue_id = child1.id
  1218. copy.author = User.find(7)
  1219. assert_difference 'Issue.count', 3 do
  1220. assert copy.save
  1221. end
  1222. parent.reload
  1223. child1.reload
  1224. copy.reload
  1225. assert_equal child1, copy.parent
  1226. assert_equal 2, parent.children.count
  1227. assert_equal 5, parent.descendants.count
  1228. assert_equal 1, child1.children.count
  1229. assert_equal 3, child1.descendants.count
  1230. assert_equal 2, copy.children.count
  1231. assert_equal 2, copy.descendants.count
  1232. end
  1233. def test_copy_should_copy_subtasks_to_target_project
  1234. issue = Issue.generate_with_descendants!
  1235. copy = issue.copy(:project_id => 3)
  1236. assert_difference 'Issue.count', 1+issue.descendants.count do
  1237. assert copy.save
  1238. end
  1239. assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
  1240. end
  1241. def test_copy_should_not_copy_subtasks_twice_when_saving_twice
  1242. issue = Issue.generate_with_descendants!
  1243. copy = issue.reload.copy
  1244. assert_difference 'Issue.count', 1+issue.descendants.count do
  1245. assert copy.save
  1246. assert copy.reload.save
  1247. end
  1248. end
  1249. def test_copy_should_clear_closed_on
  1250. copied_open = Issue.find(8).copy(:status_id => 1)
  1251. assert copied_open.save
  1252. assert_nil copied_open.closed_on
  1253. copied_closed = Issue.find(8).copy({}, :keep_status => 1)
  1254. assert copied_closed.save
  1255. assert_not_nil copied_closed.closed_on
  1256. end
  1257. def test_copy_should_not_copy_locked_watchers
  1258. user = User.find(2)
  1259. user2 = User.find(3)
  1260. issue = Issue.find(8)
  1261. Watcher.create!(:user => user, :watchable => issue)
  1262. Watcher.create!(:user => user2, :watchable => issue)
  1263. user2.status = User::STATUS_LOCKED
  1264. user2.save!
  1265. issue = Issue.new.copy_from(8)
  1266. assert issue.save
  1267. assert issue.watched_by?(user)
  1268. assert !issue.watched_by?(user2)
  1269. end
  1270. def test_copy_should_clear_subtasks_target_version_if_locked_or_closed
  1271. version = Version.new(:project => Project.find(1), :name => '2.1')
  1272. version.save!
  1273. parent = Issue.generate!
  1274. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1', :fixed_version_id => 3)
  1275. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2', :fixed_version_id => version.id)
  1276. version.status = 'locked'
  1277. version.save!
  1278. copy = parent.reload.copy
  1279. assert_difference 'Issue.count', 3 do
  1280. assert copy.save
  1281. end
  1282. assert_equal [3, nil], copy.children.map(&:fixed_version_id)
  1283. end
  1284. def test_copy_should_clear_subtasks_assignee_if_is_locked
  1285. user = User.find(2)
  1286. parent = Issue.generate!
  1287. child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1', :assigned_to_id => 3)
  1288. child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2', :assigned_to_id => user.id)
  1289. user.status = User::STATUS_LOCKED
  1290. user.save!
  1291. copy = parent.reload.copy
  1292. assert_difference 'Issue.count', 3 do
  1293. assert copy.save
  1294. end
  1295. assert_equal [3, nil], copy.children.map(&:assigned_to_id)
  1296. end
  1297. def test_copy_should_not_add_attachments_to_journal
  1298. set_tmp_attachments_directory
  1299. issue = Issue.generate!
  1300. copy = Issue.new
  1301. copy.init_journal User.find(1)
  1302. copy.copy_from issue
  1303. copy.project = issue.project
  1304. copy.save_attachments(
  1305. { 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')} }
  1306. )
  1307. assert copy.save
  1308. assert j = copy.journals.last
  1309. assert_equal 1, j.details.size
  1310. assert_equal 'relation', j.details[0].property
  1311. end
  1312. def test_should_not_call_after_project_change_on_creation
  1313. issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
  1314. :subject => 'Test', :author_id => 1)
  1315. issue.expects(:after_project_change).never
  1316. issue.save!
  1317. end
  1318. def test_should_not_call_after_project_change_on_update
  1319. issue = Issue.find(1)
  1320. issue.project = Project.find(1)
  1321. issue.subject = 'No project change'
  1322. issue.expects(:after_project_change).never
  1323. issue.save!
  1324. end
  1325. def test_should_call_after_project_change_on_project_change
  1326. issue = Issue.find(1)
  1327. issue.project = Project.find(2)
  1328. issue.expects(:after_project_change).once
  1329. issue.save!
  1330. end
  1331. def test_adding_journal_should_update_timestamp
  1332. issue = Issue.find(1)
  1333. updated_on_was = issue.updated_on
  1334. issue.init_journal(User.first, "Adding notes")
  1335. assert_difference 'Journal.count' do
  1336. assert issue.save
  1337. end
  1338. issue.reload
  1339. assert_not_equal updated_on_was, issue.updated_on
  1340. end
  1341. def test_should_close_duplicates
  1342. # Create 3 issues
  1343. issue1 = Issue.generate!
  1344. issue2 = Issue.generate!
  1345. issue3 = Issue.generate!
  1346. # 2 is a dupe of 1
  1347. IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
  1348. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1349. # And 3 is a dupe of 2
  1350. IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
  1351. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1352. # And 3 is a dupe of 1 (circular duplicates)
  1353. IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
  1354. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1355. assert issue1.reload.duplicates.include?(issue2)
  1356. # Closing issue 1
  1357. issue1.init_journal(User.first, "Closing issue1")
  1358. issue1.status = IssueStatus.where(:is_closed => true).first
  1359. assert issue1.save
  1360. # 2 and 3 should be also closed
  1361. assert issue2.reload.closed?
  1362. assert issue3.reload.closed?
  1363. end
  1364. def test_should_not_close_duplicate_when_disabled
  1365. issue = Issue.generate!
  1366. duplicate = Issue.generate!
  1367. IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
  1368. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1369. assert issue.reload.duplicates.include?(duplicate)
  1370. with_settings :close_duplicate_issues => '0' do
  1371. issue.init_journal(User.first, "Closing issue")
  1372. issue.status = IssueStatus.where(:is_closed => true).first
  1373. issue.save
  1374. end
  1375. assert !duplicate.reload.closed?
  1376. end
  1377. def test_should_close_duplicates_with_private_notes
  1378. issue = Issue.generate!
  1379. duplicate = Issue.generate!
  1380. IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
  1381. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1382. assert issue.reload.duplicates.include?(duplicate)
  1383. # Closing issue with private notes
  1384. issue.init_journal(User.first, "Private notes")
  1385. issue.private_notes = true
  1386. issue.status = IssueStatus.where(:is_closed => true).first
  1387. assert_save issue
  1388. duplicate.reload
  1389. assert journal = duplicate.journals.detect {|journal| journal.notes == "Private notes"}
  1390. assert_equal true, journal.private_notes
  1391. end
  1392. def test_should_not_close_duplicated_issue
  1393. issue1 = Issue.generate!
  1394. issue2 = Issue.generate!
  1395. # 2 is a dupe of 1
  1396. IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
  1397. :relation_type => IssueRelation::TYPE_DUPLICATES)
  1398. # 2 is a dup of 1 but 1 is not a duplicate of 2
  1399. assert !issue2.reload.duplicates.include?(issue1)
  1400. # Closing issue 2
  1401. issue2.init_journal(User.first, "Closing issue2")
  1402. issue2.status = IssueStatus.where(:is_closed => true).first
  1403. assert issue2.save
  1404. # 1 should not be also closed
  1405. assert !issue1.reload.closed?
  1406. end
  1407. def test_assignable_versions
  1408. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1409. :status_id => 1, :fixed_version_id => 1,
  1410. :subject => 'New issue')
  1411. assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
  1412. end
  1413. def test_should_not_be_able_to_set_an_invalid_version_id
  1414. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1415. :status_id => 1, :fixed_version_id => 424242,
  1416. :subject => 'New issue')
  1417. assert !issue.save
  1418. assert_not_equal [], issue.errors[:fixed_version_id]
  1419. end
  1420. def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
  1421. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1422. :status_id => 1, :fixed_version_id => 1,
  1423. :subject => 'New issue')
  1424. assert !issue.save
  1425. assert_not_equal [], issue.errors[:fixed_version_id]
  1426. end
  1427. def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
  1428. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1429. :status_id => 1, :fixed_version_id => 2,
  1430. :subject => 'New issue')
  1431. assert !issue.save
  1432. assert_not_equal [], issue.errors[:fixed_version_id]
  1433. end
  1434. def test_should_be_able_to_assign_a_new_issue_to_an_open_version
  1435. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1436. :status_id => 1, :fixed_version_id => 3,
  1437. :subject => 'New issue')
  1438. assert issue.save
  1439. end
  1440. def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
  1441. issue = Issue.find(11)
  1442. assert_equal 'closed', issue.fixed_version.status
  1443. issue.subject = 'Subject changed'
  1444. assert issue.save
  1445. end
  1446. def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
  1447. issue = Issue.find(11)
  1448. issue.status_id = 1
  1449. assert !issue.save
  1450. assert_not_equal [], issue.errors[:base]
  1451. end
  1452. def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
  1453. issue = Issue.find(11)
  1454. issue.status_id = 1
  1455. issue.fixed_version_id = 3
  1456. assert issue.save
  1457. end
  1458. def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
  1459. issue = Issue.find(12)
  1460. assert_equal 'locked', issue.fixed_version.status
  1461. issue.status_id = 1
  1462. assert issue.save
  1463. end
  1464. def test_should_not_be_able_to_keep_unshared_version_when_changing_project
  1465. issue = Issue.find(2)
  1466. assert_equal 2, issue.fixed_version_id
  1467. issue.project_id = 3
  1468. assert_nil issue.fixed_version_id
  1469. issue.fixed_version_id = 2
  1470. assert !issue.save
  1471. assert_include 'Target version is not included in the list', issue.errors.full_messages
  1472. end
  1473. def test_should_keep_shared_version_when_changing_project
  1474. Version.find(2).update! :sharing => 'tree'
  1475. issue = Issue.find(2)
  1476. assert_equal 2, issue.fixed_version_id
  1477. issue.project_id = 3
  1478. assert_equal 2, issue.fixed_version_id
  1479. assert issue.save
  1480. end
  1481. def test_should_not_be_able_to_set_an_invalid_category_id
  1482. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
  1483. :status_id => 1, :category_id => 3,
  1484. :subject => 'New issue')
  1485. assert !issue.save
  1486. assert_not_equal [], issue.errors[:category_id]
  1487. end
  1488. def test_allowed_target_projects_should_include_projects_with_issue_tracking_enabled
  1489. assert_include Project.find(2), Issue.allowed_target_projects(User.find(2))
  1490. end
  1491. def test_allowed_target_projects_should_not_include_projects_with_issue_tracking_disabled
  1492. Project.find(2).disable_module! :issue_tracking
  1493. assert_not_include Project.find(2), Issue.allowed_target_projects(User.find(2))
  1494. end
  1495. def test_allowed_target_projects_should_not_include_projects_without_trackers
  1496. project = Project.generate!(:tracker_ids => [])
  1497. assert project.trackers.empty?
  1498. assert_not_include project, Issue.allowed_target_projects(User.find(1))
  1499. end
  1500. def test_allowed_target_projects_for_subtask_should_not_include_invalid_projects
  1501. User.current = User.find(1)
  1502. issue = Issue.find(1)
  1503. issue.parent_id = 3
  1504. with_settings :cross_project_subtasks => 'tree' do
  1505. # Should include only the project tree
  1506. assert_equal [1, 3, 5], issue.allowed_target_projects_for_subtask.ids.sort
  1507. end
  1508. end
  1509. def test_allowed_target_trackers_with_one_role_allowed_on_all_trackers
  1510. user = User.generate!
  1511. role = Role.generate!
  1512. role.add_permission! :add_issues
  1513. role.set_permission_trackers :add_issues, :all
  1514. role.save!
  1515. User.add_to_project(user, Project.find(1), role)
  1516. assert_equal [1, 2, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1517. end
  1518. def test_allowed_target_trackers_with_one_role_allowed_on_some_trackers
  1519. user = User.generate!
  1520. role = Role.generate!
  1521. role.add_permission! :add_issues
  1522. role.set_permission_trackers :add_issues, [1, 3]
  1523. role.save!
  1524. User.add_to_project(user, Project.find(1), role)
  1525. assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1526. end
  1527. def test_allowed_target_trackers_with_two_roles_allowed_on_some_trackers
  1528. user = User.generate!
  1529. role1 = Role.generate!
  1530. role1.add_permission! :add_issues
  1531. role1.set_permission_trackers :add_issues, [1]
  1532. role1.save!
  1533. role2 = Role.generate!
  1534. role2.add_permission! :add_issues
  1535. role2.set_permission_trackers :add_issues, [3]
  1536. role2.save!
  1537. User.add_to_project(user, Project.find(1), [role1, role2])
  1538. assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1539. end
  1540. def test_allowed_target_trackers_with_two_roles_allowed_on_all_trackers_and_some_trackers
  1541. user = User.generate!
  1542. role1 = Role.generate!
  1543. role1.add_permission! :add_issues
  1544. role1.set_permission_trackers :add_issues, :all
  1545. role1.save!
  1546. role2 = Role.generate!
  1547. role2.add_permission! :add_issues
  1548. role2.set_permission_trackers :add_issues, [1, 3]
  1549. role2.save!
  1550. User.add_to_project(user, Project.find(1), [role1, role2])
  1551. assert_equal [1, 2, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1552. end
  1553. def test_allowed_target_trackers_should_not_consider_roles_without_add_issues_permission
  1554. user = User.generate!
  1555. role1 = Role.generate!
  1556. role1.remove_permission! :add_issues
  1557. role1.set_permission_trackers :add_issues, :all
  1558. role1.save!
  1559. role2 = Role.generate!
  1560. role2.add_permission! :add_issues
  1561. role2.set_permission_trackers :add_issues, [1, 3]
  1562. role2.save!
  1563. User.add_to_project(user, Project.find(1), [role1, role2])
  1564. assert_equal [1, 3], Issue.new(:project => Project.find(1)).allowed_target_trackers(user).ids.sort
  1565. end
  1566. def test_allowed_target_trackers_without_project_should_be_empty
  1567. issue = Issue.new
  1568. assert_nil issue.project
  1569. assert_equal [], issue.allowed_target_trackers(User.find(2)).ids
  1570. end
  1571. def test_allowed_target_trackers_should_include_current_tracker
  1572. user = User.generate!
  1573. role = Role.generate!
  1574. role.add_permission! :add_issues
  1575. role.set_permission_trackers :add_issues, [3]
  1576. role.save!
  1577. User.add_to_project(user, Project.find(1), role)
  1578. issue = Issue.generate!(:project => Project.find(1), :tracker => Tracker.find(1))
  1579. assert_equal [1, 3], issue.allowed_target_trackers(user).ids.sort
  1580. end
  1581. def test_move_to_another_project_with_same_category
  1582. issue = Issue.find(1)
  1583. issue.project = Project.find(2)
  1584. assert issue.save
  1585. issue.reload
  1586. assert_equal 2, issue.project_id
  1587. # Category changes
  1588. assert_equal 4, issue.category_id
  1589. # Make sure time entries were move to the target project
  1590. assert_equal 2, issue.time_entries.first.project_id
  1591. end
  1592. def test_move_to_another_project_without_same_category
  1593. issue = Issue.find(2)
  1594. issue.project = Project.find(2)
  1595. assert issue.save
  1596. issue.reload
  1597. assert_equal 2, issue.project_id
  1598. # Category cleared
  1599. assert_nil issue.category_id
  1600. end
  1601. def test_move_to_another_project_should_clear_fixed_version_when_not_shared
  1602. issue = Issue.find(1)
  1603. issue.update!(:fixed_version_id => 3)
  1604. issue.project = Project.find(2)
  1605. assert issue.save
  1606. issue.reload
  1607. assert_equal 2, issue.project_id
  1608. # Cleared fixed_version
  1609. assert_nil issue.fixed_version
  1610. end
  1611. def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
  1612. issue = Issue.find(1)
  1613. issue.update!(:fixed_version_id => 4)
  1614. issue.project = Project.find(5)
  1615. assert issue.save
  1616. issue.reload
  1617. assert_equal 5, issue.project_id
  1618. # Keep fixed_version
  1619. assert_equal 4, issue.fixed_version_id
  1620. end
  1621. def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
  1622. issue = Issue.find(1)
  1623. issue.update!(:fixed_version_id => 3)
  1624. issue.project = Project.find(5)
  1625. assert issue.save
  1626. issue.reload
  1627. assert_equal 5, issue.project_id
  1628. # Cleared fixed_version
  1629. assert_nil issue.fixed_version
  1630. end
  1631. def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
  1632. issue = Issue.find(1)
  1633. issue.update!(:fixed_version_id => 7)
  1634. issue.project = Project.find(2)
  1635. assert issue.save
  1636. issue.reload
  1637. assert_equal 2, issue.project_id
  1638. # Keep fixed_version
  1639. assert_equal 7, issue.fixed_version_id
  1640. end
  1641. def test_move_to_another_project_should_keep_parent_if_valid
  1642. issue = Issue.find(1)
  1643. issue.update! :parent_issue_id => 2
  1644. issue.project = Project.find(3)
  1645. assert issue.save
  1646. issue.reload
  1647. assert_equal 2, issue.parent_id
  1648. end
  1649. def test_move_to_another_project_should_clear_parent_if_not_valid
  1650. issue = Issue.find(1)
  1651. issue.update! :parent_issue_id => 2
  1652. issue.project = Project.find(2)
  1653. assert issue.save
  1654. issue.reload
  1655. assert_nil issue.parent_id
  1656. end
  1657. def test_move_to_another_project_with_disabled_tracker
  1658. issue = Issue.find(1)
  1659. target = Project.find(2)
  1660. target.tracker_ids = [3]
  1661. target.save
  1662. issue.project = target
  1663. assert issue.save
  1664. issue.reload
  1665. assert_equal 2, issue.project_id
  1666. assert_equal 3, issue.tracker_id
  1667. end
  1668. def test_move_to_another_project_should_set_error_message_on_child_failure
  1669. parent = Issue.generate!
  1670. child = Issue.generate!(:parent_issue_id => parent.id, :tracker_id => 2)
  1671. project = Project.generate!(:tracker_ids => [1])
  1672. parent.reload
  1673. parent.project_id = project.id
  1674. assert !parent.save
  1675. assert_include(
  1676. "Subtask ##{child.id} could not be moved to the new project: Tracker is not included in the list",
  1677. parent.errors[:base])
  1678. end
  1679. def test_copy_to_the_same_project
  1680. issue = Issue.find(1)
  1681. copy = issue.copy
  1682. assert_difference 'Issue.count' do
  1683. copy.save!
  1684. end
  1685. assert_kind_of Issue, copy
  1686. assert_equal issue.project, copy.project
  1687. assert_equal "125", copy.custom_value_for(2).value
  1688. end
  1689. def test_copy_to_another_project_and_tracker
  1690. issue = Issue.find(1)
  1691. copy = issue.copy(:project_id => 3, :tracker_id => 2)
  1692. assert_difference 'Issue.count' do
  1693. copy.save!
  1694. end
  1695. copy.reload
  1696. assert_kind_of Issue, copy
  1697. assert_equal Project.find(3), copy.project
  1698. assert_equal Tracker.find(2), copy.tracker
  1699. # Custom field #2 is not associated with target tracker
  1700. assert_nil copy.custom_value_for(2)
  1701. end
  1702. test "#copy should not create a journal" do
  1703. copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2}, :link => false)
  1704. copy.save!
  1705. assert_equal 0, copy.reload.journals.size
  1706. end
  1707. test "#copy should allow assigned_to changes" do
  1708. user = User.generate!
  1709. Member.create!(:project_id => 3, :principal => user, :role_ids => [1])
  1710. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => user.id)
  1711. assert_equal user.id, copy.assigned_to_id
  1712. end
  1713. test "#copy should allow status changes" do
  1714. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
  1715. assert_equal 2, copy.status_id
  1716. end
  1717. test "#copy should allow start date changes" do
  1718. date = Date.today
  1719. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
  1720. assert_equal date, copy.start_date
  1721. end
  1722. test "#copy should allow due date changes" do
  1723. date = Date.today
  1724. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
  1725. assert_equal date, copy.due_date
  1726. end
  1727. test "#copy should set current user as author" do
  1728. User.current = User.find(9)
  1729. copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
  1730. assert_equal User.current, copy.author
  1731. end
  1732. test "#copy should create a journal with notes" do
  1733. date = Date.today
  1734. notes = "Notes added when copying"
  1735. copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :start_date => date}, :link => false)
  1736. copy.init_journal(User.current, notes)
  1737. copy.save!
  1738. assert_equal 1, copy.journals.size
  1739. journal = copy.journals.first
  1740. assert_equal 0, journal.details.size
  1741. assert_equal notes, journal.notes
  1742. end
  1743. def test_valid_parent_project
  1744. issue = Issue.find(1)
  1745. issue_in_same_project = Issue.find(2)
  1746. issue_in_child_project = Issue.find(5)
  1747. issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
  1748. issue_in_other_child_project = Issue.find(6)
  1749. issue_in_different_tree = Issue.find(4)
  1750. with_settings :cross_project_subtasks => '' do
  1751. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1752. assert_equal false, issue.valid_parent_project?(issue_in_child_project)
  1753. assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
  1754. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1755. end
  1756. with_settings :cross_project_subtasks => 'system' do
  1757. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1758. assert_equal true, issue.valid_parent_project?(issue_in_child_project)
  1759. assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
  1760. end
  1761. with_settings :cross_project_subtasks => 'tree' do
  1762. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1763. assert_equal true, issue.valid_parent_project?(issue_in_child_project)
  1764. assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
  1765. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1766. assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
  1767. assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
  1768. end
  1769. with_settings :cross_project_subtasks => 'descendants' do
  1770. assert_equal true, issue.valid_parent_project?(issue_in_same_project)
  1771. assert_equal false, issue.valid_parent_project?(issue_in_child_project)
  1772. assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
  1773. assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
  1774. assert_equal true, issue_in_child_project.valid_parent_project?(issue)
  1775. assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
  1776. end
  1777. end
  1778. def test_recipients_should_include_previous_assignee
  1779. user = User.find(3)
  1780. user.members.update_all ["mail_notification = ?", false]
  1781. user.update! :mail_notification => 'only_assigned'
  1782. issue = Issue.find(2)
  1783. issue.assigned_to = nil
  1784. assert_include user.mail, issue.recipients
  1785. issue.save!
  1786. assert_include user.mail, issue.recipients
  1787. issue.assigned_to = User.find(2)
  1788. issue.save!
  1789. assert !issue.recipients.include?(user.mail)
  1790. end
  1791. def test_recipients_should_not_include_users_that_cannot_view_the_issue
  1792. issue = Issue.find(12)
  1793. assert issue.recipients.include?(issue.author.mail)
  1794. # copy the issue to a private project
  1795. copy = issue.copy(:project_id => 5, :tracker_id => 2)
  1796. # author is not a member of project anymore
  1797. assert !copy.recipients.include?(copy.author.mail)
  1798. end
  1799. def test_recipients_should_include_the_assigned_group_members
  1800. group_member = User.generate!
  1801. group = Group.generate!
  1802. group.users << group_member
  1803. issue = Issue.find(12)
  1804. issue.assigned_to = group
  1805. assert issue.recipients.include?(group_member.mail)
  1806. end
  1807. def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
  1808. user = User.find(3)
  1809. issue = Issue.find(9)
  1810. Watcher.create!(:user => user, :watchable => issue)
  1811. assert issue.watched_by?(user)
  1812. assert !issue.watcher_recipients.include?(user.mail)
  1813. end
  1814. def test_issue_destroy
  1815. Issue.find(1).destroy
  1816. assert_nil Issue.find_by_id(1)
  1817. assert_nil TimeEntry.find_by_issue_id(1)
  1818. end
  1819. def test_destroy_should_delete_time_entries_custom_values
  1820. issue = Issue.generate!
  1821. time_entry = TimeEntry.generate!(:issue => issue, :custom_field_values => {10 => '1'})
  1822. assert_difference 'CustomValue.where(:customized_type => "TimeEntry").count', -1 do
  1823. assert issue.destroy
  1824. end
  1825. end
  1826. def test_destroying_a_deleted_issue_should_not_raise_an_error
  1827. issue = Issue.find(1)
  1828. Issue.find(1).destroy
  1829. assert_nothing_raised do
  1830. assert_no_difference 'Issue.count' do
  1831. issue.destroy
  1832. end
  1833. assert issue.destroyed?
  1834. end
  1835. end
  1836. def test_destroying_a_stale_issue_should_not_raise_an_error
  1837. issue = Issue.find(1)
  1838. Issue.find(1).update! :subject => "Updated"
  1839. assert_nothing_raised do
  1840. assert_difference 'Issue.count', -1 do
  1841. issue.destroy
  1842. end
  1843. assert issue.destroyed?
  1844. end
  1845. end
  1846. def test_blocked
  1847. blocked_issue = Issue.find(9)
  1848. blocking_issue = Issue.find(10)
  1849. assert blocked_issue.blocked?
  1850. assert !blocking_issue.blocked?
  1851. end
  1852. def test_blocked_issues_dont_allow_closed_statuses
  1853. blocked_issue = Issue.find(9)
  1854. allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
  1855. assert !allowed_statuses.empty?
  1856. closed_statuses = allowed_statuses.select {|st| st.is_closed?}
  1857. assert closed_statuses.empty?
  1858. end
  1859. def test_unblocked_issues_allow_closed_statuses
  1860. blocking_issue = Issue.find(10)
  1861. allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
  1862. assert !allowed_statuses.empty?
  1863. closed_statuses = allowed_statuses.select {|st| st.is_closed?}
  1864. assert !closed_statuses.empty?
  1865. end
  1866. def test_parent_issues_with_open_subtask_dont_allow_closed_statuses
  1867. parent = Issue.generate!
  1868. child = Issue.generate!(:parent_issue_id => parent.id)
  1869. allowed_statuses = parent.reload.new_statuses_allowed_to(users(:users_002))
  1870. assert !parent.closable?
  1871. assert_equal l(:notice_issue_not_closable_by_open_tasks), parent.transition_warning
  1872. assert allowed_statuses.any?
  1873. assert_equal [], allowed_statuses.select(&:is_closed?)
  1874. end
  1875. def test_parent_issues_with_closed_subtask_allow_closed_statuses
  1876. parent = Issue.generate!
  1877. child = Issue.generate!(:parent_issue_id => parent.id, :status_id => 5)
  1878. allowed_statuses = parent.reload.new_statuses_allowed_to(users(:users_002))
  1879. assert parent.closable?
  1880. assert_nil parent.transition_warning
  1881. assert allowed_statuses.any?
  1882. assert allowed_statuses.any?(&:is_closed?)
  1883. end
  1884. def test_reschedule_an_issue_without_dates
  1885. with_settings :non_working_week_days => [] do
  1886. issue = Issue.new(:start_date => nil, :due_date => nil)
  1887. issue.reschedule_on '2012-10-09'.to_date
  1888. assert_equal '2012-10-09'.to_date, issue.start_date
  1889. assert_equal '2012-10-09'.to_date, issue.due_date
  1890. end
  1891. with_settings :non_working_week_days => %w(6 7) do
  1892. issue = Issue.new(:start_date => nil, :due_date => nil)
  1893. issue.reschedule_on '2012-10-09'.to_date
  1894. assert_equal '2012-10-09'.to_date, issue.start_date
  1895. assert_equal '2012-10-09'.to_date, issue.due_date
  1896. issue = Issue.new(:start_date => nil, :due_date => nil)
  1897. issue.reschedule_on '2012-10-13'.to_date
  1898. assert_equal '2012-10-15'.to_date, issue.start_date
  1899. assert_equal '2012-10-15'.to_date, issue.due_date
  1900. end
  1901. end
  1902. def test_reschedule_an_issue_with_start_date
  1903. with_settings :non_working_week_days => [] do
  1904. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1905. issue.reschedule_on '2012-10-13'.to_date
  1906. assert_equal '2012-10-13'.to_date, issue.start_date
  1907. assert_equal '2012-10-13'.to_date, issue.due_date
  1908. end
  1909. with_settings :non_working_week_days => %w(6 7) do
  1910. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1911. issue.reschedule_on '2012-10-11'.to_date
  1912. assert_equal '2012-10-11'.to_date, issue.start_date
  1913. assert_equal '2012-10-11'.to_date, issue.due_date
  1914. issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
  1915. issue.reschedule_on '2012-10-13'.to_date
  1916. assert_equal '2012-10-15'.to_date, issue.start_date
  1917. assert_equal '2012-10-15'.to_date, issue.due_date
  1918. end
  1919. end
  1920. def test_reschedule_an_issue_with_start_and_due_dates
  1921. with_settings :non_working_week_days => [] do
  1922. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
  1923. issue.reschedule_on '2012-10-13'.to_date
  1924. assert_equal '2012-10-13'.to_date, issue.start_date
  1925. assert_equal '2012-10-19'.to_date, issue.due_date
  1926. end
  1927. with_settings :non_working_week_days => %w(6 7) do
  1928. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
  1929. issue.reschedule_on '2012-10-11'.to_date
  1930. assert_equal '2012-10-11'.to_date, issue.start_date
  1931. assert_equal '2012-10-23'.to_date, issue.due_date
  1932. issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
  1933. issue.reschedule_on '2012-10-13'.to_date
  1934. assert_equal '2012-10-15'.to_date, issue.start_date
  1935. assert_equal '2012-10-25'.to_date, issue.due_date
  1936. end
  1937. end
  1938. def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
  1939. with_settings :non_working_week_days => [] do
  1940. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1941. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1942. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1943. :relation_type => IssueRelation::TYPE_PRECEDES)
  1944. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1945. issue1.reload
  1946. issue1.due_date = '2012-10-23'
  1947. issue1.save!
  1948. issue2.reload
  1949. assert_equal Date.parse('2012-10-24'), issue2.start_date
  1950. assert_equal Date.parse('2012-10-26'), issue2.due_date
  1951. end
  1952. # The delay should honor non-working week days
  1953. with_settings :non_working_week_days => %w(6 7) do
  1954. issue1 = Issue.generate!(:start_date => '2014-03-10', :due_date => '2014-03-12')
  1955. issue2 = Issue.generate!(:start_date => '2014-03-10', :due_date => '2014-03-12')
  1956. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1957. :relation_type => IssueRelation::TYPE_PRECEDES,
  1958. :delay => 8)
  1959. assert_equal Date.parse('2014-03-25'), issue2.reload.start_date
  1960. end
  1961. end
  1962. def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
  1963. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1964. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1965. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1966. :relation_type => IssueRelation::TYPE_PRECEDES)
  1967. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  1968. issue1.reload
  1969. issue1.start_date = '2012-09-17'
  1970. issue1.due_date = '2012-09-18'
  1971. issue1.save!
  1972. issue2.reload
  1973. assert_equal Date.parse('2012-09-19'), issue2.start_date
  1974. assert_equal Date.parse('2012-09-21'), issue2.due_date
  1975. end
  1976. def test_rescheduling_an_issue_to_a_different_due_date_should_add_journal_to_following_issue
  1977. with_settings :non_working_week_days => [] do
  1978. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1979. issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
  1980. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  1981. :relation_type => IssueRelation::TYPE_PRECEDES)
  1982. assert_difference 'issue2.journals.count' do
  1983. issue1.reload
  1984. issue1.init_journal(User.find(3))
  1985. issue1.due_date = '2012-10-23'
  1986. issue1.save!
  1987. end
  1988. journal = issue2.journals.order(:id).last
  1989. start_date_detail = journal.details.find_by(:prop_key => 'start_date')
  1990. assert_equal '2012-10-18', start_date_detail.old_value
  1991. assert_equal '2012-10-24', start_date_detail.value
  1992. due_date_detail = journal.details.find_by(:prop_key => 'due_date')
  1993. assert_equal '2012-10-20', due_date_detail.old_value
  1994. assert_equal '2012-10-26', due_date_detail.value
  1995. end
  1996. end
  1997. def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
  1998. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  1999. issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  2000. issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
  2001. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  2002. :relation_type => IssueRelation::TYPE_PRECEDES)
  2003. IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
  2004. :relation_type => IssueRelation::TYPE_PRECEDES)
  2005. assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
  2006. issue1.reload
  2007. issue1.start_date = '2012-09-17'
  2008. issue1.due_date = '2012-09-18'
  2009. issue1.save!
  2010. issue2.reload
  2011. # Issue 2 must start after Issue 3
  2012. assert_equal Date.parse('2012-10-03'), issue2.start_date
  2013. assert_equal Date.parse('2012-10-05'), issue2.due_date
  2014. end
  2015. def test_rescheduling_a_stale_issue_should_not_raise_an_error
  2016. with_settings :non_working_week_days => [] do
  2017. stale = Issue.find(1)
  2018. issue = Issue.find(1)
  2019. issue.subject = "Updated"
  2020. issue.save!
  2021. date = 10.days.from_now.to_date
  2022. assert_nothing_raised do
  2023. stale.reschedule_on!(date)
  2024. end
  2025. assert_equal date, stale.reload.start_date
  2026. end
  2027. end
  2028. def test_child_issue_should_consider_parent_soonest_start_on_create
  2029. set_language_if_valid 'en'
  2030. issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
  2031. issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
  2032. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
  2033. :relation_type => IssueRelation::TYPE_PRECEDES)
  2034. issue1.reload
  2035. issue2.reload
  2036. assert_equal Date.parse('2012-10-18'), issue2.start_date
  2037. with_settings :date_format => '%m/%d/%Y' do
  2038. child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
  2039. :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
  2040. assert !child.valid?
  2041. assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
  2042. assert_equal Date.parse('2012-10-18'), child.soonest_start
  2043. child.start_date = '2012-10-18'
  2044. assert child.save
  2045. end
  2046. end
  2047. def test_setting_parent_to_a_an_issue_that_precedes_should_not_validate
  2048. # tests that 3 cannot have 1 as parent:
  2049. #
  2050. # 1 -> 2 -> 3
  2051. #
  2052. set_language_if_valid 'en'
  2053. issue1 = Issue.generate!
  2054. issue2 = Issue.generate!
  2055. issue3 = Issue.generate!
  2056. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  2057. IssueRelation.create!(:issue_from => issue2, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
  2058. issue3.reload
  2059. issue3.parent_issue_id = issue1.id
  2060. assert !issue3.valid?
  2061. assert_include 'Parent task is invalid', issue3.errors.full_messages
  2062. end
  2063. def test_setting_parent_to_a_an_issue_that_follows_should_not_validate
  2064. # tests that 1 cannot have 3 as parent:
  2065. #
  2066. # 1 -> 2 -> 3
  2067. #
  2068. set_language_if_valid 'en'
  2069. issue1 = Issue.generate!
  2070. issue2 = Issue.generate!
  2071. issue3 = Issue.generate!
  2072. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  2073. IssueRelation.create!(:issue_from => issue2, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
  2074. issue1.reload
  2075. issue1.parent_issue_id = issue3.id
  2076. assert !issue1.valid?
  2077. assert_include 'Parent task is invalid', issue1.errors.full_messages
  2078. end
  2079. def test_setting_parent_to_a_an_issue_that_precedes_through_hierarchy_should_not_validate
  2080. # tests that 4 cannot have 1 as parent:
  2081. # changing the due date of 4 would update the end date of 1 which would reschedule 2
  2082. # which would change the end date of 3 which would reschedule 4 and so on...
  2083. #
  2084. # 3 -> 4
  2085. # ^
  2086. # 1 -> 2
  2087. #
  2088. set_language_if_valid 'en'
  2089. issue1 = Issue.generate!
  2090. issue2 = Issue.generate!
  2091. IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  2092. issue3 = Issue.generate!
  2093. issue2.reload
  2094. issue2.parent_issue_id = issue3.id
  2095. issue2.save!
  2096. issue4 = Issue.generate!
  2097. IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
  2098. issue4.reload
  2099. issue4.parent_issue_id = issue1.id
  2100. assert !issue4.valid?
  2101. assert_include 'Parent task is invalid', issue4.errors.full_messages
  2102. end
  2103. def test_issue_and_following_issue_should_be_able_to_be_moved_to_the_same_parent
  2104. set_language_if_valid 'en'
  2105. issue1 = Issue.generate!
  2106. issue2 = Issue.generate!
  2107. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_FOLLOWS)
  2108. parent = Issue.generate!
  2109. issue1.reload.parent_issue_id = parent.id
  2110. assert_save issue1
  2111. parent.reload
  2112. issue2.reload.parent_issue_id = parent.id
  2113. assert_save issue2
  2114. assert IssueRelation.exists?(relation.id)
  2115. end
  2116. def test_issue_and_preceding_issue_should_be_able_to_be_moved_to_the_same_parent
  2117. set_language_if_valid 'en'
  2118. issue1 = Issue.generate!
  2119. issue2 = Issue.generate!
  2120. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
  2121. parent = Issue.generate!
  2122. issue1.reload.parent_issue_id = parent.id
  2123. assert_save issue1
  2124. parent.reload
  2125. issue2.reload.parent_issue_id = parent.id
  2126. assert_save issue2
  2127. assert IssueRelation.exists?(relation.id)
  2128. end
  2129. def test_issue_and_blocked_issue_should_be_able_to_be_moved_to_the_same_parent
  2130. set_language_if_valid 'en'
  2131. issue1 = Issue.generate!
  2132. issue2 = Issue.generate!
  2133. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_BLOCKED)
  2134. parent = Issue.generate!
  2135. issue1.reload.parent_issue_id = parent.id
  2136. assert_save issue1
  2137. parent.reload
  2138. issue2.reload.parent_issue_id = parent.id
  2139. assert_save issue2
  2140. assert IssueRelation.exists?(relation.id)
  2141. end
  2142. def test_issue_and_blocking_issue_should_be_able_to_be_moved_to_the_same_parent
  2143. set_language_if_valid 'en'
  2144. issue1 = Issue.generate!
  2145. issue2 = Issue.generate!
  2146. relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_BLOCKS)
  2147. parent = Issue.generate!
  2148. issue1.reload.parent_issue_id = parent.id
  2149. assert_save issue1
  2150. parent.reload
  2151. issue2.reload.parent_issue_id = parent.id
  2152. assert_save issue2
  2153. assert IssueRelation.exists?(relation.id)
  2154. end
  2155. def test_issue_copy_should_be_able_to_be_moved_to_the_same_parent_as_copied_issue
  2156. issue = Issue.generate!
  2157. parent = Issue.generate!
  2158. issue.parent_issue_id = parent.id
  2159. issue.save!
  2160. issue.reload
  2161. copy = Issue.new.copy_from(issue, :link => true)
  2162. relation = new_record(IssueRelation) do
  2163. copy.save!
  2164. end
  2165. copy.reload
  2166. copy.parent_issue_id = parent.id
  2167. assert_save copy
  2168. assert IssueRelation.exists?(relation.id)
  2169. end
  2170. def test_overdue
  2171. User.current = nil
  2172. today = User.current.today
  2173. assert Issue.new(:due_date => (today - 1.day).to_date).overdue?
  2174. assert !Issue.new(:due_date => today).overdue?
  2175. assert !Issue.new(:due_date => (today + 1.day).to_date).overdue?
  2176. assert !Issue.new(:due_date => nil).overdue?
  2177. assert !Issue.
  2178. new(
  2179. :due_date => (today - 1.day).to_date,
  2180. :status => IssueStatus.where(:is_closed => true).first
  2181. ).overdue?
  2182. end
  2183. test "#behind_schedule? should be false if the issue has no start_date" do
  2184. assert !Issue.new(:start_date => nil,
  2185. :due_date => 1.day.from_now.to_date,
  2186. :done_ratio => 0).behind_schedule?
  2187. end
  2188. test "#behind_schedule? should be false if the issue has no end_date" do
  2189. assert !Issue.new(:start_date => 1.day.from_now.to_date,
  2190. :due_date => nil,
  2191. :done_ratio => 0).behind_schedule?
  2192. end
  2193. test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
  2194. assert !Issue.new(:start_date => 50.days.ago.to_date,
  2195. :due_date => 50.days.from_now.to_date,
  2196. :done_ratio => 90).behind_schedule?
  2197. end
  2198. test "#behind_schedule? should be true if the issue hasn't been started at all" do
  2199. assert Issue.new(:start_date => 1.day.ago.to_date,
  2200. :due_date => 1.day.from_now.to_date,
  2201. :done_ratio => 0).behind_schedule?
  2202. end
  2203. test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
  2204. assert Issue.new(:start_date => 100.days.ago.to_date,
  2205. :due_date => Date.today,
  2206. :done_ratio => 90).behind_schedule?
  2207. end
  2208. test "#assignable_users should be Users" do
  2209. assert_kind_of User, Issue.find(1).assignable_users.first
  2210. end
  2211. test "#assignable_users should include the issue author" do
  2212. non_project_member = User.generate!
  2213. issue = Issue.generate!(:author => non_project_member)
  2214. assert issue.assignable_users.include?(non_project_member)
  2215. end
  2216. def test_assignable_users_should_not_include_anonymous_user
  2217. issue = Issue.generate!(:author => User.anonymous)
  2218. assert !issue.assignable_users.include?(User.anonymous)
  2219. end
  2220. def test_assignable_users_should_not_include_locked_user
  2221. user = User.generate!
  2222. issue = Issue.generate!(:author => user)
  2223. user.lock!
  2224. assert !issue.assignable_users.include?(user)
  2225. end
  2226. def test_assignable_users_should_include_the_current_assignee
  2227. user = User.generate!
  2228. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2229. issue = Issue.generate!(:assigned_to => user)
  2230. user.lock!
  2231. assert Issue.find(issue.id).assignable_users.include?(user)
  2232. end
  2233. test "#assignable_users should not show the issue author twice" do
  2234. assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
  2235. assert_equal 2, assignable_user_ids.length
  2236. assignable_user_ids.each do |user_id|
  2237. assert_equal 1, assignable_user_ids.count {|i| i == user_id},
  2238. "User #{user_id} appears more or less than once"
  2239. end
  2240. end
  2241. test "#assignable_users with issue_group_assignment should include groups" do
  2242. issue = Issue.new(:project => Project.find(2))
  2243. with_settings :issue_group_assignment => '1' do
  2244. assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
  2245. assert issue.assignable_users.include?(Group.find(11))
  2246. end
  2247. end
  2248. test "#assignable_users without issue_group_assignment should not include groups" do
  2249. issue = Issue.new(:project => Project.find(2))
  2250. with_settings :issue_group_assignment => '0' do
  2251. assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
  2252. assert !issue.assignable_users.include?(Group.find(11))
  2253. end
  2254. end
  2255. def test_assignable_users_should_not_include_builtin_groups
  2256. Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [1])
  2257. Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [1])
  2258. issue = Issue.new(:project => Project.find(1))
  2259. with_settings :issue_group_assignment => '1' do
  2260. assert_nil issue.assignable_users.detect {|u| u.is_a?(GroupBuiltin)}
  2261. end
  2262. end
  2263. def test_assignable_users_should_not_include_users_that_cannot_view_the_tracker
  2264. user = User.find(3)
  2265. role = Role.find(2)
  2266. role.set_permission_trackers :view_issues, [1, 3]
  2267. role.save!
  2268. issue1 = Issue.new(:project_id => 1, :tracker_id => 1)
  2269. issue2 = Issue.new(:project_id => 1, :tracker_id => 2)
  2270. assert_include user, issue1.assignable_users
  2271. assert_not_include user, issue2.assignable_users
  2272. end
  2273. def test_create_should_send_email_notification
  2274. ActionMailer::Base.deliveries.clear
  2275. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  2276. :author_id => 3, :status_id => 1,
  2277. :priority => IssuePriority.first,
  2278. :subject => 'test_create', :estimated_hours => '1:30')
  2279. with_settings :notified_events => %w(issue_added) do
  2280. assert issue.save
  2281. assert_equal 2, ActionMailer::Base.deliveries.size
  2282. end
  2283. end
  2284. def test_create_should_send_one_email_notification_with_both_settings
  2285. ActionMailer::Base.deliveries.clear
  2286. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  2287. :author_id => 3, :status_id => 1,
  2288. :priority => IssuePriority.first,
  2289. :subject => 'test_create', :estimated_hours => '1:30')
  2290. with_settings :notified_events => %w(issue_added issue_updated) do
  2291. assert issue.save
  2292. assert_equal 2, ActionMailer::Base.deliveries.size
  2293. end
  2294. end
  2295. def test_create_should_not_send_email_notification_with_no_setting
  2296. ActionMailer::Base.deliveries.clear
  2297. issue = Issue.new(:project_id => 1, :tracker_id => 1,
  2298. :author_id => 3, :status_id => 1,
  2299. :priority => IssuePriority.first,
  2300. :subject => 'test_create', :estimated_hours => '1:30')
  2301. with_settings :notified_events => [] do
  2302. assert issue.save
  2303. assert_equal 0, ActionMailer::Base.deliveries.size
  2304. end
  2305. end
  2306. def test_update_should_notify_previous_assignee
  2307. ActionMailer::Base.deliveries.clear
  2308. user = User.find(3)
  2309. user.members.update_all ["mail_notification = ?", false]
  2310. user.update! :mail_notification => 'only_assigned'
  2311. with_settings :notified_events => %w(issue_updated) do
  2312. issue = Issue.find(2)
  2313. issue.init_journal User.find(1)
  2314. issue.assigned_to = nil
  2315. issue.save!
  2316. assert_include [user.mail], ActionMailer::Base.deliveries.map(&:to)
  2317. end
  2318. end
  2319. def test_stale_issue_should_not_send_email_notification
  2320. ActionMailer::Base.deliveries.clear
  2321. issue = Issue.find(1)
  2322. stale = Issue.find(1)
  2323. issue.init_journal(User.find(1))
  2324. issue.subject = 'Subjet update'
  2325. with_settings :notified_events => %w(issue_updated) do
  2326. assert issue.save
  2327. assert_equal 2, ActionMailer::Base.deliveries.size
  2328. ActionMailer::Base.deliveries.clear
  2329. stale.init_journal(User.find(1))
  2330. stale.subject = 'Another subjet update'
  2331. assert_raise ActiveRecord::StaleObjectError do
  2332. stale.save
  2333. end
  2334. assert ActionMailer::Base.deliveries.empty?
  2335. end
  2336. end
  2337. def test_journalized_description
  2338. IssueCustomField.delete_all
  2339. i = Issue.first
  2340. old_description = i.description
  2341. new_description = "This is the new description"
  2342. i.init_journal(User.find(2))
  2343. i.description = new_description
  2344. assert_difference 'Journal.count', 1 do
  2345. assert_difference 'JournalDetail.count', 1 do
  2346. i.save!
  2347. end
  2348. end
  2349. detail = JournalDetail.order('id DESC').first
  2350. assert_equal i, detail.journal.journalized
  2351. assert_equal 'attr', detail.property
  2352. assert_equal 'description', detail.prop_key
  2353. assert_equal old_description, detail.old_value
  2354. assert_equal new_description, detail.value
  2355. end
  2356. def test_blank_descriptions_should_not_be_journalized
  2357. IssueCustomField.delete_all
  2358. Issue.where(:id => 1).update_all("description = NULL")
  2359. i = Issue.find(1)
  2360. i.init_journal(User.find(2))
  2361. i.subject = "blank description"
  2362. i.description = "\r\n"
  2363. assert_difference 'Journal.count', 1 do
  2364. assert_difference 'JournalDetail.count', 1 do
  2365. i.save!
  2366. end
  2367. end
  2368. end
  2369. def test_journalized_multi_custom_field
  2370. field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
  2371. :is_filter => true, :is_for_all => true,
  2372. :tracker_ids => [1],
  2373. :possible_values => ['value1', 'value2', 'value3'],
  2374. :multiple => true)
  2375. issue = Issue.generate!(:project_id => 1, :tracker_id => 1,
  2376. :subject => 'Test', :author_id => 1)
  2377. assert_difference 'Journal.count' do
  2378. assert_difference 'JournalDetail.count' do
  2379. issue.init_journal(User.first)
  2380. issue.custom_field_values = {field.id => ['value1']}
  2381. issue.save!
  2382. end
  2383. assert_difference 'JournalDetail.count' do
  2384. issue.init_journal(User.first)
  2385. issue.custom_field_values = {field.id => ['value1', 'value2']}
  2386. issue.save!
  2387. end
  2388. assert_difference 'JournalDetail.count', 2 do
  2389. issue.init_journal(User.first)
  2390. issue.custom_field_values = {field.id => ['value3', 'value2']}
  2391. issue.save!
  2392. end
  2393. assert_difference 'JournalDetail.count', 2 do
  2394. issue.init_journal(User.first)
  2395. issue.custom_field_values = {field.id => nil}
  2396. issue.save!
  2397. end
  2398. end
  2399. end
  2400. def test_custom_value_cleared_on_tracker_change_should_be_journalized
  2401. a = IssueCustomField.generate!(:tracker_ids => [1])
  2402. issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {a.id.to_s => "foo"})
  2403. assert_equal "foo", issue.custom_field_value(a)
  2404. journal = new_record(Journal) do
  2405. issue.init_journal(User.first)
  2406. issue.tracker_id = 2
  2407. issue.save!
  2408. end
  2409. details = journal.details.select {|d| d.property == 'cf' && d.prop_key == a.id.to_s}
  2410. assert_equal 1, details.size
  2411. assert_equal 'foo', details.first.old_value
  2412. assert_nil details.first.value
  2413. end
  2414. def test_description_eol_should_be_normalized
  2415. i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
  2416. assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
  2417. end
  2418. def test_saving_twice_should_not_duplicate_journal_details
  2419. i = Issue.first
  2420. i.init_journal(User.find(2), 'Some notes')
  2421. # initial changes
  2422. i.subject = 'New subject'
  2423. i.done_ratio = i.done_ratio + 10
  2424. assert_difference 'Journal.count' do
  2425. assert i.save
  2426. end
  2427. # 1 more change
  2428. i.priority = IssuePriority.where("id <> ?", i.priority_id).first
  2429. assert_no_difference 'Journal.count' do
  2430. assert_difference 'JournalDetail.count', 1 do
  2431. i.save
  2432. end
  2433. end
  2434. # no more change
  2435. assert_no_difference 'Journal.count' do
  2436. assert_no_difference 'JournalDetail.count' do
  2437. i.save
  2438. end
  2439. end
  2440. end
  2441. test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
  2442. @issue = Issue.find(1)
  2443. @issue_status = IssueStatus.find(1)
  2444. @issue_status.update!(:default_done_ratio => 50)
  2445. @issue2 = Issue.find(2)
  2446. @issue_status2 = IssueStatus.find(2)
  2447. @issue_status2.update!(:default_done_ratio => 0)
  2448. with_settings :issue_done_ratio => 'issue_field' do
  2449. assert_equal 0, @issue.done_ratio
  2450. assert_equal 30, @issue2.done_ratio
  2451. end
  2452. with_settings :issue_done_ratio => 'issue_status' do
  2453. assert_equal 50, @issue.done_ratio
  2454. assert_equal 0, @issue2.done_ratio
  2455. end
  2456. end
  2457. test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
  2458. @issue = Issue.find(1)
  2459. @issue_status = IssueStatus.find(1)
  2460. @issue_status.update!(:default_done_ratio => 50)
  2461. @issue2 = Issue.find(2)
  2462. @issue_status2 = IssueStatus.find(2)
  2463. @issue_status2.update!(:default_done_ratio => 0)
  2464. with_settings :issue_done_ratio => 'issue_field' do
  2465. @issue.update_done_ratio_from_issue_status
  2466. @issue2.update_done_ratio_from_issue_status
  2467. assert_equal 0, @issue.read_attribute(:done_ratio)
  2468. assert_equal 30, @issue2.read_attribute(:done_ratio)
  2469. end
  2470. with_settings :issue_done_ratio => 'issue_status' do
  2471. @issue.update_done_ratio_from_issue_status
  2472. @issue2.update_done_ratio_from_issue_status
  2473. assert_equal 50, @issue.read_attribute(:done_ratio)
  2474. assert_equal 0, @issue2.read_attribute(:done_ratio)
  2475. end
  2476. end
  2477. test "#by_tracker" do
  2478. User.current = User.find(2)
  2479. groups = Issue.by_tracker(Project.find(1))
  2480. groups_containing_subprojects = Issue.by_tracker(Project.find(1), true)
  2481. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2482. assert_equal 13, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2483. end
  2484. test "#by_version" do
  2485. User.current = User.find(2)
  2486. project = Project.find(1)
  2487. Issue.generate!(:project_id => project.descendants.visible.first, :fixed_version_id => project.shared_versions.find_by(:sharing => 'tree').id)
  2488. groups = Issue.by_version(project)
  2489. groups_containing_subprojects = Issue.by_version(project, true)
  2490. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2491. assert_equal 14, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2492. end
  2493. test "#by_priority" do
  2494. User.current = User.find(2)
  2495. project = Project.find(1)
  2496. groups = Issue.by_priority(project)
  2497. groups_containing_subprojects = Issue.by_priority(project, true)
  2498. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2499. assert_equal 13, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2500. end
  2501. test "#by_category" do
  2502. User.current = User.find(2)
  2503. project = Project.find(1)
  2504. issue_category = IssueCategory.create(:project => project.descendants.visible.first, :name => 'test category')
  2505. Issue.generate!(:project_id => project.descendants.visible.first, :category_id => issue_category.id)
  2506. groups = Issue.by_category(project)
  2507. groups_containing_subprojects = Issue.by_category(project, true)
  2508. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2509. assert_equal 14, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2510. end
  2511. test "#by_assigned_to" do
  2512. User.current = User.find(2)
  2513. project = Project.find(1)
  2514. Issue.generate!(:project_id => project.descendants.visible.first, :assigned_to => User.current)
  2515. groups = Issue.by_assigned_to(project)
  2516. groups_containing_subprojects = Issue.by_assigned_to(project, true)
  2517. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2518. assert_equal 14, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2519. end
  2520. test "#by_author" do
  2521. User.current = User.find(2)
  2522. project = Project.find(1)
  2523. groups = Issue.by_author(project)
  2524. groups_containing_subprojects = Issue.by_author(project, true)
  2525. assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2526. assert_equal 13, groups_containing_subprojects.inject(0) {|sum, group| sum + group['total'].to_i}
  2527. end
  2528. test "#by_subproject" do
  2529. User.current = User.anonymous
  2530. groups = Issue.by_subproject(Project.find(1))
  2531. # Private descendant not visible
  2532. assert_equal 1, groups.count
  2533. assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
  2534. end
  2535. def test_recently_updated_scope
  2536. # should return the last updated issue
  2537. assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
  2538. end
  2539. def test_on_active_projects_scope
  2540. assert Project.find(2).archive
  2541. before = Issue.on_active_project.length
  2542. # test inclusion to results
  2543. issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
  2544. assert_equal before + 1, Issue.on_active_project.length
  2545. # Move to an archived project
  2546. issue.project = Project.find(2)
  2547. assert issue.save
  2548. assert_equal before, Issue.on_active_project.length
  2549. end
  2550. test "Issue#recipients should include project recipients" do
  2551. issue = Issue.generate!
  2552. assert issue.project.recipients.present?
  2553. issue.project.recipients.each do |project_recipient|
  2554. assert issue.recipients.include?(project_recipient)
  2555. end
  2556. end
  2557. test "Issue#recipients should include the author if the author is active" do
  2558. issue = Issue.generate!(:author => User.generate!(:mail_notification => 'only_my_events'))
  2559. assert issue.author, "No author set for Issue"
  2560. assert issue.recipients.include?(issue.author.mail)
  2561. end
  2562. test "Issue#recipients should include the assigned to user if the assigned to user is active" do
  2563. user = User.generate!
  2564. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2565. issue = Issue.generate!(:assigned_to => user)
  2566. assert issue.assigned_to, "No assigned_to set for Issue"
  2567. assert issue.recipients.include?(issue.assigned_to.mail)
  2568. end
  2569. test "Issue#recipients should not include users who opt out of all email" do
  2570. issue = Issue.generate!(:author => User.generate!)
  2571. issue.author.update!(:mail_notification => :none)
  2572. assert !issue.recipients.include?(issue.author.mail)
  2573. end
  2574. test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
  2575. issue = Issue.generate!(:author => User.generate!)
  2576. issue.author.update!(:mail_notification => :only_assigned)
  2577. assert !issue.recipients.include?(issue.author.mail)
  2578. end
  2579. test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
  2580. user = User.generate!
  2581. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2582. issue = Issue.generate!(:assigned_to => user)
  2583. issue.assigned_to.update!(:mail_notification => :only_owner)
  2584. assert !issue.recipients.include?(issue.assigned_to.mail)
  2585. end
  2586. test "Issue#recipients should include users who want to be notified about high issues but only when issue has high priority" do
  2587. user = User.generate!
  2588. user.pref.update! notify_about_high_priority_issues: true
  2589. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2590. # creation with high prio
  2591. issue = Issue.generate!(priority: IssuePriority.find(6))
  2592. assert issue.recipients.include?(user.mail)
  2593. # creation with default prio
  2594. issue = Issue.generate!
  2595. assert !issue.recipients.include?(user.mail)
  2596. # update prio to high
  2597. issue.update! priority: IssuePriority.find(6)
  2598. assert issue.recipients.include?(user.mail)
  2599. # update prio to low
  2600. issue.update! priority: IssuePriority.find(4)
  2601. assert !issue.recipients.include?(user.mail)
  2602. end
  2603. test "Authors who don't want to be self-notified should not receive emails even when issue has high priority" do
  2604. user = User.generate!
  2605. user.pref.update! notify_about_high_priority_issues: true
  2606. user.pref.update! no_self_notified: true
  2607. project = Project.find(1)
  2608. project.memberships.destroy_all
  2609. Member.create!(:project_id => 1, :principal => user, :role_ids => [1])
  2610. ActionMailer::Base.deliveries.clear
  2611. Issue.create(author: user,
  2612. priority: IssuePriority.find(6),
  2613. subject: 'test create',
  2614. project: project,
  2615. tracker: Tracker.first,
  2616. status: IssueStatus.first)
  2617. assert ActionMailer::Base.deliveries.empty?
  2618. end
  2619. def test_last_journal_id_with_journals_should_return_the_journal_id
  2620. assert_equal 2, Issue.find(1).last_journal_id
  2621. end
  2622. def test_last_journal_id_without_journals_should_return_nil
  2623. assert_nil Issue.find(3).last_journal_id
  2624. end
  2625. def test_journals_after_should_return_journals_with_greater_id
  2626. assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
  2627. assert_equal [], Issue.find(1).journals_after('2')
  2628. end
  2629. def test_journals_after_with_blank_arg_should_return_all_journals
  2630. assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
  2631. end
  2632. def test_css_classes_should_include_tracker
  2633. issue = Issue.new(:tracker => Tracker.find(2))
  2634. classes = issue.css_classes.split(' ')
  2635. assert_include 'tracker-2', classes
  2636. end
  2637. def test_css_classes_should_include_priority
  2638. issue = Issue.new(:priority => IssuePriority.find(8))
  2639. classes = issue.css_classes.split(' ')
  2640. assert_include 'priority-8', classes
  2641. assert_include 'priority-highest', classes
  2642. end
  2643. def test_css_classes_should_include_user_and_group_assignment
  2644. project = Project.first
  2645. user = User.generate!
  2646. group = Group.generate!
  2647. Member.create!(:principal => group, :project => project, :role_ids => [1, 2])
  2648. group.users << user
  2649. assert user.member_of?(project)
  2650. issue1 = Issue.generate(:assigned_to_id => group.id)
  2651. assert_include 'assigned-to-my-group', issue1.css_classes(user)
  2652. assert_not_include 'assigned-to-me', issue1.css_classes(user)
  2653. issue2 = Issue.generate(:assigned_to_id => user.id)
  2654. assert_not_include 'assigned-to-my-group', issue2.css_classes(user)
  2655. assert_include 'assigned-to-me', issue2.css_classes(user)
  2656. end
  2657. def test_css_classes_behind_schedule
  2658. assert_include 'behind-schedule', Issue.find(1).css_classes.split(' ')
  2659. assert_not_include 'behind-schedule', Issue.find(2).css_classes.split(' ')
  2660. end
  2661. def test_save_attachments_with_hash_should_save_attachments_in_keys_order
  2662. set_tmp_attachments_directory
  2663. issue = Issue.generate!
  2664. issue.save_attachments(
  2665. {
  2666. 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
  2667. '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
  2668. '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
  2669. }
  2670. )
  2671. issue.attach_saved_attachments
  2672. assert_equal 3, issue.reload.attachments.count
  2673. assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
  2674. end
  2675. def test_save_attachments_with_array_should_warn_about_missing_tokens
  2676. set_tmp_attachments_directory
  2677. issue = Issue.generate!
  2678. issue.save_attachments([{'token' => 'missing'}])
  2679. assert !issue.save
  2680. assert issue.errors[:base].present?
  2681. assert_equal 0, issue.reload.attachments.count
  2682. end
  2683. def test_closed_on_should_be_nil_when_creating_an_open_issue
  2684. issue = Issue.generate!(:status_id => 1).reload
  2685. assert !issue.closed?
  2686. assert_nil issue.closed_on
  2687. end
  2688. def test_closed_on_should_be_set_when_creating_a_closed_issue
  2689. issue = Issue.generate!(:status_id => 5).reload
  2690. assert issue.closed?
  2691. assert_not_nil issue.closed_on
  2692. assert_equal issue.updated_on, issue.closed_on
  2693. assert_equal issue.created_on, issue.closed_on
  2694. end
  2695. def test_closed_on_should_be_nil_when_updating_an_open_issue
  2696. issue = Issue.find(1)
  2697. issue.subject = 'Not closed yet'
  2698. issue.save!
  2699. issue.reload
  2700. assert_nil issue.closed_on
  2701. end
  2702. def test_closed_on_should_be_set_when_closing_an_open_issue
  2703. issue = Issue.find(1)
  2704. issue.subject = 'Now closed'
  2705. issue.status_id = 5
  2706. issue.save!
  2707. issue.reload
  2708. assert_not_nil issue.closed_on
  2709. assert_equal issue.updated_on, issue.closed_on
  2710. end
  2711. def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
  2712. issue = Issue.open(false).first
  2713. was_closed_on = issue.closed_on
  2714. assert_not_nil was_closed_on
  2715. issue.subject = 'Updating a closed issue'
  2716. issue.save!
  2717. issue.reload
  2718. assert_equal was_closed_on, issue.closed_on
  2719. end
  2720. def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
  2721. issue = Issue.open(false).first
  2722. was_closed_on = issue.closed_on
  2723. assert_not_nil was_closed_on
  2724. issue.subject = 'Reopening a closed issue'
  2725. issue.status_id = 1
  2726. issue.save!
  2727. issue.reload
  2728. assert !issue.closed?
  2729. assert_equal was_closed_on, issue.closed_on
  2730. end
  2731. def test_status_was_should_return_nil_for_new_issue
  2732. issue = Issue.new
  2733. assert_nil issue.status_was
  2734. end
  2735. def test_status_was_should_return_status_before_change
  2736. issue = Issue.find(1)
  2737. issue.status = IssueStatus.find(2)
  2738. assert_equal IssueStatus.find(1), issue.status_was
  2739. end
  2740. def test_status_was_should_return_status_before_change_with_status_id
  2741. issue = Issue.find(1)
  2742. assert_equal IssueStatus.find(1), issue.status
  2743. issue.status_id = 2
  2744. assert_equal IssueStatus.find(1), issue.status_was
  2745. end
  2746. def test_status_was_should_be_reset_on_save
  2747. issue = Issue.find(1)
  2748. issue.status = IssueStatus.find(2)
  2749. assert_equal IssueStatus.find(1), issue.status_was
  2750. assert issue.save!
  2751. assert_equal IssueStatus.find(2), issue.status_was
  2752. end
  2753. def test_closing_should_return_true_when_closing_an_issue
  2754. issue = Issue.find(1)
  2755. issue.status = IssueStatus.find(2)
  2756. assert_equal false, issue.closing?
  2757. issue.status = IssueStatus.find(5)
  2758. assert_equal true, issue.closing?
  2759. end
  2760. def test_closing_should_return_true_when_closing_an_issue_with_status_id
  2761. issue = Issue.find(1)
  2762. issue.status_id = 2
  2763. assert_equal false, issue.closing?
  2764. issue.status_id = 5
  2765. assert_equal true, issue.closing?
  2766. end
  2767. def test_closing_should_return_true_for_new_closed_issue
  2768. issue = Issue.new
  2769. assert_equal false, issue.closing?
  2770. issue.status = IssueStatus.find(5)
  2771. assert_equal true, issue.closing?
  2772. end
  2773. def test_closing_should_return_true_for_new_closed_issue_with_status_id
  2774. issue = Issue.new
  2775. assert_equal false, issue.closing?
  2776. issue.status_id = 5
  2777. assert_equal true, issue.closing?
  2778. end
  2779. def test_closing_should_be_reset_after_save
  2780. issue = Issue.find(1)
  2781. issue.status_id = 5
  2782. assert_equal true, issue.closing?
  2783. issue.save!
  2784. assert_equal false, issue.closing?
  2785. end
  2786. def test_reopening_should_return_true_when_reopening_an_issue
  2787. issue = Issue.find(8)
  2788. issue.status = IssueStatus.find(6)
  2789. assert_equal false, issue.reopening?
  2790. issue.status = IssueStatus.find(2)
  2791. assert_equal true, issue.reopening?
  2792. end
  2793. def test_reopening_should_return_true_when_reopening_an_issue_with_status_id
  2794. issue = Issue.find(8)
  2795. issue.status_id = 6
  2796. assert_equal false, issue.reopening?
  2797. issue.status_id = 2
  2798. assert_equal true, issue.reopening?
  2799. end
  2800. def test_reopening_should_return_false_for_new_open_issue
  2801. issue = Issue.new
  2802. issue.status = IssueStatus.find(1)
  2803. assert_equal false, issue.reopening?
  2804. end
  2805. def test_reopening_should_be_reset_after_save
  2806. issue = Issue.find(8)
  2807. issue.status_id = 2
  2808. assert_equal true, issue.reopening?
  2809. issue.save!
  2810. assert_equal false, issue.reopening?
  2811. end
  2812. def test_default_status_without_tracker_should_be_nil
  2813. issue = Issue.new
  2814. assert_nil issue.tracker
  2815. assert_nil issue.default_status
  2816. end
  2817. def test_default_status_should_be_tracker_default_status
  2818. issue = Issue.new(:tracker_id => 1)
  2819. assert_not_nil issue.status
  2820. assert_equal issue.tracker.default_status, issue.default_status
  2821. end
  2822. def test_initializing_with_tracker_should_set_default_status
  2823. issue = Issue.new(:tracker => Tracker.find(1))
  2824. assert_not_nil issue.status
  2825. assert_equal issue.default_status, issue.status
  2826. end
  2827. def test_initializing_with_tracker_id_should_set_default_status
  2828. issue = Issue.new(:tracker_id => 1)
  2829. assert_not_nil issue.status
  2830. assert_equal issue.default_status, issue.status
  2831. end
  2832. def test_setting_tracker_should_set_default_status
  2833. issue = Issue.new
  2834. issue.tracker = Tracker.find(1)
  2835. assert_not_nil issue.status
  2836. assert_equal issue.default_status, issue.status
  2837. end
  2838. def test_changing_tracker_should_set_default_status_if_status_was_default
  2839. WorkflowTransition.delete_all
  2840. WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1
  2841. Tracker.find(2).update! :default_status_id => 2
  2842. issue = Issue.new(:tracker_id => 1, :status_id => 1)
  2843. assert_equal IssueStatus.find(1), issue.status
  2844. issue.tracker = Tracker.find(2)
  2845. assert_equal IssueStatus.find(2), issue.status
  2846. end
  2847. def test_changing_tracker_should_set_default_status_if_status_is_not_used_by_tracker
  2848. WorkflowTransition.delete_all
  2849. Tracker.find(2).update! :default_status_id => 2
  2850. issue = Issue.new(:tracker_id => 1, :status_id => 3)
  2851. assert_equal IssueStatus.find(3), issue.status
  2852. issue.tracker = Tracker.find(2)
  2853. assert_equal IssueStatus.find(2), issue.status
  2854. end
  2855. def test_changing_tracker_should_keep_status_if_status_was_not_default_and_is_used_by_tracker
  2856. WorkflowTransition.delete_all
  2857. WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3
  2858. Tracker.find(2).update! :default_status_id => 2
  2859. issue = Issue.new(:tracker_id => 1, :status_id => 3)
  2860. assert_equal IssueStatus.find(3), issue.status
  2861. issue.tracker = Tracker.find(2)
  2862. assert_equal IssueStatus.find(3), issue.status
  2863. end
  2864. def test_previous_assignee_with_a_group
  2865. group = Group.find(10)
  2866. Member.create!(:project_id => 1, :principal => group, :role_ids => [1])
  2867. with_settings :issue_group_assignment => '1' do
  2868. issue = Issue.generate!(:assigned_to => group)
  2869. issue.reload.assigned_to = nil
  2870. assert_equal group, issue.previous_assignee
  2871. end
  2872. end
  2873. def test_issue_overdue_should_respect_user_timezone
  2874. user_in_europe = users(:users_001)
  2875. user_in_europe.pref.update! :time_zone => 'UTC'
  2876. user_in_asia = users(:users_002)
  2877. user_in_asia.pref.update! :time_zone => 'Hongkong'
  2878. issue = Issue.generate! :due_date => Date.parse('2016-03-20')
  2879. # server time is UTC
  2880. time = Time.parse '2016-03-20 20:00 UTC'
  2881. Time.stubs(:now).returns(time)
  2882. Date.stubs(:today).returns(time.to_date)
  2883. # for a user in the same time zone as the server the issue is not overdue
  2884. # yet
  2885. User.current = user_in_europe
  2886. assert !issue.overdue?
  2887. # at the same time, a user in East Asia looks at the issue - it's already
  2888. # March 21st and the issue should be marked overdue
  2889. User.current = user_in_asia
  2890. assert issue.overdue?
  2891. end
  2892. def test_closable
  2893. issue10 = Issue.find(10)
  2894. assert issue10.closable?
  2895. assert_nil issue10.transition_warning
  2896. # Issue blocked by another issue
  2897. issue9 = Issue.find(9)
  2898. assert !issue9.closable?
  2899. assert_equal l(:notice_issue_not_closable_by_blocking_issue), issue9.transition_warning
  2900. end
  2901. def test_reopenable
  2902. parent = Issue.generate!(:status_id => 5)
  2903. child = parent.generate_child!(:status_id => 5)
  2904. assert !child.reopenable?
  2905. assert_equal l(:notice_issue_not_reopenable_by_closed_parent_issue), child.transition_warning
  2906. end
  2907. def test_filter_projects_scope
  2908. Issue.send(:public, :filter_projects_scope)
  2909. # Project eCookbook
  2910. issue = Issue.find(1)
  2911. assert_equal Project, issue.filter_projects_scope
  2912. assert_equal Project, issue.filter_projects_scope('system')
  2913. # Project Onlinestore (id 2) is not part of the tree
  2914. assert_equal [1, 3, 4, 5, 6], Issue.find(5).filter_projects_scope('tree').ids.sort
  2915. # Project "Private child of eCookbook"
  2916. issue2 = Issue.find(9)
  2917. # Projects "eCookbook Subproject 1" (id 3) and "eCookbook Subproject 1" (id 4) are not part of hierarchy
  2918. assert_equal [1, 5, 6], issue2.filter_projects_scope('hierarchy').ids.sort
  2919. # Project "Child of private child" is descendant of "Private child of eCookbook"
  2920. assert_equal [5, 6], issue2.filter_projects_scope('descendants').ids.sort
  2921. assert_equal [5], issue2.filter_projects_scope('').ids.sort
  2922. end
  2923. def test_create_should_add_watcher
  2924. user = User.first
  2925. user.pref.auto_watch_on=['issue_created']
  2926. user.pref.save
  2927. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => user.id, :subject => 'test_create_should_add_watcher')
  2928. assert_difference 'Watcher.count', 1 do
  2929. assert_equal true, issue.save
  2930. end
  2931. end
  2932. def test_create_should_add_author_watcher_only_once
  2933. user = User.first
  2934. user.pref.auto_watch_on=['issue_created']
  2935. user.pref.save
  2936. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => user.id, :subject => 'test_create_should_add_watcher')
  2937. issue.watcher_user_ids = [user.id]
  2938. assert_difference 'Watcher.count', 1 do
  2939. assert_equal true, issue.save
  2940. end
  2941. end
  2942. def test_create_should_not_add_watcher
  2943. user = User.first
  2944. user.pref.auto_watch_on=[]
  2945. user.pref.save
  2946. issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => user.id, :subject => 'test_create_should_not_add_watcher')
  2947. assert_no_difference 'Watcher.count' do
  2948. assert_equal true, issue.save
  2949. end
  2950. end
  2951. def test_change_of_project_parent_should_update_shared_versions_with_derived_priorities
  2952. with_settings('parent_issue_priority' => 'derived') do
  2953. parent = Project.find 1
  2954. child = Project.find 3
  2955. assert_equal parent, child.parent
  2956. assert version = parent.versions.create(name: 'test', sharing: 'descendants')
  2957. assert version.persisted?
  2958. assert child.shared_versions.include?(version)
  2959. # create a situation where the child issue id is lower than the parent issue id.
  2960. # When the parent project is removed, the version inherited from there will be removed from
  2961. # both issues. At least on MySQL the record with the lower Id will be processed first.
  2962. #
  2963. # If this update on the child triggers an update on the parent record (here, due to the derived
  2964. # priority), the already loaded parent issue is considered stale when it's version is updated.
  2965. assert child_issue = child.issues.first
  2966. parent_issue = Issue.create! project: child, subject: 'test', tracker: child_issue.tracker, author: child_issue.author, status: child_issue.status, fixed_version: version
  2967. assert child_issue.update fixed_version: version, priority_id: 6, parent: parent_issue
  2968. parent_issue.update_column :priority_id, 4 # force a priority update when the version is nullified
  2969. assert child.update parent: nil
  2970. child.reload
  2971. assert !child.shared_versions.include?(version)
  2972. child_issue.reload
  2973. assert_nil child_issue.fixed_version
  2974. assert_equal 6, child_issue.priority_id
  2975. parent_issue.reload
  2976. assert_nil parent_issue.fixed_version
  2977. assert_equal 6, parent_issue.priority_id
  2978. end
  2979. end
  2980. def test_create_should_not_add_anonymous_as_watcher
  2981. Role.anonymous.add_permission!(:add_issue_watchers)
  2982. user = User.anonymous
  2983. assert user.pref.auto_watch_on?('issue_contributed_to')
  2984. journal = Journal.new(:journalized => Issue.first, :notes => 'notes', :user => user)
  2985. assert_no_difference 'Watcher.count' do
  2986. assert journal.save
  2987. assert journal.valid?
  2988. assert journal.journalized.valid?
  2989. end
  2990. end
  2991. def test_like_should_escape_query
  2992. issue = Issue.generate!(:subject => "asdf")
  2993. r = Issue.like('as_f')
  2994. assert_not_include issue, r
  2995. r = Issue.like('as%f')
  2996. assert_not_include issue, r
  2997. issue = Issue.generate!(:subject => "as%f")
  2998. r = Issue.like('as%f')
  2999. assert_include issue, r
  3000. issue = Issue.generate!(:subject => "as_f")
  3001. r = Issue.like('as_f')
  3002. assert_include issue, r
  3003. end
  3004. def test_like_should_tokenize
  3005. r = Issue.like('issue today')
  3006. assert_include Issue.find(7), r
  3007. end
  3008. end