You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

roles_controller_test.rb 8.7KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283
  1. # frozen_string_literal: true
  2. # Redmine - project management software
  3. # Copyright (C) 2006-2019 Jean-Philippe Lang
  4. #
  5. # This program is free software; you can redistribute it and/or
  6. # modify it under the terms of the GNU General Public License
  7. # as published by the Free Software Foundation; either version 2
  8. # of the License, or (at your option) any later version.
  9. #
  10. # This program is distributed in the hope that it will be useful,
  11. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  12. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13. # GNU General Public License for more details.
  14. #
  15. # You should have received a copy of the GNU General Public License
  16. # along with this program; if not, write to the Free Software
  17. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  18. require File.expand_path('../../test_helper', __FILE__)
  19. class RolesControllerTest < Redmine::ControllerTest
  20. fixtures :roles, :users, :members, :member_roles, :workflows, :trackers
  21. def setup
  22. User.current = nil
  23. @request.session[:user_id] = 1 # admin
  24. end
  25. def test_index
  26. get :index
  27. assert_response :success
  28. assert_select 'table.roles tbody' do
  29. assert_select 'tr', Role.count
  30. assert_select 'a[href="/roles/1/edit"]', :text => 'Manager'
  31. end
  32. end
  33. def test_index_should_show_warning_when_no_workflow_is_defined
  34. Role.find_by_name('Developer').workflow_rules.destroy_all
  35. Role.find_by_name('Anonymous').workflow_rules.destroy_all
  36. get :index
  37. assert_response :success
  38. assert_select 'table.roles' do
  39. # Manager
  40. assert_select 'tr.givable:nth-of-type(1) span.icon-warning', :count => 0
  41. # Developer
  42. assert_select 'tr.givable:nth-of-type(2) span.icon-warning', :text => /#{I18n.t(:text_role_no_workflow)}/
  43. # Reporter
  44. assert_select 'tr.givable:nth-of-type(3) span.icon-warning', :count => 0
  45. # No warnings for built-in roles such as Anonymous and Non-member
  46. assert_select 'tr.builtin span.icon-warning', :count => 0
  47. end
  48. end
  49. def test_new
  50. get :new
  51. assert_response :success
  52. assert_select 'input[name=?]', 'role[name]'
  53. assert_select 'input[name=?]', 'role[permissions][]'
  54. end
  55. def test_new_should_prefill_permissions_with_non_member_permissions
  56. role = Role.non_member
  57. role.permissions = [:view_issues, :view_documents]
  58. role.save!
  59. get :new
  60. assert_response :success
  61. assert_equal %w(view_documents view_issues),
  62. css_select('input[name="role[permissions][]"][checked=checked]').map {|e| e.attr('value')}.sort
  63. end
  64. def test_new_with_copy
  65. copy_from = Role.find(2)
  66. get :new, :params => {:copy => copy_from.id.to_s}
  67. assert_response :success
  68. assert_select 'input[name=?]', 'role[name]'
  69. assert_select 'form' do
  70. # blank name
  71. assert_select 'input[name=?][value=""]', 'role[name]'
  72. # edit_project permission checked
  73. assert_select 'input[type=checkbox][name=?][value=edit_project][checked=checked]', 'role[permissions][]'
  74. # add_project permission not checked
  75. assert_select 'input[type=checkbox][name=?][value=add_project]', 'role[permissions][]'
  76. assert_select 'input[type=checkbox][name=?][value=add_project][checked=checked]', 'role[permissions][]', 0
  77. # workflow copy selected
  78. assert_select 'select[name=?]', 'copy_workflow_from' do
  79. assert_select 'option[value="2"][selected=selected]'
  80. end
  81. end
  82. end
  83. def test_create_with_validaton_failure
  84. post :create, :params => {
  85. :role => {
  86. :name => '',
  87. :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
  88. :assignable => '0'
  89. }
  90. }
  91. assert_response :success
  92. assert_select_error /Name cannot be blank/
  93. end
  94. def test_create_without_workflow_copy
  95. post :create, :params => {
  96. :role => {
  97. :name => 'RoleWithoutWorkflowCopy',
  98. :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
  99. :assignable => '0'
  100. }
  101. }
  102. assert_redirected_to '/roles'
  103. role = Role.find_by_name('RoleWithoutWorkflowCopy')
  104. assert_not_nil role
  105. assert_equal [:add_issues, :edit_issues, :log_time], role.permissions
  106. assert !role.assignable?
  107. end
  108. def test_create_with_workflow_copy
  109. post :create, :params => {
  110. :role => {
  111. :name => 'RoleWithWorkflowCopy',
  112. :permissions => ['add_issues', 'edit_issues', 'log_time', ''],
  113. :assignable => '0'
  114. },
  115. :copy_workflow_from => '1'
  116. }
  117. assert_redirected_to '/roles'
  118. role = Role.find_by_name('RoleWithWorkflowCopy')
  119. assert_not_nil role
  120. assert_equal Role.find(1).workflow_rules.size, role.workflow_rules.size
  121. end
  122. def test_create_with_managed_roles
  123. role = new_record(Role) do
  124. post :create, :params => {
  125. :role => {
  126. :name => 'Role',
  127. :all_roles_managed => '0',
  128. :managed_role_ids => ['2', '3', '']
  129. }
  130. }
  131. assert_response 302
  132. end
  133. assert_equal false, role.all_roles_managed
  134. assert_equal [2, 3], role.managed_role_ids.sort
  135. end
  136. def test_edit
  137. get :edit, :params => {:id => 1}
  138. assert_response :success
  139. assert_select 'input[name=?][value=?]', 'role[name]', 'Manager'
  140. assert_select 'select[name=?]', 'role[issues_visibility]'
  141. end
  142. def test_edit_anonymous
  143. get :edit, :params => {:id => Role.anonymous.id}
  144. assert_response :success
  145. assert_select 'input[name=?]', 'role[name]', 0
  146. assert_select 'select[name=?]', 'role[issues_visibility]', 0
  147. end
  148. def test_edit_invalid_should_respond_with_404
  149. get :edit, :params => {:id => 999}
  150. assert_response 404
  151. end
  152. def test_update
  153. put :update, :params => {
  154. :id => 1,
  155. :role => {
  156. :name => 'Manager',
  157. :permissions => ['edit_project', ''],
  158. :assignable => '0'
  159. }
  160. }
  161. assert_redirected_to '/roles'
  162. role = Role.find(1)
  163. assert_equal [:edit_project], role.permissions
  164. end
  165. def test_update_trackers_permissions
  166. put :update, :params => {
  167. :id => 1,
  168. :role => {
  169. :permissions_all_trackers => {'add_issues' => '0'},
  170. :permissions_tracker_ids => {'add_issues' => ['1', '3', '']}
  171. }
  172. }
  173. assert_redirected_to '/roles'
  174. role = Role.find(1)
  175. assert_equal({'add_issues' => '0'}, role.permissions_all_trackers)
  176. assert_equal({'add_issues' => ['1', '3']}, role.permissions_tracker_ids)
  177. assert_equal false, role.permissions_all_trackers?(:add_issues)
  178. assert_equal [1, 3], role.permissions_tracker_ids(:add_issues).sort
  179. end
  180. def test_update_with_failure
  181. put :update, :params => {:id => 1, :role => {:name => ''}}
  182. assert_response :success
  183. assert_select_error /Name cannot be blank/
  184. end
  185. def test_destroy
  186. r = Role.create!(:name => 'ToBeDestroyed', :permissions => [:view_wiki_pages])
  187. delete :destroy, :params => {:id => r}
  188. assert_redirected_to '/roles'
  189. assert_nil Role.find_by_id(r.id)
  190. end
  191. def test_destroy_role_in_use
  192. delete :destroy, :params => {:id => 1}
  193. assert_redirected_to '/roles'
  194. assert_equal 'This role is in use and cannot be deleted.', flash[:error]
  195. assert_not_nil Role.find_by_id(1)
  196. end
  197. def test_get_permissions
  198. get :permissions
  199. assert_response :success
  200. assert_select 'input[name=?][type=checkbox][value=add_issues][checked=checked]', 'permissions[3][]'
  201. assert_select 'input[name=?][type=checkbox][value=delete_issues]:not([checked])', 'permissions[3][]'
  202. end
  203. def test_post_permissions
  204. post :permissions, :params => {
  205. :permissions => {
  206. '0' => '',
  207. '1' => ['edit_issues'],
  208. '3' => ['add_issues', 'delete_issues']
  209. }
  210. }
  211. assert_redirected_to '/roles'
  212. assert_equal [:edit_issues], Role.find(1).permissions
  213. assert_equal [:add_issues, :delete_issues], Role.find(3).permissions
  214. assert Role.find(2).permissions.empty?
  215. end
  216. def test_clear_all_permissions
  217. post :permissions, :params => {:permissions => { '0' => '' }}
  218. assert_redirected_to '/roles'
  219. assert Role.find(1).permissions.empty?
  220. end
  221. def test_move_highest
  222. put :update, :params => {:id => 3, :role => {:position => 1}}
  223. assert_redirected_to '/roles'
  224. assert_equal 1, Role.find(3).position
  225. end
  226. def test_move_higher
  227. position = Role.find(3).position
  228. put :update, :params => {:id => 3, :role => {:position => position - 1}}
  229. assert_redirected_to '/roles'
  230. assert_equal position - 1, Role.find(3).position
  231. end
  232. def test_move_lower
  233. position = Role.find(2).position
  234. put :update, :params => {:id => 2, :role => {:position => position + 1}}
  235. assert_redirected_to '/roles'
  236. assert_equal position + 1, Role.find(2).position
  237. end
  238. def test_move_lowest
  239. put :update, :params => {:id => 2, :role => {:position => Role.givable.count}}
  240. assert_redirected_to '/roles'
  241. assert_equal Role.givable.count, Role.find(2).position
  242. end
  243. end