You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

users_controller_test.rb 12KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391
  1. # Redmine - project management software
  2. # Copyright (C) 2006-2011 Jean-Philippe Lang
  3. #
  4. # This program is free software; you can redistribute it and/or
  5. # modify it under the terms of the GNU General Public License
  6. # as published by the Free Software Foundation; either version 2
  7. # of the License, or (at your option) any later version.
  8. #
  9. # This program is distributed in the hope that it will be useful,
  10. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  11. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  12. # GNU General Public License for more details.
  13. #
  14. # You should have received a copy of the GNU General Public License
  15. # along with this program; if not, write to the Free Software
  16. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  17. require File.expand_path('../../test_helper', __FILE__)
  18. require 'users_controller'
  19. # Re-raise errors caught by the controller.
  20. class UsersController; def rescue_action(e) raise e end; end
  21. class UsersControllerTest < ActionController::TestCase
  22. include Redmine::I18n
  23. fixtures :users, :projects, :members, :member_roles, :roles, :custom_fields, :custom_values, :groups_users, :auth_sources
  24. def setup
  25. @controller = UsersController.new
  26. @request = ActionController::TestRequest.new
  27. @response = ActionController::TestResponse.new
  28. User.current = nil
  29. @request.session[:user_id] = 1 # admin
  30. end
  31. def test_index
  32. get :index
  33. assert_response :success
  34. assert_template 'index'
  35. end
  36. def test_index
  37. get :index
  38. assert_response :success
  39. assert_template 'index'
  40. assert_not_nil assigns(:users)
  41. # active users only
  42. assert_nil assigns(:users).detect {|u| !u.active?}
  43. end
  44. def test_index_with_status_filter
  45. get :index, :status => 3
  46. assert_response :success
  47. assert_template 'index'
  48. assert_not_nil assigns(:users)
  49. assert_equal [3], assigns(:users).map(&:status).uniq
  50. end
  51. def test_index_with_name_filter
  52. get :index, :name => 'john'
  53. assert_response :success
  54. assert_template 'index'
  55. users = assigns(:users)
  56. assert_not_nil users
  57. assert_equal 1, users.size
  58. assert_equal 'John', users.first.firstname
  59. end
  60. def test_index_with_group_filter
  61. get :index, :group_id => '10'
  62. assert_response :success
  63. assert_template 'index'
  64. users = assigns(:users)
  65. assert users.any?
  66. assert_equal([], (users - Group.find(10).users))
  67. end
  68. def test_show
  69. @request.session[:user_id] = nil
  70. get :show, :id => 2
  71. assert_response :success
  72. assert_template 'show'
  73. assert_not_nil assigns(:user)
  74. assert_tag 'li', :content => /Phone number/
  75. end
  76. def test_show_should_not_display_hidden_custom_fields
  77. @request.session[:user_id] = nil
  78. UserCustomField.find_by_name('Phone number').update_attribute :visible, false
  79. get :show, :id => 2
  80. assert_response :success
  81. assert_template 'show'
  82. assert_not_nil assigns(:user)
  83. assert_no_tag 'li', :content => /Phone number/
  84. end
  85. def test_show_should_not_fail_when_custom_values_are_nil
  86. user = User.find(2)
  87. # Create a custom field to illustrate the issue
  88. custom_field = CustomField.create!(:name => 'Testing', :field_format => 'text')
  89. custom_value = user.custom_values.build(:custom_field => custom_field).save!
  90. get :show, :id => 2
  91. assert_response :success
  92. end
  93. def test_show_inactive
  94. @request.session[:user_id] = nil
  95. get :show, :id => 5
  96. assert_response 404
  97. end
  98. def test_show_should_not_reveal_users_with_no_visible_activity_or_project
  99. @request.session[:user_id] = nil
  100. get :show, :id => 9
  101. assert_response 404
  102. end
  103. def test_show_inactive_by_admin
  104. @request.session[:user_id] = 1
  105. get :show, :id => 5
  106. assert_response 200
  107. assert_not_nil assigns(:user)
  108. end
  109. def test_show_displays_memberships_based_on_project_visibility
  110. @request.session[:user_id] = 1
  111. get :show, :id => 2
  112. assert_response :success
  113. memberships = assigns(:memberships)
  114. assert_not_nil memberships
  115. project_ids = memberships.map(&:project_id)
  116. assert project_ids.include?(2) #private project admin can see
  117. end
  118. def test_show_current_should_require_authentication
  119. @request.session[:user_id] = nil
  120. get :show, :id => 'current'
  121. assert_response 302
  122. end
  123. def test_show_current
  124. @request.session[:user_id] = 2
  125. get :show, :id => 'current'
  126. assert_response :success
  127. assert_template 'show'
  128. assert_equal User.find(2), assigns(:user)
  129. end
  130. def test_new
  131. get :new
  132. assert_response :success
  133. assert_template :new
  134. assert assigns(:user)
  135. end
  136. def test_create
  137. Setting.bcc_recipients = '1'
  138. assert_difference 'User.count' do
  139. assert_difference 'ActionMailer::Base.deliveries.size' do
  140. post :create,
  141. :user => {
  142. :firstname => 'John',
  143. :lastname => 'Doe',
  144. :login => 'jdoe',
  145. :password => 'secret',
  146. :password_confirmation => 'secret',
  147. :mail => 'jdoe@gmail.com',
  148. :mail_notification => 'none'
  149. },
  150. :send_information => '1'
  151. end
  152. end
  153. user = User.first(:order => 'id DESC')
  154. assert_redirected_to :controller => 'users', :action => 'edit', :id => user.id
  155. assert_equal 'John', user.firstname
  156. assert_equal 'Doe', user.lastname
  157. assert_equal 'jdoe', user.login
  158. assert_equal 'jdoe@gmail.com', user.mail
  159. assert_equal 'none', user.mail_notification
  160. assert user.check_password?('secret')
  161. mail = ActionMailer::Base.deliveries.last
  162. assert_not_nil mail
  163. assert_equal [user.mail], mail.bcc
  164. assert_mail_body_match 'secret', mail
  165. end
  166. def test_create_with_preferences
  167. assert_difference 'User.count' do
  168. post :create,
  169. :user => {
  170. :firstname => 'John',
  171. :lastname => 'Doe',
  172. :login => 'jdoe',
  173. :password => 'secret',
  174. :password_confirmation => 'secret',
  175. :mail => 'jdoe@gmail.com',
  176. :mail_notification => 'none'
  177. },
  178. :pref => {
  179. 'hide_mail' => '1',
  180. 'time_zone' => 'Paris',
  181. 'comments_sorting' => 'desc',
  182. 'warn_on_leaving_unsaved' => '0'
  183. }
  184. end
  185. user = User.first(:order => 'id DESC')
  186. assert_equal 'jdoe', user.login
  187. assert_equal true, user.pref.hide_mail
  188. assert_equal 'Paris', user.pref.time_zone
  189. assert_equal 'desc', user.pref[:comments_sorting]
  190. assert_equal '0', user.pref[:warn_on_leaving_unsaved]
  191. end
  192. def test_create_with_failure
  193. assert_no_difference 'User.count' do
  194. post :create, :user => {}
  195. end
  196. assert_response :success
  197. assert_template 'new'
  198. end
  199. def test_edit
  200. get :edit, :id => 2
  201. assert_response :success
  202. assert_template 'edit'
  203. assert_equal User.find(2), assigns(:user)
  204. end
  205. def test_update
  206. ActionMailer::Base.deliveries.clear
  207. put :update, :id => 2, :user => {:firstname => 'Changed', :mail_notification => 'only_assigned'}, :pref => {:hide_mail => '1', :comments_sorting => 'desc'}
  208. user = User.find(2)
  209. assert_equal 'Changed', user.firstname
  210. assert_equal 'only_assigned', user.mail_notification
  211. assert_equal true, user.pref[:hide_mail]
  212. assert_equal 'desc', user.pref[:comments_sorting]
  213. assert ActionMailer::Base.deliveries.empty?
  214. end
  215. def test_update_with_failure
  216. assert_no_difference 'User.count' do
  217. put :update, :id => 2, :user => {:firstname => ''}
  218. end
  219. assert_response :success
  220. assert_template 'edit'
  221. end
  222. def test_update_with_group_ids_should_assign_groups
  223. put :update, :id => 2, :user => {:group_ids => ['10']}
  224. user = User.find(2)
  225. assert_equal [10], user.group_ids
  226. end
  227. def test_update_with_activation_should_send_a_notification
  228. u = User.new(:firstname => 'Foo', :lastname => 'Bar', :mail => 'foo.bar@somenet.foo', :language => 'fr')
  229. u.login = 'foo'
  230. u.status = User::STATUS_REGISTERED
  231. u.save!
  232. ActionMailer::Base.deliveries.clear
  233. Setting.bcc_recipients = '1'
  234. put :update, :id => u.id, :user => {:status => User::STATUS_ACTIVE}
  235. assert u.reload.active?
  236. mail = ActionMailer::Base.deliveries.last
  237. assert_not_nil mail
  238. assert_equal ['foo.bar@somenet.foo'], mail.bcc
  239. assert_mail_body_match ll('fr', :notice_account_activated), mail
  240. end
  241. def test_update_with_password_change_should_send_a_notification
  242. ActionMailer::Base.deliveries.clear
  243. Setting.bcc_recipients = '1'
  244. put :update, :id => 2, :user => {:password => 'newpass', :password_confirmation => 'newpass'}, :send_information => '1'
  245. u = User.find(2)
  246. assert u.check_password?('newpass')
  247. mail = ActionMailer::Base.deliveries.last
  248. assert_not_nil mail
  249. assert_equal [u.mail], mail.bcc
  250. assert_mail_body_match 'newpass', mail
  251. end
  252. def test_update_user_switchin_from_auth_source_to_password_authentication
  253. # Configure as auth source
  254. u = User.find(2)
  255. u.auth_source = AuthSource.find(1)
  256. u.save!
  257. put :update, :id => u.id, :user => {:auth_source_id => '', :password => 'newpass', :password_confirmation => 'newpass'}
  258. assert_equal nil, u.reload.auth_source
  259. assert u.check_password?('newpass')
  260. end
  261. def test_destroy
  262. assert_difference 'User.count', -1 do
  263. delete :destroy, :id => 2
  264. end
  265. assert_redirected_to '/users'
  266. assert_nil User.find_by_id(2)
  267. end
  268. def test_destroy_should_be_denied_for_non_admin_users
  269. @request.session[:user_id] = 3
  270. assert_no_difference 'User.count' do
  271. get :destroy, :id => 2
  272. end
  273. assert_response 403
  274. end
  275. def test_create_membership
  276. assert_difference 'Member.count' do
  277. post :edit_membership, :id => 7, :membership => { :project_id => 3, :role_ids => [2]}
  278. end
  279. assert_redirected_to :action => 'edit', :id => '7', :tab => 'memberships'
  280. member = Member.first(:order => 'id DESC')
  281. assert_equal User.find(7), member.principal
  282. assert_equal [2], member.role_ids
  283. assert_equal 3, member.project_id
  284. end
  285. def test_create_membership_js_format
  286. assert_difference 'Member.count' do
  287. post :edit_membership, :id => 7, :membership => {:project_id => 3, :role_ids => [2]}, :format => 'js'
  288. end
  289. assert_response :success
  290. assert_select_rjs :replace_html, 'tab-content-memberships'
  291. member = Member.first(:order => 'id DESC')
  292. assert_equal User.find(7), member.principal
  293. assert_equal [2], member.role_ids
  294. assert_equal 3, member.project_id
  295. end
  296. def test_create_membership_js_format_with_failure
  297. assert_no_difference 'Member.count' do
  298. post :edit_membership, :id => 7, :membership => {:project_id => 3}, :format => 'js'
  299. end
  300. assert_response :success
  301. assert @response.body.match(/alert/i), "Alert message not sent"
  302. assert @response.body.match(/role can't be empty/i), "Error message not sent"
  303. end
  304. def test_update_membership
  305. assert_no_difference 'Member.count' do
  306. put :edit_membership, :id => 2, :membership_id => 1, :membership => { :role_ids => [2]}
  307. end
  308. assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
  309. assert_equal [2], Member.find(1).role_ids
  310. end
  311. def test_update_membership_js_format
  312. assert_no_difference 'Member.count' do
  313. put :edit_membership, :id => 2, :membership_id => 1, :membership => {:role_ids => [2]}, :format => 'js'
  314. end
  315. assert_response :success
  316. assert_select_rjs :replace_html, 'tab-content-memberships'
  317. end
  318. def test_destroy_membership
  319. assert_difference 'Member.count', -1 do
  320. delete :destroy_membership, :id => 2, :membership_id => 1
  321. end
  322. assert_redirected_to :action => 'edit', :id => '2', :tab => 'memberships'
  323. assert_nil Member.find_by_id(1)
  324. end
  325. def test_destroy_membership_js_format
  326. assert_difference 'Member.count', -1 do
  327. delete :destroy_membership, :id => 2, :membership_id => 1, :format => 'js'
  328. end
  329. assert_response :success
  330. assert_select_rjs :replace_html, 'tab-content-memberships'
  331. end
  332. end