You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_nested_set_test.rb 16KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399
  1. # Redmine - project management software
  2. # Copyright (C) 2006-2011 Jean-Philippe Lang
  3. #
  4. # This program is free software; you can redistribute it and/or
  5. # modify it under the terms of the GNU General Public License
  6. # as published by the Free Software Foundation; either version 2
  7. # of the License, or (at your option) any later version.
  8. #
  9. # This program is distributed in the hope that it will be useful,
  10. # but WITHOUT ANY WARRANTY; without even the implied warranty of
  11. # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  12. # GNU General Public License for more details.
  13. #
  14. # You should have received a copy of the GNU General Public License
  15. # along with this program; if not, write to the Free Software
  16. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  17. require File.expand_path('../../test_helper', __FILE__)
  18. class IssueNestedSetTest < ActiveSupport::TestCase
  19. fixtures :projects, :users, :members, :member_roles, :roles,
  20. :trackers, :projects_trackers,
  21. :versions,
  22. :issue_statuses, :issue_categories, :issue_relations, :workflows,
  23. :enumerations,
  24. :issues,
  25. :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
  26. :time_entries
  27. self.use_transactional_fixtures = false
  28. def test_create_root_issue
  29. issue1 = create_issue!
  30. issue2 = create_issue!
  31. issue1.reload
  32. issue2.reload
  33. assert_equal [issue1.id, nil, 1, 2], [issue1.root_id, issue1.parent_id, issue1.lft, issue1.rgt]
  34. assert_equal [issue2.id, nil, 1, 2], [issue2.root_id, issue2.parent_id, issue2.lft, issue2.rgt]
  35. end
  36. def test_create_child_issue
  37. parent = create_issue!
  38. child = create_issue!(:parent_issue_id => parent.id)
  39. parent.reload
  40. child.reload
  41. assert_equal [parent.id, nil, 1, 4], [parent.root_id, parent.parent_id, parent.lft, parent.rgt]
  42. assert_equal [parent.id, parent.id, 2, 3], [child.root_id, child.parent_id, child.lft, child.rgt]
  43. end
  44. def test_creating_a_child_in_different_project_should_not_validate
  45. issue = create_issue!
  46. child = Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
  47. :subject => 'child', :parent_issue_id => issue.id)
  48. assert !child.save
  49. assert_not_nil child.errors[:parent_issue_id]
  50. end
  51. def test_move_a_root_to_child
  52. parent1 = create_issue!
  53. parent2 = create_issue!
  54. child = create_issue!(:parent_issue_id => parent1.id)
  55. parent2.parent_issue_id = parent1.id
  56. parent2.save!
  57. child.reload
  58. parent1.reload
  59. parent2.reload
  60. assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
  61. assert_equal [parent1.id, 4, 5], [parent2.root_id, parent2.lft, parent2.rgt]
  62. assert_equal [parent1.id, 2, 3], [child.root_id, child.lft, child.rgt]
  63. end
  64. def test_move_a_child_to_root
  65. parent1 = create_issue!
  66. parent2 = create_issue!
  67. child = create_issue!(:parent_issue_id => parent1.id)
  68. child.parent_issue_id = nil
  69. child.save!
  70. child.reload
  71. parent1.reload
  72. parent2.reload
  73. assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
  74. assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
  75. assert_equal [child.id, 1, 2], [child.root_id, child.lft, child.rgt]
  76. end
  77. def test_move_a_child_to_another_issue
  78. parent1 = create_issue!
  79. parent2 = create_issue!
  80. child = create_issue!(:parent_issue_id => parent1.id)
  81. child.parent_issue_id = parent2.id
  82. child.save!
  83. child.reload
  84. parent1.reload
  85. parent2.reload
  86. assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
  87. assert_equal [parent2.id, 1, 4], [parent2.root_id, parent2.lft, parent2.rgt]
  88. assert_equal [parent2.id, 2, 3], [child.root_id, child.lft, child.rgt]
  89. end
  90. def test_move_a_child_with_descendants_to_another_issue
  91. parent1 = create_issue!
  92. parent2 = create_issue!
  93. child = create_issue!(:parent_issue_id => parent1.id)
  94. grandchild = create_issue!(:parent_issue_id => child.id)
  95. parent1.reload
  96. parent2.reload
  97. child.reload
  98. grandchild.reload
  99. assert_equal [parent1.id, 1, 6], [parent1.root_id, parent1.lft, parent1.rgt]
  100. assert_equal [parent2.id, 1, 2], [parent2.root_id, parent2.lft, parent2.rgt]
  101. assert_equal [parent1.id, 2, 5], [child.root_id, child.lft, child.rgt]
  102. assert_equal [parent1.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
  103. child.reload.parent_issue_id = parent2.id
  104. child.save!
  105. child.reload
  106. grandchild.reload
  107. parent1.reload
  108. parent2.reload
  109. assert_equal [parent1.id, 1, 2], [parent1.root_id, parent1.lft, parent1.rgt]
  110. assert_equal [parent2.id, 1, 6], [parent2.root_id, parent2.lft, parent2.rgt]
  111. assert_equal [parent2.id, 2, 5], [child.root_id, child.lft, child.rgt]
  112. assert_equal [parent2.id, 3, 4], [grandchild.root_id, grandchild.lft, grandchild.rgt]
  113. end
  114. def test_move_a_child_with_descendants_to_another_project
  115. parent1 = create_issue!
  116. child = create_issue!(:parent_issue_id => parent1.id)
  117. grandchild = create_issue!(:parent_issue_id => child.id)
  118. child.reload
  119. child.project = Project.find(2)
  120. assert child.save
  121. child.reload
  122. grandchild.reload
  123. parent1.reload
  124. assert_equal [1, parent1.id, 1, 2], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
  125. assert_equal [2, child.id, 1, 4], [child.project_id, child.root_id, child.lft, child.rgt]
  126. assert_equal [2, child.id, 2, 3], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
  127. end
  128. def test_invalid_move_to_another_project
  129. parent1 = create_issue!
  130. child = create_issue!(:parent_issue_id => parent1.id)
  131. grandchild = create_issue!(:parent_issue_id => child.id, :tracker_id => 2)
  132. Project.find(2).tracker_ids = [1]
  133. parent1.reload
  134. assert_equal [1, parent1.id, 1, 6], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
  135. # child can not be moved to Project 2 because its child is on a disabled tracker
  136. child = Issue.find(child.id)
  137. child.project = Project.find(2)
  138. assert !child.save
  139. child.reload
  140. grandchild.reload
  141. parent1.reload
  142. # no change
  143. assert_equal [1, parent1.id, 1, 6], [parent1.project_id, parent1.root_id, parent1.lft, parent1.rgt]
  144. assert_equal [1, parent1.id, 2, 5], [child.project_id, child.root_id, child.lft, child.rgt]
  145. assert_equal [1, parent1.id, 3, 4], [grandchild.project_id, grandchild.root_id, grandchild.lft, grandchild.rgt]
  146. end
  147. def test_moving_an_issue_to_a_descendant_should_not_validate
  148. parent1 = create_issue!
  149. parent2 = create_issue!
  150. child = create_issue!(:parent_issue_id => parent1.id)
  151. grandchild = create_issue!(:parent_issue_id => child.id)
  152. child.reload
  153. child.parent_issue_id = grandchild.id
  154. assert !child.save
  155. assert_not_nil child.errors[:parent_issue_id]
  156. end
  157. def test_moving_an_issue_should_keep_valid_relations_only
  158. issue1 = create_issue!
  159. issue2 = create_issue!
  160. issue3 = create_issue!(:parent_issue_id => issue2.id)
  161. issue4 = create_issue!
  162. r1 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
  163. r2 = IssueRelation.create!(:issue_from => issue1, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
  164. r3 = IssueRelation.create!(:issue_from => issue2, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
  165. issue2.reload
  166. issue2.parent_issue_id = issue1.id
  167. issue2.save!
  168. assert !IssueRelation.exists?(r1.id)
  169. assert !IssueRelation.exists?(r2.id)
  170. assert IssueRelation.exists?(r3.id)
  171. end
  172. def test_destroy_should_destroy_children
  173. issue1 = create_issue!
  174. issue2 = create_issue!
  175. issue3 = create_issue!(:parent_issue_id => issue2.id)
  176. issue4 = create_issue!(:parent_issue_id => issue1.id)
  177. issue3.init_journal(User.find(2))
  178. issue3.subject = 'child with journal'
  179. issue3.save!
  180. assert_difference 'Issue.count', -2 do
  181. assert_difference 'Journal.count', -1 do
  182. assert_difference 'JournalDetail.count', -1 do
  183. Issue.find(issue2.id).destroy
  184. end
  185. end
  186. end
  187. issue1.reload
  188. issue4.reload
  189. assert !Issue.exists?(issue2.id)
  190. assert !Issue.exists?(issue3.id)
  191. assert_equal [issue1.id, 1, 4], [issue1.root_id, issue1.lft, issue1.rgt]
  192. assert_equal [issue1.id, 2, 3], [issue4.root_id, issue4.lft, issue4.rgt]
  193. end
  194. def test_destroy_child_should_update_parent
  195. issue = create_issue!
  196. child1 = create_issue!(:parent_issue_id => issue.id)
  197. child2 = create_issue!(:parent_issue_id => issue.id)
  198. issue.reload
  199. assert_equal [issue.id, 1, 6], [issue.root_id, issue.lft, issue.rgt]
  200. child2.reload.destroy
  201. issue.reload
  202. assert_equal [issue.id, 1, 4], [issue.root_id, issue.lft, issue.rgt]
  203. end
  204. def test_destroy_parent_issue_updated_during_children_destroy
  205. parent = create_issue!
  206. create_issue!(:start_date => Date.today, :parent_issue_id => parent.id)
  207. create_issue!(:start_date => 2.days.from_now, :parent_issue_id => parent.id)
  208. assert_difference 'Issue.count', -3 do
  209. Issue.find(parent.id).destroy
  210. end
  211. end
  212. def test_destroy_child_issue_with_children
  213. root = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'root')
  214. child = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => root.id)
  215. leaf = Issue.create!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'leaf', :parent_issue_id => child.id)
  216. leaf.init_journal(User.find(2))
  217. leaf.subject = 'leaf with journal'
  218. leaf.save!
  219. assert_difference 'Issue.count', -2 do
  220. assert_difference 'Journal.count', -1 do
  221. assert_difference 'JournalDetail.count', -1 do
  222. Issue.find(child.id).destroy
  223. end
  224. end
  225. end
  226. root = Issue.find(root.id)
  227. assert root.leaf?, "Root issue is not a leaf (lft: #{root.lft}, rgt: #{root.rgt})"
  228. end
  229. def test_destroy_issue_with_grand_child
  230. parent = create_issue!
  231. issue = create_issue!(:parent_issue_id => parent.id)
  232. child = create_issue!(:parent_issue_id => issue.id)
  233. grandchild1 = create_issue!(:parent_issue_id => child.id)
  234. grandchild2 = create_issue!(:parent_issue_id => child.id)
  235. assert_difference 'Issue.count', -4 do
  236. Issue.find(issue.id).destroy
  237. parent.reload
  238. assert_equal [1, 2], [parent.lft, parent.rgt]
  239. end
  240. end
  241. def test_parent_priority_should_be_the_highest_child_priority
  242. parent = create_issue!(:priority => IssuePriority.find_by_name('Normal'))
  243. # Create children
  244. child1 = create_issue!(:priority => IssuePriority.find_by_name('High'), :parent_issue_id => parent.id)
  245. assert_equal 'High', parent.reload.priority.name
  246. child2 = create_issue!(:priority => IssuePriority.find_by_name('Immediate'), :parent_issue_id => child1.id)
  247. assert_equal 'Immediate', child1.reload.priority.name
  248. assert_equal 'Immediate', parent.reload.priority.name
  249. child3 = create_issue!(:priority => IssuePriority.find_by_name('Low'), :parent_issue_id => parent.id)
  250. assert_equal 'Immediate', parent.reload.priority.name
  251. # Destroy a child
  252. child1.destroy
  253. assert_equal 'Low', parent.reload.priority.name
  254. # Update a child
  255. child3.reload.priority = IssuePriority.find_by_name('Normal')
  256. child3.save!
  257. assert_equal 'Normal', parent.reload.priority.name
  258. end
  259. def test_parent_dates_should_be_lowest_start_and_highest_due_dates
  260. parent = create_issue!
  261. create_issue!(:start_date => '2010-01-25', :due_date => '2010-02-15', :parent_issue_id => parent.id)
  262. create_issue!( :due_date => '2010-02-13', :parent_issue_id => parent.id)
  263. create_issue!(:start_date => '2010-02-01', :due_date => '2010-02-22', :parent_issue_id => parent.id)
  264. parent.reload
  265. assert_equal Date.parse('2010-01-25'), parent.start_date
  266. assert_equal Date.parse('2010-02-22'), parent.due_date
  267. end
  268. def test_parent_done_ratio_should_be_average_done_ratio_of_leaves
  269. parent = create_issue!
  270. create_issue!(:done_ratio => 20, :parent_issue_id => parent.id)
  271. assert_equal 20, parent.reload.done_ratio
  272. create_issue!(:done_ratio => 70, :parent_issue_id => parent.id)
  273. assert_equal 45, parent.reload.done_ratio
  274. child = create_issue!(:done_ratio => 0, :parent_issue_id => parent.id)
  275. assert_equal 30, parent.reload.done_ratio
  276. create_issue!(:done_ratio => 30, :parent_issue_id => child.id)
  277. assert_equal 30, child.reload.done_ratio
  278. assert_equal 40, parent.reload.done_ratio
  279. end
  280. def test_parent_done_ratio_should_be_weighted_by_estimated_times_if_any
  281. parent = create_issue!
  282. create_issue!(:estimated_hours => 10, :done_ratio => 20, :parent_issue_id => parent.id)
  283. assert_equal 20, parent.reload.done_ratio
  284. create_issue!(:estimated_hours => 20, :done_ratio => 50, :parent_issue_id => parent.id)
  285. assert_equal (50 * 20 + 20 * 10) / 30, parent.reload.done_ratio
  286. end
  287. def test_parent_estimate_should_be_sum_of_leaves
  288. parent = create_issue!
  289. create_issue!(:estimated_hours => nil, :parent_issue_id => parent.id)
  290. assert_equal nil, parent.reload.estimated_hours
  291. create_issue!(:estimated_hours => 5, :parent_issue_id => parent.id)
  292. assert_equal 5, parent.reload.estimated_hours
  293. create_issue!(:estimated_hours => 7, :parent_issue_id => parent.id)
  294. assert_equal 12, parent.reload.estimated_hours
  295. end
  296. def test_move_parent_updates_old_parent_attributes
  297. first_parent = create_issue!
  298. second_parent = create_issue!
  299. child = create_issue!(:estimated_hours => 5, :parent_issue_id => first_parent.id)
  300. assert_equal 5, first_parent.reload.estimated_hours
  301. child.update_attributes(:estimated_hours => 7, :parent_issue_id => second_parent.id)
  302. assert_equal 7, second_parent.reload.estimated_hours
  303. assert_nil first_parent.reload.estimated_hours
  304. end
  305. def test_reschuling_a_parent_should_reschedule_subtasks
  306. parent = create_issue!
  307. c1 = create_issue!(:start_date => '2010-05-12', :due_date => '2010-05-18', :parent_issue_id => parent.id)
  308. c2 = create_issue!(:start_date => '2010-06-03', :due_date => '2010-06-10', :parent_issue_id => parent.id)
  309. parent.reload
  310. parent.reschedule_after(Date.parse('2010-06-02'))
  311. c1.reload
  312. assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-08')], [c1.start_date, c1.due_date]
  313. c2.reload
  314. assert_equal [Date.parse('2010-06-03'), Date.parse('2010-06-10')], [c2.start_date, c2.due_date] # no change
  315. parent.reload
  316. assert_equal [Date.parse('2010-06-02'), Date.parse('2010-06-10')], [parent.start_date, parent.due_date]
  317. end
  318. def test_project_copy_should_copy_issue_tree
  319. p = Project.create!(:name => 'Tree copy', :identifier => 'tree-copy', :tracker_ids => [1, 2])
  320. i1 = create_issue!(:project_id => p.id, :subject => 'i1')
  321. i2 = create_issue!(:project_id => p.id, :subject => 'i2', :parent_issue_id => i1.id)
  322. i3 = create_issue!(:project_id => p.id, :subject => 'i3', :parent_issue_id => i1.id)
  323. i4 = create_issue!(:project_id => p.id, :subject => 'i4', :parent_issue_id => i2.id)
  324. i5 = create_issue!(:project_id => p.id, :subject => 'i5')
  325. c = Project.new(:name => 'Copy', :identifier => 'copy', :tracker_ids => [1, 2])
  326. c.copy(p, :only => 'issues')
  327. c.reload
  328. assert_equal 5, c.issues.count
  329. ic1, ic2, ic3, ic4, ic5 = c.issues.find(:all, :order => 'subject')
  330. assert ic1.root?
  331. assert_equal ic1, ic2.parent
  332. assert_equal ic1, ic3.parent
  333. assert_equal ic2, ic4.parent
  334. assert ic5.root?
  335. end
  336. # Helper that creates an issue with default attributes
  337. def create_issue!(attributes={})
  338. Issue.create!({:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'test'}.merge(attributes))
  339. end
  340. end