Merge pull request #4648 from fatalbanana/luacheck

[Test] Banish luacheck from functional tests

.drone.jsonnet

@@ -287,6 +287,14 @@ local noarch_pipeline = {
         './node_modules/.bin/stylelint ./**/*.css ./**/*.html ./**/*.js',
       ],
     },
+    {
+      name: 'luacheck',
+      image: 'pipelinecomponents/luacheck',
+      pull: 'if-not-exists',
+      commands: [
+        'luacheck -q --no-color .',
+      ],
+    },
   ],
 } + default_trigger + docker_pipeline;
 

.drone.yml

@@ -499,6 +499,14 @@
          "image": "node:18-alpine",
          "name": "eslint",
          "pull": "if-not-exists"
+      },
+      {
+         "commands": [
+            "luacheck -q --no-color ."
+         ],
+         "image": "pipelinecomponents/luacheck",
+         "name": "luacheck",
+         "pull": "if-not-exists"
       }
    ],
    "trigger": {
@@ -553,7 +561,7 @@
 }
 ---
 {
-   "hmac": "3f01ceb14c7dd3ba2f5343fc52216843f72212e1cb25f944c2366d57e78d2b79",
+   "hmac": "6c89d1423ccbddbfac9e2b67f24192018670209a293cfee308880a16a2f2b372",
    "kind": "signature"
 }
 ...

test/functional/cases/200_luacheck.robot

@@ -1,10 +0,0 @@
-*** Settings ***
-Library         Process
-
-*** Test Cases ***
-Lua Check
-  ${result} =  Run Process  luacheck  -q  --no-color  .  cwd=${TOPDIR}
-  IF  ${result.rc} != 0
-    Log  ${result.stdout}
-  END
-  Should Be Equal As Integers  ${result.rc}  0  msg=${result.stdout}  values=false