Browse Source

SONARPLUGINS-1466 Display all missing mandatory properties

tags/2.5-rc1
Evgeny Mandrikov 12 years ago
parent
commit
cbb8754679

+ 8
- 1
src/main/java/org/sonar/runner/Runner.java View File

@@ -79,11 +79,18 @@ public final class Runner {
}

void checkMandatoryProperties() {
StringBuilder missing = new StringBuilder();
for (String mandatoryProperty : MANDATORY_PROPERTIES) {
if (!properties.containsKey(mandatoryProperty)) {
throw new RunnerException("You must define mandatory property: " + mandatoryProperty);
if (missing.length() > 0) {
missing.append(", ");
}
missing.append(mandatoryProperty);
}
}
if (missing.length() != 0) {
throw new RunnerException("You must define mandatory properties: " + missing);
}
}

public String getServerURL() {

+ 1
- 1
src/test/java/org/sonar/runner/RunnerTest.java View File

@@ -40,7 +40,7 @@ public class RunnerTest {
Runner.create(new Properties()).checkMandatoryProperties();
fail();
} catch (RunnerException e) {
assertThat(e.getMessage(), is("You must define mandatory property: sonar.projectKey"));
assertThat(e.getMessage(), is("You must define mandatory properties: sonar.projectKey, sonar.projectName, sonar.projectVersion, sources"));
}
}


Loading…
Cancel
Save