Use same build stats reporter for all modules

server/sonar-vsts/scripts/build.js

@@ -22,7 +22,7 @@ process.env.NODE_ENV = 'production';
 
 const chalk = require('chalk');
 const webpack = require('webpack');
-const sortBy = require('lodash/sortBy');
+const reportBuildStats = require('./utils/reportBuildStats');
 const getConfig = require('../config/webpack.config');
 
 const config = getConfig({ production: true });
@@ -37,18 +37,7 @@ function build() {
       console.log(chalk.red(err.message || err));
       process.exit(1);
     }
-
-    if (stats.compilation.errors && stats.compilation.errors.length) {
-      console.log(chalk.red.bold('Failed to create a production build!'));
-      stats.compilation.errors.forEach(err => console.log(chalk.red(err.message || err)));
-      process.exit(1);
-    }
-
-    const jsonStats = stats.toJson();
-    const seconds = jsonStats.time / 1000;
-    console.log('Duration: ' + seconds.toFixed(2) + 's');
-    console.log();
-
+    reportBuildStats(stats);
     console.log(chalk.green.bold('Compiled successfully!'));
   });
 }

server/sonar-web/scripts/utils/formatSize.js → server/sonar-vsts/scripts/utils/reportBuildStats.js

@@ -17,7 +17,11 @@
  * along with this program; if not, write to the Free Software Foundation,
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
-module.exports = function(bytes) {
+/* eslint-disable no-console*/
+const chalk = require('chalk');
+const sortBy = require('lodash/sortBy');
+
+function formatSize(bytes) {
   if (bytes === 0) {
     return '0';
   }
@@ -25,4 +29,27 @@ module.exports = function(bytes) {
   const sizes = ['Bytes', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
   const i = Math.floor(Math.log(bytes) / Math.log(k));
   return parseFloat((bytes / Math.pow(k, i)).toFixed(0)) + ' ' + sizes[i];
+}
+
+module.exports = (stats, bundleName = '', filesLimit = 10) => {
+  if (stats.compilation.errors && stats.compilation.errors.length) {
+    console.log(chalk.red.bold('Failed to create a production build!'));
+    stats.compilation.errors.forEach(err => console.log(chalk.red(err.message || err)));
+    process.exit(1);
+  }
+  const jsonStats = stats.toJson();
+  const onlyJS = jsonStats.assets.filter(asset => asset.name.endsWith('.js'));
+  console.log(`Biggest js chunks (${onlyJS.length} total) ${bundleName && `[${bundleName}]`}:`);
+  sortBy(onlyJS, asset => -asset.size)
+    .slice(0, filesLimit)
+    .forEach(asset => {
+      let sizeLabel = formatSize(asset.size);
+      const leftPadding = ' '.repeat(Math.max(0, 8 - sizeLabel.length));
+      sizeLabel = leftPadding + sizeLabel;
+      console.log('', chalk.yellow(sizeLabel), asset.name);
+    });
+  console.log();
+  const seconds = jsonStats.time / 1000;
+  console.log('Duration: ' + seconds.toFixed(2) + 's');
+  console.log();
 };

server/sonar-web/scripts/build.js

@@ -22,8 +22,7 @@ process.env.NODE_ENV = 'production';
 
 const chalk = require('chalk');
 const webpack = require('webpack');
-const sortBy = require('lodash/sortBy');
-const formatSize = require('./utils/formatSize');
+const reportBuildStats = require('./utils/reportBuildStats');
 const getConfigs = require('../config/webpack.config');
 
 const configs = getConfigs({ production: true });
@@ -38,31 +37,9 @@ function build() {
       console.log(chalk.red(err.message || err));
       process.exit(1);
     }
-
-    const report = (stats, bundleName, filesLimit = 10) => {
-      if (stats.compilation.errors && stats.compilation.errors.length) {
-        console.log(chalk.red.bold('Failed to create a production build!'));
-        stats.compilation.errors.forEach(err => console.log(chalk.red(err.message || err)));
-        process.exit(1);
-      }
-      const jsonStats = stats.toJson();
-      const onlyJS = jsonStats.assets.filter(asset => asset.name.endsWith('.js'));
-      console.log(`Biggest js chunks (${onlyJS.length} total) [${bundleName}]:`);
-      sortBy(onlyJS, asset => -asset.size)
-        .slice(0, filesLimit)
-        .forEach(asset => {
-          let sizeLabel = formatSize(asset.size);
-          const leftPadding = ' '.repeat(Math.max(0, 8 - sizeLabel.length));
-          sizeLabel = leftPadding + sizeLabel;
-          console.log('', chalk.yellow(sizeLabel), asset.name);
-        });
-      console.log();
-    };
-
-    report(stats.stats[0], 'modern');
+    reportBuildStats(stats.stats[0], 'modern');
     console.log();
-    report(stats.stats[1], 'legacy');
-
+    reportBuildStats(stats.stats[1], 'legacy');
     console.log(chalk.green.bold('Compiled successfully!'));
   });
 }

server/sonar-web/scripts/utils/reportBuildStats.js

@@ -0,0 +1,55 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2019 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+/* eslint-disable no-console*/
+const chalk = require('chalk');
+const sortBy = require('lodash/sortBy');
+
+function formatSize(bytes) {
+  if (bytes === 0) {
+    return '0';
+  }
+  const k = 1000; // or 1024 for binary
+  const sizes = ['Bytes', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
+  const i = Math.floor(Math.log(bytes) / Math.log(k));
+  return parseFloat((bytes / Math.pow(k, i)).toFixed(0)) + ' ' + sizes[i];
+}
+
+module.exports = (stats, bundleName = '', filesLimit = 10) => {
+  if (stats.compilation.errors && stats.compilation.errors.length) {
+    console.log(chalk.red.bold('Failed to create a production build!'));
+    stats.compilation.errors.forEach(err => console.log(chalk.red(err.message || err)));
+    process.exit(1);
+  }
+  const jsonStats = stats.toJson();
+  const onlyJS = jsonStats.assets.filter(asset => asset.name.endsWith('.js'));
+  console.log(`Biggest js chunks (${onlyJS.length} total) ${bundleName && `[${bundleName}]`}:`);
+  sortBy(onlyJS, asset => -asset.size)
+    .slice(0, filesLimit)
+    .forEach(asset => {
+      let sizeLabel = formatSize(asset.size);
+      const leftPadding = ' '.repeat(Math.max(0, 8 - sizeLabel.length));
+      sizeLabel = leftPadding + sizeLabel;
+      console.log('', chalk.yellow(sizeLabel), asset.name);
+    });
+  console.log();
+  const seconds = jsonStats.time / 1000;
+  console.log('Duration: ' + seconds.toFixed(2) + 's');
+  console.log();
+};