Browse Source

Improve code coverage

tags/4.0
Julien HENRY 10 years ago
parent
commit
0d8f6d214d

+ 1
- 1
sonar-plugin-api/src/main/java/org/sonar/api/utils/internal/DefaultTempFolder.java View File

@@ -67,7 +67,7 @@ public class DefaultTempFolder implements TempFolder {
try {
FileUtils.forceMkdir(dir);
} catch (IOException e) {
throw new IllegalStateException("Unable to create temp directory in " + dir, e);
throw new IllegalStateException("Failed to create temp directory in " + dir, e);
}
return dir;
}

+ 26
- 0
sonar-plugin-api/src/test/java/org/sonar/api/utils/internal/DefaultTempFolderTest.java View File

@@ -60,4 +60,30 @@ public class DefaultTempFolderTest {
new TempFolderCleaner(tempFolder).stop();
assertThat(rootTempFolder).doesNotExist();
}

@Test
public void createTempFolderWithInvalidName() throws Exception {
File rootTempFolder = temp.newFolder();
DefaultTempFolder tempFolder = new DefaultTempFolder(rootTempFolder);
String tooLong = "tooooolong";
for (int i = 0; i < 50; i++) {
tooLong += "tooooolong";
}
throwable.expect(IllegalStateException.class);
throwable.expectMessage("Failed to create temp directory");
tempFolder.newDir(tooLong);
}

@Test
public void createNewFileWithInvalidName() throws Exception {
File rootTempFolder = temp.newFolder();
DefaultTempFolder tempFolder = new DefaultTempFolder(rootTempFolder);
String tooLong = "tooooolong";
for (int i = 0; i < 50; i++) {
tooLong += "tooooolong";
}
throwable.expect(IllegalStateException.class);
throwable.expectMessage("Failed to create temp file");
tempFolder.newFile(tooLong, ".txt");
}
}

Loading…
Cancel
Save