Browse Source

SONAR-15404 Fix documentation tooltip links when running in a web context

tags/9.2.0.49834
Wouter Admiraal 2 years ago
parent
commit
3852fab0f0

+ 3
- 3
server/sonar-web/src/main/js/components/common/DocumentationTooltip.tsx View File

@@ -58,14 +58,14 @@ export default function DocumentationTooltip(props: DocumentationTooltipProps) {
<span>{label}</span>
</Link>
) : (
<a
<Link
className="display-inline-flex-center link-with-icon"
href={href}
to={href}
rel="noopener noreferrer"
target="_blank">
{isWebUri(href) && <DetachIcon size={14} className="spacer-right" />}
<span>{label}</span>
</a>
</Link>
)}
</div>
))}

+ 10
- 6
server/sonar-web/src/main/js/components/common/__tests__/__snapshots__/DocumentationTooltip-test.tsx.snap View File

@@ -76,11 +76,13 @@ exports[`renders correctly: with links 1`] = `
<div
className="little-spacer-bottom"
>
<a
<Link
className="display-inline-flex-center link-with-icon"
href="http://link.tosome.place"
onlyActiveOnIndex={false}
rel="noopener noreferrer"
style={Object {}}
target="_blank"
to="http://link.tosome.place"
>
<DetachIcon
className="spacer-right"
@@ -89,21 +91,23 @@ exports[`renders correctly: with links 1`] = `
<span>
external link
</span>
</a>
</Link>
</div>
<div
className="little-spacer-bottom"
>
<a
<Link
className="display-inline-flex-center link-with-icon"
href="/documentation/guide"
onlyActiveOnIndex={false}
rel="noopener noreferrer"
style={Object {}}
target="_blank"
to="/documentation/guide"
>
<span>
internal link
</span>
</a>
</Link>
</div>
<div
className="little-spacer-bottom"

Loading…
Cancel
Save