Browse Source

Revert "SONAR-14642 - SSF-142"

This reverts commit 0810d5dcbc.
tags/8.9.0.43852
Zipeng WU 3 years ago
parent
commit
39abd3de73

+ 4
- 4
server/sonar-webserver-ws/src/test/java/org/sonar/server/ws/WebServiceEngineTest.java View File

@@ -208,7 +208,7 @@ public class WebServiceEngineTest {

DumbResponse response = run(request, newWs("api/foo", a -> a.setHandler((req, resp) -> request.param("unknown"))));

assertThat(response.stream().outputAsString()).isEqualTo("{\"errors\":[{\"msg\":\"BUG - parameter \\u0027unknown\\u0027 is undefined for action \\u0027foo\\u0027\"}]}");
assertThat(response.stream().outputAsString()).isEqualTo("{\"errors\":[{\"msg\":\"BUG - parameter 'unknown' is undefined for action 'foo'\"}]}");
assertThat(response.stream().status()).isEqualTo(400);
}

@@ -221,7 +221,7 @@ public class WebServiceEngineTest {
a.setHandler((req, resp) -> request.mandatoryParam("bar"));
}));

assertThat(response.stream().outputAsString()).isEqualTo("{\"errors\":[{\"msg\":\"The \\u0027bar\\u0027 parameter is missing\"}]}");
assertThat(response.stream().outputAsString()).isEqualTo("{\"errors\":[{\"msg\":\"The 'bar' parameter is missing\"}]}");
assertThat(response.stream().status()).isEqualTo(400);
}

@@ -235,7 +235,7 @@ public class WebServiceEngineTest {
a.setHandler((req, resp) -> request.param("bar"));
}));

assertThat(response.stream().outputAsString()).isEqualTo("{\"errors\":[{\"msg\":\"The \\u0027bar\\u0027 parameter is missing\"}]}");
assertThat(response.stream().outputAsString()).isEqualTo("{\"errors\":[{\"msg\":\"The 'bar' parameter is missing\"}]}");
assertThat(response.stream().status()).isEqualTo(400);
}

@@ -287,7 +287,7 @@ public class WebServiceEngineTest {
a.setHandler((req, resp) -> resp.stream().output().write(req.mandatoryParam("format").getBytes(UTF_8)));
}));

assertThat(response.stream().outputAsString()).isEqualTo("{\"errors\":[{\"msg\":\"Value of parameter \\u0027format\\u0027 (yml) must be one of: [json, xml]\"}]}");
assertThat(response.stream().outputAsString()).isEqualTo("{\"errors\":[{\"msg\":\"Value of parameter 'format' (yml) must be one of: [json, xml]\"}]}");
assertThat(response.stream().status()).isEqualTo(400);
}


+ 0
- 1
sonar-plugin-api/src/main/java/org/sonar/api/utils/text/JsonWriter.java View File

@@ -74,7 +74,6 @@ public class JsonWriter implements AutoCloseable {
this.stream = new com.google.gson.stream.JsonWriter(writer);
this.stream.setSerializeNulls(false);
this.stream.setLenient(false);
this.stream.setHtmlSafe(true);
this.serializeEmptyStrings = true;
}


+ 1
- 9
sonar-plugin-api/src/test/java/org/sonar/api/utils/text/JsonWriterTest.java View File

@@ -152,15 +152,7 @@ public class JsonWriterTest {
underTest.beginObject()
.prop("foo", "<hello \"world\">")
.endObject().close();
expect("{\"foo\":\"\\u003chello \\\"world\\\"\\u003e\"}");
}

@Test
public void escape_html_characters() {
underTest.beginObject()
.prop("foo", "123<>abc")
.endObject().close();
expect("{\"foo\":\"123\\u003c\\u003eabc\"}");
expect("{\"foo\":\"<hello \\\"world\\\">\"}");
}

@Test

Loading…
Cancel
Save