SONAR-11468 truncate name and description of adhoc rules metadata

server/sonar-ce-task-projectanalysis/src/main/java/org/sonar/ce/task/projectanalysis/issue/AdHocRuleCreator.java

@@ -34,11 +34,14 @@ import org.sonar.db.rule.RuleMetadataDto;
 import org.sonar.server.rule.index.RuleIndexer;
 
 import static java.util.Objects.requireNonNull;
+import static org.apache.commons.lang.StringUtils.substring;
 import static org.sonar.api.rule.RuleStatus.READY;
 import static org.sonar.db.rule.RuleDto.Scope.ALL;
 
 public class AdHocRuleCreator {
 
+  private static final int MAX_LENGTH_AD_HOC_NAME = 200;
+  private static final int MAX_LENGTH_AD_HOC_DESC = 16_777_215;
   private final DbClient dbClient;
   private final System2 system2;
   private final RuleIndexer ruleIndexer;
@@ -82,11 +85,11 @@ public class AdHocRuleCreator {
     if (adHoc.hasDetails()) {
       boolean changed = false;
       if (!Objects.equals(metadata.getAdHocName(), adHoc.getName())) {
-        metadata.setAdHocName(adHoc.getName());
+        metadata.setAdHocName(substring(adHoc.getName(), 0, MAX_LENGTH_AD_HOC_NAME));
         changed = true;
       }
       if (!Objects.equals(metadata.getAdHocDescription(), adHoc.getDescription())) {
-        metadata.setAdHocDescription(adHoc.getDescription());
+        metadata.setAdHocDescription(substring(adHoc.getDescription(), 0, MAX_LENGTH_AD_HOC_DESC));
         changed = true;
       }
       if (!Objects.equals(metadata.getAdHocSeverity(), adHoc.getSeverity())) {

server/sonar-ce-task-projectanalysis/src/test/java/org/sonar/ce/task/projectanalysis/issue/AdHocRuleCreatorTest.java

@@ -35,6 +35,7 @@ import org.sonar.scanner.protocol.output.ScannerReport;
 import org.sonar.server.es.EsTester;
 import org.sonar.server.rule.index.RuleIndexer;
 
+import static org.apache.commons.lang.StringUtils.repeat;
 import static org.assertj.core.api.Assertions.assertThat;
 
 public class AdHocRuleCreatorTest {
@@ -99,6 +100,24 @@ public class AdHocRuleCreatorTest {
     assertThat(rule.getMetadata().getAdHocType()).isEqualTo(RuleType.BUG.getDbConstant());
   }
 
+  @Test
+  public void truncate_metadata_name_and_desc_if_longer_than_max_value() {
+    OrganizationDto organization = db.organizations().insert();
+    NewAdHocRule addHocRule = new NewAdHocRule(ScannerReport.AdHocRule.newBuilder()
+      .setEngineId("eslint")
+      .setRuleId("no-cond-assign")
+      .setName(repeat("a", 201))
+      .setDescription(repeat("a", 16_777_216))
+      .setSeverity(Constants.Severity.BLOCKER)
+      .setType(ScannerReport.IssueType.BUG)
+      .build());
+
+    RuleDto rule = underTest.persistAndIndex(dbSession, addHocRule, organization);
+
+    assertThat(rule.getMetadata().getAdHocName()).isEqualTo(repeat("a", 200));
+    assertThat(rule.getMetadata().getAdHocDescription()).isEqualTo(repeat("a", 16_777_215));
+  }
+
   @Test
   public void update_metadata_only() {
     OrganizationDto organization = db.organizations().insert();