Mirrors/sonarqube
1
0
Fork 0
mirror of https://github.com/SonarSource/sonarqube.git synced 2024-08-12 02:10:16 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

SONAR-2867 Standard copy-paste detection should happen within a project, not only within a module

Browse Source
This commit is contained in:
Duarte Meneses 2015-12-23 11:29:14 +01:00
parent 7f5a8542ce
commit 638244f43d
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sonar-batch/src/main/java/org/sonar/batch/cpd/CpdExecutor.java
View File

@ -93,13 +93,25 @@ public class CpdExecutor {
}
InputFile inputFile = (InputFile) component.inputComponent();
Predicate<CloneGroup> minimumTokensPredicate = DuplicationPredicates.numberOfUnitsNotLessThan(getMinimumTokens(inputFile.language()));
List<CloneGroup> filtered = from(duplications).filter(minimumTokensPredicate).toList();
List<CloneGroup> filtered;
if (!"java".equalsIgnoreCase(inputFile.language())) {
Predicate<CloneGroup> minimumTokensPredicate = DuplicationPredicates.numberOfUnitsNotLessThan(getMinimumTokens(inputFile.language()));
filtered = from(duplications).filter(minimumTokensPredicate).toList();
} else {
filtered = duplications;
}
saveDuplications(component, filtered);
}
@VisibleForTesting
/**
* Not applicable to Java, as the {@link BlockChunker} that it uses does not record start and end units of each block.
* Also, it uses statements instead of tokens.
* @param languageKey
* @return
*/
int getMinimumTokens(String languageKey) {
int minimumTokens = settings.getInt("sonar.cpd." + languageKey + ".minimumTokens");
if (minimumTokens == 0) {