Browse Source

SONAR-10435 Improve error message of licenses issues for normal users

tags/7.5
Grégoire Aubert 6 years ago
parent
commit
86bc73dcba

+ 5
- 3
server/sonar-web/src/main/js/app/components/nav/component/ComponentNavBgTaskNotif.tsx View File

@@ -87,11 +87,13 @@ export default class ComponentNavBgTaskNotif extends React.PureComponent<Props>
) {
return (
<NavBarNotif className="alert alert-danger">
<span>{currentTask.errorMessage}</span>
{this.context.canAdmin && (
<Link className="little-spacer-left" to="/admin/extension/license/app">
<span className="little-spacer-right">{currentTask.errorMessage}</span>
{this.context.canAdmin ? (
<Link to="/admin/extension/license/app">
{translate('license.component_navigation.button', currentTask.errorType)}.
</Link>
) : (
translate('please_contact_administrator')
)}
</NavBarNotif>
);

+ 8
- 2
server/sonar-web/src/main/js/app/components/nav/component/__tests__/ComponentNavBgTaskNotif-test.tsx View File

@@ -64,15 +64,21 @@ it('renders background task license info correctly', () => {
expect(
getWrapper({ currentTask: { status: 'FAILED', errorType: 'LICENSING', errorMessage: 'Foo' } })
).toMatchSnapshot();
expect(
getWrapper(
{ currentTask: { status: 'FAILED', errorType: 'LICENSING', errorMessage: 'Foo' } },
{ canAdmin: false }
)
).toMatchSnapshot();
});

function getWrapper(props = {}) {
function getWrapper(props = {}, context = {}) {
return shallow(
<ComponentNavBgTaskNotif
component={component}
currentTask={{ status: 'FAILED' } as Task}
{...props}
/>,
{ context: { canAdmin: true } }
{ context: { canAdmin: true, ...context } }
);
}

+ 16
- 2
server/sonar-web/src/main/js/app/components/nav/component/__tests__/__snapshots__/ComponentNavBgTaskNotif-test.tsx.snap View File

@@ -27,11 +27,12 @@ exports[`renders background task license info correctly 1`] = `
<NavBarNotif
className="alert alert-danger"
>
<span>
<span
className="little-spacer-right"
>
Foo
</span>
<Link
className="little-spacer-left"
onlyActiveOnIndex={false}
style={Object {}}
to="/admin/extension/license/app"
@@ -42,6 +43,19 @@ exports[`renders background task license info correctly 1`] = `
</NavBarNotif>
`;

exports[`renders background task license info correctly 2`] = `
<NavBarNotif
className="alert alert-danger"
>
<span
className="little-spacer-right"
>
Foo
</span>
please_contact_administrator
</NavBarNotif>
`;

exports[`renders background task pending info correctly 1`] = `
<NavBarNotif
className="alert alert-info"

+ 1
- 0
sonar-core/src/main/resources/org/sonar/l10n/core.properties View File

@@ -222,6 +222,7 @@ no_results_search.favorites=We couldn't find any results matching selected crite
no_results_search.2=Try to change filters to get some results.
no_results_search.favorites.2=Would you like to search among {url} projects?
page_extension_failed=Page extension failed.
please_contact_administrator=Please contact the instance administrator.
set_as_default=Set as Default
short_number_suffix.g=G
short_number_suffix.k=k

Loading…
Cancel
Save