SONAR-21165 Fix code smells

server/sonar-webserver-common/src/main/java/org/sonar/server/common/rule/RuleCreator.java

@@ -230,7 +230,7 @@ public class RuleCreator {
     return ruleDto;
   }
 
-  private void setCleanCodeAttributeAndImpacts(NewCustomRule newRule, RuleDto ruleDto, RuleDto templateRuleDto) {
+  private static void setCleanCodeAttributeAndImpacts(NewCustomRule newRule, RuleDto ruleDto, RuleDto templateRuleDto) {
     RuleType ruleType = newRule.type();
     int type = ruleType == null ? templateRuleDto.getType() : ruleType.getDbConstant();
     String severity = ofNullable(newRule.severity()).orElse(Severity.MAJOR);

server/sonar-webserver-core/src/main/java/org/sonar/server/rule/registration/StartupRuleUpdater.java

@@ -161,7 +161,7 @@ public class StartupRuleUpdater {
       changed = true;
     }
     changed |= mergeCleanCodeAttribute(def, dto, ruleChange);
-    changed |= mergeImpacts(def, dto, uuidFactory, ruleChange);
+    changed |= mergeImpacts(def, dto, ruleChange);
     if (dto.isAdHoc()) {
       dto.setIsAdHoc(false);
       changed = true;
@@ -188,7 +188,7 @@ public class StartupRuleUpdater {
     return changed;
   }
 
-  boolean mergeImpacts(RulesDefinition.Rule def, RuleDto dto, UuidFactory uuidFactory, RuleChange ruleChange) {
+  boolean mergeImpacts(RulesDefinition.Rule def, RuleDto dto, RuleChange ruleChange) {
     if (dto.getEnumType() == RuleType.SECURITY_HOTSPOT) {
       return false;
     }